Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)
Seems okay, do a rebase for all checks to pass, hopefully this should be sufficient for it to be merged. @pmatilai , anything else holding this one off? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/359#issuecomment-366882575___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)
Shouldn't the time have come to review this again for finally merging this one after more than a half year now? With rpm 4.14 out, it should be the right time to merge this one now, no? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/226#issuecomment-366881541___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: give some freshness to brp scripts (#308)
This one too has been left without any movement on for way too long despite all issues raised has been adressed... I notice that the existing upstream brp- has been macroized, creating conflicts with this PR and requiring it to be adapted to this change. Again, I don't have that great possibility to follow up on this one immediately either, @Conan-Kudo could you attend to it perhaps? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/308#issuecomment-366879903___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Reopened #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1481746956___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Closed #190. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#event-1481746644___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
@Conan-Kudo could you take care of reopening this one? I'm currently -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-366877938___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#360)
pmatilai commented on this pull request.
> + snprintf(archmarker, sizeof(archmarker), "(%s%s-%s)", elf_machine,
> elf_endian, elf_bitsize);
+ break;
+case EM_X86_64:
+ /* This handling for x32 makes me weep inside... */
+ if (ehdr->e_ident[EI_CLASS] == ELFCLASS32) {
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s-%s)", elf_machine,
"64", "x32");
+ } else {
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s)", elf_machine,
elf_bitsize);
+ }
+ break;
+default:
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s)", elf_machine,
elf_bitsize);
+ break;
+}
+
+return strndup(archmarker, strlen(archmarker));
rasprintf() is rpm's local version of asprintf() (so we can rely on it always
being there), it's used all over rpm codebase - elfdeps.c included.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/360#discussion_r169100955___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#360)
Conan-Kudo commented on this pull request.
> + snprintf(archmarker, sizeof(archmarker), "(%s%s-%s)", elf_machine,
> elf_endian, elf_bitsize);
+ break;
+case EM_X86_64:
+ /* This handling for x32 makes me weep inside... */
+ if (ehdr->e_ident[EI_CLASS] == ELFCLASS32) {
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s-%s)", elf_machine,
"64", "x32");
+ } else {
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s)", elf_machine,
elf_bitsize);
+ }
+ break;
+default:
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s)", elf_machine,
elf_bitsize);
+ break;
+}
+
+return strndup(archmarker, strlen(archmarker));
@pmatilai Because I've never heard of `rasprintf()` before? Any reference to it
somewhere?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/360#discussion_r169098454___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#360)
pmatilai commented on this pull request.
> + snprintf(archmarker, sizeof(archmarker), "(%s%s-%s)", elf_machine,
> elf_endian, elf_bitsize);
+ break;
+case EM_X86_64:
+ /* This handling for x32 makes me weep inside... */
+ if (ehdr->e_ident[EI_CLASS] == ELFCLASS32) {
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s-%s)", elf_machine,
"64", "x32");
+ } else {
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s)", elf_machine,
elf_bitsize);
+ }
+ break;
+default:
+ snprintf(archmarker, sizeof(archmarker), "(%s-%s)", elf_machine,
elf_bitsize);
+ break;
+}
+
+return strndup(archmarker, strlen(archmarker));
Um, why the static-sized "lets hope this is enough" buffer when you end up
strdup()'ing it afterall?
Just use rasprintf() to construct the marker to begin with...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/360#pullrequestreview-97569346___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM_BIN_TYPE get wrong length if HEADERIMPORT_FAST is used (#398)
(from memory) I think I fixed this problem 4-5 years ago in RPM5 (like rpm-5.4.15? I forget). The MD5 tag length (and RPM_BIN_TYPE in general) includes padding (if present) to the next tag. The bug only shows up if the next tag needs to be aligned. The real fix wasn't hard, but was rather subtle and surprising. The proposed fix special casing the MD5 tag is deficient because it ignores legacy compatibility: nearly all versions of rpm this century are affected. Mark Hatle (from Poky/Yocto) likely can supply the actual patch I checked into RPM5. I was somewhat surprised at the time that the bug had never been reported against RPM4 with identical code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/398#issuecomment-366710446___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)
Closed #346 via 5ac4305bdd2701f70cae81195b5518b339967b76. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/346#event-1480595762___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)
Closed #351. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/351#event-1480557163___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)
Sorry but NAK, we're not going to add OS2 support since it's not something we can even try to promise to keep, see eg #345 (comment) for rationale. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/351#issuecomment-366694152___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: detect OS/2 operating system (#349)
Sorry but NAK, we're not going to add OS2 support since it's not something we can even try to promise to keep, see eg https://github.com/rpm-software-management/rpm/pull/345#issuecomment-366686531 for rationale. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/349#issuecomment-366694057___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: detect OS/2 operating system (#349)
Closed #349. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/349#event-1480556434___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
The right thing to do is actually not have rpm mess with -fPIC and friends at all, these are up to distro/platform policies etc. Done in commit d7dfd0dc0c6ad7fc067a1d0e292a74e134b0720c so this PR is not needed at all. And by doing the right thing we actually end up reducing the need for those OS2-specific patches, and those kind of changes are always welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#issuecomment-366693047___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Closed #350. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#event-1480549359___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
Closed #345. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#event-1480502056___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
After discussing this with others from a wider perspective: Sorry but no. This is a POSIX mandated function and even if this particular one would be easy to work around in one way or another, the next one(s) that we introduce might not be, in fact are not likely to be. If we let this door open ajar now, we'd have to consider non-POSIX systems for every new addition that we do, and that's just not an option at all. We think OS2 support will be better off in a separately maintained tree - as it has been all along - for everybody involved. I know I suggested adding this particular check myself, that was a mistake on my behalf having not thought about the bigger picture. Apologies for sending you on a fools errand. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-366686531___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RPM_BIN_TYPE get wrong length if HEADERIMPORT_FAST is used (#398)
See https://github.com/openSUSE/libsolv/pull/255 for the background. I think rpm should not overwrite the count with the entry length (line 1107 in header.c). I don't know if everything still works if the line is removed. Please investigate ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/398___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmrc: Add architecture compatibility mapping between aarch64 and arm64 (#397)
Not a big fan of duplicate names but... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/397#issuecomment-33821___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmrc: Add architecture compatibility mapping between aarch64 and arm64 (#397)
Merged #397. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/397#event-1480372165___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Need to update http://rpm.org/about.html (#396)
Closed #396. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/396#event-1480365026___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improve hardlink handling in the disk space calculation (#394)
Thanks for the fixes! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/394#issuecomment-31550___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improve hardlink handling in the disk space calculation (#394)
Merged #394. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/394#event-1480356200___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
