Re: [Rpm-maint] [rpm-software-management/rpm] Noarch RPMs that contain EBPF binaries code incorrectly fail with "Arch dependent binaries in noarch package" (Issue #2875)
Fixed both in rpmbuild and in rpmlint ? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2875#issuecomment-1943706675 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Noarch RPMs that contain EBPF binaries code incorrectly fail with "Arch dependent binaries in noarch package" (Issue #2875)
rpmlint also considers ebpf as arch-dependent package. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2875#issuecomment-1909982487 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Noarch RPMs that contain EBPF binaries code incorrectly fail with "Arch dependent binaries in noarch package" (Issue #2875)
Noarch RPMs that contain EBPF binaries code incorrectly fail with "Arch dependent binaries in noarch package" EBPF is really noarch binary. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2875 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
#781 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746702064 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] 'rpmbuild -br --nodeps' does not always generate buildreqs.nosrc.rpm (#781)
#797 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/781#issuecomment-1746701819 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
Seems dup of #797 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746700437 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
Seems I figured out. After installing deps from file generated by `-bs` some macroses appear. that's what is changed in environment. So the bug is: not generating `.buildreqs.nosrc.rpm`. If it was generated, bug would not happen. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746648425 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
@pmatilai there are no difference. Really. I have provided part of the shell script. Tell me how to debug, please. I strongly consider there is a bug in RPM, but con not knock it down. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746632944 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
Interesting... `-rr --nodeps` rewrites .src.rpm in a way that `dnf` INSTALLS `pkgconfig(systemd)` afterwards. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746625208 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
@pmatilai sorry for not explaining clearly. Seems it is another bug. When `-rr` says error about missing deps but does not generate `.buildreqs.nosrc.rpm` in some conditions. In generally – yes, it works as expected. Especially on pyproject srpms, where 3-5 iterations are possible. please reopen -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746597606 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
@pmatilai sorry for bash script, but I want just show what happens in our build
script:
```bash
unpriv rpmbuild "${defines[@]}" -bs "$spec_file" --rmspec
srpm=("$RPMBUILD"/SRPMS/*.src.rpm)
while :; do
unpriv rpmbuild "${defines[@]}" -rr "$srpm" && exit_code=0 ||
exit_code=$?
case "$exit_code" in
0)
break
;;
11)
reqsrpm=("$RPMBUILD"/SRPMS/*.buildreqs.nosrc.rpm)
if [ -f "$reqsrpm" ]; then
install_deps "$reqsrpm"
rm -f "$reqsrpm"
else
install_deps "$srpm"
fi
;;
*)
echo "rpmbuild -rr FAILED code $exit_code" >&2
exit 42
;;
esac
done
```
And on this package it falls into endless loop. Note, environment is exactly
the same on both rpmbuild runs.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746578126
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
@pmatilai I always run everything in a clear environment. i.e. in the container, yes. Does `rpmbuild -rr` re-parse .spec-file ? Thought it does not. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746570147 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
@pmatilai Commented things – are my lines – I did not remove after experiments. Yes, our scripts build `.src.rpm` from `.spec` file and then (in the same environment) install build deps. The problem that `rpmbuild -rr` says about missing deps, but `dnf builddep` does not install them (does not see them). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746512482 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
Moreover, I don't understand how it appears in this srpm file. This file was made in our build scripts. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1745146423 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)
`rpm -qRp /home/fedora/rpmbuild/SRPMS/frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.rpm`: gives the following: ``` ... perl-XML-LibXML perl-generators python3-devel ... ``` That's OK. Nothing about pkgconfig. Now, try to build it: `su --login --shell=/usr/bin/env fedora -- "PATH=$PATH" "HOME=/home/fedora" rpmbuild --verbose --debug -rr /home/fedora/rpmbuild/SRPMS/frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.rpm` ``` Last login: Tue Oct 3 14:43:10 UTC 2023 on pts/0 Installing /home/fedora/rpmbuild/SRPMS/frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.rpm D: loading keyring from rpmdb D: PRAGMA secure_delete = OFF: 0 D: PRAGMA case_sensitive_like = ON: 0 D: read h# 1 Header SHA256 digest: OK Header SHA1 digest: OK D: added key gpg-pubkey-5323552a-6112bcdc to keyring D: /home/fedora/rpmbuild/SRPMS/frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.rpm: Header SHA256 digest: OK D: /home/fedora/rpmbuild/SRPMS/frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.rpm: Header SHA1 digest: OK D: install: frr-8.5.2-2.1696341206.16.8ff8ce50.utm.x86_64 has 13 files D: create 100644 1 (1000,1000) 1364 -remove-babeld-and-ldpd.patch;651c292f D: create 100644 1 (1000,1000) 1740 0002-enable-openssl.patch;651c292f D: create 100644 1 (1000,1000) 6746 0003-disable-eigrp-crypto.patch;651c292f D: create 100644 1 (1000,1000) 3619 0004-fips-mode.patch;651c292f D: create 100644 1 (1000,1000) 870 0005-remove-grpc-test.patch;651c292f D: create 100644 1 (1000,1000) 1619 0007-ideco-route-table.patch;651c292f D: create 100644 1 (1000,1000)9881857 frr-8.5.2.tar.gz;651c292f D: create 100644 1 (1000,1000) 185 frr-sysusers.conf;651c292f D: create 100644 1 (1000,1000)26 frr-tmpfiles.conf;651c292f D: create 100644 1 (1000,1000) 1633 frr.fc;651c292f D: create 100644 1 (1000,1000) 4177 frr.if;651c292f D: create 100644 1 (1000,1000) 16037 frr.spec;651c292f D: create 100644 1 (1000,1000) 3511 frr.te;651c292f setting SOURCE_DATE_EPOCH=1696204800 D: == +++ frr-8.5.2-2.1696341206.16.8ff8ce50.utm x86_64/linux 0x0 ... D: read h# 474 Header V4 RSA/SHA256 Signature, key ID 5323552a: OK Header SHA256 digest: OK Header SHA1 digest: OK D: Requires: perl-generators YES (db provides) D: Requires: pkgconfig(systemd)NO == D: read h# 480 Header V4 RSA/SHA256 Signature, key ID 5323552a: OK Header SHA256 digest: OK Header SHA1 digest: OK D: Requires: python3-devel YES (db provides) ... error: Failed build dependencies: pkgconfig(systemd) is needed by frr-8.5.2-2.1696341206.16.8ff8ce50.utm.x86_64 ``` So, WHY? From one point of view it's not in dependencies, from another – it is. RPM version 4.18.1 File is attached. Sorry for zip. GitHub does not allow attaching just rpm. [frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.zip](https://github.com/rpm-software-management/rpm/files/12793803/frr-8.5.2-2.1696341206.16.8ff8ce50.utm.src.zip) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
@socketpair commented on this pull request. > @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile) if (pipefd[1]) close(pipefd[1]); -(void) waitpid(pid, , 0); OK -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398#discussion_r1128077640 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
@socketpair commented on this pull request.
> @@ -402,7 +402,19 @@ static int getOutputFrom(ARGV_t argv,
reap:
/* Collect status from prog */
-reaped = waitpid(child, , 0);
+
+do {
+ reaped = waitpid(child, , 0);
+} while (reaped == -1 && errno == EINTR);
+
+// It's not allowed to call WIFEXITED or WEXITSTATUS if waitpid return -1.
+// Note, all bits set, since -1 == 0x
Fixed
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2398#discussion_r1128077353
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
@socketpair pushed 1 commit. 8cb5c6a31a475067d41923b8306f8625dde4a71f Fix ignoring exit code of child scripts in case of EINTR -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398/files/e36832755b35ae9aa4b5103987e9375e86e08ba3..8cb5c6a31a475067d41923b8306f8625dde4a71f You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
@socketpair commented on this pull request. > @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile) if (pipefd[1]) close(pipefd[1]); -(void) waitpid(pid, , 0); It's better to switch to new `rpmfc`. It's too difficult for me, I just can only recommend swithching. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398#pullrequestreview-1312736769 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
I can make backport (the code has changed recently, so fix is slightly different) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398#issuecomment-1443101095 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2398 -- Commit Summary -- * Fix ignoring exit code of child scripts in case of EINTR -- File Changes -- M build/rpmfc.c (14) M sign/rpmgensig.c (12) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2398.patch https://github.com/rpm-software-management/rpm/pull/2398.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398 You are receiving this because you are subscribed to this thread. Message ID: rpm-software-management/rpm/pull/2...@github.com ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use multhtreading by default for unpacking zstd-compressed Source0: (Issue #2299)
Closed #2299 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2299#event-7900676024 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use multhtreading by default for unpacking zstd-compressed Source0: (Issue #2299)
You are right, I did not read thoroughly. https://github.com/facebook/zstd/issues/2470 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2299#issuecomment-1328737840 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Use multhtreading by default for unpacking zstd-compressed Source0: (Issue #2299)
Not, it's NOT about #1303 ``` Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.APuaoT + umask 022 + cd /home/fedora/rpmbuild/BUILD + cd /home/fedora/rpmbuild/BUILD + rm -rf ClickHouse-22.8.8.3-lts + /usr/bin/zstd -dc /home/fedora/rpmbuild/SOURCES/v22.8.8.3-lts.tar.zstd + /usr/bin/tar -xof - ``` ``` ./macros:%__zstd/usr/bin/zstd ./brp-compress: *.zst|*.zstd) unzstd -f --rm $f; b=`echo $f | sed -e 's/\.\(zst\|zstd\)$//'`;; ``` Unpacking may be faster. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2299 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: read sources checksums from the SPEC file and verify them (#463)
OKAY. so rpmlint should check three checksums match: 1. downloaded file from github 2. attached archive in srpm 3. sha-256 sum in .spec file -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/463#issuecomment-886787834___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: read sources checksums from the SPEC file and verify them (#463)
I want rpmlint to fight against packagers who unintentionally put wrong archives. Yes, I trust github, so I want rpmlint to download from github, i.e. 1. unpack .srpm 2. remove archives that are expected to be from github 3. run something like `rpmbuild --undefine=_disable_source_fetch --define '_sourcedir XXX' -ba *.spec` 4. compare `sha256sum($file_in_srpm)` and `sha256sum($downloaded_file)` Github is trusted because of git (i.e. block-chain) that is hard to fake without other able to notice. I mean history rewriting. I don't see any real cases where specifying sha256sum inside spec-file could help. Just suppose, stupid developer has got .tar.gz from wrong branch or so, calculated it and put to the .spec file. Comparing checksums will show everything is OK, but actually data does not correspond to URL. I think, silent data corruption is not a case we should care of. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/463#issuecomment-886674548___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
@ffesti could you make `BuildRequires(check)` to work as expected ? i.e. ignore them if `--nocheck` was passed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-685868765___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Disallow buildrequires: inside %package section (#1083)
@ffesti There is no place, since documentation does not tell us whether we may use buildrequires inside `%package` section or not. Moreover, documentation does not say exactly what macroses we can define right inside `%package` section, except `requires`, `version`, `summary` and `group`. (http://ftp.rpm.org/max-rpm/s1-rpm-subpack-spec-file-changes.html). For example, `license` ? (for cases where a plugin has a different license). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1083#issuecomment-589989931___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Disallow buildrequires: inside %package section (#1083)
Well, guys. If this is allowed, it should be documented. If core RPM team considers it OK, I have no questions except missing documentation for that case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1083#issuecomment-589750994___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Disallow buildrequires: inside %package section (#1083)
Yes, but I thought RPM does not scan %package sections while looking for `buildrequires`. Since it is not clearly documented, I can't consider current behaviour stable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1083#issuecomment-589742251___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Disallow buildrequires: inside %package section (#1083)
Currently, `buildrequires` specified in `%package` work. But I think this is completely wrong and I think RPM should consider such things as mistakes. In any case, documentation should be updated regarding whether it is allowed to add `buildrequires` inside `%package` section, or not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1083___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
