Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)

2018-12-21 Thread Andreas Schwab
For the same reason there is ls when a script uses *.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449497239___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)

2018-12-21 Thread Andreas Schwab
You can get the list of files with rpm -q --qf='[%{FILENAMES}\n]'.  There is 
nothing dirty about that, those are the building blocks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449483367___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)

2018-12-21 Thread Andreas Schwab
You can use rpm -q --qf='%{FILENAMES:arraysize}\n' to get the number of files.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449384859___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Ignore object files as they do not have a build id (#604)

2018-11-23 Thread Andreas Schwab
Don't make them executable.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/604#issuecomment-441207296___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [PATCH] debugedit: handle RISC-V relocation

2018-03-05 Thread Andreas Schwab
---
 tools/debugedit.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/tools/debugedit.c b/tools/debugedit.c
index e0b1d98d99..57cd83030f 100644
--- a/tools/debugedit.c
+++ b/tools/debugedit.c
@@ -1947,6 +1947,12 @@ edit_dwarf2 (DSO *dso)
  if (rtype != R_68K_32)
goto fail;
  break;
+#if defined(EM_RISCV) && defined(R_RISCV_32)
+   case EM_RISCV:
+ if (rtype != R_RISCV_32)
+   goto fail;
+ break;
+#endif
default:
fail:
  error (1, 0, "%s: Unhandled relocation %d in .debug_info 
section",
-- 
2.16.2


-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] debugedit: handle RISC-V relocation (#407)

2018-03-05 Thread Andreas Schwab

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/407

-- Commit Summary --

  * debugedit: handle RISC-V relocation

-- File Changes --

M tools/debugedit.c (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/407.patch
https://github.com/rpm-software-management/rpm/pull/407.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/407
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Human readable size in --queryformat (#375)

2017-12-29 Thread Andreas Schwab
... | numfmt --field 1 --to=iec

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/375#issuecomment-354421883___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm without TTY gives wrong error message (#355)

2017-11-12 Thread Andreas Schwab
It's actually rpmlock_acquire not setting errno when it returns with a failure 
when asked to write-lock a read-only lock.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/355#issuecomment-343745260___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [PATCH] Don't lose errno from rpmPackageFilesInstall

2013-07-10 Thread Andreas Schwab
There are a lot of ways to lose the value of errno after a failed
rpmPackageFilesInstall.  Typically, stdio will call isatty which then
overwrites errno with ENOTTY.  Save and restore errno between the return
from rpmPackageFilesInstall and the logging of the error.  There may be
more opportunities inside rpmPackageFilesInstall to clobber the real
errno which I haven't investigated yet.
---
 lib/psm.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/psm.c b/lib/psm.c
index df09bd3..e327bba 100644
--- a/lib/psm.c
+++ b/lib/psm.c
@@ -806,6 +806,7 @@ static rpmRC rpmpsmStage(rpmpsm psm, pkgStage stage)
 case PSM_PROCESS:
if (psm-goal == PKG_INSTALL) {
int fsmrc = 0;
+   int saved_errno = 0;
 
rpmpsmNotify(psm, RPMCALLBACK_INST_START, 0);
/* make sure first progress call gets made */
@@ -820,6 +821,7 @@ static rpmRC rpmpsmStage(rpmpsm psm, pkgStage stage)
 
fsmrc = rpmPackageFilesInstall(psm-ts, psm-te, psm-fi,
  payload, psm, psm-failedFile);
+   saved_errno = errno;
 
rpmswAdd(rpmtsOp(psm-ts, RPMTS_OP_UNCOMPRESS),
 fdOp(payload, FDSTAT_READ));
@@ -834,7 +836,9 @@ static rpmRC rpmpsmStage(rpmpsm psm, pkgStage stage)
rpmpsmNotify(psm, RPMCALLBACK_INST_STOP, psm-total);
 
if (fsmrc) {
-   char *emsg = rpmcpioStrerror(fsmrc);
+   char *emsg;
+   errno = saved_errno;
+   emsg = rpmcpioStrerror(fsmrc);
rpmlog(RPMLOG_ERR,
_(unpacking of archive failed%s%s: %s\n),
(psm-failedFile != NULL ? _( on file ) : ),
-- 
1.8.3.1

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [Suse patch] debugedit: include compilation directory if used

2007-06-08 Thread Andreas Schwab
Michael Schroeder [EMAIL PROTECTED] writes:

 On Fri, Jun 08, 2007 at 02:25:23PM +0300, Panu Matilainen wrote:
 
 Michael, any idea what the case behind this patch was? It's not that I 
 object to it or anything, I just have no clue what this is supposed to be 
 doing :)

 I just asked Andreas Schwab, the guy who created the patch. He
 said that it is needed so that one can translate relative pathnames
 to absolute ones. (CC to Andreas, maybe he can shed some more light
 on this.)

compilation directory + relative file name must be a valid file name,
which can only be true when the compilation directory exits.

Andreas.

-- 
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint