Re: [Rpm-maint] [rpm-software-management/rpm] Fix GCC compiler error (PR #2656)

2023-09-13 Thread Panu Matilainen
Closed #2656.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2656#event-10356304616
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix GCC compiler error (PR #2656)

2023-09-13 Thread Panu Matilainen
Oh, this "wonderful" quirk of C99. I wonder why newer gcc doesn't complain 
because I don't think it's legit in C11 either.

Fixed a little differently in 34d983fa2a9b9276fc540b6bd554605b2c72689a because 
I hate the way those locally added blocks mess up the git history (or blame 
rather), and for full disclosure in the commit log: it's a regression 
introduced in 071be753cf05b2753efb0d3c51d4fa59b9641d09.

Thanks for the patch!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2656#issuecomment-1717147924
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Fix GCC compiler error (PR #2656)

2023-09-12 Thread Dmitry Mikushin
Fixing the following compiler error on gcc (GCC) 8.5.0 20210514 (RedHat 
8.5.0-18):

```
/root/rpm/plugins/dbus_announce.c:69:5: error: a label can only be part of a 
statement and a declaration is not a statement
 int ignore = dbus_error_has_name(err, DBUS_ERROR_NO_SERVER) ||
 ^~~
```
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2656

-- Commit Summary --

  * Fixing the following compiler error on gcc (GCC) 8.5.0 20210514 (Red Hat 
8.5.0-18):

-- File Changes --

M plugins/dbus_announce.c (12)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2656.patch
https://github.com/rpm-software-management/rpm/pull/2656.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2656
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/2...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint