Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
I prefer handle https://github.com/rpm-software-management/rpm/issues/2362 and https://github.com/rpm-software-management/rpm/issues/1929 since I don't use it but I found many people that use _without (wrongly) https://sourcegraph.com/search?q=context:global+r:src.fedoraproject.org+file:.*%5C.spec%24+%5C%3Fwithout_=regexp=yes=0=repo -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1901260310 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
> ```spec
> # Add handle --{with|without} check
> %__spec_check_pre \
> %{!?with_check:echo "%%check disabled."; exit 0} \
> %{___build_pre}
> ```
Actually this is not all. It needs to be added default value of the
%with_check. So wole solution has two additional lines.
```spec
# Add handle --{with|without} check
%with_check 1
%__spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1900926087
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
> we can use : rpmbuild --without check
This can be added very easy by place in global macros single line modification
```spec
# Add handle --{with|without} check
%__spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}
```
Than you can place in spec file:
```spec
%bcond_with check
```
to disable %check.
I'm using that hack +3 years.
Do you want this as PR? 樂
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1900766922
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
we can use : rpmbuild --without check -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1899391222 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
> I remember people were using `BuildRequires(check)` until this syntax was > prohibited (this might be hint for BZ query smile) Found it, * [Bug 1134397](https://bugzilla.redhat.com/show_bug.cgi?id=1134397) - RFE: %check-only requirements specification * [Bug 1394870](https://bugzilla.redhat.com/show_bug.cgi?id=1394870) - [RFE] Support BuildRequires(check) (closed as duplicate of the previous one) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1580686968 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
@ffesti could you make `BuildRequires(check)` to work as expected ? i.e. ignore them if `--nocheck` was passed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-685868765___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
Did a PR for this on Friday. Comments on #1256 are welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-640425280___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
+1 this would be a great way to standardize on disabling tests! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-639545601___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
+1 so this. Please make it possible. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-475006060___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
Oh, I'm sure packagers would just luv yet more pesky details to fill in. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-330482100___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
@pmatilai It doesn't sound like a bad idea to have `BuildRequires(stage)`, though. That way global controls on stages would have the proper effects during rpmbuild... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-330056943___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
BuildRequires(check) never did anything special, it was just a flaw in the spec parser that BuildRequires(whatever) was accepted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-327117606___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
@voxik actually when I was looking into #104 I had some similar idea for having `BuildRequires(prep)` which are basically needed to unpack archive and run some tool to get new BuildRequires. So it might be not that bad idea. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-327106697___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
I remember people were using ```BuildRequires(check)``` until this syntax was prohibited (this might be hint for BZ query ) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-327104884___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
currently when I pass `--nocheck` to `rpmbuild`, it just skips running check
section, but there is no way to know this from spec file. would be nice if rpm
would add some bcond for this, so packagers can do things like:
```
%if %{with check}
BuildRequires: xxx
%endif
```
or, do something like
```
%global _without_check 1
```
I remember that this was requested in RHBZ, but I can't find link (usual
situation for bugzillas)..
The problem which I hit that MBS can't pass any parameters to koji (and passing
them to mock is complicated in current code), so workaround was to put
`%__spec_check_pre exit 0` in macros file which I don't like.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/316___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
