Re: [Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

[Dmitry V. Levin]

First of all, the github review process is awful, a traditional post to the 
mailing list would be much better.

wrt your patch,

> fprintf(stderr, "%s: refusing to output archive data to a terminal.\n");
> fprintf(stderr, "%s: refusing to output cpio data to a terminal.\n");

what do you mean by not passing any argument to %s format specifier?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/116#issuecomment-271085647___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

[soig]

On 6 January 2017 at 05:11, Neal Gompa (ニール・ゴンパ) 
wrote:

> *@Conan-Kudo* approved this pull request.
>
> Looks fantastic to me!
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>
​+1
This often annoyed me too​ but I never bothered trying to fixing it.
So thanks!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/116#issuecomment-271085180___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

[ニール・ゴンパ]

Conan-Kudo approved this pull request.

Looks fantastic to me!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/116#pullrequestreview-15439382___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

[Peter Jones]

rpm2cpio and rpm2archive happily write binary data to the output
terminal.  This happens, for example, when I'm typing a command such as
"rpm2cpio foo.rpm | less" and I make a typo, hitting  instead of
the pipe key.  This often results in hilarious (if bewildering) font and
character encoding changes.  On some systems, this can even result in
installation of relatively arbitrary rpms!

Nobody has ever meant to do this, and it's easy to prevent, so that's
what this patch does.

Signed-off-by: Peter Jones 
Reviewed-by: Adam Jackson 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/116

-- Commit Summary --

  * rpm2cpio and rpm2archive: don't write archive data to a terminal.

-- File Changes --

M rpm2archive.c (6)
M rpm2cpio.c (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/116.patch
https://github.com/rpm-software-management/rpm/pull/116.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/116
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint