Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sysusers group membership lines (PR #2990)

2024-04-04 Thread Panu Matilainen
@pmatilai approved this pull request.

Other than the dependencies doc nit, looks fine to me now.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2990#pullrequestreview-1978812025
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support for 'm' in sysusers file? (Issue #2816)

2024-04-04 Thread Panu Matilainen
Closed #2816 as completed via ad0eb9a461bce444271d9cf18748e8de821a8960.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2816#event-12352560560
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Ignore non-scriptlet weak dependencies in ordering (PR #3004)

2024-04-04 Thread Panu Matilainen
Merged #3004 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3004#event-12352564263
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Transaction ordering should break dependency loops at weak dependencies (if there are any) (#1346)

2024-04-04 Thread Panu Matilainen
Closed #1346 as completed via #3004.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1346#event-12352564431
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sysusers group membership lines (PR #2990)

2024-04-04 Thread Panu Matilainen
Merged #2990 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2990#event-12352560333
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: ensure unwritable buildroot during %check (Issue #3010)

2024-04-04 Thread Panu Matilainen
Having a separate short-circuit for check is fine, but it's NOT the same 
benefit! I get that you look at the world through mock lenses, but not 
everybody does :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3010#issuecomment-2036261052
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sysusers group membership lines (PR #2990)

2024-04-04 Thread Florian Festi
@ffesti pushed 1 commit.

c3ea56e308e81e83a55ffb1a5b4fe5bb4b6b7cad  Add support for sysusers group 
membership lines

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2990/files/8558a2c2bf06c4b89a4ea59b50cedb80b00c6d87..c3ea56e308e81e83a55ffb1a5b4fe5bb4b6b7cad
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: execute rpmbuild tests as a regular user (Issue #3005)

2024-04-04 Thread Panu Matilainen
> I believe this is not true. I see no code in rpmbuild that would elevate UID 
> to root. Nor any consolehelper. Nor setuid bits.

In the container.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3005#issuecomment-2036268291
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package format draft, major update (Discussion #2919)

2024-04-04 Thread Daniel Alley
How about defaulting to Zstd compression as opposed to Gzip?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2919#discussioncomment-9014566
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add option to use an external decompressor to rpm2cpio and rpm2archive (Issue #1939)

2024-04-04 Thread Daniel Alley
@pmatilai As a behavioral change, perhaps this is suitable for RPM v6?  (as in 
v6 of the tool, not v6 of the format)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1939#issuecomment-2038570348
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package format draft, major update (Discussion #2919)

2024-04-04 Thread Panu Matilainen
It's not a bad idea. Gzip is getting a bit long in the tooth, and I guess all 
distros moved to something better 10-15 years ago.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2919#discussioncomment-9017177
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add option to use an external decompressor to rpm2cpio and rpm2archive (Issue #1939)

2024-04-04 Thread Panu Matilainen
Uh? This would be just an extra option, not replace any existing functionality.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1939#issuecomment-2038983260
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Bump version to 5.99.90 to begin a new devel cycle (PR #3016)

2024-04-04 Thread Panu Matilainen
Let the floodgates open!
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3016

-- Commit Summary --

  * Bump version to 5.99.90 to begin a new devel cycle

-- File Changes --

M CMakeLists.txt (2)
M tests/pinned/rpmsigdig.txt (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3016.patch
https://github.com/rpm-software-management/rpm/pull/3016.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3016
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/3...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] First batch of v6 package format (PR #3017)

2024-04-04 Thread Panu Matilainen
Merged #3017 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3017#event-12355437943
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Ensure rpmbuild's cleanup doesn't fail due to permissions (PR #3006)

2024-04-04 Thread Panu Matilainen
If this breaks something, we're not going to find it by studying this on a 
petri-dish.
I'll merge and if all hell breaks loose in testing, we'll just revert the damn 
thing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3006#issuecomment-2036326288
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Ensure rpmbuild's cleanup doesn't fail due to permissions (PR #3006)

2024-04-04 Thread Panu Matilainen
Merged #3006 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3006#event-12352647299
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Ensure %clean always succeeds (Issue #2519)

2024-04-04 Thread Panu Matilainen
Closed #2519 as completed via #3006.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2519#event-12352647496
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Stop populating os and arch in the lead structure (Issue #2368)

2024-04-04 Thread Panu Matilainen
Closed #2368 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2368#event-12355469187
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Stop populating os and arch in the lead structure (Issue #2368)

2024-04-04 Thread Panu Matilainen
Done in #3017 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2368#issuecomment-2036746689
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Ensure unique tags in signature header (#1570)

2024-04-04 Thread Panu Matilainen
The tag conflicts between signature and header are gone as of #3017, what 
remains is to error out if tags >= 1000 are found in v6 signature header.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1570#issuecomment-2036760091
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Random failure on dependency generation 3 test (Issue #2470)

2024-04-04 Thread Panu Matilainen
Reopened #2470.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2470#event-12354300211
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Random failure on dependency generation 3 test (Issue #2470)

2024-04-04 Thread Panu Matilainen
Not so fast it seems, I just got this:

```
+++ /srv/rpmtests.dir/at-groups/353/stderr  2024-04-04 08:40:58.419002150 
+
@@ -1,2 +1,2 @@
-error: Illegal char '*' (0x2a) in: *
+error: failed to write all data to /tmp/bad.req: Broken pipe
```

But at least it's now hinting at the problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2470#issuecomment-2036561135
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] First batch of v6 package format (PR #3017)

2024-04-04 Thread Panu Matilainen
Here we go. Details in commits, and this is obviously nowhere near complete, 
the v6 work will be on-going throughout the year.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3017

-- Commit Summary --

  * Start a v6 format draft doc
  * Add tests for v6 package structure and digests, equal to v4 just now
  * First commit of rpm v6: add version switch, drop obsolete signature tags
  * Introduce new payloadsize + alt tags in the v6 main header
  * Always use long filesizes and the new non-cpio payload format 
on v6
  * Add a new unique v6-only reserved signature tag below header base
  * Add rpm package format version as a tag to = v6 packages.
  * Dont populate os and arch in the lead structure
  * Bump the rpm version in the lead to 4 for v6 packages

-- File Changes --

M build/files.c (7)
M build/pack.c (49)
M build/rpmbuild_internal.h (1)
M build/spec.c (1)
A docs/manual/format_v6.md (132)
M docs/manual/index.md (1)
M include/rpm/rpmtag.h (6)
M lib/rpmlead.c (10)
M lib/signature.c (15)
M lib/signature.h (4)
M macros.in (6)
M sign/rpmgensig.c (7)
M tests/data/misc/rpmdump4.txt (4)
A tests/data/misc/rpmdump6.txt (394)
M tests/pinned/common/buildrepr.sh (1)
M tests/pinned/common/rpmsigdig.sh (2)
M tests/pinned/rpmsigdig.txt (2)
A tests/pinned/rpmsigdig6.sh (5)
A tests/pinned/rpmsigdig6.txt (11)
M tests/rpmgeneral.at (3)
M tests/rpmpkgfmt.at (17)
M tests/rpmsigdig.at (3)
M tools/rpmdump.c (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3017.patch
https://github.com/rpm-software-management/rpm/pull/3017.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3017
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/3...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Default to 64bit size tags in headers (#864)

2024-04-04 Thread Panu Matilainen
Done in #3017 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/864#issuecomment-2036747341
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Default to 64bit size tags in headers (#864)

2024-04-04 Thread Panu Matilainen
Closed #864 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/864#event-12355475047
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Phasing out obsolete crypto in rpm (#1292)

2024-04-04 Thread Panu Matilainen
Obsolete crypto tags are gone from v6 packages  in #3017 , what remains to be 
done is disabling validation on those by default.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1292#issuecomment-2036758478
You are receiving this because you commented.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Bump version to 5.99.90 to begin a new devel cycle (PR #3016)

2024-04-04 Thread Panu Matilainen
Merged #3016 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3016#event-12354439990
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Start a v6 format draft doc (PR #2988)

2024-04-04 Thread Panu Matilainen
Closed #2988.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2988#event-12355359872
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Pass arg3 to regular and file trigger scripts (PR #3018)

2024-04-04 Thread Michal Domonkos
Details in the commit messages (GH didnt populate the description 
automatically for some reason).
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3018

-- Commit Summary --

  * Rename script-args to script-prog
  * Replace hacky hge-style array with ARGV_t
  * Pass scriptlet args via a new function internally
  * Pass arg2 (albeit -1) to transaction triggers too
  * Pass arg3 to regular and file trigger scripts

-- File Changes --

M docs/manual/file_triggers.md (2)
M docs/manual/triggers.md (9)
M include/rpm/argv.h (9)
M lib/psm.c (11)
M lib/rpmscript.c (63)
M lib/rpmscript.h (7)
M lib/rpmtriggers.c (10)
M lib/rpmts_internal.h (2)
M lib/transaction.c (5)
M rpmio/argv.c (27)
M tests/data/SPECS/filetriggers.spec (2)
M tests/rpmscript.at (74)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3018.patch
https://github.com/rpm-software-management/rpm/pull/3018.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3018
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/3...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin doesn't share what's in transaction (#386)

2024-04-04 Thread Michal Domonkos
As mentioned above, this is indeed expected behavior; when the trigger source 
is part of the transaction, the trigger is also activated, and is fed *all* the 
matching prefixes. It's analogous to *all* the packages shipping files in the 
`/` prefix being part of the transaction.

That said, I can see how this would be useful to distinguish in the trigger so 
I've submitted #3018.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/386#issuecomment-2037045744
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint