RE: [Samba] Sync unix and samba passwords
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Craig Jackson Sent: Friday, September 29, 2006 3:57 PM To: samba@lists.samba.org Subject: [Samba] Sync unix and samba passwords Hi, We have an Exchange server (server 2003) that is a domain controller and a few Samba file servers that are not part of the Windows domain. The Samba servers use their own LDAP directory ( ldapsam backend with pam_ldap ) that is synchronized to one openldap directory server but is not synchronized to the Windows domain AD. The workstations are all local accounts and not members of any domain either. I am happy with this arrangement despite having to enter user information twice and would rather not change it. Goal: I would like to use Services for Unix on the Windows AD controller to synchronize linux passwords so that the end user has to change password once for email/Samba and once for local computer. Problem: When Linux administrator issues the passwd command as in # passwd username the ldap userPassword attribute is changed correctly but the Samba NT/LM passwords are not also changed. What I have already done: Googled the issue and found that unix passwd sync in smb.conf is not what I need. Ldap passwd sync = yes is in smb.conf. I have found some info on pam_smbpass.so but do not have enough information to know if this is what I need and how to use it. Or can someone tell me if this will not work at all. Better ideas? Thanks! Craig -- Samba docs say that pam_smbpass.so is in fact what I need and I have added the following line to /etc/pam.d/common-passwd password required pam_smbpass.so nullok use_authtok try_first_pass But #passwd user doesn't sync the LDAP NT/LM passwords and there is this in the log: CRON[18769]: PAM adding faulty module: /lib/security/pam_smbpass.so According to Samba docs, pam_smbpass.so is used to keep the smbpasswd (Samba password) database in sync, but does that really mean ONLY smbpasswd or any Samba backend? Thanks. Craig -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Accesserror when using smbpasswd
Hi there.. after removing,installing, compiling samba, removing and again installing it using apt-get, smbd and nmbd wouldn't start anymore.. I then deleted all tdb's in /var/lib/samba, and reinstalled samba again. Smbd/nmbd then started, but now when I try to add a user using smbpass -a it it gives me an accesserror. Although all tdb's were automatically created in /var/lib/samba.. they do exist there. Please could someone tell me what might be wrong? Thnx for any help! Regards, Michael -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Re: Accesserror when using smbpasswd
BTW: This is samba.latest 23c-1 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] wbinfo -u not working against Windows 2003 DC
Hello all, This is my first post on this list, so please bear with me. :-) I'm managing a couple of Samba servers located at our customers. Since a couple of weeks we have a problem with winbind on one of our samba servers. It runs in a mixed Windows/Samba environment where a W2k3 server is the PDC. As far as I know it runs in mixed mode. Is there any way I can check this (WINS is running btw)? Until today we used samba 3.0.3 on a Fedora Core 2 server, but I have upgraded this to 3.0.23c using a SRPM. The problem as of two weeks is that it no longer looks up domain users from the PDC. Users are no longer of the form DOMAIN\User, but looked like a local account: user, when running smbstatus. The gid is now nobody instead of DOMAIN\Domain Users. I have now upgraded to version 3.0.23c and now it won't let domain users logon to the samba server. Samba had joined the domain and net rpc testjoin returns ok. I've added winbind to /etc/nsswitch.conf: passwd:files winbind shadow:files group: files winbind And libnss_winbind.so exists in /lib: -rwxr-xr-x 1 root root 17972 Sep 29 18:23 /lib/libnss_winbind.so lrwxrwxrwx 1 root root17 Sep 30 15:42 /lib/libnss_winbind.so.2 - libnss_winbind.so When running winbindd -d 2 -i I get: winbindd version 3.0.23c started. Copyright The Samba Team 2000-2004 Processing section [sas] Processing section [printers] added interface ip=172.17.0.247 bcast=172.17.0.255 nmask=255.255.255.0 added interface ip=172.17.0.247 bcast=172.17.0.255 nmask=255.255.255.0 Registered MSG_REQ_POOL_USAGE Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED Added domain SOLINES S-1-5-21-2535601797-1986373083-18572363 Added domain SOLSAMBA S-1-5-21-1760014737-3532484745-1612504851 Added domain BUILTIN S-1-5-32 ads_dns_lookup_srv: Failed to resolve _ldap._tcp.dc._msdcs.solines (Success) ads_connect for domain SOLINES failed: Operations error My question is: when W2K3 is running in mixed mode can I run samba with security=domain, or must I use security=ads? The above situation has always worked. Can anyone give me some advice or is there something I've overlooked?? Best regards, Alexander van der Leun -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] mssql, problem authenticating from stored procedure...
Hello, running plain samba 3.023c on debian, I'm trying to connect to a samba share from within a stored procedure. This works as long as samba is in share mode: [2006/09/29 14:53:01, 5] auth/auth.c:check_ntlm_password(309) check_ntlm_password: guest authentication for user [] - [] - [nobody] succeeded When I try to attach samba share manually when logged in as the user running the sqlserver agent, it also works: [2006/09/30 17:58:43, 2] auth/auth.c:check_ntlm_password(309) check_ntlm_password: authentication for user [sqlserver] - [sqlserver] - [sqlserver] succeeded But when running the stored procedure, which causes the sqlserver user to login to the samba server I get this: [2006/09/30 17:59:28, 2] auth/auth.c:check_ntlm_password(319) check_ntlm_password: Authentication for user [sqlserver] - [sqlserver] FAILED with error NT_STATUS_WRONG_PASSWORD This is extremely strange to me... :( Any ideas is greatly appreciated... :) /Kristoffer but when user authentication is needed -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] why are nmbd browser elections classed as err
shouldn't they be info messages instead? the huge number of fake errors makes syslog management difficult -- Eric A. Hallhttp://www.ehsco.com/ Internet Core Protocols http://www.oreilly.com/catalog/coreprot/ -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] wbinfo -u not working against Windows 2003 DC
Alexander van der Leun wrote: Hello all, This is my first post on this list, so please bear with me. :-) I'm managing a couple of Samba servers located at our customers. Since a couple of weeks we have a problem with winbind on one of our samba servers. It runs in a mixed Windows/Samba environment where a W2k3 server is the PDC. As far as I know it runs in mixed mode. Is there any way I can check this (WINS is running btw)? Until today we used samba 3.0.3 on a Fedora Core 2 server, but I have upgraded this to 3.0.23c using a SRPM. The problem as of two weeks is that it no longer looks up domain users from the PDC. Users are no longer of the form DOMAIN\User, but looked like a local account: user, when running smbstatus. The gid is now nobody instead of DOMAIN\Domain Users. I have now upgraded to version 3.0.23c and now it won't let domain users logon to the samba server. Samba had joined the domain and net rpc testjoin returns ok. I've added winbind to /etc/nsswitch.conf: passwd:files winbind shadow:files group: files winbind And libnss_winbind.so exists in /lib: -rwxr-xr-x 1 root root 17972 Sep 29 18:23 /lib/libnss_winbind.so lrwxrwxrwx 1 root root17 Sep 30 15:42 /lib/libnss_winbind.so.2 - libnss_winbind.so When running winbindd -d 2 -i I get: winbindd version 3.0.23c started. Copyright The Samba Team 2000-2004 Processing section [sas] Processing section [printers] added interface ip=172.17.0.247 bcast=172.17.0.255 nmask=255.255.255.0 added interface ip=172.17.0.247 bcast=172.17.0.255 nmask=255.255.255.0 Registered MSG_REQ_POOL_USAGE Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED Added domain SOLINES S-1-5-21-2535601797-1986373083-18572363 Added domain SOLSAMBA S-1-5-21-1760014737-3532484745-1612504851 Added domain BUILTIN S-1-5-32 ads_dns_lookup_srv: Failed to resolve _ldap._tcp.dc._msdcs.solines (Success) ads_connect for domain SOLINES failed: Operations error My question is: when W2K3 is running in mixed mode can I run samba with security=domain, or must I use security=ads? The above situation has always worked. Can anyone give me some advice or is there something I've overlooked?? As far as the users go, I'm seeing the same situation in security=ads mode and idmap backend=ad, and have previously posted but gotten no resolution. As a workaround, I can get users logged on with file access by individually mapping the domain members to the local accounts using usermap. But for your situation, you need to post at least the security, realm, winbind, and idmap backend options you are using to make sense of this. If your Realm is MY.REALM.COM, the DNS record should be _ldap._tcp.dc._msdcs.my.realm.com it's an SRV record that contains the address of the DC. Samba thinks your realm is the domain name right now, maybe because you don't have a realm option in smb.conf. Regards, Doug -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] How to handle domain logons if users using same accountname are logged on the same time?
Hi, I'm working at a small office. I'm running Samba 2.x for about a year without any problem, it's working absolutely GREAT and the community kicks ass :) We don't have too many machines so about 6 Users use about 3 PCs to do similar tasks. I just setup samba latest 23c-1 as a DC because we got some more machines, and everything's fine. Except when the same account is used on multiple machines the same time, there are problems of course. It simply doesn't make sense to me to create different accounts if users who are using these machines change frequently and they all do the same tasks.. I even couldn't control whether they login as acc1 or acc2 on machine1 or 2. Let's say account xyz is logged in on two machines the same time. If a user saves a file on the desktop on machine 1, and the user on machine 2 logges off after user on machine 1 logges off it happenes that the changes done to a location like desktop are not synchronised properly on the server share.. How should I handle this? Deny all access to Desktop? Also it would be a problem if an application is installed on a machine using the same account which is currently used on another machine. Would I need to make sure each account is used only one time at once? Sorry, these are total newbie questions.. I used the official samba howto practice tuts, but these questions aren't covered it seems.. I really don't know how I should/could handle this. Could someone plz point me to the right direction? Would be very appreciated and very very nice. Thnx, Regards, Michael Rignaz -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Re: Accesserror when using smbpasswd
Michael Rignaz schrieb: BTW: This is samba.latest 23c-1 Sorry for bothering this group, I just reinstalled debian (was a fresh install before too) and everything's fine now.. still don't know what the problem was though.. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Re: How to handle domain logons if users using same accountname are logged on the same time?
I'd especially like to know how to force users to store their files on the home share rather than on Desktop, without mounting the desktop path on the home network share.. How could I deny write access to the Desktop globally? Thnx a lot Regards, Michael Rignaz -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
RE: [Samba] Sync unix and samba passwords
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Craig Jackson Sent: Saturday, September 30, 2006 8:06 AM To: samba@lists.samba.org Subject: RE: [Samba] Sync unix and samba passwords -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Craig Jackson Sent: Friday, September 29, 2006 3:57 PM To: samba@lists.samba.org Subject: [Samba] Sync unix and samba passwords Hi, We have an Exchange server (server 2003) that is a domain controller and a few Samba file servers that are not part of the Windows domain. The Samba servers use their own LDAP directory ( ldapsam backend with pam_ldap ) that is synchronized to one openldap directory server but is not synchronized to the Windows domain AD. The workstations are all local accounts and not members of any domain either. I am happy with this arrangement despite having to enter user information twice and would rather not change it. Goal: I would like to use Services for Unix on the Windows AD controller to synchronize linux passwords so that the end user has to change password once for email/Samba and once for local computer. Problem: When Linux administrator issues the passwd command as in # passwd username the ldap userPassword attribute is changed correctly but the Samba NT/LM passwords are not also changed. What I have already done: Googled the issue and found that unix passwd sync in smb.conf is not what I need. Ldap passwd sync = yes is in smb.conf. I have found some info on pam_smbpass.so but do not have enough information to know if this is what I need and how to use it. Or can someone tell me if this will not work at all. Better ideas? Thanks! Craig -- Samba docs say that pam_smbpass.so is in fact what I need and I have added the following line to /etc/pam.d/common-passwd password required pam_smbpass.so nullok use_authtok try_first_pass But #passwd user doesn't sync the LDAP NT/LM passwords and there is this in the log: CRON[18769]: PAM adding faulty module: /lib/security/pam_smbpass.so According to Samba docs, pam_smbpass.so is used to keep the smbpasswd (Samba password) database in sync, but does that really mean ONLY smbpasswd or any Samba backend? #apt-get install pam_smbpass fixed the faulty module error -- DUH! but still no sync of LDAP smb passwords after changing unix password with passwd command. Using samba 3.022 on Ubuntu Dapper Is this the right list for this? Thanks. Craig -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Re: How to handle domain logons if users using same accountname are logged on the same time?
On Sun, 2006-10-01 at 10:15 +0200, Michael Rignaz wrote: I'd especially like to know how to force users to store their files on the home share rather than on Desktop, without mounting the desktop path on the home network share.. How could I deny write access to the Desktop globally? Thnx a lot Regards, Michael Rignaz Hi Michael, What you want to do is called folder redirection in windoze-speak. It is discussed on the samba wiki (http://wiki.samba.org/index.php/Samba__Windows_Profiles) and in many other places. The object is to control windoze' pathological desire to copy every fsck'n file to every client on your network, and the file server. Folder redirection can be accomplished two ways, AFAIK. One is on the client (I'm assuming XP) with the Group Policy Object snap in (start run gpedit.msc), the other is by using system policies as in NT4. Both can be googled. Hope that gets you started. Steve G -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
svn commit: samba r19009 - in branches/SAMBA_4_0/source/lib/ldb/ldb_ldap: .
Author: tridge
Date: 2006-09-30 07:54:20 + (Sat, 30 Sep 2006)
New Revision: 19009
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19009
Log:
ensure that data values from ldap libs are null terminated, to allow
ldb_msg_find_attr_as_string() to work correctly.
Thanks to Jim Myers for spotting this!
Modified:
branches/SAMBA_4_0/source/lib/ldb/ldb_ldap/ldb_ldap.c
Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/ldb_ldap/ldb_ldap.c
===
--- branches/SAMBA_4_0/source/lib/ldb/ldb_ldap/ldb_ldap.c 2006-09-29
21:26:33 UTC (rev 19008)
+++ branches/SAMBA_4_0/source/lib/ldb/ldb_ldap/ldb_ldap.c 2006-09-30
07:54:20 UTC (rev 19009)
@@ -210,10 +210,15 @@
}
for (i=0;icount;i++) {
- el-values[i].data = talloc_memdup(el-values, bval[i]-bv_val,
bval[i]-bv_len);
+ /* we have to ensure this is null terminated so that
+ ldb_msg_find_attr_as_string() can work */
+ el-values[i].data = talloc_size(el-values, bval[i]-bv_len+1);
if (!el-values[i].data) {
+ errno = ENOMEM;
return -1;
}
+ memcpy(el-values[i].data, bval[i]-bv_val, bval[i]-bv_len);
+ el-values[i].data[bval[i]-bv_len] = 0;
el-values[i].length = bval[i]-bv_len;
el-num_values++;
}
svn commit: samba r19010 - in branches/SAMBA_3_0/source/smbd: .
Author: vlendec
Date: 2006-09-30 09:45:53 + (Sat, 30 Sep 2006)
New Revision: 19010
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19010
Log:
Fix bug 4137
Modified:
branches/SAMBA_3_0/source/smbd/share_access.c
Changeset:
Modified: branches/SAMBA_3_0/source/smbd/share_access.c
===
--- branches/SAMBA_3_0/source/smbd/share_access.c 2006-09-30 07:54:20 UTC
(rev 19009)
+++ branches/SAMBA_3_0/source/smbd/share_access.c 2006-09-30 09:45:53 UTC
(rev 19010)
@@ -217,6 +217,10 @@
const char *list[2];
list[0] = lp_username(snum);
list[1] = NULL;
+ if ((list[0] == NULL) || (*list[0] == '\0')) {
+ DEBUG(0, ('only user = yes' and no 'username ='\n));
+ return False;
+ }
if (!token_contains_name_in_list(NULL, lp_servicename(snum),
token, list)) {
DEBUG(10, (%s != 'username'\n, username));
svn commit: samba r19011 - in branches/SAMBA_3_0/source/lib/replace: .
Author: vlendec
Date: 2006-09-30 14:12:02 + (Sat, 30 Sep 2006)
New Revision: 19011
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19011
Log:
Attempt to fix the BSD RAW-CHKPATH failures: In Samba3 we rely on opendir
returning ENOTDIR when the file opened is not a directory. Can we merge this
back into Samba4?
Volker
Modified:
branches/SAMBA_3_0/source/lib/replace/repdir_getdents.c
branches/SAMBA_3_0/source/lib/replace/repdir_getdirentries.c
Changeset:
Modified: branches/SAMBA_3_0/source/lib/replace/repdir_getdents.c
===
--- branches/SAMBA_3_0/source/lib/replace/repdir_getdents.c 2006-09-30
09:45:53 UTC (rev 19010)
+++ branches/SAMBA_3_0/source/lib/replace/repdir_getdents.c 2006-09-30
14:12:02 UTC (rev 19011)
@@ -68,6 +68,7 @@
DIR *opendir(const char *dname)
{
struct dir_buf *d;
+ struct stat sb;
d = malloc(sizeof(*d));
if (d == NULL) {
errno = ENOMEM;
@@ -78,6 +79,17 @@
free(d);
return NULL;
}
+ if (fstat(d-fd, sb) 0) {
+close(d-fd);
+free(d);
+return NULL;
+}
+if (!S_ISDIR(sb.st_mode)) {
+close(d-fd);
+free(d);
+errno = ENOTDIR;
+return NULL;
+}
d-ofs = 0;
d-seekpos = 0;
d-nbytes = 0;
Modified: branches/SAMBA_3_0/source/lib/replace/repdir_getdirentries.c
===
--- branches/SAMBA_3_0/source/lib/replace/repdir_getdirentries.c
2006-09-30 09:45:53 UTC (rev 19010)
+++ branches/SAMBA_3_0/source/lib/replace/repdir_getdirentries.c
2006-09-30 14:12:02 UTC (rev 19011)
@@ -70,6 +70,7 @@
DIR *opendir(const char *dname)
{
struct dir_buf *d;
+ struct stat sb;
d = malloc(sizeof(*d));
if (d == NULL) {
errno = ENOMEM;
@@ -80,6 +81,17 @@
free(d);
return NULL;
}
+ if (fstat(d-fd, sb) 0) {
+close(d-fd);
+free(d);
+return NULL;
+}
+if (!S_ISDIR(sb.st_mode)) {
+close(d-fd);
+free(d);
+errno = ENOTDIR;
+return NULL;
+}
d-ofs = 0;
d-seekpos = 0;
d-nbytes = 0;
svn commit: samba-docs r988 - in trunk/Samba3-HOWTO: .
Author: jht Date: 2006-09-30 16:58:18 + (Sat, 30 Sep 2006) New Revision: 988 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=988 Log: Adding samba user comments and feedback. Modified: trunk/Samba3-HOWTO/TOSHARG-NetworkBrowsing.xml Changeset: Modified: trunk/Samba3-HOWTO/TOSHARG-NetworkBrowsing.xml === --- trunk/Samba3-HOWTO/TOSHARG-NetworkBrowsing.xml 2006-09-13 17:08:53 UTC (rev 987) +++ trunk/Samba3-HOWTO/TOSHARG-NetworkBrowsing.xml 2006-09-30 16:58:18 UTC (rev 988) @@ -4,8 +4,15 @@ chapterinfo author.jht; author.jelmer; + author + firstnameJonathan/firstnamesurnameJohnson/surname + affiliation + orgnameSutinen Consulting, Inc./orgname +addressemail[EMAIL PROTECTED]/email/address + /affiliation + /author pubdateJuly 5, 1998/pubdate - pubdateUpdated: April 21, 2003/pubdate + pubdateUpdated: September 20, 2006/pubdate /chapterinfo titleNetwork Browsing/title @@ -14,6 +21,7 @@ indextermprimarybrowsing across subnets/primary/indexterm indextermprimaryresolution of NetBIOS names/primary/indexterm indextermprimarybrowse list handling/primary/indexterm +indextermprimaryWINS/primary/indexterm This chapter contains detailed information as well as a fast-track guide to implementing browsing across subnets and/or across workgroups (or domains). WINS is the best tool for resolution of NetBIOS names to IP addresses; however, WINS is @@ -21,6 +29,15 @@ /para notepara +indextermprimaryWINS/primary/indexterm +What is WINS? +/para +para +WINS is a facility that provides resolution of a NetBIOS name to its IP address. WINS is like a +Dynamic-DNS service for NetBIOS networking names. +/para/note + +notepara indextermprimaryWindows 2000/primary/indexterm indextermprimaryNetBIOS over TCP/IP/primary/indexterm indextermprimaryDNS/primary/indexterm @@ -2168,5 +2185,41 @@ /variablelist /sect2 +sect2 +titleInvalid Cached Share References Affects Network Browsing/title +para +Cached references on your MS Windows client (workstation or server) to shares or servers that no longer exist +can cause MS Windows Explorer to appear unresponsive as it tries to connect to these shares. After a delay +(can take a long time) it times out and browsing will appear to be mostly normal again. +/para + +para +To eliminate the problem the stale cached references should be removed. This does not happen automatically and +requires manual intervention. This is a design feature of MS Windows and not anything that Samba can change. +To remove the stale shortcuts found in emphasisMy Network Places/emphasis which refer to what are now +invalid shares or servers it is necessary to edit the Windows Registry under +literalHKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\/literal. Edit the entry +literalMountPoints2/literal (on Windows XP and later, or literalMountPoints/literal on +Windows 2000 and earlier). Remove all keys named literal\\server\share/literal (where 'server' and 'share' refer to a +non-existent server or share). Note that this must be done for every user profile that has such stale +references. +/para + +para +Samba users have reported that these stale references negatively affect network browsing with Windows, Samba, +and Novell servers. They suspect it is a universal problem not directly related to the existence of a Samba +server. Samba users may experience this more often due to Samba being somewhat viewed as an experimenter's +toolkit. This results from the fact that a user might go through several reconfigurations and incarnations of +their Samba server, by different names, with different shares, increasing the chances for having stale +(invalid) cached share references. Strangely (or not so strangely), Windows does not seem to expire these +references. I am not sure how or why the registry keys are created. +/para + +para +It is common for emphasisOpen/emphasis dialog boxes (for example; in Word and Excel) to respond very +slowly, as they attempt to locate all of the cached references, even if they are not in the current directory +being accessed. +/para +/sect2 /sect1 /chapter
svn commit: samba r19012 - in branches/SAMBA_3_0/source/libgpo: .
Author: vlendec
Date: 2006-09-30 17:20:02 + (Sat, 30 Sep 2006)
New Revision: 19012
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19012
Log:
Fix an uninitialized variable
Modified:
branches/SAMBA_3_0/source/libgpo/gpo_filesync.c
Changeset:
Modified: branches/SAMBA_3_0/source/libgpo/gpo_filesync.c
===
--- branches/SAMBA_3_0/source/libgpo/gpo_filesync.c 2006-09-30 14:12:02 UTC
(rev 19011)
+++ branches/SAMBA_3_0/source/libgpo/gpo_filesync.c 2006-09-30 17:20:02 UTC
(rev 19012)
@@ -40,7 +40,8 @@
const char *unix_path)
{
NTSTATUS result;
- int fnum, fd;
+ int fnum;
+ int fd = 0;
char *data = NULL;
static int io_bufsize = 64512;
int read_size = io_bufsize;
svn commit: samba r19013 - in branches/SAMBA_3_0/source/rpcclient: .
Author: vlendec
Date: 2006-09-30 17:32:26 + (Sat, 30 Sep 2006)
New Revision: 19013
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19013
Log:
Fix some 64-bit warnings.
Jelmer, Jerry, in cmd_unixinfo.c:159 there is still the warning that info is
being used uninitialized which I don't really know how to fix.
Any hints?
Volker
Modified:
branches/SAMBA_3_0/source/rpcclient/cmd_lsarpc.c
branches/SAMBA_3_0/source/rpcclient/cmd_samr.c
branches/SAMBA_3_0/source/rpcclient/cmd_unixinfo.c
Changeset:
Modified: branches/SAMBA_3_0/source/rpcclient/cmd_lsarpc.c
===
--- branches/SAMBA_3_0/source/rpcclient/cmd_lsarpc.c2006-09-30 17:20:02 UTC
(rev 19012)
+++ branches/SAMBA_3_0/source/rpcclient/cmd_lsarpc.c2006-09-30 17:32:26 UTC
(rev 19013)
@@ -63,9 +63,9 @@
{
d_printf(percent_full:\t%d\n, d.percent_full);
d_printf(log_size:\t%d\n, d.log_size);
- d_printf(retention_time:\t%lld\n, d.retention_time);
+ d_printf(retention_time:\t%lld\n, (long long)d.retention_time);
d_printf(shutdown_in_progress:\t%d\n, d.shutdown_in_progress);
- d_printf(time_to_shutdown:\t%lld\n, d.time_to_shutdown);
+ d_printf(time_to_shutdown:\t%lld\n, (long long)d.time_to_shutdown);
d_printf(next_audit_record:\t%d\n, d.next_audit_record);
d_printf(unknown:\t%d\n, d.unknown);
}
Modified: branches/SAMBA_3_0/source/rpcclient/cmd_samr.c
===
--- branches/SAMBA_3_0/source/rpcclient/cmd_samr.c 2006-09-30 17:20:02 UTC
(rev 19012)
+++ branches/SAMBA_3_0/source/rpcclient/cmd_samr.c 2006-09-30 17:32:26 UTC
(rev 19013)
@@ -165,7 +165,7 @@
printf(Total Groups:\t%d\n, info2-num_domain_grps);
printf(Total Aliases:\t%d\n, info2-num_local_grps);
- printf(Sequence No:\t%lld\n, info2-seq_num);
+ printf(Sequence No:\t%llu\n, (unsigned long long)info2-seq_num);
printf(Force Logoff:\t%d\n, (int)nt_time_to_unix_abs(info2-logout));
@@ -210,7 +210,7 @@
static void display_sam_unk_info_8(SAM_UNK_INFO_8 *info8)
{
- printf(Sequence No:\t%lld\n, info8-seq_num);
+ printf(Sequence No:\t%llu\n, (unsigned long long)info8-seq_num);
printf(Domain Create Time:\t%s\n,
http_timestring(nt_time_to_unix(info8-domain_create_time)));
}
@@ -229,7 +229,7 @@
static void display_sam_unk_info_13(SAM_UNK_INFO_13 *info13)
{
- printf(Sequence No:\t%lld\n, info13-seq_num);
+ printf(Sequence No:\t%llu\n, (unsigned long long)info13-seq_num);
printf(Domain Create Time:\t%s\n,
http_timestring(nt_time_to_unix(info13-domain_create_time)));
printf(Unknown1:\t%d\n, info13-unknown1);
Modified: branches/SAMBA_3_0/source/rpcclient/cmd_unixinfo.c
===
--- branches/SAMBA_3_0/source/rpcclient/cmd_unixinfo.c 2006-09-30 17:20:02 UTC
(rev 19012)
+++ branches/SAMBA_3_0/source/rpcclient/cmd_unixinfo.c 2006-09-30 17:32:26 UTC
(rev 19013)
@@ -70,7 +70,7 @@
if (!NT_STATUS_IS_OK(result))
goto done;
- printf(%llu\n, uid);
+ printf(%llu\n, (unsigned long long)uid);
done:
return result;
@@ -125,7 +125,7 @@
if (!NT_STATUS_IS_OK(result))
goto done;
- printf(%llu\n, gid);
+ printf(%llu\n, (unsigned long long)gid);
done:
return result;
@@ -164,10 +164,11 @@
for (i=0; inum_uids; i++) {
if (NT_STATUS_IS_OK(info[i].status)) {
- printf(%llu:%s:%s\n, uids[i], info[i].homedir,
- info[i].shell);
+ printf(%llu:%s:%s\n, (unsigned long long)uids[i],
+ info[i].homedir, info[i].shell);
} else {
- printf(%llu:%s\n, uids[i], nt_errstr(info[i].status));
+ printf(%llu:%s\n, (unsigned long long)uids[i],
+ nt_errstr(info[i].status));
}
}
svn commit: samba r19014 - in branches/SAMBA_3_0_23/source/smbd: .
Author: vlendec
Date: 2006-09-30 21:30:24 + (Sat, 30 Sep 2006)
New Revision: 19014
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19014
Log:
By request of Tom Bork, merge r19010 from 3_0
Modified:
branches/SAMBA_3_0_23/source/smbd/share_access.c
Changeset:
Modified: branches/SAMBA_3_0_23/source/smbd/share_access.c
===
--- branches/SAMBA_3_0_23/source/smbd/share_access.c2006-09-30 17:32:26 UTC
(rev 19013)
+++ branches/SAMBA_3_0_23/source/smbd/share_access.c2006-09-30 21:30:24 UTC
(rev 19014)
@@ -214,6 +214,10 @@
const char *list[2];
list[0] = lp_username(snum);
list[1] = NULL;
+ if ((list[0] == NULL) || (*list[0] == '\0')) {
+ DEBUG(0, ('only user = yes' and no 'username ='\n));
+ return False;
+ }
if (!token_contains_name_in_list(NULL, lp_servicename(snum),
token, list)) {
DEBUG(10, (%s != 'username'\n, username));
Build status as of Sun Oct 1 00:00:02 2006
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2006-09-30 00:00:10.0 + +++ /home/build/master/cache/broken_results.txt 2006-10-01 00:01:04.0 + @@ -1,21 +1,21 @@ -Build status as of Sat Sep 30 00:00:01 2006 +Build status as of Sun Oct 1 00:00:02 2006 Build counts: Tree Total Broken Panic SOC 0 0 0 build_farm 0 0 0 -ccache 39 8 0 -distcc 39 6 0 -ldb 36 5 0 -libreplace 37 1 0 -lorikeet-heimdal 3 2 0 +ccache 38 7 0 +distcc 38 7 0 +ldb 35 5 0 +libreplace 37 2 0 +lorikeet-heimdal 2 2 0 ppp 17 0 0 -rsync39 10 0 +rsync38 11 0 samba0 0 0 samba-docs 0 0 0 -samba4 39 9 1 -samba_3_039 16 1 +samba4 36 9 1 +samba_3_038 11 1 smb-build31 3 0 -talloc 40 4 0 +talloc 40 5 0 tdb 38 2 0
svn commit: linux-cifs-client r86 - in branches/linux-2.6-cifs-git-devel/fs/cifs: .
Author: sfrench Date: 2006-10-01 02:42:30 + (Sun, 01 Oct 2006) New Revision: 86 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=linux-cifs-clientrev=86 Log: Missing file Added: branches/linux-2.6-cifs-git-devel/fs/cifs/sess.c Changeset: Sorry, the patch is too large (544 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=linux-cifs-clientrev=86
