Re: CVS update: samba/source/printing

2003-03-04 Thread Gerald (Jerry) Carter 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Tue, 4 Mar 2003 [EMAIL PROTECTED] wrote:

 
 Date: Tue Mar  4 09:33:34 2003
 Author:   abartlet
 
 Update of /data/cvs/samba/source/printing
 In directory dp.samba.org:/tmp/cvs-serv25296/printing
 
 Modified Files:
   nt_printing.c 
 Log Message:

 Fix another 'off by one' bug with safe_strcpy().  It is unclear if the
 intent was to limit the string to 31 or 32 characters (excluding the
 null term), so I've assumed for now that 32 is fine, as this matches
 current behaviour (well, current behaviour would crash, but anyway...)
 
 Jerry:  Can you look at this for me?

The devicename is truncated at 32 characters (including NULL).  See
spool_io_devmode() for details.  This probably should be a memcpy of MAX
size 32 instead of a string copy. You change won't break anything I don't
think, but i'll fix it up so the intent of the code is a little more
clear.




cheers, jerry
 --
 Hewlett-Packard- http://www.hp.com
 SAMBA Team -- http://www.samba.org
 GnuPG Key   http://www.plainjoe.org/gpg_public.asc
 You can never go home again, Oatman, but I guess you can shop there.  
--John Cusack - Grosse Point Blank (1997)

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE+ZKlsIR7qMdg1EfYRAm5RAKCXW+XAz91RTeL7EnSYNd5RQlqF7gCgpmkf
dEHvZ+v2VNtrkPw+Y+ENgVs=
=qS3b
-END PGP SIGNATURE-

Re: CVS update: samba/source/printing

2003-02-12 Thread jra 
On Wed, Feb 12, 2003 at 09:03:44AM -0600, Gerald (Jerry) Carter wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 On Wed, 12 Feb 2003 [EMAIL PROTECTED] wrote:
 
  
  Date:   Wed Feb 12 06:38:18 2003
  Author: abartlet
  
  Update of /data/cvs/samba/source/printing
  In directory dp.samba.org:/tmp/cvs-serv1930/printing
  
  Modified Files:
  notify.c 
  Log Message:
  Prevent NULL-pointer induced segfaults.
  
  Is tdb_pack in appliance_head different for some reason?  
 
 apparently so.
 
 $ cvs log -r1.9.2.14 tdb/tdbutil.c
 
 revision 1.9.2.14
 date: 2002/11/27 01:51:43;  author: jra;  state: Exp;  lines: +21 -25
 SMBencrypt needs dos codepage also. Change tdb_pack/unpack to take a 
 function pointer applied to all strings if it exists.   Jeremy.

Sorry about that. I'll watch for these nasty differences more closely
in future.

Jeremy.

Re: CVS update: samba/source/printing

2003-02-12 Thread Martin Pool 
On 12 Feb 2003, [EMAIL PROTECTED] wrote:

  $ cvs log -r1.9.2.14 tdb/tdbutil.c
  
  revision 1.9.2.14
  date: 2002/11/27 01:51:43;  author: jra;  state: Exp;  lines: +21 -25
  SMBencrypt needs dos codepage also. Change tdb_pack/unpack to take a 
  function pointer applied to all strings if it exists.   Jeremy.
 
 Sorry about that. I'll watch for these nasty differences more closely
 in future.

The patch I originally sent for this kept them in line -- it would
have been better to do the conversion in the HP Python code than to
put this in tdbpack.

I'm sure you had a good reason in the heat of battle though.

-- 
Martin