Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread ron minnich
In the event handler your have returns, which are invalid in an event
handler. Every single return now gets an error. Must have been ignored
before?

See, e.g., acp-dsdt.dsl.i, at the end. (the _GPE block).

ron

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread ron minnich
next problem:


Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations
  Compiling whole program /root/coreboot/build/seabios/out/ccode32flat.o
In file included from /root/coreboot/build/seabios/out/ccode32flat.o.tmp.c:42:0:
/root/coreboot/build/seabios/out/../src/acpi.c: In function ‘build_ssdt’:
/root/coreboot/build/seabios/out/../src/acpi.c:416:34: error:
‘ssdt_proc_end’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c:416:34: note: each
undeclared identifier is reported only once for each function it
appears in
/root/coreboot/build/seabios/out/../src/acpi.c:416:34: error:
‘ssdt_proc_start’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c:437:26: error:
‘ssdp_proc_aml’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c:438:18: error:
‘ssdt_proc_name’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c:441:18: error:
‘ssdt_proc_id’ undeclared (first use in this function)
In file included from /root/coreboot/build/seabios/out/ccode32flat.o.tmp.c:42:0:
/root/coreboot/build/seabios/out/../src/acpi.c: In function ‘build_pcihp’:
/root/coreboot/build/seabios/out/../src/acpi.c:498:35: error:
‘ssdp_pcihp_aml’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c:507:9: error:
‘aml_ej0_name’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c:507:37: error:
‘aml_adr_dword’ undeclared (first use in this function)
/root/coreboot/build/seabios/out/../src/acpi.c: In function ‘acpi_bios_init’:
/root/coreboot/build/seabios/out/../src/acpi.c:737:41: error:
‘AmlCode’ undeclared (first use in this function)
make[2]: *** [/root/coreboot/build/seabios/out/ccode32flat.o] Error 1
make[1]: *** [build] Error 2
make: *** [seabios] Error 2

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread ron minnich
finally, on the master branch, there are python problems. I've stopped
using Python; did the way prints work change?

Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations
  Compiling whole program /root/coreboot/build/seabios/out/ccode32flat.o
  Compiling whole program /root/coreboot/build/seabios/out/code32seg.o
  Compiling whole program /root/coreboot/build/seabios/out/ccode16.o
  Compiling to assembler /root/coreboot/build/seabios/out/asm-offsets.s
  Generating offset file /root/coreboot/build/seabios/out/asm-offsets.h
  Compiling (16bit) /root/coreboot/build/seabios/out/romlayout.o
  Building ld scripts
Version: rel-1.7.0-91-g7a39e72-20121015_065847-chromix
  File ./tools/layoutrom.py, line 76
print Error: Fixed section %s has non-zero alignment (%d) % (


ron

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Peter Stuge
ron minnich wrote:
 next problem: If the seabios build fails, and you do a make again,
 it fails with this kind of error
 
 CC cbfs/fallback/coreboot_ram.debug
 OBJCOPYcbfs/fallback/coreboot_ram.elf
 Checking out SeaBIOS revision 385a7d0dec28841a05531cba96c62138c3959fef
 error: Your local changes to the following files would be overwritten
 by checkout:
 src/acpi-dsdt.hex
 Please, commit your changes or stash them before you can switch branches.
 Aborting
 fatal: A branch named 'coreboot' already exists.
 make[1]: *** [checkout] Error 128
 make: *** [seabios] Error 2

I've seen this happen. The coreboot Makefile stuff that builds
SeaBIOS assumes that there are never uncommitted changes in the
SeaBIOS directory, and you get the above error when there are.

It is easy to forcefully overwrite any uncommitted changes in the
SeaBIOS build directory, but I am not sure if we want to do that.

I would very much appreciate an explanation why the src/acpi-dsdt.hex
file gets modified as part of the build.

It is in the src/ directory, but .hex does not suggest that it is in
a source format? It's confusing why it has been added to the repo if
it is not a source file. Can someone explain, so that we can fix the
build commands?


Thanks!


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread ron minnich
Thanks Idwer, I completely forgot the Python 2 dependency ...

ron

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread ron minnich
we're going a tutorial at CISL here in buenos aires tomorrow, so would
be very cool if we can fix this before then :-)

thanks

ron

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Idwer Vollering
2012/10/15 ron minnich rminn...@gmail.com:
 finally, on the master branch, there are python problems. I've stopped
 using Python; did the way prints work change?

 Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations
   Compiling whole program /root/coreboot/build/seabios/out/ccode32flat.o
   Compiling whole program /root/coreboot/build/seabios/out/code32seg.o
   Compiling whole program /root/coreboot/build/seabios/out/ccode16.o
   Compiling to assembler /root/coreboot/build/seabios/out/asm-offsets.s
   Generating offset file /root/coreboot/build/seabios/out/asm-offsets.h
   Compiling (16bit) /root/coreboot/build/seabios/out/romlayout.o
   Building ld scripts
 Version: rel-1.7.0-91-g7a39e72-20121015_065847-chromix
   File ./tools/layoutrom.py, line 76
 print Error: Fixed section %s has non-zero alignment (%d) % (

tools/layoutrom.py (and possibly tools/*.py are) is assuming that
python2 is installed.



 ron

 ___
 SeaBIOS mailing list
 SeaBIOS@seabios.org
 http://www.seabios.org/mailman/listinfo/seabios

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Peter Stuge
ron minnich wrote:
 we're going a tutorial at CISL here in buenos aires tomorrow,
 so would be very cool if we can fix this before then :-)

It is simple to work around the modified src/acpi-dsdt.hex error, but
I don't know if blindly overwriting changed files including whatever
the user has done is really sane. I need to know why the file is
being modified during SeaBIOS build.

I tend to think that it should just be removed from the SeaBIOS
repository, then the error goes away, and users' modifications
will not silently be deleted by building coreboot.


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


[SeaBIOS] Git over http

2012-10-15 Thread Christian Gmeiner
Hi all

At the moment seabios is only available via
git clone git://git.seabios.org/seabios.git seabios

It would be really cool if it would be also accessible via
git clone http://git.seabios.org/seabios.git seabios

For build-servers etc. behind a firewall.

thanks
---
Christian Gmeiner, MSc

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Kevin O'Connor
On Mon, Oct 15, 2012 at 06:53:16AM -0700, ron minnich wrote:
 In the event handler your have returns, which are invalid in an event
 handler. Every single return now gets an error. Must have been ignored
 before?
 
 See, e.g., acp-dsdt.dsl.i, at the end. (the _GPE block).

Hrmm - I put together a patch for this, but it looks like I never
committed it.  I'll resend.

-Kevin

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Kevin O'Connor
On Mon, Oct 15, 2012 at 04:25:07PM +0200, Peter Stuge wrote:
 ron minnich wrote:
  next problem: If the seabios build fails, and you do a make again,
  it fails with this kind of error
  
  CC cbfs/fallback/coreboot_ram.debug
  OBJCOPYcbfs/fallback/coreboot_ram.elf
  Checking out SeaBIOS revision 385a7d0dec28841a05531cba96c62138c3959fef
  error: Your local changes to the following files would be overwritten
  by checkout:
  src/acpi-dsdt.hex
  Please, commit your changes or stash them before you can switch branches.
  Aborting
  fatal: A branch named 'coreboot' already exists.
  make[1]: *** [checkout] Error 128
  make: *** [seabios] Error 2
 
 I've seen this happen. The coreboot Makefile stuff that builds
 SeaBIOS assumes that there are never uncommitted changes in the
 SeaBIOS directory, and you get the above error when there are.
 
 It is easy to forcefully overwrite any uncommitted changes in the
 SeaBIOS build directory, but I am not sure if we want to do that.
 
 I would very much appreciate an explanation why the src/acpi-dsdt.hex
 file gets modified as part of the build.

It no longer does.  The ACPI file is now generated on each build.
This should be in the v1.7.1 release - maybe you're on an old version?

-Kevin

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Peter Stuge
Kevin O'Connor wrote:
   Checking out SeaBIOS revision 385a7d0dec28841a05531cba96c62138c3959fef
   error: Your local changes to the following files would be overwritten
   by checkout:
   src/acpi-dsdt.hex
..
  I've seen this happen.
..
  I would very much appreciate an explanation why the src/acpi-dsdt.hex
  file gets modified as part of the build.
 
 It no longer does.  The ACPI file is now generated on each build.
 This should be in the v1.7.1 release - maybe you're on an old version?

coreboot has SeaBIOS stable at commit
a0263083cb4cda172832fbc916dc1417ee930574 which is by now rather old.

Would you suggest bumping what coreboot uses as stable commit to 1.7.1?


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Kevin O'Connor
On Tue, Oct 16, 2012 at 01:08:13AM +0200, Peter Stuge wrote:
 Kevin O'Connor wrote:
Checking out SeaBIOS revision 
385a7d0dec28841a05531cba96c62138c3959fef
error: Your local changes to the following files would be overwritten
by checkout:
src/acpi-dsdt.hex
 ..
   I've seen this happen.
 ..
   I would very much appreciate an explanation why the src/acpi-dsdt.hex
   file gets modified as part of the build.
  
  It no longer does.  The ACPI file is now generated on each build.
  This should be in the v1.7.1 release - maybe you're on an old version?
 
 coreboot has SeaBIOS stable at commit
 a0263083cb4cda172832fbc916dc1417ee930574 which is by now rather old.
 
 Would you suggest bumping what coreboot uses as stable commit to 1.7.1?

Yes.

-Kevin

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread Peter Stuge
Kevin O'Connor wrote:
  Would you suggest bumping what coreboot uses as stable commit to 1.7.1?
 
 Yes.

OK. Ron, please see if that issue is fixed now.


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] great things are coming your way :-)

2012-10-15 Thread ron minnich
I'll do it tomorrow after the tutorial :-)
ron

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios