Re: [SeaBIOS] [PATCH] Ignore sgabios rom in case sercon is enabled.

2017-11-04 Thread Paolo Bonzini 
On 04/11/2017 11:09, Peter Stuge wrote:
>> +if (strcmp(file->name, "vgaroms/sgabios.bin") == 0 &&
>> +CONFIG_SERCON && romfile_loadint("etc/sercon-port", 0)) {
>> +dprintf(1, "sercon: is enabled, not loading sgabios rom.\n");
>> +continue;
>> +}
> This heuristic isn't very reliable. Is there nothing in the sgabios.bin
> option ROM itself that can be used instead?

In what sense it is not very reliable?

Paolo

___
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH] Ignore sgabios rom in case sercon is enabled.

2017-11-04 Thread Peter Stuge 
Gerd Hoffmann wrote:
> +++ b/src/optionroms.c
> @@ -193,6 +193,11 @@ run_file_roms(const char *prefix, int isvga, u64 
> *sources)
>  file = romfile_findprefix(prefix, file);
>  if (!file)
>  break;
> +if (strcmp(file->name, "vgaroms/sgabios.bin") == 0 &&
> +CONFIG_SERCON && romfile_loadint("etc/sercon-port", 0)) {
> +dprintf(1, "sercon: is enabled, not loading sgabios rom.\n");
> +continue;
> +}

This heuristic isn't very reliable. Is there nothing in the sgabios.bin
option ROM itself that can be used instead?


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios