[jira] [Commented] (JAMES-3127) Cassandra migrations should not depend on Guice

2020-06-18 Thread Matthieu Baechler (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139947#comment-17139947
 ] 

Matthieu Baechler commented on JAMES-3127:
--

I don't think there's any work on that topic.
Yet it's still a design issue.

> Cassandra migrations should not depend on Guice
> ---
>
> Key: JAMES-3127
> URL: https://issues.apache.org/jira/browse/JAMES-3127
> Project: James Server
>  Issue Type: Improvement
>  Components: cassandra, guice
>Reporter: Matthieu Baechler
>Priority: Major
>
> For now, Cassandra migrations are associated to schema versions in a guice 
> module, preventing the reuse of the versions in other parts of the code.
> We don't really need guice to build a Map so we should move this code in the 
> non-guice module and stop duplicating schema version information in the 
> codebase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3127) Cassandra migrations should not depend on Guice

2020-06-17 Thread Benoit Tellier (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139045#comment-17139045
 ] 

Benoit Tellier commented on JAMES-3127:
---

What is the status of this work?

> Cassandra migrations should not depend on Guice
> ---
>
> Key: JAMES-3127
> URL: https://issues.apache.org/jira/browse/JAMES-3127
> Project: James Server
>  Issue Type: Improvement
>  Components: cassandra, guice
>Reporter: Matthieu Baechler
>Priority: Major
>
> For now, Cassandra migrations are associated to schema versions in a guice 
> module, preventing the reuse of the versions in other parts of the code.
> We don't really need guice to build a Map so we should move this code in the 
> non-guice module and stop duplicating schema version information in the 
> codebase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3127) Cassandra migrations should not depend on Guice

2020-03-30 Thread Matthieu Baechler (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070807#comment-17070807
 ] 

Matthieu Baechler commented on JAMES-3127:
--

> Then how do you know the number associated with each migration, and enforce 
> there is no conflicts?

You have a SchemaVersion for each module (one for mailbox, one for data)

> Also, if you attach migration tasks to the Module, then the dependency part 
> of it might be complicated IMO

I don't see why

> Cassandra migrations should not depend on Guice
> ---
>
> Key: JAMES-3127
> URL: https://issues.apache.org/jira/browse/JAMES-3127
> Project: James Server
>  Issue Type: Improvement
>  Components: cassandra, guice
>Reporter: Matthieu Baechler
>Priority: Major
>
> For now, Cassandra migrations are associated to schema versions in a guice 
> module, preventing the reuse of the versions in other parts of the code.
> We don't really need guice to build a Map so we should move this code in the 
> non-guice module and stop duplicating schema version information in the 
> codebase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3127) Cassandra migrations should not depend on Guice

2020-03-30 Thread Benoit Tellier (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070805#comment-17070805
 ] 

Benoit Tellier commented on JAMES-3127:
---

Then how do you know the number associated with each migration, and enforce 
there is no conflicts?

Also, if you attach migration tasks to the Module, then the dependency part of 
it might be complicated IMO

> Cassandra migrations should not depend on Guice
> ---
>
> Key: JAMES-3127
> URL: https://issues.apache.org/jira/browse/JAMES-3127
> Project: James Server
>  Issue Type: Improvement
>  Components: cassandra, guice
>Reporter: Matthieu Baechler
>Priority: Major
>
> For now, Cassandra migrations are associated to schema versions in a guice 
> module, preventing the reuse of the versions in other parts of the code.
> We don't really need guice to build a Map so we should move this code in the 
> non-guice module and stop duplicating schema version information in the 
> codebase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3127) Cassandra migrations should not depend on Guice

2020-03-30 Thread Matthieu Baechler (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070782#comment-17070782
 ] 

Matthieu Baechler commented on JAMES-3127:
--

We recently added a migration of data-cassandra module so there's no longer a 
central place to put these migrations.
We should probably have a dedicated set of migration for each cassandra module.

> Cassandra migrations should not depend on Guice
> ---
>
> Key: JAMES-3127
> URL: https://issues.apache.org/jira/browse/JAMES-3127
> Project: James Server
>  Issue Type: Improvement
>  Components: cassandra, guice
>Reporter: Matthieu Baechler
>Priority: Major
>
> For now, Cassandra migrations are associated to schema versions in a guice 
> module, preventing the reuse of the versions in other parts of the code.
> We don't really need guice to build a Map so we should move this code in the 
> non-guice module and stop duplicating schema version information in the 
> codebase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org