Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v55]

2023-12-04 Thread Man Cao
On Sat, 2 Dec 2023 07:37:26 GMT, Jonathan Joo  wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Only create CPUTimeCounters if supported
>  - Ensure TTTC is destructed before publishing

Marked as reviewed by manc (Committer).

-

PR Review: https://git.openjdk.org/jdk/pull/15082#pullrequestreview-1763690561


Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v55]

2023-12-04 Thread Stefan Johansson
On Sat, 2 Dec 2023 07:37:26 GMT, Jonathan Joo  wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Only create CPUTimeCounters if supported
>  - Ensure TTTC is destructed before publishing

Marked as reviewed by sjohanss (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/15082#pullrequestreview-1762364095


Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v55]

2023-12-01 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads

Jonathan Joo has updated the pull request incrementally with two additional 
commits since the last revision:

 - Only create CPUTimeCounters if supported
 - Ensure TTTC is destructed before publishing

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/15082/files
  - new: https://git.openjdk.org/jdk/pull/15082/files/fcf00cfe..242fef84

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=15082=54
 - incr: https://webrevs.openjdk.org/?repo=jdk=15082=53-54

  Stats: 23 lines in 3 files changed: 11 ins; 0 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/15082.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15082/head:pull/15082

PR: https://git.openjdk.org/jdk/pull/15082