Re: [sheepdog] [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-23 Thread Kevin Wolf 
Am 21.09.2020 um 13:01 hat Philippe Mathieu-Daudé geschrieben:
> Use self-explicit NANOSECONDS_PER_SECOND definition instead
> of magic value.
> 
> Signed-off-by: Philippe Mathieu-Daudé 

Thanks, applied to the block branch.

Kevin

-- 
sheepdog mailing list
sheepdog@lists.wpkg.org
https://lists.wpkg.org/mailman/listinfo/sheepdog

Re: [sheepdog] [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-21 Thread Alberto Garcia 
On Mon 21 Sep 2020 01:01:45 PM CEST, Philippe Mathieu-Daudé wrote:
> Use self-explicit NANOSECONDS_PER_SECOND definition instead
> of magic value.
>
> Signed-off-by: Philippe Mathieu-Daudé 

Reviewed-by: Alberto Garcia 

Berto
-- 
sheepdog mailing list
sheepdog@lists.wpkg.org
https://lists.wpkg.org/mailman/listinfo/sheepdog

[sheepdog] [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-21 Thread Philippe Mathieu-Daudé 
Use self-explicit NANOSECONDS_PER_SECOND definition instead
of magic value.

Signed-off-by: Philippe Mathieu-Daudé 
---
 block/sheepdog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index cbbebc1aaf2..cbc655a1a05 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -740,7 +740,7 @@ static coroutine_fn void reconnect_to_sdog(void *opaque)
 if (s->fd < 0) {
 trace_sheepdog_reconnect_to_sdog();
 error_report_err(local_err);
-qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, 10ULL);
+qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, NANOSECONDS_PER_SECOND);
 }
 };
 
-- 
2.26.2

-- 
sheepdog mailing list
sheepdog@lists.wpkg.org
https://lists.wpkg.org/mailman/listinfo/sheepdog