Re: [Spacewalk-devel] [PATCH] Date/Time picker
On 02/06/2014 11:12 AM, Duncan Mac-Vicar P. wrote: See attached patches. [...] On a slightly unrelated note, I have just noticed the current date picker allows incorrect dates to be picked, such as February 31. In the SSM errata scheduling page, among other things, such values cause a NPE. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches
Pushed to master as 1ae33e052ef7b449ed34b8bea9411bc45631c0e6. Two little things were fixed in following two commits: * 31d358af3f9707771107ed6887989d30e50f Consistent closing of void tags (as you said that you completely rewritten the page so I thought it would be nice co have it consistent). * 6303cdfbff967d124c8113b1ecef534ca71c610c While checking how the page looks you probably missed doubled colons. Thanks for contribution :-). -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Bo Maryniuk b...@suse.de To: Bo Maryniuk b...@suse.de, spacewalk-devel@redhat.com Sent: Monday, February 10, 2014 3:40:58 PM Subject: Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches Hi, errata fix (again), must be applicable this time. -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer No matter where you go in the world, there never seems to be a shortage of idiots. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches
On Mon, Feb 10, 2014 at 07:49:48AM -0500, Matej Kollar wrote: Nevertheless I have a note for mentioned #0009: If you really insist on reformatting .jsp-s, please * do it in separate step to make review simpler, * do not introduce trailing white-spaces, * make consistent use of space before slash in void tags, * make indentation of pairs of opening and closing tags match. This sounds like need of a pretty precise checkstyle. Well, fixed. -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer He can compress the most words into the smallest idea of any man I know. datepicker-ui-unification-errata-pages.tar.bz2 Description: application/bzip-compressed-tar ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
