Re: [Spacewalk-devel] [PATCH] build rhn-custom-info on openSUSE

2011-04-15 Thread Michael Calmer
Hi,

Am Montag, 11. April 2011, 16:58:21 schrieb Miroslav Suchý:
 On 04/08/2011 02:59 PM, Michael Calmer wrote:
  Hi,
  
  here is the patch to build rhn-custom-info on openSUSE.
  
  0008-build-rhn-custom-info-on-SUSE.patch:
  - only some specfile modifications
 
  %else
 +%if 0%{?suse_version}
 +Requires: zypp-plugin-spacewalk
 +%else
 
 I would much rather prefer usage of %elif here.

Hmm, rpm do not support %elif. It does not in OBS and we looked in the 
upstream code and also there is elif not implemented.
 
 +%dir %{_datadir}/rhn
 
 Again. rhn-custom-info requires yum-rhn-plugin, which requires
 rhn-client-tools, which own this directory. So this should not be there.

Ok, here is a modified version of the patch.

-- 
Regards,

Michael Calmer

--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575  - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
From 9fb215881dd38f79382a889e5dfdb02b244be1ff Mon Sep 17 00:00:00 2001
From: Michael Calmer m...@suse.de
Date: Fri, 15 Apr 2011 10:24:18 +0200
Subject: [PATCH 07/13] build rhn-custom-info on SUSE

- require zypp-plugin-spacewalk
- BuildRequire rhn-client-tools for the filelist check in OBS
---
 client/tools/rhncustominfo/rhn-custom-info.spec |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/client/tools/rhncustominfo/rhn-custom-info.spec b/client/tools/rhncustominfo/rhn-custom-info.spec
index 7d2e7813..da410d8 100644
--- a/client/tools/rhncustominfo/rhn-custom-info.spec
+++ b/client/tools/rhncustominfo/rhn-custom-info.spec
@@ -21,8 +21,15 @@ Requires: rhnlib
 %if 0%{?rhel} = 5 || 0%{?fedora} = 1
 Requires: yum-rhn-plugin
 %else
+# rpm do not support elif
+%if 0%{?suse_version}
+Requires: zypp-plugin-spacewalk
+# provide rhn directories for filelist check
+BuildRequires: rhn-client-tools
+%else
 Requires: up2date
 %endif
+%endif
 
 %description 
 Allows for the setting and listing of custom key/value pairs for 
-- 
1.7.3.4

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] [PATCH] build rhn-custom-info on openSUSE

2011-04-15 Thread Jan Pazdziora
On Fri, Apr 15, 2011 at 01:42:10PM +0200, Michael Calmer wrote:
 Hi,
 
 Am Montag, 11. April 2011, 16:58:21 schrieb Miroslav Suchý:
  On 04/08/2011 02:59 PM, Michael Calmer wrote:
   Hi,
   
   here is the patch to build rhn-custom-info on openSUSE.
   
   0008-build-rhn-custom-info-on-SUSE.patch:
   - only some specfile modifications
  
   %else
  +%if 0%{?suse_version}
  +Requires: zypp-plugin-spacewalk
  +%else
  
  I would much rather prefer usage of %elif here.
 
 Hmm, rpm do not support %elif. It does not in OBS and we looked in the 
 upstream code and also there is elif not implemented.
  
  +%dir %{_datadir}/rhn
  
  Again. rhn-custom-info requires yum-rhn-plugin, which requires
  rhn-client-tools, which own this directory. So this should not be there.
 
 Ok, here is a modified version of the patch.

Pushed to master as fcb043e5c59703a7803be5af2920b95041571db4
and tagged as rhn-custom-info-5.4.12-1.

Thanks,

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] [PATCH] build rhn-custom-info on openSUSE

2011-04-11 Thread Miroslav Suchý
On 04/08/2011 02:59 PM, Michael Calmer wrote:
 Hi,
 
 here is the patch to build rhn-custom-info on openSUSE.
 
 0008-build-rhn-custom-info-on-SUSE.patch:
 - only some specfile modifications

 %else
+%if 0%{?suse_version}
+Requires: zypp-plugin-spacewalk
+%else

I would much rather prefer usage of %elif here.

+%dir %{_datadir}/rhn

Again. rhn-custom-info requires yum-rhn-plugin, which requires
rhn-client-tools, which own this directory. So this should not be there.

-- 
Miroslav Suchy
Red Hat Satellite Engineering

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel