Re: [Spice-devel] which chennel whose value is 2 or 5?
Hi, bigclouds píše v Pá 17. 05. 2013 v 10:51 +0800: hi, please tell me what is the channel type whose value is 2 ,5? as defined in this enum of spice-protocol: http://cgit.freedesktop.org/spice/spice-protocol/tree/spice/enums.h#n368 2 is display channel and 5 is playback channel David any other channels and its value. thanks. reds_handle_link: YY client connection 192.168.5.188, 5901 reds_handle_link: YY client connection 192.168.5.129, 38167 reds_handle_link: YY client channeltype 2 reds_handle_link: YY client connection 192.168.5.188, 5901 reds_handle_link: YY client connection 192.168.5.129, 38165 reds_handle_link: YY client channeltype 5 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel -- David Jaša, RHCE SPICE QE based in Brno GPG Key: 22C33E24 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24 smime.p7s Description: S/MIME cryptographic signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] spice-vdagent on Ovirt 3.1
- Original Message - From: Terrence Wu (吳星輝) terrence...@mediatek.com To: Marian Krcmarik mkrcm...@redhat.com Cc: spice-devel@lists.freedesktop.org Sent: Wednesday, May 15, 2013 10:33:33 AM Subject: RE: [Spice-devel] spice-vdagent on Ovirt 3.1 Hi, Thanks for your response. We have another question, is it possible to launch SPICE connection on Android Tablet? We've found something like android-spice-client but we couldn't make it work with Android web browser. spice-client is a dropped project replaced by virt-viewer which uses spice-gtk, and afaik this adroid-spice-client project is stalled as well, kind of POC. Could it work with Chrome or some other components we need? Only alternative I could think of is the html5 [1] client but others may know better. [1] http://www.spice-space.org/page/Html5 Best Regards, Terrence Terrence Wu (吳星輝) MediaTek Inc. el: +886-3-5670766 ext. 25317 Fax: +886-3-5787610 Email : terrence...@mediatek.com -Original Message- From: Marian Krcmarik [mailto:mkrcm...@redhat.com] Sent: Tuesday, May 07, 2013 10:19 PM To: Terrence Wu (吳星輝) Cc: spice-devel@lists.freedesktop.org Subject: Re: [Spice-devel] spice-vdagent on Ovirt 3.1 - Original Message - From: Terrence Wu (吳星輝) terrence...@mediatek.com To: spice-devel@lists.freedesktop.org Sent: Wednesday, April 17, 2013 10:39:23 AM Subject: [Spice-devel] spice-vdagent on Ovirt 3.1 Hi, We’re proceeding on a benchmark for SPICE and other remote access programs. We found that SPICE is really cool espacially when the spice-vdagentd is working. Yet there is something we concern about the data security, spice-vdagentd enables the capability to share clipboard data between SPICE client and the virtual guestOS. It’s also a useful function but we do not expect to provide copy/paste function for text or graphic in certain restrictive cases. Is there any way to enable spice-vdagentd without copy/paste bwtween client and guest OS? There is a qemu command line option disable-copy-paste[1] available with libvirt element clipboard copypaste='no'/[2] but unfortunately It's not exposed in Ovirt management, but probably could be added with using a vdsm hook[3]. [1] man qemu [2] http://libvirt.org/formatdomain.html#elementsGraphics [3] http://wiki.ovirt.org/VDSM-Hooks The performance wih QXL, SPICE, and spice-vdagent is quite excellent, but the copy/paste issue is the only constraint. System info: Virtual solution: Ovirt 3.1 Host server OS: CentOS 6.3 (kernel: 2.6.32-358.2.1.el6.x86_64) qemu-kvm-0.12.1.2-2.295.el6x86_64 spice-server-0.12.0-12.el6x86_64 Guest OS: RHEL 5.8 (kernel 2.6.18-308.el5.x86_64) spice-vdagent-0.10.1-1.el5 Best Regards, Terrence * Email Confidentiality Notice The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel * Email Confidentiality Notice The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org
Re: [Spice-devel] 回复： MacOS SPICE client
Hi, On Fri, May 17, 2013 at 05:00:56PM +0800, jojo wrote: Hi, Can you share source code of OSX ? I want to debug for learning the protocol in my MBP easily :) The client is all free software, and the code is already available online, just follow the building steps, and this will download all the needed source as part of the build process. Christophe pgpK2_4qcIr6B.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] where to find msg type and its meaning
On Fri, May 17, 2013 at 11:17:30AM +0800, bigclouds wrote: hi, version 0.10.1 rpm please tell me the meaningof 107,109,110, where to find its define. red_peer_receive: No route to host red_channel_client_disconnect: 0x7fb1b8606650 (channel 0x7fb1b80458d0 type 2 id 0) display_channel_client_on_disconnect: display_channel_client_on_disconnect main_channel_handle_parsed: main_channel_handle_parsed type 107 main_channel_send_item: main_channel_send_item client 0x7fb1d41fa390 msg type 109 main_channel_handle_parsed: main_channel_handle_parsed type 107 main_channel_send_item: main_channel_send_item client 0x7fb1d41fa390 msg type 110 You can find message type definitions at http://cgit.freedesktop.org/spice/spice-protocol/tree/spice/enums.h#n382 They are per-channel. Christophe pgpVsXB_QnaW2.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk] widget: remove grab key filter
On Thu, May 16, 2013 at 09:32:33PM +0200, Marc-André Lureau wrote: Thanks for checking history, but no, this patch actually removes the filter entirely. The commit you mentionned removed it already partially. Ah right, I read it backward ;) ACK. Christophe pgpLqftw7G5Mk.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 0/9] 0.12.3 + a bunch of small fixes I had laying around
Feel free to shoot down anything (like the rename for no apparent reason other then using the word cap) Alon Levy (9): server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small comment) server/red_worker: turn critical (assert) non error into warning server/tests/test_display_base: add missing set_client_capabilities, fix client_monitors_config signature server/red_worker: simplify monitors_config update server/tests: test_display_width_stride server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect for valgrind server/dispatchers: initialize stack to 0 for valgrind server/red_parse_qxl: two coding convention pointer cast fix 0.12.3 release NEWS | 18 +++ configure.ac | 4 +- server/main_dispatcher.c | 2 +- server/red_dispatcher.c | 8 +-- server/red_dispatcher.h | 4 +- server/red_parse_qxl.c | 4 +- server/red_worker.c | 30 ++- server/tests/Makefile.am | 8 ++- server/tests/test_display_base.c | 60 ++--- server/tests/test_display_base.h | 13 + server/tests/test_display_width_stride.c | 92 11 files changed, 211 insertions(+), 32 deletions(-) create mode 100644 server/tests/test_display_width_stride.c -- 1.8.2.1 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 1/9] server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small comment)
---
server/red_worker.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index fb736b5..8f3e478 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1040,7 +1040,7 @@ typedef struct RedWorker {
uint64_t *command_counter;
#endif
-int driver_has_monitors_config;
+int driver_cap_monitors_config;
int set_client_capabilities_pending;
} RedWorker;
@@ -11442,7 +11442,9 @@ static void dev_create_primary_surface(RedWorker
*worker, uint32_t surface_id,
set_monitors_config_to_primary(worker);
if (display_is_connected(worker)
!worker-display_channel-common.during_target_migrate) {
-if (!worker-driver_has_monitors_config) {
+/* guest created primary, so it will (hopefully) send a monitors_config
+ * now, don't send our own temporary one */
+if (!worker-driver_cap_monitors_config) {
red_worker_push_monitors_config(worker);
}
red_pipes_add_verb(worker-display_channel-common.base,
@@ -11746,7 +11748,7 @@ static void handle_dev_monitors_config_async(void
*opaque, void *payload)
/* TODO: raise guest bug (requires added QXL interface) */
return;
}
-worker-driver_has_monitors_config = 1;
+worker-driver_cap_monitors_config = 1;
if (dev_monitors_config-count == 0) {
spice_warning(ignoring an empty monitors config message from driver);
return;
@@ -11902,7 +11904,7 @@ void handle_dev_driver_unload(void *opaque, void
*payload)
{
RedWorker *worker = opaque;
-worker-driver_has_monitors_config = 0;
+worker-driver_cap_monitors_config = 0;
}
void handle_dev_loadvm_commands(void *opaque, void *payload)
@@ -12171,7 +12173,7 @@ static void red_init(RedWorker *worker, WorkerInitData
*init_data)
worker-jpeg_state = init_data-jpeg_state;
worker-zlib_glz_state = init_data-zlib_glz_state;
worker-streaming_video = init_data-streaming_video;
-worker-driver_has_monitors_config = 0;
+worker-driver_cap_monitors_config = 0;
ring_init(worker-current_list);
image_cache_init(worker-image_cache);
image_surface_init(worker);
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 2/9] server/red_worker: turn critical (assert) non error into warning
The situation causing this assert is unknown but it doesn't cause
correctness issues with later rendering, and it is causing an abort.
---
server/red_worker.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 8f3e478..14d219b 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -11367,7 +11367,10 @@ static void
red_push_monitors_config(DisplayChannelClient *dcc)
{
MonitorsConfig *monitors_config = DCC_TO_WORKER(dcc)-monitors_config;
-spice_return_if_fail(monitors_config != NULL);
+if (monitors_config == NULL) {
+spice_warning(monitors_config is NULL);
+return;
+}
if (!red_channel_client_test_remote_cap(dcc-common.base,
SPICE_DISPLAY_CAP_MONITORS_CONFIG)) {
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 3/9] server/tests/test_display_base: add missing set_client_capabilities, fix client_monitors_config signature
---
server/tests/test_display_base.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index 588e960..8657e91 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_display_base.c
@@ -701,13 +701,22 @@ static int flush_resources(QXLInstance *qin)
return TRUE;
}
-static void client_monitors_config(QXLInstance *qin, VDAgentMonitorsConfig
*monitors_config)
+static int client_monitors_config(QXLInstance *qin,
+ VDAgentMonitorsConfig *monitors_config)
{
if (!monitors_config) {
printf(%s: NULL monitors_config\n, __func__);
} else {
printf(%s: %d\n, __func__, monitors_config-num_of_monitors);
}
+return 0;
+}
+
+static void set_client_capabilities(QXLInstance *qin,
+uint8_t client_present,
+uint8_t caps[58])
+{
+printf(%s: present %d caps %d\n, __func__, client_present, caps[0]);
}
QXLInterface display_sif = {
@@ -731,6 +740,7 @@ QXLInterface display_sif = {
.notify_update = notify_update,
.flush_resources = flush_resources,
.client_monitors_config = client_monitors_config,
+.set_client_capabilities = set_client_capabilities,
};
/* interface for tests */
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 4/9] server/red_worker: simplify monitors_config update
---
server/red_worker.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 14d219b..f047d29 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1279,6 +1279,9 @@ static MonitorsConfig
*monitors_config_getref(MonitorsConfig *monitors_config)
static void monitors_config_decref(MonitorsConfig *monitors_config)
{
+if (!monitors_config) {
+return;
+}
if (--monitors_config-refs 0) {
return;
}
@@ -11339,9 +11342,7 @@ static void worker_update_monitors_config(RedWorker
*worker,
MonitorsConfig *monitors_config;
int i;
-if (worker-monitors_config) {
-monitors_config_decref(worker-monitors_config);
-}
+monitors_config_decref(worker-monitors_config);
spice_debug(monitors config %d(%d),
dev_monitors_config-count,
@@ -11396,12 +11397,10 @@ static void set_monitors_config_to_primary(RedWorker
*worker)
DrawContext *context;
if (!worker-surfaces[0].context.canvas) {
-spice_warning(%s: no primary surface, __FUNCTION__);
+spice_warning(no primary surface);
return;
}
-if (worker-monitors_config) {
-monitors_config_decref(worker-monitors_config);
-}
+monitors_config_decref(worker-monitors_config);
context = worker-surfaces[0].context;
worker-monitors_config =
spice_malloc(sizeof(*worker-monitors_config) + sizeof(QXLHead));
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 5/9] server/tests: test_display_width_stride
---
server/tests/Makefile.am | 8 ++-
server/tests/test_display_base.c | 48 ++---
server/tests/test_display_base.h | 13 +
server/tests/test_display_width_stride.c | 92
4 files changed, 154 insertions(+), 7 deletions(-)
create mode 100644 server/tests/test_display_width_stride.c
diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index e0472f3..655bc83 100644
--- a/server/tests/Makefile.am
+++ b/server/tests/Makefile.am
@@ -35,6 +35,7 @@ noinst_PROGRAMS =
\
test_display_resolution_changes \
test_two_servers\
test_vdagent\
+ test_display_width_stride \
$(NULL)
test_vdagent_SOURCES = \
@@ -90,4 +91,9 @@ test_two_servers_SOURCES =\
test_two_servers.c \
$(NULL)
-
+test_display_width_stride_SOURCES =\
+ $(COMMON_BASE) \
+ test_display_base.c \
+ test_display_base.h \
+ test_display_width_stride.c \
+ $(NULL)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index 8657e91..b4c93f3 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_display_base.c
@@ -309,20 +309,36 @@ static SimpleSpiceUpdate
*test_spice_create_update_copy_bits(Test *test, uint32_
return update;
}
-static SimpleSurfaceCmd *create_surface(int surface_id, int width, int height,
uint8_t *data)
+static int format_to_bpp(int format)
+{
+switch (format) {
+case SPICE_SURFACE_FMT_8_A:
+return 1;
+case SPICE_SURFACE_FMT_16_555:
+case SPICE_SURFACE_FMT_16_565:
+return 2;
+case SPICE_SURFACE_FMT_32_xRGB:
+case SPICE_SURFACE_FMT_32_ARGB:
+return 4;
+}
+abort();
+}
+
+static SimpleSurfaceCmd *create_surface(int surface_id, int format, int width,
int height, uint8_t *data)
{
SimpleSurfaceCmd *simple_cmd = calloc(sizeof(SimpleSurfaceCmd), 1);
QXLSurfaceCmd *surface_cmd = simple_cmd-surface_cmd;
+int bpp = format_to_bpp(format);
set_cmd(simple_cmd-ext, QXL_CMD_SURFACE, (intptr_t)surface_cmd);
simple_set_release_info(surface_cmd-release_info, (intptr_t)simple_cmd);
surface_cmd-type = QXL_SURFACE_CMD_CREATE;
surface_cmd-flags = 0; // ?
surface_cmd-surface_id = surface_id;
-surface_cmd-u.surface_create.format = SPICE_SURFACE_FMT_32_xRGB;
+surface_cmd-u.surface_create.format = format;
surface_cmd-u.surface_create.width = width;
surface_cmd-u.surface_create.height = height;
-surface_cmd-u.surface_create.stride = -width * 4;
+surface_cmd-u.surface_create.stride = -width * bpp;
surface_cmd-u.surface_create.data = (intptr_t)data;
return simple_cmd;
}
@@ -471,7 +487,10 @@ static void produce_command(Test *test)
if (test-has_secondary)
test-target_surface = 1;
-ASSERT(test-num_commands);
+if (!test-num_commands) {
+usleep(1000);
+return;
+}
command = test-commands[test-cmd_index];
if (command-cb) {
@@ -538,8 +557,17 @@ static void produce_command(Test *test)
case SIMPLE_CREATE_SURFACE: {
SimpleSurfaceCmd *update;
test-target_surface = MAX_SURFACE_NUM - 1;
-update = create_surface(test-target_surface, SURF_WIDTH,
SURF_HEIGHT,
-test-secondary_surface);
+if (command) {
+update = create_surface(command-create_surface.surface_id,
+command-create_surface.format,
+command-create_surface.width,
+command-create_surface.height,
+command-create_surface.data);
+} else {
+update = create_surface(test-target_surface,
SPICE_SURFACE_FMT_32_xRGB,
+SURF_WIDTH, SURF_HEIGHT,
+test-secondary_surface);
+}
push_command(update-ext);
test-has_secondary = 1;
break;
@@ -716,7 +744,15 @@ static void set_client_capabilities(QXLInstance *qin,
uint8_t client_present,
uint8_t caps[58])
{
+Test *test = SPICE_CONTAINEROF(qin, Test, qxl_instance);
+
printf(%s: present %d caps %d\n, __func__, client_present, caps[0]);
+if (test-on_client_connected client_present) {
+test-on_client_connected(test);
+}
+if (test-on_client_disconnected !client_present) {
+test-on_client_disconnected(test);
+}
}
QXLInterface display_sif = {
[Spice-devel] [PATCH 6/9] server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect for valgrind
---
server/red_dispatcher.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h
index 4d0d2a8..7d23b11 100644
--- a/server/red_dispatcher.h
+++ b/server/red_dispatcher.h
@@ -43,10 +43,10 @@ void
red_dispatcher_client_monitors_config(VDAgentMonitorsConfig *monitors_confi
typedef struct RedWorkerMessageDisplayConnect {
RedClient * client;
RedsStream * stream;
-int migration;
uint32_t *common_caps; // red_worker should free
-int num_common_caps;
uint32_t *caps;// red_worker should free
+int migration;
+int num_common_caps;
int num_caps;
} RedWorkerMessageDisplayConnect;
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 7/9] server/dispatchers: initialize stack to 0 for valgrind
---
server/main_dispatcher.c | 2 +-
server/red_dispatcher.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/main_dispatcher.c b/server/main_dispatcher.c
index 92b0791..e7a451a 100644
--- a/server/main_dispatcher.c
+++ b/server/main_dispatcher.c
@@ -78,7 +78,7 @@ static void main_dispatcher_handle_channel_event(void *opaque,
void main_dispatcher_channel_event(int event, SpiceChannelEventInfo *info)
{
-MainDispatcherChannelEventMessage msg;
+MainDispatcherChannelEventMessage msg = {0,};
if (pthread_self() == main_dispatcher.base.self) {
main_dispatcher_self_handle_channel_event(event, info);
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index f4b140c..ef47c28 100644
--- a/server/red_dispatcher.c
+++ b/server/red_dispatcher.c
@@ -97,7 +97,7 @@ static void red_dispatcher_set_display_peer(RedChannel
*channel, RedClient *clie
int num_common_caps, uint32_t
*common_caps, int num_caps,
uint32_t *caps)
{
-RedWorkerMessageDisplayConnect payload;
+RedWorkerMessageDisplayConnect payload = {0,};
RedDispatcher *dispatcher;
spice_debug(%s, );
@@ -159,7 +159,7 @@ static void red_dispatcher_set_cursor_peer(RedChannel
*channel, RedClient *clien
uint32_t *common_caps, int num_caps,
uint32_t *caps)
{
-RedWorkerMessageCursorConnect payload;
+RedWorkerMessageCursorConnect payload = {0,};
RedDispatcher *dispatcher = (RedDispatcher *)channel-data;
spice_printerr();
payload.client = client;
@@ -292,7 +292,7 @@ static void red_dispatcher_update_area(RedDispatcher
*dispatcher, uint32_t surfa
QXLRect *qxl_area, QXLRect *qxl_dirty_rects,
uint32_t num_dirty_rects, uint32_t
clear_dirty_region)
{
-RedWorkerMessageUpdate payload;
+RedWorkerMessageUpdate payload = {0,};
payload.surface_id = surface_id;
payload.qxl_area = qxl_area;
@@ -522,7 +522,7 @@ static void
red_dispatcher_create_primary_surface_sync(RedDispatcher *dispatcher, uint32_t
surface_id,
QXLDevSurfaceCreate *surface)
{
-RedWorkerMessageCreatePrimarySurface payload;
+RedWorkerMessageCreatePrimarySurface payload = {0,};
dispatcher-surface_create = *surface;
payload.surface_id = surface_id;
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 8/9] server/red_parse_qxl: two coding convention pointer cast fix
---
server/red_parse_qxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
index 4b39029..65781e7 100644
--- a/server/red_parse_qxl.c
+++ b/server/red_parse_qxl.c
@@ -104,7 +104,7 @@ static size_t red_get_data_chunks_ptr(RedMemSlotInfo
*slots, int group_id,
red_prev = red;
red = spice_new(RedDataChunk, 1);
memslot_id = get_memslot_id(slots, qxl-next_chunk);
-qxl = (QXLDataChunk*)get_virt(slots, qxl-next_chunk, sizeof(*qxl),
group_id,
+qxl = (QXLDataChunk *)get_virt(slots, qxl-next_chunk, sizeof(*qxl),
group_id,
error);
if (error) {
return 0;
@@ -130,7 +130,7 @@ static size_t red_get_data_chunks(RedMemSlotInfo *slots,
int group_id,
int error;
int memslot_id = get_memslot_id(slots, addr);
-qxl = (QXLDataChunk*)get_virt(slots, addr, sizeof(*qxl), group_id, error);
+qxl = (QXLDataChunk *)get_virt(slots, addr, sizeof(*qxl), group_id,
error);
if (error) {
return 0;
}
--
1.8.2.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH 9/9] 0.12.3 release
--- NEWS | 18 ++ configure.ac | 4 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 30912c5..acfffb8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,21 @@ +Major changes in 0.12.3: + +* monitor client bandwidth and latency. +* dynamically adjust video stream quality based on client bandwidth latency. +** new SPICE_MSGC_DISPLAY_STREAM_REPORT +** can also set SPICE_BIT_RATE environment variable to override. +* support arbitrary latency of audio stream wrt video stream: +** new SPICE_MSG_PLAYBACK_LATENCY +* notify agent on client disconnection +** new VD_AGENT_CLIENT_DISCONNECTED message +* better support for switching from qxl to vga mode +** new library export spice_qxl_driver_unload +* multiple monitor support in single channel fixes. +* stop streams before migration. +* don't send empty volume messages. +* Bugs fixed: rhbz#891326, rhbz#958276, rhbz#956345 +* fixes to inputs, chardev, build fixes. + Major changes in 0.12.2: * Stable Release diff --git a/configure.ac b/configure.ac index fc0216f..78896cb 100644 --- a/configure.ac +++ b/configure.ac @@ -13,9 +13,9 @@ AC_PREREQ([2.57]) # 4. Follow the libtool manual for the so version: # http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html -m4_define([SPICE_CURRENT], [7]) +m4_define([SPICE_CURRENT], [8]) m4_define([SPICE_REVISION], [0]) -m4_define([SPICE_AGE], [6]) +m4_define([SPICE_AGE], [7]) # Note on the library name on linux (SONAME) produced by libtool (for reference, gleaned # from looking at libtool 2.4.2) -- 1.8.2.1 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] Resolution
When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] resolution
When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] Resolution
When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] spice-html5 development plan
Hi: What is the development plans of spice-html5?___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] resolution
Why don't you use remote-viewer? It's available precompiled for download at downloads page and it will work better for you if you want just to use spice. On topic - the client resolution change is the way of old spicec to get remote guest monitor displayed fullscreen as it made almost no harm on CRTs and CPU power for software scaling was way more scarce. The opposite is true these days so remote-viewer won't touch your client resolution at all but it will try to adjust remote system resolution to best match current view and if that won't be possible, it will scale the remote guest monitor to fit the widget viewport. David 天外银龙 píše v Ne 12. 05. 2013 v 11:17 +0800: When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~ ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel -- David Jaša, RHCE SPICE QE based in Brno GPG Key: 22C33E24 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24 smime.p7s Description: S/MIME cryptographic signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH 0/9] 0.12.3 + a bunch of small fixes I had laying around
Looks good, ACK series, On 05/17/2013 05:08 PM, Alon Levy wrote: Feel free to shoot down anything (like the rename for no apparent reason other then using the word cap) Alon Levy (9): server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small comment) server/red_worker: turn critical (assert) non error into warning server/tests/test_display_base: add missing set_client_capabilities, fix client_monitors_config signature server/red_worker: simplify monitors_config update server/tests: test_display_width_stride server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect for valgrind server/dispatchers: initialize stack to 0 for valgrind server/red_parse_qxl: two coding convention pointer cast fix 0.12.3 release NEWS | 18 +++ configure.ac | 4 +- server/main_dispatcher.c | 2 +- server/red_dispatcher.c | 8 +-- server/red_dispatcher.h | 4 +- server/red_parse_qxl.c | 4 +- server/red_worker.c | 30 ++- server/tests/Makefile.am | 8 ++- server/tests/test_display_base.c | 60 ++--- server/tests/test_display_base.h | 13 + server/tests/test_display_width_stride.c | 92 11 files changed, 211 insertions(+), 32 deletions(-) create mode 100644 server/tests/test_display_width_stride.c ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] spice server release 0.12.3
I'm pleased to announce a bug fixing minor release of spice server: http://spice-space.org/download/releases/spice-0.12.3.tar.bz2 here is the excerpt from NEWS: * monitor client bandwidth and latency. * dynamically adjust video stream quality based on client bandwidth latency. ** new SPICE_MSGC_DISPLAY_STREAM_REPORT ** can also set SPICE_BIT_RATE environment variable to override. * support arbitrary latency of audio stream wrt video stream: ** new SPICE_MSG_PLAYBACK_LATENCY * notify agent on client disconnection ** new VD_AGENT_CLIENT_DISCONNECTED message * better support for switching from qxl to vga mode ** new library export spice_qxl_driver_unload * multiple monitor support in single channel fixes. * stop streams before migration. * don't send empty volume messages. * Bugs fixed: rhbz#891326, rhbz#958276, rhbz#956345 * fixes to inputs, chardev, build fixes. Spice Team ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] 回复： MacOS SPICE client
Hi, Ok, i will try to compile it :) Thanks, - Jojo 在 2013年5月17日星期五，下午7:40，Christophe Fergeau 写道： Hi, On Fri, May 17, 2013 at 05:00:56PM +0800, jojo wrote: Hi, Can you share source code of OSX ? I want to debug for learning the protocol in my MBP easily :) The client is all free software, and the code is already available online, just follow the building steps, and this will download all the needed source as part of the build process. Christophe ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
