Re: [Spice-devel] Spice on OS/X

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:36:45PM +0200, Kai Mosebach wrote:
 If I run configure --with-coroutine=gthread I don¹t need those patches
 below. 
 Are there any disadvantages out of the gthreads?

No idea, I'm trying to stay as close as possible to upstream defaults :)

Christophe


pgpxSxdBRmQ0r.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-28 Thread Kai Mosebach
# find / -name libglib*
/Applications/Adium.app/Contents/Frameworks/libglib.framework
/Applications/Adium.app/Contents/Frameworks/libglib.framework/libglib
/Applications/Adium.app/Contents/Frameworks/libglib.framework/Versions/2.0.
0/libglib
/opt/local/lib/libglib-2.0.0.dylib
/opt/local/lib/libglib-2.0.a
/opt/local/lib/libglib-2.0.dylib
/opt/local/lib/libglib-2.0.la


$ which spicy
/usr/local/bin/spicy
$ otool -L /usr/local/bin/spicy|grep glib
/usr/local/lib/libspice-client-glib-2.0.2.dylib (compatibility
version 3.0.0, current version 3.1.0)
/opt/local/lib/libglib-2.0.0.dylib (compatibility version
2801.0.0, current version 2801.5.0)


$ locate glib.h
/opt/local/include/glib-2.0/glib.h


Well hope that¹s prove enough ;-)

Were are all these #define's defined anyway? Couldn¹t we ask if #ifdef
__MACOSX__ or similar at this point?

On 4/28/11 10:37 AM, Christophe Fergeau cferg...@redhat.com wrote:

Until proven otherwise, I'll assume it's a mismatch between several glibs
:) To figure it out, looking at make V=1, checking which versions of glib
are available on the system (find / -name libglib*), maybe looking at
what ldd say, ... would be helpful

Christophe


___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote:
 Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/
 
 Another note, on building the OSX client the symbol _g_get_monotonic_clock
 is missing.
 I think this comes from gtk/spice-session.c but does not seem to resolve
 the glib version correctly.

This was fixed 2 months ago in
https://gitorious.org/spice-gtk/spice-gtk/commit/bf0e167d157d12f9df463d224094d4ff8d1bf146

Christophe


pgpQyVHBMTe49.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Alon Levy
_spice_inputs_set_key_locks, referenced from:
_sync_keyboard_lock_modifiers in spice-widget.o
_spice_main_channel_get_type, referenced from:
_channel_destroy in spice-widget.o
_channel_new in spice-widget.o
_channel_new in spice-widget.o
_spice_main_clipboard_notify, referenced from:
_clipboard_received_cb in spice-widget.o
_spice_session_get_channels, referenced from:
_spice_display_new in spice-widget.o
_spice_inputs_key_release, referenced from:
_send_key in spice-widget.o
_spice_inputs_channel_get_type, referenced from:
_channel_destroy in spice-widget.o
_channel_destroy in spice-widget.o
_channel_new in spice-widget.o
_channel_new in spice-widget.o
_channel_new in spice-widget.o
_spice_inputs_position, referenced from:
_motion_event in spice-widget.o
_spice_main_clipboard_request, referenced from:
_clipboard_get in spice-widget.o
_spice_inputs_button_press, referenced from:
_scroll_event in spice-widget.o
_button_event in spice-widget.o
_spice_inputs_button_release, referenced from:
_scroll_event in spice-widget.o
_button_event in spice-widget.o
_spice_display_channel_get_type, referenced from:
_channel_destroy in spice-widget.o
_channel_destroy in spice-widget.o
_channel_new in spice-widget.o
_channel_new in spice-widget.o
  ld: symbol(s) not found
  collect2: ld returned 1 exit status
  make[3]: *** [libspice-client-gtk-2.0.la] Error 1
  make[2]: *** [all] Error 2
  make[1]: *** [all-recursive] Error 1
  make: *** [all] Error 2
 
  From: Cliff Sharp csh...@vbridges.com
  Date: Tue, 26 Apr 2011 07:44:34 -0500
  To: Attila Sukosd attila.suk...@gmail.com
  Cc: spice-devel@lists.freedesktop.org
  Subject: Re: [Spice-devel] Spice on OS/X
 
  Great suggestion.
  I have been looking into spice-gtk because it does seem like it would be
  much less work.
 
  Thanks.
 
  On Apr 26, 2011, at 3:01 AM, Attila Sukosd wrote:
 
  Hi,
 
 
  This might be a stupid question, but why don't you try to use spice-gtk on
  OS/X instead of spicec ?
  It has everything needed, such as gtk2/gtk3 and gstreamer for audio, all
  cross platform.
 
  Rgrds,
 
  Attila
 
 
  On Mon, Apr 25, 2011 at 11:34 PM, Cliff Sharp csh...@vbridges.comwrote:
 
   When trying to port the alsa-lib to OS/X while porting Spice to OS/X I
  am having some difficulties resolving issues with alsa-lib. I am using
  alsa-lib-1.0.24.1
 
  After doing a ./configure - I have also tried
  ./configure --enable-shared=no --enable-static=yes
 
  Either way I get the following error in the middle ---
  ./configure: line 18735: CC_NOUNDEFINED: command not found
 
  ___
 
  And then the end of the ./configure looks like this ---
 
  configure: creating ./config.status
  config.status: creating Makefile
  config.status: creating doc/Makefile
  config.status: creating doc/pictures/Makefile
  config.status: creating doc/doxygen.cfg
  config.status: creating include/Makefile
  config.status: creating include/sound/Makefile
  config.status: creating src/Versions
  config.status: creating src/Makefile
  config.status: creating src/control/Makefile
  config.status: creating src/mixer/Makefile
  config.status: creating src/pcm/Makefile
  config.status: creating src/pcm/scopes/Makefile
  config.status: creating src/rawmidi/Makefile
  config.status: creating src/timer/Makefile
  config.status: creating src/hwdep/Makefile
  config.status: creating src/seq/Makefile
  config.status: creating src/ucm/Makefile
  config.status: creating src/compat/Makefile
  config.status: creating src/alisp/Makefile
  config.status: creating src/conf/Makefile
  config.status: creating src/conf/cards/Makefile
  config.status: creating src/conf/pcm/Makefile
  config.status: creating modules/Makefile
  config.status: creating modules/mixer/Makefile
  config.status: creating modules/mixer/simple/Makefile
  config.status: creating alsalisp/Makefile
  config.status: creating aserver/Makefile
  config.status: creating test/Makefile
  config.status: creating test/lsb/Makefile
  config.status: creating utils/Makefile
  config.status: creating utils/alsa-lib.spec
  config.status: creating utils/alsa.pc
  config.status: creating include/config.h
  config.status: include/config.h is unchanged
  config.status: executing depfiles commands
  Creating asoundlib.h...
 
  Does this look like the ./configure completed successfully???
 
  __
 
  Then as a result of the make I get the following ---
 
  Making all in doc
  Making all in pictures
  make[2]: Nothing to be done for `all'.
  make[2]: Nothing to be done for `all-am'.
  Making all in include
  make  all-recursive
  Making all in sound
  make[3]: Nothing to be done for `all'.
  Making all in src
  Making all in control
   CC cards.lo
   CC tlv.lo
   CC namehint.lo
   CC hcontrol.lo
   CC control.lo
  /var/folders/Pv/PvC

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote:
 Also I've attached the patch which fixes a few things here and there... With
 this it builds fine.

Ah, so you've already built spice-gtk on macosx? How well did it work?

I had some questions about your patch, it would be really helpful if you
remembered why you had to change these things :)

Thanks for the patch,

Christophe

diff --git a/common/lines.c b/common/lines.c
index 1a14c18..59d0689 100644
--- a/common/lines.c
+++ b/common/lines.c
@@ -2985,7 +2985,7 @@ miWideDashSegment (GCPtr pGC,
 double L, l;
 double k;
 PolyVertexRec vertices[4];
-PolyVertexRec saveRight = { 0 }, saveBottom;
+PolyVertexRec saveRight = { 0 }, saveBottom = { 0 };
 PolySlopeRec slopes[4];
 PolyEdgeRec left[2], right[2];
 LineFaceRec lcapFace, rcapFace;

I assume this bit is to avoid a saveBottom can be used without being
initialized gcc warning?



diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index 7ce8a65..e5f3c1c 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -27,6 +27,7 @@ if HAVE_LD_VERSION_SCRIPT
 VERSION_LDFLAGS = -Wl,--version-script=${srcdir}/map-file
 else
 VERSION_LDFLAGS = -export-symbols ${srcdir}/sym-file
+#VERSION_LDFLAGS =
 endif
 
 KEYMAP_GEN = $(srcdir)/keymap-gen.pl


macosx ld indeed doesn't have any of --version-script nor -export-symbols,
but it does have --exported_symbols_list which seems to be equivalent to
what we are trying to do here. This means m4/ld-version.m4 could be
improved to deal with this.


@@ -420,7 +421,6 @@ INTROSPECTION_GIRS =
 INTROSPECTION_SCANNER_ARGS = --add-include-path=$(builddir) $(PREFIX_ARGS)
 INTROSPECTION_COMPILER_ARGS = --includedir=$(builddir)
 
-if HAVE_INTROSPECTION
 glib_introspection_files = $(libspice_client_glibinclude_HEADERS)
 gtk_introspection_files = $(libspice_client_gtkinclude_HEADERS)
 
@@ -453,7 +453,6 @@ typelibsdir = $(libdir)/girepository-1.0
 typelibs_DATA = $(INTROSPECTION_GIRS:.gir=.typelib)
 
 CLEANFILES += $(gir_DATA) $(typelibs_DATA)
-endif

I'm not sure why you needed this change.
My first guess was that this change is needed to prevent autoconf from
complaining that HAVE_INTROSPECTION is not present in an AM_CONDITIONAL
when gobject-introspection (and introspection.m4) are not installed.
However, this would mean that unconditionally building the introspection
stuff would fail, and moreover, when I tested just this change without
introspection, configure didn't succeed. Can you tell more about why this
change was needed?


diff --git a/gtk/continuation.c b/gtk/continuation.c
index 4f5b027..3aefa54 100644
--- a/gtk/continuation.c
+++ b/gtk/continuation.c
@@ -21,7 +21,10 @@
 #include config.h
 
 #include continuation.h
-
+#ifdef __MACH__
+#define _XOPEN_SOURCE 
+#include ucontext.h
+#endif

continuation.h already has the #include ucontext.h, including it again
shouldn't do much. Does something like
--- a/gtk/continuation.c
+++ b/gtk/continuation.c
@@ -21,7 +21,10 @@
 #include config.h
 
+#define _XOPEN_SOURCE 
 #include continuation.h

help with the issue you were having?


diff --git a/gtk/continuation.h b/gtk/continuation.h
index 585788e..6822757 100644
--- a/gtk/continuation.h
+++ b/gtk/continuation.h
@@ -21,7 +21,8 @@
 #ifndef _CONTINUATION_H_
 #define _CONTINUATION_H_
 
-#include ucontext.h
+#include string.h
+#include sys/ucontext.h

Ah, this explains the #include ucontext.h you added in the previous hunk.
I suspect dropping both hunks and only adding the #define _XOPEN_SOURCE
here would fix your issues. Though nothing in ucontext.h nor in
sys/ucontext.h on a macosx box depends on _XOPEN_SOURCE, so I'm not sure
what issues you were seeing here?


diff --git a/gtk/coroutine_ucontext.c b/gtk/coroutine_ucontext.c
index 91059ad..ee48249 100644
--- a/gtk/coroutine_ucontext.c
+++ b/gtk/coroutine_ucontext.c
@@ -25,6 +25,9 @@
 #include stdio.h
 #include stdlib.h
 #include coroutine.h
+#ifndef MAP_ANONYMOUS
+# define MAP_ANONYMOUS MAP_ANON
+#endif

Yep, macosx has MAP_ANON but no MAP_ANONYMOUS


diff --git a/gtk/spice-client-gtk.override b/gtk/spice-client-gtk.override
index 7b3543a..e634f78 100644
--- a/gtk/spice-client-gtk.override
+++ b/gtk/spice-client-gtk.override
@@ -1,6 +1,7 @@
 %%
 headers
 #include Python.h
+#define NO_IMPORT_PYGOBJECT

This one seems to be here for the same kind of issues as what led to
https://gitorious.org/rb-lastfm/rb-lastfm/commit/ab102ef5a954eb87354c3467d1a35c8fa596242b
but I must say I don't understand very well the issue/what's going on. Do
you happen to have the compile error handy (just for my knowledge). I'm
happy to take this one as is whatsoever.

Thanks again for the patch,

Christophe


pgptixDweZpHE.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Mosebach Kai
I finally build it on OSX 10.6.6 successfully :-)

From the patches below I only used :

common/lines.c
gtk/Makefile.am


Then a 

./configure --with-audio=gstreamer --without-python
--with-coroutine=gthread

did the trick, I think --with-coroutine=gthread avoid the _XOPEN_SOURCE
patches.

Best Kai


On 4/27/11 10:47 AM, Christophe Fergeau cferg...@redhat.com wrote:

On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote:
 Also I've attached the patch which fixes a few things here and there...
With
 this it builds fine.

Ah, so you've already built spice-gtk on macosx? How well did it work?

I had some questions about your patch, it would be really helpful if you
remembered why you had to change these things :)

Thanks for the patch,

Christophe

diff --git a/common/lines.c b/common/lines.c
index 1a14c18..59d0689 100644
--- a/common/lines.c
+++ b/common/lines.c
@@ -2985,7 +2985,7 @@ miWideDashSegment (GCPtr pGC,
 double L, l;
 double k;
 PolyVertexRec vertices[4];
-PolyVertexRec saveRight = { 0 }, saveBottom;
+PolyVertexRec saveRight = { 0 }, saveBottom = { 0 };
 PolySlopeRec slopes[4];
 PolyEdgeRec left[2], right[2];
 LineFaceRec lcapFace, rcapFace;

I assume this bit is to avoid a saveBottom can be used without being
initialized gcc warning?



diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index 7ce8a65..e5f3c1c 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -27,6 +27,7 @@ if HAVE_LD_VERSION_SCRIPT
 VERSION_LDFLAGS = -Wl,--version-script=${srcdir}/map-file
 else
 VERSION_LDFLAGS = -export-symbols ${srcdir}/sym-file
+#VERSION_LDFLAGS =
 endif
 
 KEYMAP_GEN = $(srcdir)/keymap-gen.pl


macosx ld indeed doesn't have any of --version-script nor -export-symbols,
but it does have --exported_symbols_list which seems to be equivalent to
what we are trying to do here. This means m4/ld-version.m4 could be
improved to deal with this.


@@ -420,7 +421,6 @@ INTROSPECTION_GIRS =
 INTROSPECTION_SCANNER_ARGS = --add-include-path=$(builddir)
$(PREFIX_ARGS)
 INTROSPECTION_COMPILER_ARGS = --includedir=$(builddir)
 
-if HAVE_INTROSPECTION
 glib_introspection_files = $(libspice_client_glibinclude_HEADERS)
 gtk_introspection_files = $(libspice_client_gtkinclude_HEADERS)
 
@@ -453,7 +453,6 @@ typelibsdir = $(libdir)/girepository-1.0
 typelibs_DATA = $(INTROSPECTION_GIRS:.gir=.typelib)
 
 CLEANFILES += $(gir_DATA) $(typelibs_DATA)
-endif

I'm not sure why you needed this change.
My first guess was that this change is needed to prevent autoconf from
complaining that HAVE_INTROSPECTION is not present in an AM_CONDITIONAL
when gobject-introspection (and introspection.m4) are not installed.
However, this would mean that unconditionally building the introspection
stuff would fail, and moreover, when I tested just this change without
introspection, configure didn't succeed. Can you tell more about why this
change was needed?


diff --git a/gtk/continuation.c b/gtk/continuation.c
index 4f5b027..3aefa54 100644
--- a/gtk/continuation.c
+++ b/gtk/continuation.c
@@ -21,7 +21,10 @@
 #include config.h
 
 #include continuation.h
-
+#ifdef __MACH__
+#define _XOPEN_SOURCE
+#include ucontext.h
+#endif

continuation.h already has the #include ucontext.h, including it again
shouldn't do much. Does something like
--- a/gtk/continuation.c
+++ b/gtk/continuation.c
@@ -21,7 +21,10 @@
 #include config.h
 
+#define _XOPEN_SOURCE
 #include continuation.h

help with the issue you were having?


diff --git a/gtk/continuation.h b/gtk/continuation.h
index 585788e..6822757 100644
--- a/gtk/continuation.h
+++ b/gtk/continuation.h
@@ -21,7 +21,8 @@
 #ifndef _CONTINUATION_H_
 #define _CONTINUATION_H_
 
-#include ucontext.h
+#include string.h
+#include sys/ucontext.h

Ah, this explains the #include ucontext.h you added in the previous
hunk.
I suspect dropping both hunks and only adding the #define _XOPEN_SOURCE
here would fix your issues. Though nothing in ucontext.h nor in
sys/ucontext.h on a macosx box depends on _XOPEN_SOURCE, so I'm not sure
what issues you were seeing here?


diff --git a/gtk/coroutine_ucontext.c b/gtk/coroutine_ucontext.c
index 91059ad..ee48249 100644
--- a/gtk/coroutine_ucontext.c
+++ b/gtk/coroutine_ucontext.c
@@ -25,6 +25,9 @@
 #include stdio.h
 #include stdlib.h
 #include coroutine.h
+#ifndef MAP_ANONYMOUS
+# define MAP_ANONYMOUS MAP_ANON
+#endif

Yep, macosx has MAP_ANON but no MAP_ANONYMOUS


diff --git a/gtk/spice-client-gtk.override b/gtk/spice-client-gtk.override
index 7b3543a..e634f78 100644
--- a/gtk/spice-client-gtk.override
+++ b/gtk/spice-client-gtk.override
@@ -1,6 +1,7 @@
 %%
 headers
 #include Python.h
+#define NO_IMPORT_PYGOBJECT

This one seems to be here for the same kind of issues as what led to
https://gitorious.org/rb-lastfm/rb-lastfm/commit/ab102ef5a954eb87354c3467d
1a35c8fa596242b
but I must say I don't understand very well the issue/what's going on. Do
you happen to have the compile error handy (just for my knowledge). I'm
happy to take this one as is whatsoever.


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote:
 I just triesbuild the OSX gtk client, my findings :
 
 1.) Installed gtk2 and gstreamer via ports

Do you get a gtk2 version using x11 or the native osx port when you get
it from (mac?)ports ?

Christophe


pgp3ZllVEhXHR.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
Regarding the native gtk2 build I think its not possible with macports.
You would need to use this I guess : http://gtk-osx.sourceforge.net/

Cheers Kai

On 4/27/11 11:18 AM, Christophe Fergeau cferg...@redhat.com wrote:

On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote:
 I just triesbuild the OSX gtk client, my findings :
 
 1.) Installed gtk2 and gstreamer via ports

Do you get a gtk2 version using x11 or the native osx port when you get
it from (mac?)ports ?

Christophe


___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 11:27:53AM +0200, Kai Mosebach wrote:
 Regarding the native gtk2 build I think its not possible with macports.
 You would need to use this I guess : http://gtk-osx.sourceforge.net/

yes, trying out http://sourceforge.net/apps/trac/gtk-osx/wiki/Build is part
of my medium term plans :)

Christophe


pgputl7ndOP2U.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/

Another note, on building the OSX client the symbol _g_get_monotonic_clock
is missing.
I think this comes from gtk/spice-session.c but does not seem to resolve
the glib version correctly.

I had to uncomment this pretty ugly:

//#if !GLIB_CHECK_VERSION(2,28,0)
static guint64 g_get_monotonic_clock(void)
{
GTimeVal tv;

/* TODO: support real monotonic clock? */
g_get_current_time (tv);

return (((gint64) tv.tv_sec) * 100) + tv.tv_usec;
}
//#endif



On 4/27/11 7:23 PM, Christophe Fergeau cferg...@redhat.com wrote:

On Wed, Apr 27, 2011 at 11:29:37AM +0200, Christophe Fergeau wrote:
 On Wed, Apr 27, 2011 at 11:27:53AM +0200, Kai Mosebach wrote:
  Regarding the native gtk2 build I think its not possible with
macports.
  You would need to use this I guess : http://gtk-osx.sourceforge.net/
 
 yes, trying out http://sourceforge.net/apps/trac/gtk-osx/wiki/Build is
part
 of my medium term plans :)

Actually I tested this today, I think starting from that work, it should
be
possible to make building a spice client on osx much easier. Basically, by
using these instructions, then by building gstreamer using what is
provided
by the gtk-osx project, and finally plugging and tweaking the jhbuild
spice
module from http://cgit.freedesktop.org/~teuf/spice-gtk/ I wasn't too far
from getting spice-gtk to build using a native gtk build. There are still
a
part of spice-gtk that expects either x11 or windows, so that doesn't work
yet :)
I'll try to get all the small tweaks I had to make integrated in whatever
git they belong to.

Christophe


___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote:
 Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/
 
 Another note, on building the OSX client the symbol _g_get_monotonic_clock
 is missing.
 I think this comes from gtk/spice-session.c but does not seem to resolve
 the glib version correctly.

I suspect you have 2 sets of glib headers, one from a newer one and one
from an older version, and the file is compiled with the newer headers and
linked with the older library, or something like that. I didn't have such
issues at least.

Christophe


pgpQ2gExN7N9A.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote:
 diff --git a/gtk/continuation.h b/gtk/continuation.h
 index 585788e..6822757 100644
 --- a/gtk/continuation.h
 +++ b/gtk/continuation.h
 @@ -21,7 +21,8 @@
  #ifndef _CONTINUATION_H_
  #define _CONTINUATION_H_
  
 -#include ucontext.h
 +#include string.h
 +#include sys/ucontext.h
 
 Ah, this explains the #include ucontext.h you added in the previous hunk.
 I suspect dropping both hunks and only adding the #define _XOPEN_SOURCE
 here would fix your issues. Though nothing in ucontext.h nor in
 sys/ucontext.h on a macosx box depends on _XOPEN_SOURCE, so I'm not sure
 what issues you were seeing here?

For the record, on the osx build I tried, I only had to add #include
stddef.h to continuation.h, and didn't need to define _XOPEN_SOURCE in
continuation.[ch].
string.h wasn't needed here, but I had to add it to ssl_verify.c. On my
leopard system, openssl was too old and EVP_PKEY_cmp didn't exist (it was
introduced in openssl 0.9.8). Copying the openssl 0.9.8 implementation in
the file was enough to workaround the problem, so we can probably test for
its presence in configure.ac and conditionally compile such code if the
function wasn't available.

Christophe


pgplwso06OLm1.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
If I run configure --with-coroutine=gthread I don¹t need those patches
below. 
Are there any disadvantages out of the gthreads?

On 4/27/11 7:28 PM, Christophe Fergeau cferg...@redhat.com wrote:

On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote:
 diff --git a/gtk/continuation.h b/gtk/continuation.h
 index 585788e..6822757 100644
 --- a/gtk/continuation.h
 +++ b/gtk/continuation.h
 @@ -21,7 +21,8 @@
  #ifndef _CONTINUATION_H_
  #define _CONTINUATION_H_
  
 -#include ucontext.h
 +#include string.h
 +#include sys/ucontext.h
 
 Ah, this explains the #include ucontext.h you added in the previous
hunk.
 I suspect dropping both hunks and only adding the #define _XOPEN_SOURCE
 here would fix your issues. Though nothing in ucontext.h nor in
 sys/ucontext.h on a macosx box depends on _XOPEN_SOURCE, so I'm not sure
 what issues you were seeing here?

For the record, on the osx build I tried, I only had to add #include
stddef.h to continuation.h, and didn't need to define _XOPEN_SOURCE in
continuation.[ch].
string.h wasn't needed here, but I had to add it to ssl_verify.c. On my
leopard system, openssl was too old and EVP_PKEY_cmp didn't exist (it was
introduced in openssl 0.9.8). Copying the openssl 0.9.8 implementation in
the file was enough to workaround the problem, so we can probably test for
its presence in configure.ac and conditionally compile such code if the
function wasn't available.

Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-26 Thread Attila Sukosd
Hi,


This might be a stupid question, but why don't you try to use spice-gtk on
OS/X instead of spicec ?
It has everything needed, such as gtk2/gtk3 and gstreamer for audio, all
cross platform.

Rgrds,

Attila


On Mon, Apr 25, 2011 at 11:34 PM, Cliff Sharp csh...@vbridges.com wrote:

  When trying to port the alsa-lib to OS/X while porting Spice to OS/X I am
 having some difficulties resolving issues with alsa-lib. I am using
 alsa-lib-1.0.24.1

 After doing a ./configure - I have also tried
 ./configure --enable-shared=no --enable-static=yes

 Either way I get the following error in the middle ---
 ./configure: line 18735: CC_NOUNDEFINED: command not found

 ___

 And then the end of the ./configure looks like this ---

 configure: creating ./config.status
 config.status: creating Makefile
 config.status: creating doc/Makefile
 config.status: creating doc/pictures/Makefile
 config.status: creating doc/doxygen.cfg
 config.status: creating include/Makefile
 config.status: creating include/sound/Makefile
 config.status: creating src/Versions
 config.status: creating src/Makefile
 config.status: creating src/control/Makefile
 config.status: creating src/mixer/Makefile
 config.status: creating src/pcm/Makefile
 config.status: creating src/pcm/scopes/Makefile
 config.status: creating src/rawmidi/Makefile
 config.status: creating src/timer/Makefile
 config.status: creating src/hwdep/Makefile
 config.status: creating src/seq/Makefile
 config.status: creating src/ucm/Makefile
 config.status: creating src/compat/Makefile
 config.status: creating src/alisp/Makefile
 config.status: creating src/conf/Makefile
 config.status: creating src/conf/cards/Makefile
 config.status: creating src/conf/pcm/Makefile
 config.status: creating modules/Makefile
 config.status: creating modules/mixer/Makefile
 config.status: creating modules/mixer/simple/Makefile
 config.status: creating alsalisp/Makefile
 config.status: creating aserver/Makefile
 config.status: creating test/Makefile
 config.status: creating test/lsb/Makefile
 config.status: creating utils/Makefile
 config.status: creating utils/alsa-lib.spec
 config.status: creating utils/alsa.pc
 config.status: creating include/config.h
 config.status: include/config.h is unchanged
 config.status: executing depfiles commands
 Creating asoundlib.h...

 Does this look like the ./configure completed successfully???

 __

 Then as a result of the make I get the following ---

 Making all in doc
 Making all in pictures
 make[2]: Nothing to be done for `all'.
 make[2]: Nothing to be done for `all-am'.
 Making all in include
 make  all-recursive
 Making all in sound
 make[3]: Nothing to be done for `all'.
 Making all in src
 Making all in control
  CC cards.lo
  CC tlv.lo
  CC namehint.lo
  CC hcontrol.lo
  CC control.lo
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6097:Expected
 comma after segment-name
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6101:Expected
 comma after segment-name
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6101:Rest of
 line ignored. 1st junk character valued 32 ( ).
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6593:Unknown
 pseudo-op: .symver
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6593:Rest of
 line ignored. 1st junk character valued 95 (_).
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6637:Unknown
 pseudo-op: .symver
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6637:Rest of
 line ignored. 1st junk character valued 95 (_).
 make[2]: *** [control.lo] Error 1
 make[1]: *** [all-recursive] Error 1
 make: *** [all-recursive] Error 1

 I haven't been able to quite figure out what is going with the make errors.
 I would appreciate it if someone would be able to give me some hints.

 Thanks

 





 ___
 Spice-devel mailing list
 Spice-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/spice-devel


___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] Spice on OS/X

2011-04-26 Thread Cliff Sharp
Great suggestion. 
I have been looking into spice-gtk because it does seem like it would be much 
less work.

Thanks.

On Apr 26, 2011, at 3:01 AM, Attila Sukosd wrote:

 Hi,
 
 
 This might be a stupid question, but why don't you try to use spice-gtk on 
 OS/X instead of spicec ?
 It has everything needed, such as gtk2/gtk3 and gstreamer for audio, all 
 cross platform.
 
 Rgrds,
 
 Attila
 
 
 On Mon, Apr 25, 2011 at 11:34 PM, Cliff Sharp csh...@vbridges.com wrote:
  When trying to port the alsa-lib to OS/X while porting Spice to OS/X I am 
 having some difficulties resolving issues with alsa-lib. I am using 
 alsa-lib-1.0.24.1
 
 After doing a ./configure - I have also tried
 ./configure --enable-shared=no --enable-static=yes
 
 Either way I get the following error in the middle ---
 ./configure: line 18735: CC_NOUNDEFINED: command not found
 
 ___
 
 And then the end of the ./configure looks like this ---
 
 configure: creating ./config.status
 config.status: creating Makefile
 config.status: creating doc/Makefile
 config.status: creating doc/pictures/Makefile
 config.status: creating doc/doxygen.cfg
 config.status: creating include/Makefile
 config.status: creating include/sound/Makefile
 config.status: creating src/Versions
 config.status: creating src/Makefile
 config.status: creating src/control/Makefile
 config.status: creating src/mixer/Makefile
 config.status: creating src/pcm/Makefile
 config.status: creating src/pcm/scopes/Makefile
 config.status: creating src/rawmidi/Makefile
 config.status: creating src/timer/Makefile
 config.status: creating src/hwdep/Makefile
 config.status: creating src/seq/Makefile
 config.status: creating src/ucm/Makefile
 config.status: creating src/compat/Makefile
 config.status: creating src/alisp/Makefile
 config.status: creating src/conf/Makefile
 config.status: creating src/conf/cards/Makefile
 config.status: creating src/conf/pcm/Makefile
 config.status: creating modules/Makefile
 config.status: creating modules/mixer/Makefile
 config.status: creating modules/mixer/simple/Makefile
 config.status: creating alsalisp/Makefile
 config.status: creating aserver/Makefile
 config.status: creating test/Makefile
 config.status: creating test/lsb/Makefile
 config.status: creating utils/Makefile
 config.status: creating utils/alsa-lib.spec
 config.status: creating utils/alsa.pc
 config.status: creating include/config.h
 config.status: include/config.h is unchanged
 config.status: executing depfiles commands
 Creating asoundlib.h...
 
 Does this look like the ./configure completed successfully???
 
 __
 
 Then as a result of the make I get the following ---
 
 Making all in doc
 Making all in pictures
 make[2]: Nothing to be done for `all'.
 make[2]: Nothing to be done for `all-am'.
 Making all in include
 make  all-recursive
 Making all in sound
 make[3]: Nothing to be done for `all'.
 Making all in src
 Making all in control
  CC cards.lo
  CC tlv.lo
  CC namehint.lo
  CC hcontrol.lo
  CC control.lo
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6097:Expected 
 comma after segment-name
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6101:Expected 
 comma after segment-name
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6101:Rest of 
 line ignored. 1st junk character valued 32 ( ).
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6593:Unknown 
 pseudo-op: .symver
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6593:Rest of 
 line ignored. 1st junk character valued 95 (_).
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6637:Unknown 
 pseudo-op: .symver
 /var/folders/Pv/PvC+gYnqE1aH2WUpUaGMJk+++TI/-Tmp-//cctnQSSU.s:6637:Rest of 
 line ignored. 1st junk character valued 95 (_).
 make[2]: *** [control.lo] Error 1
 make[1]: *** [all-recursive] Error 1
 make: *** [all-recursive] Error 1
 
 I haven't been able to quite figure out what is going with the make errors.
 I would appreciate it if someone would be able to give me some hints.
 
 Thanks
 
 
 
 
 
 
 
 ___
 Spice-devel mailing list
 Spice-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/spice-devel
 
 

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel