Re: [PATCH net-next] udp: properly support MSG_PEEK with truncated buffers

[David Miller]

From: Eric Dumazet 
Date: Wed, 30 Dec 2015 08:51:12 -0500

> From: Eric Dumazet 
> 
> Backport of this upstream commit into stable kernels :
> 89c22d8c3b27 ("net: Fix skb csum races when peeking")
> exposed a bug in udp stack vs MSG_PEEK support, when user provides
> a buffer smaller than skb payload.
> 
> In this case,
> skb_copy_and_csum_datagram_iovec(skb, sizeof(struct udphdr),
>  msg->msg_iov);
> returns -EFAULT.
> 
> This bug does not happen in upstream kernels since Al Viro did a great
> job to replace this into :
> skb_copy_and_csum_datagram_msg(skb, sizeof(struct udphdr), msg);
> This variant is safe vs short buffers.
> 
> For the time being, instead reverting Herbert Xu patch and add back
> skb->ip_summed invalid changes, simply store the result of
> udp_lib_checksum_complete() so that we avoid computing the checksum a
> second time, and avoid the problematic
> skb_copy_and_csum_datagram_iovec() call.
> 
> This patch can be applied on recent kernels as it avoids a double
> checksumming, then backported to stable kernels as a bug fix.
> 
> Signed-off-by: Eric Dumazet 

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [stable] ip6mr: call del_timer_sync() in ip6mr_free_table()

[David Miller]

From: Ben Hutchings 
Date: Wed, 23 Dec 2015 17:32:45 +

> It looks like this commit should be cherry-picked for stable branches
> older than 4.0:
> 
> commit 7ba0c47c34a1ea5bc7a24ca67309996cce0569b5
> Author: WANG Cong 
> Date:   Tue Mar 31 11:01:47 2015 -0700
> 
> ip6mr: call del_timer_sync() in ip6mr_free_table()

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up

[David Miller]

From: Martin Roth 
Date: Tue, 15 Dec 2015 04:17:53 +0200

> The patch fixes FCC port lock-up, which occurs as a result of a bug
> during underrun/collision handling. Within the tx_startup() function
> in mac-fcc.c, the address of last BD is not calculated correctly.
> As a result of wrong calculation of the last BD address, the next
> transmitted BD may be set to an area out of the transmit BD ring.
> This actually causes to port lock-up and it is not recoverable.
> 
> Signed-off-by: Martin Roth 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4.3] vrf: Fix memory leak on registration failure in vrf_newlink()

[David Miller]

From: Ben Hutchings 
Date: Tue, 15 Dec 2015 15:12:43 +

> The backported version of commit 7f109f7cc371 ("vrf: fix double free
> and memory corruption on register_netdevice failure") incorrectly
> removed a kfree() from the failure path as well as the free_netdev().
> Add that back.
> 
> Signed-off-by: Ben Hutchings 

Thanks for catching this:

Acked-by: David S. Miller 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: fix uninitialized variable issue

[David Miller]

From: Tadeusz Struk 
Date: Tue, 15 Dec 2015 10:46:17 -0800

> msg_iocb needs to be initialized on the recv/recvfrom path.
> Otherwise afalg will wrongly interpret it as an async call.
> 
> Cc: stable@vger.kernel.org
> Reported-by: Harald Freudenberger 
> Signed-off-by: Tadeusz Struk 

Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double allocations

[David Miller]

From: Eric Dumazet 
Date: Sun, 13 Dec 2015 12:43:10 -0800

> 2) I have no idea why this patch is even backported to 3.16,
>  since it is fixing a problem added in 3.18 :

Because someone on the path to some of the -stable trees aren't even
checking the Fixes: tag in the patches they are backporting.

And that's really bad...
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: netlink: Add missing goto statement to netlink_insert

[David Miller]

From: Herbert Xu 
Date: Tue, 8 Dec 2015 14:13:19 +0800

> On Mon, Dec 07, 2015 at 07:58:25AM +0100, Stefan Priebe - Profihost AG wrote:
>>
>> Thanks, good. Can you help me to get this fix upstream into the stable
>> lines?
> 
> Sure.  Greg, please apply this patch to fix up the backport for 4.1.

Herbert, thanks so much for taking care of this.

> ---8<---
> The backport of 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink:
> Fix autobind race condition that leads to zero port ID") missed a
> goto statement, which causes netlink to break subtly.
> 
> This was discovered by Stefan Priebe .
> 
> Fixes: 4e2776241766 ("netlink: Fix autobind race condition that...")
> Reported-by: Stefan Priebe 
> Reported-by: Philipp Hahn 
> Signed-off-by: Herbert Xu 

Acked-by: David S. Miller 

> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index d139c43..0d6038c 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1118,6 +1118,7 @@ static int netlink_insert(struct sock *sk, u32 portid)
>   if (err == -EEXIST)
>   err = -EADDRINUSE;
>   sock_put(sk);
> + goto err;
>   }
>  
>   /* We need to ensure that the socket is hashed and visible. */
> 
> -- 
> Email: Herbert Xu 
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: qca_spi: fix transmit queue timeout handling

[David Miller]

From: Stefan Wahren 
Date: Fri,  4 Dec 2015 16:29:10 +0100

> In case of a tx queue timeout every transmit is blocked until the
> QCA7000 resets himself and triggers a sync which makes the driver
> flushs the tx ring. So avoid this blocking situation by triggering
> the sync immediately after the timeout. Waking the queue doesn't
> make sense in this situation.
> 
> Signed-off-by: Stefan Wahren 
> Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for 
> QCA7000")

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/neighbour: fix crash at dumping device-agnostic proxy entries

[David Miller]

From: Konstantin Khlebnikov 
Date: Tue, 01 Dec 2015 01:14:48 +0300

> Proxy entries could have null pointer to net-device.
> 
> Signed-off-by: Konstantin Khlebnikov 
> Fixes: 84920c1420e2 ("net: Allow ipv6 proxies and arp proxies be shown with 
> iproute2")

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wan/x25: Fix use-after-free in x25_asy_open_tty()

[David Miller]

From: Peter Hurley 
Date: Fri, 27 Nov 2015 14:18:39 -0500

> The N_X25 line discipline may access the previous line discipline's closed
> and already-freed private data on open [1].
> 
> The tty->disc_data field _never_ refers to valid data on entry to the
> line discipline's open() method. Rather, the ldisc is expected to
> initialize that field for its own use for the lifetime of the instance
> (ie. from open() to close() only).
 ...
> Reported-and-tested-by: Sasha Levin 
> Cc: 
> Signed-off-by: Peter Hurley 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Resend PATCH] RDS: fix race condition when sending a message on unbound socket

[David Miller]

From: Santosh Shilimkar 
Date: Tue, 24 Nov 2015 17:13:21 -0500

> From: Quentin Casasnovas 
> 
> Sasha's found a NULL pointer dereference in the RDS connection code when
> sending a message to an apparently unbound socket.  The problem is caused
> by the code checking if the socket is bound in rds_sendmsg(), which checks
> the rs_bound_addr field without taking a lock on the socket.  This opens a
> race where rs_bound_addr is temporarily set but where the transport is not
> in rds_bind(), leading to a NULL pointer dereference when trying to
> dereference 'trans' in __rds_conn_create().
> 
> Vegard wrote a reproducer for this issue, so kindly ask him to share if
> you're interested.
> 
> I cannot reproduce the NULL pointer dereference using Vegard's reproducer
> with this patch, whereas I could without.
> 
> Complete earlier incomplete fix to CVE-2015-6937:
> 
>   74e98eb08588 ("RDS: verify the underlying transport exists before creating 
> a connection")
> 
> Cc: David S. Miller 
> Cc: stable@vger.kernel.org
> 
> Reviewed-by: Vegard Nossum 
> Reviewed-by: Sasha Levin 
> Acked-by: Santosh Shilimkar 
> Signed-off-by: Quentin Casasnovas 

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHES] Networking

[David Miller]

From: Jiri Slaby <jsl...@suse.cz>
Date: Sat, 14 Nov 2015 16:59:34 +0100

> On 11/13/2015, 10:38 PM, David Miller wrote:
>> 
>> Please queue up the following bug fixes to 4.3.x, 4.2.x, 4.1.x, and
>> 3.18.x -stable, respectively.
> 
> Hi,
> 
> it looks like 3.18 backport of 4ece9009774596ee3df0acba65a324b7ea79387c
> is missing removal of ipip6_tunnel_clone_6rd call, right?

Indeed, good catch.

The following should be more correct:


>From 7cc46fa7d5de9f253615f887522a18bb621737dc Mon Sep 17 00:00:00 2001
From: Eric Dumazet <eduma...@google.com>
Date: Mon, 2 Nov 2015 17:08:19 -0800
Subject: [PATCH] sit: fix sit0 percpu double allocations

[ Upstream commit 4ece9009774596ee3df0acba65a324b7ea79387c ]

sit0 device allocates its percpu storage twice :
- One time in ipip6_tunnel_init()
- One time in ipip6_fb_tunnel_init()

Thus we leak 48 bytes per possible cpu per network namespace dismantle.

ipip6_fb_tunnel_init() can be much simpler and does not
return an error, and should be called after register_netdev()

Note that ipip6_tunnel_clone_6rd() also needs to be called
after register_netdev() (calling ipip6_tunnel_init())

Fixes: ebe084aafb7e ("sit: Use ipip6_tunnel_init as the ndo_init function.")
Signed-off-by: Eric Dumazet <eduma...@google.com>
Reported-by: Dmitry Vyukov <dvyu...@google.com>
Cc: Steffen Klassert <steffen.klass...@secunet.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
 net/ipv6/sit.c | 27 ---
 1 file changed, 4 insertions(+), 23 deletions(-)

diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index a24557a..45eae1e 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -1394,34 +1394,20 @@ static int ipip6_tunnel_init(struct net_device *dev)
return 0;
 }
 
-static int __net_init ipip6_fb_tunnel_init(struct net_device *dev)
+static void __net_init ipip6_fb_tunnel_init(struct net_device *dev)
 {
struct ip_tunnel *tunnel = netdev_priv(dev);
struct iphdr *iph = >parms.iph;
struct net *net = dev_net(dev);
struct sit_net *sitn = net_generic(net, sit_net_id);
 
-   tunnel->dev = dev;
-   tunnel->net = dev_net(dev);
-
iph->version= 4;
iph->protocol   = IPPROTO_IPV6;
iph->ihl= 5;
iph->ttl= 64;
 
-   dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
-   if (!dev->tstats)
-   return -ENOMEM;
-
-   tunnel->dst_cache = alloc_percpu(struct ip_tunnel_dst);
-   if (!tunnel->dst_cache) {
-   free_percpu(dev->tstats);
-   return -ENOMEM;
-   }
-
dev_hold(dev);
rcu_assign_pointer(sitn->tunnels_wc[0], tunnel);
-   return 0;
 }
 
 static int ipip6_validate(struct nlattr *tb[], struct nlattr *data[])
@@ -1831,23 +1817,18 @@ static int __net_init sit_init_net(struct net *net)
 */
sitn->fb_tunnel_dev->features |= NETIF_F_NETNS_LOCAL;
 
-   err = ipip6_fb_tunnel_init(sitn->fb_tunnel_dev);
-   if (err)
-   goto err_dev_free;
-
-   ipip6_tunnel_clone_6rd(sitn->fb_tunnel_dev, sitn);
-
if ((err = register_netdev(sitn->fb_tunnel_dev)))
goto err_reg_dev;
 
+   ipip6_tunnel_clone_6rd(sitn->fb_tunnel_dev, sitn);
+   ipip6_fb_tunnel_init(sitn->fb_tunnel_dev);
+
t = netdev_priv(sitn->fb_tunnel_dev);
 
strcpy(t->parms.name, sitn->fb_tunnel_dev->name);
return 0;
 
 err_reg_dev:
-   dev_put(sitn->fb_tunnel_dev);
-err_dev_free:
ipip6_dev_free(sitn->fb_tunnel_dev);
 err_alloc_dev:
return err;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

[David Miller]

From: Sabrina Dubroca 
Date: Thu, 12 Nov 2015 10:48:22 +0100

> 2015-11-10, 16:03:52 -0800, Greg Kroah-Hartman wrote:
>> On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote:
>> > On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca  
>> > wrote:
>> > > 2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote:
>> > >> Without this length argument, we can read past the end of the iovec in
>> > >> memcpy_toiovec because we have no way of knowing the total length of the
>> > >> iovec's buffers.
>> > >>
>> > >> This is needed for stable kernels where 89c22d8c3b27 ("net: Fix skb
>> > >> csum races when peeking") has been backported but that don't have the
>> > >> ioviter conversion, which is almost all the stable trees <= 3.18.
>> > >>
>> > >> This also fixes a kernel crash for NFS servers when the client uses
>> > >>  -onfsvers=3,proto=udp to mount the export.
>> > >>
>> > >> Signed-off-by: Sabrina Dubroca 
>> > >> Reviewed-by: Hannes Frederic Sowa 
>> > >
>> > > Fixes CVE-2015-8019.
>> > > http://www.openwall.com/lists/oss-security/2015/10/29/1
>> > >
>> > > --
>> > > Sabrina
>> > > --
>> > > To unsubscribe from this list: send the line "unsubscribe netdev" in
>> > > the body of a message to majord...@vger.kernel.org
>> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> > 
>> > Greg
>> > 
>> > Do you have this in your queue? I saw a few other stables pick this
>> > up, but haven't seen it in 3.14 or 3.18 yet. It wasn't clear to me if
>> > this had been fully reviewed yet.
>> 
>> I rely on Dave to package up networking stable patches and forward them
>> on to me, that's why you haven't seen it be picked up yet.
>> 
>> thanks,
>> 
>> greg k-h
> 
> David, can you queue this up?

This doesn't even apply to v3.18.24, the patched call site in
net/rxrpc/ar-recvmsg.c doesn't even exist.

Once you fix this up just submit it to -stable directly, I'm
fine with that for this.  I'm only handling submissions back
to v3.18 (4 releases) anyways.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] netlink: fix locking around NETLINK_LIST_MEMBERSHIPS

[David Miller]

From: David Herrmann 
Date: Wed, 21 Oct 2015 11:47:43 +0200

> Currently, NETLINK_LIST_MEMBERSHIPS grabs the netlink table while copying
> the membership state to user-space. However, grabing the netlink table is
> effectively a write_lock_irq(), and as such we should not be triggering
> page-faults in the critical section.
> 
> This can be easily reproduced by the following snippet:
> int s = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE);
> void *p = mmap(0, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, -1, 
> 0);
> int r = getsockopt(s, 0x10e, 9, p, (void*)((char*)p + 4092));
> 
> This should work just fine, but currently triggers EFAULT and a possible
> WARN_ON below handle_mm_fault().
> 
> Fix this by reducing locking of NETLINK_LIST_MEMBERSHIPS to a read-side
> lock. The write-lock was overkill in the first place, and the read-lock
> allows page-faults just fine.
> 
> Reported-by: Dmitry Vyukov 
> Signed-off-by: David Herrmann 

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] xen-netfront: update num_queues to real created

[David Miller]

From: Joe Jin 
Date: Mon, 19 Oct 2015 13:37:17 +0800

> Sometimes xennet_create_queues() may failed to created all requested
> queues, we need to update num_queues to real created to avoid NULL
> pointer dereference.
> 
> Signed-off-by: Joe Jin 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4.1 22/29] net: dsa: bcm_sf2: Do not override speed settings

[David Miller]

From: Ben Hutchings 
Date: Fri, 02 Oct 2015 01:47:23 +0100

> On Thu, 2015-10-01 at 11:31 +0200, Greg Kroah-Hartman wrote:
>> 4.1-stable review patch.  If anyone has any objections, please let me
>> know.
>> 
>> --
>> 
>> From: Florian Fainelli 
>> 
>> [ Upstream d2eac98f7d1b950b762a7eca05a9ce0ea1d878d2 in net-next tree,
>>   will be pushed to Linus very soon. ]
> [...]
> 
> Patches 22-25 are all in 4.3-rc3, so perhaps you should change these
> comments to match the real status?

Greg et al. can feel free to do this :-)
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] net: netcp: a set of bug fixes

[David Miller]

From: Murali Karicheri 
Date: Wed, 23 Sep 2015 13:37:04 -0400

> This patch series fixes a set of issues in netcp driver seen during internal
> testing of the driver. While at it, do some clean up as well.
> 
> The fixes are tested on K2HK, K2L and K2E EVMs and the boot up logs can be
> seen at
> 
>  http://pastebin.ubuntu.com/12533100/

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: mvneta: fix DMA buffer unmapping in mvneta_rx()

[David Miller]

From: Simon Guinot 
Date: Tue, 15 Sep 2015 22:41:21 +0200

> This patch fixes a regression introduced by the commit a84e32894191
> ("net: mvneta: fix refilling for Rx DMA buffers"). Due to this commit
> the newly allocated Rx buffers are DMA-unmapped in place of those passed
> to the networking stack. Obviously, this causes data corruptions.
> 
> This patch fixes the issue by ensuring that the right Rx buffers are
> DMA-unmapped.
> 
> Reported-by: Oren Laskin 
> Signed-off-by: Simon Guinot 
> Fixes: a84e32894191 ("net: mvneta: fix refilling for Rx DMA buffers")

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] stmmac: fix check for phydev being open

[David Miller]

From: Alexey Brodkin <alexey.brod...@synopsys.com>
Date: Wed,  9 Sep 2015 18:01:08 +0300

> Current check of phydev with IS_ERR(phydev) may make not much sense
> because of_phy_connect() returns NULL on failure instead of error value.
> 
> Still for checking result of phy_connect() IS_ERR() makes perfect sense.
> 
> So let's use combined check IS_ERR_OR_NULL() that covers both cases.
> 
> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
> Cc: Giuseppe Cavallaro <peppe.cavall...@st.com>
> Cc: linux-ker...@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <da...@davemloft.net>
> Signed-off-by: Alexey Brodkin <abrod...@synopsys.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v5 00/11] ipv6: Only create RTF_CACHE route after encountering pmtu exception

[David Miller]

From: Martin KaFai Lau ka...@fb.com
Date: Fri, 28 Aug 2015 00:36:38 -0700

 On Mon, Aug 17, 2015 at 11:43:20AM +0200, Alexander Holler wrote:
 That's why I vote to check out if it's possible/reasonable to backport this
 series to the stable kernels.
 I have backported to 4.0.y without major issue, so possible.
 
 I did try on 3.1x and gave up.
 
 It is a lot of changes,  so I don't think it is a good idea for -stable.

I am absolutely, firmly, against any of this work going into -stable.

It is completely inappropriate, the potential for regressions is
enormous.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHES] Networking

[David Miller]

From: Luis Henriques luis.henriq...@canonical.com
Date: Thu, 27 Aug 2015 14:35:57 +0100

 Hi David,
 
 On Wed, Aug 26, 2015 at 11:05:12PM -0700, David Miller wrote:
 
 Please queue up the following networking bug fixes for v3.12, v3.14, v3.18,
 and v4.1 -stable, respectively.
 
 Thanks!
 
 While going through these patches to pick those applicable to the 3.16
 kernel, I believe I found an issue with the backport of 1c1bf34951e8
 (net/mlx4_core: Fix wrong index in propagating port change event to
 VFs) into 3.14.
 
 The 2nd hunk has the following:
 
 @@ -583,7 +583,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct 
 mlx4_eq *eq)
   for (i = 0; i  dev-num_slaves; i++) {
   if (i == 
 mlx4_master_func_num(dev))
   continue;
 - s_info = 
 priv-mfunc.master.vf_oper[slave].vport[port].state;
 + s_info = 
 priv-mfunc.master.vf_oper[slave].vport[i].state;
 
 It should be:
 
 - s_info = 
 priv-mfunc.master.vf_oper[slave].vport[port].state;
 + s_info = 
 priv-mfunc.master.vf_oper[i].vport[port].state;
 
 (the 'slave' index should be changed by 'i', not 'port').

Sorry, you are definitely correct.  I hope the v3.14 -stable maintain
catches this, thanks!
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC v3] netlink: add NETLINK_CAP_ACK socket option

[David Miller]

From: Christophe Ricard christophe.ric...@gmail.com
Date: Thu, 27 Aug 2015 21:31:31 +0200

 Since commit c05cdb1b864f (netlink: allow large data transfers from
 user-space), the kernel may fail to allocate the necessary room for the
 acknowledgment message back to userspace. This patch introduces a new
 socket option that trims off the payload of the original netlink message.
 
 The netlink message header is still included, so the user can guess from
 the sequence number what is the message that has triggered the
 acknowledgment.
 
 Cc: stable@vger.kernel.org

Please do not CC: stable for networking changes, that is not how we handle
-stable submissions.

Instead, please just explicitly ask me to queue it up for -stable when
you make a bonafide non-RFC submission of a change.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHES] Sparc

[David Miller]

Please queue up the following sparc64 FPU register corruption bug fix
for all active -stable releases.

Thank you.



sparc_32.mbox
Description: Binary data


sparc_34.mbox
Description: Binary data


sparc_310.mbox
Description: Binary data


sparc_312.mbox
Description: Binary data


sparc_314.mbox
Description: Binary data


sparc_318.mbox
Description: Binary data


sparc_41.mbox
Description: Binary data

Re: [PATCH 3.2 089/110] net: Clone skb before setting peeked flag

[David Miller]

From: Konstantin Khlebnikov khlebni...@yandex-team.ru
Date: Mon, 10 Aug 2015 14:37:05 +0300

 On 10.08.2015 13:12, Ben Hutchings wrote:
 3.2.71-rc1 review patch.  If anyone has any objections, please let me
 know.
 
 Here is important fix: https://patchwork.ozlabs.org/patch/503374/
 net: Fix skb_set_peeked use-after-free. not in upstream yet.

It is in my -stable queue and will be submitted to the stable trees
when I deem it appropriate.  I wanted the fix to sit and soak in
Linus's tree before just throwing it to the stable folks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

[David Miller]

From: Simon Guinot simon.gui...@sequanux.org
Date: Sun, 19 Jul 2015 13:00:53 +0200

 With the actual code, if a memory allocation error happens while
 refilling a Rx descriptor, then the original Rx buffer is both passed
 to the networking stack (in a SKB) and let in the Rx ring. This leads
 to various kernel oops and crashes.
 
 As a fix, this patch moves Rx descriptor refilling ahead of building
 SKB with the associated Rx buffer. In case of a memory allocation
 failure, data is dropped and the original DMA buffer is put back into
 the Rx ring.
 
 Signed-off-by: Simon Guinot simon.gui...@sequanux.org
 Fixes: c5aff18204da (net: mvneta: driver for Marvell Armada 370/XP network 
 unit)
 Cc: stable@vger.kernel.org # v3.8+
 Tested-by: Yoann Sculo yo...@sculo.fr

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: mvneta: fix refilling for Rx DMA buffers

[David Miller]

From: Simon Guinot simon.gui...@sequanux.org
Date: Mon, 13 Jul 2015 00:04:57 +0200

 On some Armada 370-based NAS, I have experimented kernel bugs and
 crashes when the mvneta Ethernet driver fails to refill Rx DMA buffers
 due to memory shortage.
 
 With the actual code, if the memory allocation fails while refilling a
 Rx DMA buffer, then the corresponding descriptor is let with the address
 of an unmapped DMA buffer already passed to the network stack. Since the
 driver still increments the non-occupied counter for Rx descriptor (if a
 next packet is handled successfully), then the Ethernet controller is
 allowed to reuse the unfilled Rx descriptor...
 
 As a fix, this patch first refills a Rx descriptor before handling the
 stored data and unmapping the associated Rx DMA buffer. Additionally the
 occupied and non-occupied counters for the Rx descriptors queues are now
 both updated with the rx_done value: the number of descriptors ready to
 be returned to the networking controller. Moreover note that there is no
 point in using different values for this counters because both the
 mvneta driver and the Ethernet controller are unable to handle holes in
 the Rx descriptors queues.
 
 Signed-off-by: Simon Guinot simon.gui...@sequanux.org
 Fixes: c5aff18204da (net: mvneta: driver for Marvell Armada 370/XP network 
 unit)
 Cc: stable@vger.kernel.org # v3.8+
 Tested-by: Yoann Sculo yo...@sculo.fr

Failed memory allocations, are normal and if necessary kernel log
messages will be triggered by the core memory allocator.  So there is
zero reason to do anything other than bump the drop counter in your
driver.

If I understand the rest of your logic, if the allocator fails, we
will reuse the original SKB and place it back into the RX ring?
Right?

If not, that's the approach you should be using and it is what we
advise all networking driver authors to do.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] NET: AX.25: Stop heartbeat timer on disconnect.

[David Miller]

From: Ralf Baechle r...@linux-mips.org
Date: Mon, 13 Jul 2015 11:38:24 +0200

 From: Richard Stearn rich...@rns-stearn.demon.co.uk
 
 This may result in a kernel panic.  The bug has always existed but
 somehow we've run out of luck now and it bites.
 
 Signed-off-by: Richard Stearn rich...@rns-stearn.demon.co.uk
 Cc: stable@vger.kernel.org# all branches
 Signed-off-by: Ralf Baechle r...@linux-mips.org
 ---
 v2: Correctly attribute the patch to Richard Stearn in the From: line

Applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: mvneta: fix refilling for Rx DMA buffers

[David Miller]

From: Simon Guinot simon.gui...@sequanux.org
Date: Thu, 16 Jul 2015 02:25:30 +0200

 On Wed, Jul 15, 2015 at 03:52:56PM -0700, David Miller wrote:
 Failed memory allocations, are normal and if necessary kernel log
 messages will be triggered by the core memory allocator.  So there is
 zero reason to do anything other than bump the drop counter in your
 driver.
 
 Sure.

Ok so just get rid of this log message in your patch and resubmit,
thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check

[David Miller]

From: Krzysztof Kozlowski k.kozlowsk...@gmail.com
Date: Thu,  9 Jul 2015 22:21:20 +0900

 Value returned by devm_ioremap_resource() was checked for non-NULL but
 devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of
 error this could lead to dereference of ERR_PTR.
 
 Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
 Cc: stable@vger.kernel.org
 Fixes: 46aa27df8853 (net: axienet: Use devm_* calls)

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH v2 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Wed, 8 Jul 2015 14:35:22 +0530

 In commit 'c03abd84634d (net: ethernet: cpsw: don't requests
 IRQs we don't use)', common isr is split into tx and rx, but
 in rx isr tx interrupt is also disabledi in cpsw_disable_irq().
 So tx interrupts are not handled during rx interrupts and rx
 napi completion and results in poor tx performance by 40Mbps.
 Fixing by disabling only rx interrupt in rx isr.
 
 Cc: Felipe Balbi ba...@ti.com
 Cc: stable@vger.kernel.org # v4.0+
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] NET: hamradio: Fix IP over bpq encapsulation.

[David Miller]

From: Ralf Baechle r...@linux-mips.org
Date: Sat, 4 Jul 2015 11:22:30 +0200

 Since 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic
 neighbour cache operations.) any attempt to transmit IP packets over
 a bpqether device will result in a message like Dead loop on virtual
 device bpq0, fix it urgently!
 
 Fix suggested by Eric W. Biederman ebied...@xmission.com.
 
 Signed-off-by: Ralf Baechle r...@linux-mips.org
 Cc: stable@vger.kernel.org # 4.1

Applied, thanks Ralf.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 1/1] drivers: net: cpsw: fix crash while accessing second slave ethernet interface

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 7 Jul 2015 18:30:39 +0530

 When cpsw's number of slave is set to 1 in device tree and while
 accessing second slave ndev and priv in cpsw_tx_interrupt(),
 there is a kernel crash. This is due to cpsw_get_slave_priv()
 not verifying number of slaves while retriving netdev priv and
 returns a invalid memory region. Fixing the issue by introducing
 number of slave check in cpsw_get_slave_priv() and
 cpsw_get_slave_ndev().
...
 Signed-off-by: Mugunthan V N mugunthan...@ti.com
 Cc: stable@vger.kernel.org # v3.8+

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] SPARC

[David Miller]

Please queue up the following Sparc bug fix for 3.14, 3.18, and
4.0 -stable, respectively.

Thanks!
From patchwork Tue Apr 21 14:30:41 2015
Content-Type: text/plain; charset=utf-8
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: sparc: Use GFP_ATOMIC in ldc_alloc_exp_dring() as it can be called in
 softirq context
From: Sowmini Varadhan sowmini.varad...@oracle.com
X-Patchwork-Id: 463148
Message-Id: 1429626641-199974-1-git-send-email-sowmini.varad...@oracle.com
To: sowmini.varad...@oracle.com, sparcli...@vger.kernel.org
Cc: david.stev...@oracle.com, da...@davemloft.net
Date: Tue, 21 Apr 2015 10:30:41 -0400

[ Upstream commit 671d773297969bebb1732e1cdc1ec03aa53c6be2 ]

Since it is possible for vnet_event_napi to end up doing
vnet_control_pkt_engine - ... - vnet_send_attr -
vnet_port_alloc_tx_ring - ldc_alloc_exp_dring - kzalloc()
(i.e., in softirq context), kzalloc() should be called with
GFP_ATOMIC from ldc_alloc_exp_dring.

Signed-off-by: Sowmini Varadhan sowmini.varad...@oracle.com
---
 arch/sparc/kernel/ldc.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/kernel/ldc.c b/arch/sparc/kernel/ldc.c
index d2ae0f7..7d3ca30 100644
--- a/arch/sparc/kernel/ldc.c
+++ b/arch/sparc/kernel/ldc.c
@@ -2290,7 +2290,7 @@ void *ldc_alloc_exp_dring(struct ldc_channel *lp, unsigned int len,
 	if (len  (8UL - 1))
 		return ERR_PTR(-EINVAL);
 
-	buf = kzalloc(len, GFP_KERNEL);
+	buf = kzalloc(len, GFP_ATOMIC);
 	if (!buf)
 		return ERR_PTR(-ENOMEM);
 

Re: missing in stable 4.1.1 - was Re: pull-request: can 2015-06-21

[David Miller]

From: Oliver Hartkopp socket...@hartkopp.net
Date: Tue, 30 Jun 2015 21:31:36 +0200

 Hello Greg,
 
 On 23.06.2015 15:43, David Miller wrote:
 From: Marc Kleine-Budde m...@pengutronix.de
 Date: Sun, 21 Jun 2015 19:04:58 +0200

 this is a, probably too late, pull request for v4.1.

 Oliver Hartkopp fixed a bug in the generic CAN frame handling code,
 which may
 lead to loss of CAN frames. It was introduced during v4.1 development.

 Please queue via net/master if possible, net-next/master
 otherwise. I've added
 stable on Cc, just in case.

 Pulled, thanks.
 
 the patch can: fix loss of CAN frames in raw_rcv was sent to stable
 on 2015-06-21 but unfortunately did not find its way into 4.1.1 :-(
 
 The upstream commit is:
 
 http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=36c01245eb8046c16eee6431e7dbfbb302635fa8
 
 which slipped into 4.2 at merge window opening time.
 
 So it just got lost in the stable queue somehow.

Please take care of CAN -stable submissions yourself, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] stmmac: troubleshoot unexpected bits in des0 des1

[David Miller]

From: Alexey Brodkin alexey.brod...@synopsys.com
Date: Wed, 24 Jun 2015 11:47:41 +0300

 Current implementation of descriptor init procedure only takes
 care about setting/clearing ownership flag in des0/des1
 fields while it is perfectly possible to get unexpected bits
 set because of the following factors:

Applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 des1

[David Miller]

From: Alexey Brodkin alexey.brod...@synopsys.com
Date: Wed, 24 Jun 2015 11:07:26 +0300

  
 - priv-dma_tx = dma_alloc_coherent(priv-device, txsize *
 + priv-dma_tx = dma_zalloc_coherent(priv-device, txsize *
 sizeof(struct dma_desc),
 priv-dma_tx_phy,
 GFP_KERNEL);

When you change the column at which the openning parenthesis of the
function call occurs, you must indent the subsequent lines of the
function call such that the all are adjusted to properly start
at the very next column after that openning parenthesis.'

Please fix this up for all of the dma_zalloc_coherent()
transformations.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] stmmac: explicitly zero des0 des1 on init

[David Miller]

From: Alexey Brodkin alexey.brod...@synopsys.com
Date: Tue, 23 Jun 2015 15:04:31 +

 I'm wondering if my comment makes sense and should I just change commit
 message or you'd prefer to still use dma_zalloc_coherent() during
 driver probe?

I think you should do both, convert to dma_zalloc_coherent() and perform
the explicit clearing in the routine in question.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mvneta: add forgotten initialization of autonegotiation bits

[David Miller]

From: Stas Sergeev s...@list.ru
Date: Thu, 18 Jun 2015 18:36:03 +0300

 
 The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state
 signaling)
 changed mvneta_adjust_link() so that it does not clear the auto-negotiation
 bits in MVNETA_GMAC_AUTONEG_CONFIG register. This was necessary for
 auto-negotiation mode to work.
 Unfortunately I haven't checked if these bits are ever initialized.
 It appears they are not.
 This patch adds the missing initialization of the auto-negotiation bits
 in the MVNETA_GMAC_AUTONEG_CONFIG register.
 It fixes the following regression:
 https://www.mail-archive.com/netdev@vger.kernel.org/msg67928.html
 
 Since the patch was tested to fix a regression, it should be applied to
 stable tree.
 
 Tested-by: Arnaud Ebalard a...@natisbad.org
 
 CC: Thomas Petazzoni thomas.petazz...@free-electrons.com
 CC: Florian Fainelli f.faine...@gmail.com
 CC: net...@vger.kernel.org
 CC: linux-ker...@vger.kernel.org
 CC: stable@vger.kernel.org
 
 Signed-off-by: Stas Sergeev s...@users.sourceforge.net

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.

[David Miller]

From: Ralf Baechle r...@linux-mips.org
Date: Fri, 19 Jun 2015 00:46:53 +0200

 A ROSE socket doesn't necessarily always have a neighbour pointer so check
 if the neighbour pointer is valid before dereferencing it.
 
 Signed-off-by: Ralf Baechle r...@linux-mips.org
 Tested-by: Bernard Pidoux f6...@free.fr
 Cc: stable@vger.kernel.org #2.6.11+

Applied, thanks Ralf.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] stmmac: explicitly zero des0 des1 on init

[David Miller]

From: Alexey Brodkin alexey.brod...@synopsys.com
Date: Tue, 16 Jun 2015 20:40:41 +0300

 Current implementtion of descriptor init procedure only takes care about
 ownership flag. While it is perfectly possible to have underlying memory
 filled with garbage on boot or driver installation.
 
 And randomly set flags in non-zeroed des0 and des1 fields may lead to
 unpredictable behavior of the GMAC DMA block.
 
 Solution to this problem is as simple as explicit zeroing of both des0
 and des1 fields of all buffer descriptors.
 
 Signed-off-by: Alexey Brodkin abrod...@synopsys.com

If you need the memory zero initialized, use dma_zalloc_coherent().
--
To unsubscribe from this list: send the line unsubscribe stable in

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

[David Miller]

From: Junling Zheng zhengjunl...@huawei.com
Date: Mon, 1 Jun 2015 09:28:00 +

 We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL
 was expected.
 
 We tested it through the recvmsg01 testcase come from LTP testsuit. It set
 msg-msg_namelen to -1 and the recvmsg syscall returned errno 14, which is
 unexpected (errno 22 is expected):
 
 recvmsg014  TFAIL  :  invalid socket length ; returned -1 (expected -1),
 errno 14 (expected 22)
 
 Linux mainline has no this bug for commit 08adb7dab fixes it accidentally.
 However, it is too large and complex to be backported to LTS 3.10.
 
 So, I made the following patch to fix the above problem for LTS 3.10.

Upstream the code doesn't look anything like this, so it's probably
just a missing bug fix for -stable.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

[David Miller]

From: Junling Zheng zhengjunl...@huawei.com
Date: Tue, 2 Jun 2015 12:05:32 +0800

 So, the problem commit is 281c9c36 (net: compat: Update
 get_compat_msghdr() to match copy_msghdr_from_user() behaviour),
 which fixes db31c55a6fb2 and brings the get_compat_msghdr() in line
 with copy_msghdr_from_user().

Upstream this got fixed by:

08adb7dabd4874cc5666b4490653b26534702ce0

So the part that makes us not unconditionally return -EFAULT needs
to be backported, and that's probably equivalent to the patch
your proposed which therefore should be applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] Fix lockup related to stop_machine being stuck in __do_softirq.

[David Miller]

From: Eric Dumazet eric.duma...@gmail.com
Date: Mon, 18 May 2015 13:34:36 -0700

 On Mon, 2015-05-18 at 12:19 -0700, Linus Torvalds wrote:
 So this one kind of fell through the cracks, partly because I don't
 exactly love the patch.
 
 What is it that keeps re-arming the softirq pending bit all the time?
 You mention the ath9k driver..
 
 Also, do we really need the jiffies-based one at all? Maybe we should
 just get rid of that entirely, if it's not sufficiently reliable
 anyway. It's not like we should *ever* keep doing softirq's forever,
 and quite frankly, when you introduce the limit of doing the loop at
 most ten times, I doubt that the 2 milliseconds limit is even
 relevant any more. It would be a strange situation where ten times
 through the softirq handling loop would take more than 2ms.
 
 We've seen very often this taking more than 50ms here.
 
 Things get better, but back in 2013, timer handlers could run for quite
 a long time. The infamous one is scheduled to me removed for 4.1 (TCP
 SYNACK retransmit timer)

If he is doing full crypto in software, it is definitely possible for
new packets to show up (and thus new softirq work) before existing
work is complete.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5] net: phy: micrel: Fix regression in kszphy_probe

[David Miller]

From: Niklas Cassel niklas.cas...@axis.com
Date: Tue, 12 May 2015 09:43:14 +0200

 Don't do clock-mode-select if clk == NULL,
 since when building without CONFIG_HAVE_CLK,
 clk_get returns NULL and clk_get_rate returns 0.
 
 Doing clock-mode-select in this cause causes kszphy_probe to
 return -EINVAL and thus prevents the device from being probed.
 
 The original code (before regression) would return 0
 when building without CONFIG_HAVE_CLK.
 
 Cc: stable stable@vger.kernel.org # 3.18+
 Fixes: 1fadee0c3645 (net/phy: micrel: Add clock support for
 KSZ8021/KSZ8031)
 Reviewed-by: Fabio Estevam fabio.este...@freescale.com
 Reviewed-by: Johan Hovold jo...@kernel.org
 Signed-off-by: Niklas Cassel nikl...@axis.com

Applied, thank you.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: net fix emit_udiv() for BPF_ALU | BPF_DIV | BPF_K intruction.

[David Miller]

From: Nicolas Schichan nschic...@freebox.fr
Date: Wed,  6 May 2015 18:31:56 +0200

 In that case, emit_udiv() will be called with rn == ARM_R0 (r_scratch)
 and loading rm first into ARM_R0 will result in jit_udiv() function
 being called the same dividend and divisor. Fix that by loading rn
 first into ARM_R1 and then rm into ARM_R0.
 
 Signed-off-by: Nicolas Schichan nschic...@freebox.fr
 Cc: stable@vger.kernel.org # v3.13+
 Fixes: aee636c4809f (bpf: do not use reciprocal divide)

Applied, thank you.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: net fix emit_udiv() for BPF_ALU | BPF_DIV | BPF_K intruction.

[David Miller]

From: Nicolas Schichan nschic...@freebox.fr
Date: Wed,  6 May 2015 18:31:56 +0200

 In that case, emit_udiv() will be called with rn == ARM_R0 (r_scratch)
 and loading rm first into ARM_R0 will result in jit_udiv() function
 being called the same dividend and divisor. Fix that by loading rn
 first into ARM_R1 and then rm into ARM_R0.
 
 Signed-off-by: Nicolas Schichan nschic...@freebox.fr
 Cc: stable@vger.kernel.org # v3.13+
 Fixes: aee636c4809f (bpf: do not use reciprocal divide)

Do you want me to push this via my net tree?
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHES] NETWORKING

[David Miller]

Greg, I know you said to skip v3.19 going forward, but the ping unhashing crash
fix might justify one more release so I present it here for your consideration.

Please queue up the following networking bug fixes for v3.12, v3.14, v3.18,
v3.19, and v4.0, respectively.

Thanks a lot!


net_312.mbox
Description: Binary data


net_314.mbox
Description: Binary data


net_318.mbox
Description: Binary data


net_319.mbox
Description: Binary data


net_40.mbox
Description: Binary data

Re: [PATCHES] Networking

[David Miller]

From: Greg KH gre...@linuxfoundation.org
Date: Wed, 29 Apr 2015 13:09:50 +0200

 No need to make up 3.19 patches anymore, this is going to be the last
 3.19 kernel I release.

Ok thanks for the info.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHES] Networking

[David Miller]

Please queue up the following networking bug fixes for
3.12, 3.14, 3.18, 3.19, and 4.0 -stable, respectively.

Thanks a lot!


net_312.mbox
Description: Binary data


net_314.mbox
Description: Binary data


net_318.mbox
Description: Binary data


net_319.mbox
Description: Binary data


net_40.mbox
Description: Binary data

Re: v3.12-stable-queue build errors

[David Miller]

From: ebied...@xmission.com (Eric W. Biederman)
Date: Mon, 27 Apr 2015 10:35:51 -0500

 Jiri Slaby jsl...@suse.cz writes:
 
 On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
 Several powerpc build fail with:
 
 drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':
 drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit 
 declaration of
 function 'dev_consume_skb_any' [-Werror=implicit-function-declaration]
dev_consume_skb_any(skb);
 
 dev_consume_skb_any() does not exist in 3.12.
 
 Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'.

 Eric, David,

 what action should I take here?

 1) take also:
 commit e6247027e5173c00efb2084d688d06ff835bc3b0
 Author: Eric Dumazet eduma...@google.com
 Date:   Thu Dec 5 04:45:08 2013 -0800

 net: introduce dev_consume_skb_any()


 2) drop 'gianfar: Carefully free skbs in functions called by netpoll'
 from stable-3.12
 
 This is probably the most reasonable.   KISS.

Yeah just drop the patch.

I didn't even want to submit this series in the first place but
people kept poking me endlessly about it.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [stable request] mlx4 dev_kfree_skb

[David Miller]

From: Jiri Slaby jsl...@suse.cz
Date: Mon, 27 Apr 2015 11:10:51 +0200

 On 04/21/2015, 08:30 PM, David Miller wrote:
 Please queue up the following networking bug fixes for 3.12, 3.14, 3.18,
 3.19, and 4.0 -stable, respectively.
 
 Hi,
 
 similar to other Call dev_kfree_skby_any instead of dev_kfree_skb., I
 believe, that mlx4 (only) in 3.14 should receive the fix too:

No, enough is enough.  I didn't even want to submit the first series you
asked for.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb-tstamp

[David Miller]

From: Willy Tarreau w...@1wt.eu
Date: Mon, 27 Apr 2015 06:02:22 +0200

 Hi Greg,
 
 On Sun, Apr 26, 2015 at 03:46:26PM +0200, Greg Kroah-Hartman wrote:
 3.10-stable review patch.  If anyone has any objections, please let me know.
 
 --
 
 From: Eric Dumazet eduma...@google.com
 
 [ Upstream commit b50edd7812852d989f2ef09dcfc729690f54a42d ]
 
 I noticed tcpdump was giving funky timestamps for locally
 generated SYNACK messages on loopback interface.
 
 11:42:46.938990 IP 127.0.0.1.48245  127.0.0.2.23850: S
 945476042:945476042(0) win 43690 mss 65495,nop,nop,sackOK,nop,wscale 7
 
 20:28:58.502209 IP 127.0.0.2.23850  127.0.0.1.48245: S
 3160535375:3160535375(0) ack 945476043 win 43690 mss
 65495,nop,nop,sackOK,nop,wscale 7
 
 This is because we need to clear skb-tstamp before
 entering lower stack, otherwise net_timestamp_check()
 does not set skb-tstamp.
 
 Fixes: 7faee5c0d514 (tcp: remove TCP_SKB_CB(skb)-when)
 Signed-off-by: Eric Dumazet eduma...@google.com
 Signed-off-by: David S. Miller da...@davemloft.net
 Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org
 ---
 
 Unless I missed something, the commit this patch fixes was not
 backported to 3.10 so I think we don't need this one. I have no
 idea whether it can have a side effect there though, Eric will
 probably know better.

Eric Dumazet mentioned this and said it's harmless.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: commit d0af71a3573 for 3.19.y stable

[David Miller]

From: Josh Boyer jwbo...@fedoraproject.org
Date: Wed, 1 Apr 2015 20:34:22 -0400

 Another possible stable candidate.  We had a report[1] of deadlocks
 with tigon devices on 3.19.y and the commit below fixes it.  It
 cherry-picks cleanly on top of 3.19.3.  I don't see it queued up so I
 thought I would point it out.
 
 commit d0af71a3573f1217b140c60b66f1a9b335fb058b
 Author: Jun'ichi Nomura \(NEC\) j-nom...@ce.jp.nec.com
 Date:   Thu Feb 12 01:26:24 2015 +
 
 tg3: Hold tp-lock before calling tg3_halt() from tg3_init_one()

Queued up, thanks Josh.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

[David Miller]

From: Eric Dumazet eric.duma...@gmail.com
Date: Wed, 15 Apr 2015 11:22:44 -0700

 On Wed, 2015-04-15 at 19:00 +0100, Ben Hutchings wrote:
 Commit 355a901e6cf1 (tcp: make connect() mem charging friendly)
 changed tcp_send_syn_data() to perform an open-coded copy of the 'syn'
 skb rather than using skb_copy_expand().
 
 The open-coded copy does not cover the skb_shared_info::gso_segs
 field, so in the new skb it is left set to 0.  When this commit was
 backported into stable branches between 3.10.y and 3.16.7-ckty
 inclusive, it triggered the BUG() in tcp_transmit_skb().
 
 Since Linux 3.18 the GSO segment count is kept in the
 tcp_skb_cb::tcp_gso_segs field and tcp_send_syn_data() does copy the
 tcp_skb_cb structure to the new skb, so mainline and newer stable
 branches are not affected.
 
 Set skb_shared_info::gso_segs to the correct value of 1.
 
 Signed-off-by: Ben Hutchings b...@decadent.org.uk
 ...
 Looks goot to me, thanks Ben !
 
 Acked-by: Eric Dumazet eduma...@google.com

Ben, thanks for taking care of this.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3.4 140/176] lib/checksum.c: fix carry in csum_tcpudp_nofold

[David Miller]

From: Karl Beldan karl.bel...@gmail.com
Date: Thu, 9 Apr 2015 19:44:08 +0200

 On Thu, Apr 09, 2015 at 04:46:28PM +0800, l...@kernel.org wrote:
 From: karl beldan karl.bel...@gmail.com
 
 3.4.107-rc1 review patch.  If anyone has any objections, please let me know.
 
 --
 
 
 commit 150ae0e94634714b23919f0c333fee28a5b199d5 upstream.
 
 
 Hi Zefan,
 
 The above patch introduced a build error for some archs, please consider
 applying 9ce357795ef208faa0d59894d9d119a7434e37f3 
 lib/checksum.c: fix build for generic csum_tcpudp_nofold as well.

+1
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] PCI: Set pref for mem64 resource of pcie device

[David Miller]

From: Bjorn Helgaas bhelg...@google.com
Date: Wed, 8 Apr 2015 10:47:59 -0500

 Dave, I know you weren't happy with this proposal the first time around,
 but I'm not sure why.  If you have a better idea, let me know.

At this point getting things working again is more important I guess,
so I'm fine with this for now.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] PCI: Set pref for mem64 resource of pcie device

[David Miller]

From: Bjorn Helgaas bhelg...@google.com
Date: Mon, 6 Apr 2015 17:06:38 -0500

 But this is a general change that affects all platforms, and it's late in
 the cycle for something as invasive as this.  I'd rather include your patch
 in the v4.1 merge window, and revert d63e2e1f3df9 (sparc/PCI: Clip bridge
 windows to fit in upstream windows) for v4.0.

I would kindly ask that we not proceed this way and use the change
which implements the fix properly.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 3.10-stable commits missing in 3.12-stable

[David Miller]

From: Jiri Slaby jsl...@suse.cz
Date: Fri, 03 Apr 2015 12:22:02 +0200

 I am crawling through commits which are in 3.10-stable but are not in
 3.12-stable. Could you either ACK them so that I can pick them or
 include them in the next stable NETWORKING patches, please?

Sorry, I am not going through arbitrary non-trivial sets of commits.

I'm willing to look at individual -stable backport candidates
on a case by case basis with a well worded and well thought
out justification for each candidate from the person interested
in seeing the -stable submission because it effects something
they care about.

But wholesale collections like this, I'm not going to invest the time
into.  It's not reasonable at all.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] PCI: Introduce pci_bus_addr_t

[David Miller]

From: Bjorn Helgaas bhelg...@google.com
Date: Fri, 3 Apr 2015 13:59:39 -0500

 On Tue, Mar 31, 2015 at 07:57:47PM -0700, Yinghai Lu wrote:
 David Ahern found commit d63e2e1f3df9 (sparc/PCI: Clip bridge windows
 to fit in upstream windows) broke booting on sparc/T5-8.
 
 In the boot log, there is
   pci :06:00.0: reg 0x184: can't handle BAR above 4GB (bus address
   0x110204000)
 but that only could happen when dma_addr_t is 32-bit.
 
 According to David Miller, all DMA occurs behind an IOMMU and these
 IOMMUs only support 32-bit addressing, therefore dma_addr_t is
 32-bit on sparc64.
 
 Let's introduce pci_bus_addr_t instead of using dma_addr_t,
 and pci_bus_addr_t will be 64-bit on 64-bit platform or X86_PAE.
 
 I propose the following doc updates (I can just fold them into this patch
 if you approve):

No objection.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHES] Networking

[David Miller]

From: Jiri Slaby jsl...@suse.cz
Date: Thu, 26 Mar 2015 19:10:32 +0100

 On 03/24/2015, 07:09 AM, David Miller wrote:
 Please queue up the following networking fixes for 3.12, 3.14,
 3.18, and 3.19 -stable, respectively.\
 
 Just heads-up:
 
 Backport of net: sysctl_net_core: check SNDBUF and RCVBUF for min
  length [ Upstream commit b1cb59cf2efe7971d3d72a7b963d09a512d994c9 ]
 causes a new build warning:
 
 net/core/sysctl_net_core.c:26:12: warning: ‘one’ defined but not used
 [-Wunused-variable]
  static int one = 1;
 
 It happens in all trees. They do not have the only user
 tstamp_allow_data yet.
 
 In 3.12, I am going to remove 'one' in that patch too, if there are no
 objections.

I know, I just didn't want to modify the upstream commit just for this
harmless warning.

Re: commit 957f094f221f for 3.19.y stable

[David Miller]

From: Josh Boyer jwbo...@fedoraproject.org
Date: Wed, 25 Mar 2015 13:21:33 -0400

 We had a report[1] that 3.19 broke the Juniper VPN.  Commit
 957f094f221f (tun: return proper error code from tun_do_read) was
 identified as the fix and tested successfully on top of 3.19.2.  I
 noticed it wasn't included in your latest set of patches for the
 stable trees.  I don't believe it's something you have queued in your
 stable mbox on patchwork either.  Is this something that should be
 queued up for stable?
 
 josh
 
 [1] http://bugzilla.redhat.com/1204512

Ok queued up for my next batch of -stable submissions, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHES] Sparc

[David Miller]

Please queue up the following sparc bug fixes for 3.12, 3.14, 3.18,
and 3.19 -stable, respectively.

Thanks!


sparc_312.mbox
Description: Binary data


sparc_314.mbox
Description: Binary data


sparc_318.mbox
Description: Binary data


sparc_319.mbox
Description: Binary data

Re: [PATCH v2] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5}

[David Miller]

From: Markos Chandras markos.chand...@imgtec.com
Date: Thu, 19 Mar 2015 10:28:14 +

 On a MIPS Malta board, tons of fifo underflow errors have been observed
 when using u-boot as bootloader instead of YAMON. The reason for that
 is that YAMON used to set the pcnet device to SRAM mode but u-boot does
 not. As a result, the default Tx threshold (64 bytes) is now too small to
 keep the fifo relatively used and it can result to Tx fifo underflow errors.
 As a result of which, it's best to setup the SRAM on supported controllers
 so we can always use the NOUFLO bit.
 
 Cc: net...@vger.kernel.org
 Cc: stable@vger.kernel.org
 Cc: linux-ker...@vger.kernel.org
 Cc: Don Fry pcne...@frontier.com
 Signed-off-by: Markos Chandras markos.chand...@imgtec.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: iptables problem upgrading kernel from 3.18.8 to 3.19.1

[David Miller]

From: Florian Westphal f...@strlen.de
Date: Sun, 8 Mar 2015 18:55:53 +0100

 David R da...@unsolicited.net wrote:
 
 [ CC Pablo  stable@ ]
 
 I've just had an exception to my uneventful kernel upgrade monotony.
 
 My boot scripts failed when setting up the firewall due to this :-
 
 xt_recent: hitcount (1) is larger than packets to be remembered (1)
 for table 
 
 This is a completely straightforward
 
 iptables -A  -j REJECT -p tcp --reject-with tcp-reset -m recent
 --set --name  --rsource
 
 Looking at the history for xt_recent.c it looks like this was introduced
 in abc86d0f99242b7f142b7cb8f90e30081dd3c256 but maybe corrected in
 cef9ed86ed62eeffcd017882278bbece32001f86 ?
 
 Right.  I would recommend to revert abc86d0f99242b7f142b7cb8f90e30081dd3c256
 in 3.19.y series rather than applying cef9ed86ed62, though.

Greg, please queue up a revert of abc86d0f99242b7f142b7cb8f90e30081dd3c256 for
3.19.x -stable, if you haven't done so already.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] bnx2x: Force fundamental reset for EEH recovery

[David Miller]

From: Brian King brk...@linux.vnet.ibm.com
Date: Wed, 04 Mar 2015 08:09:44 -0600

 EEH recovery for bnx2x based adapters is not reliable on all Power
 systems using the default hot reset, which can result in an
 unrecoverable EEH error. Forcing the use of fundamental reset
 during EEH recovery fixes this.
 
 Cc: stablestable@vger.kernel.org
 Signed-off-by: Brian King brk...@linux.vnet.ibm.com

Applied, thanks Brian.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] net: fec: fix rcv is not last issue when do suspend/resume test

[David Miller]

From: Peter Chen peter.c...@freescale.com
Date: Wed, 4 Mar 2015 07:52:11 +0800

 From: Fugang Duan b38...@freescale.com
 
 When do suspend/resume stress test, some log shows rcv is not +last.
 The issue is that enet suspend will disable phy clock, phy link down,
 after resume back, enet MAC redo initial and ready to tx/rx packet,
 but phy still is not ready which is doing auto-negotiation. When phy
 link is not up, don't schdule napi soft irq.
 
...
 Tested-by: Peter Chen peter.c...@freescale.com
 Signed-off-by: Peter Chen peter.c...@freescale.com
 Signed-off-by: Fugang Duan b38...@freescale.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][3.13.y-ckt][PATCH 0/1] Backport of mainline commit 4a46b24e for upstream 3.13.y-ckt.

[David Miller]

Please line wrap your email to ~80 columns, it was totally unreadable
in my plain text email client.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] lib/checksum.c: fix carry in csum_tcpudp_nofold

[David Miller]

From: Karl Beldan karl.bel...@gmail.com
Date: Wed, 28 Jan 2015 10:58:11 +0100

 The carry from the 64-32bits folding was dropped, e.g with:
 saddr=0x daddr=0xFFFF len=0x proto=0 sum=1,
 csum_tcpudp_nofold returned 0 instead of 1.
 
 Signed-off-by: Karl Beldan karl.bel...@rivierawaves.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH v2 1/1] drivers: net: cpsw: discard dual emac default vlan configuration

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 22 Jan 2015 15:19:22 +0530

 In Dual EMAC, the default VLANs are used to segregate Rx packets between
 the ports, so adding the same default VLAN to the switch will affect the
 normal packet transfers. So returning error on addition of dual EMAC
 default VLANs.
 
 Even if EMAC 0 default port VLAN is added to EMAC 1, it will lead to
 break dual EMAC port separations.
 
 Fixes: d9ba8f9e6298 (driver: net: ethernet: cpsw: dual emac interface 
 implementation)
 Cc: stable@vger.kernel.org # v3.9+
 Reported-by: Felipe Balbi ba...@ti.com
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: net: prevent of emerging cross-namespace symlinks patches for 3.14?

[David Miller]

From: Miquel van Smoorenburg mik...@xs4all.net
Date: Mon, 19 Jan 2015 00:17:06 +0100

 On 15/01/15 19:39, Alexander Y. Fomichev wrote:
 On Thu, Jan 15, 2015 at 12:45 AM, Miquel van Smoorenburg
 mik...@xs4all.net wrote:
 [first sent to lkml, now to netdev and the original patch author]

 When running 'lxc' on the latest -stable kernel, 3.14.28, I'm seeing
 these
 errors:

 Jan 14 17:47:16 lxc2 kernel: [ 10.704892] sysfs: cannot create
 duplicate
 filename '/devices/virtual/net/eth0.104/upper_eth0'
 I did not see these errors in 3.12. This was fixed in 3.17

 Hi,

 no objections of course,
 actually it was written and tested with 3.14 in mind.
 
 David, could you have a quick look and ack this if you agree this
 should go in 3.14-stable ?

Yes, this is fine, thanks for asking.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net] ipv6: stop sending PTB packets for MTU 1280

[David Miller]

From: Hagen Paul Pfeifer ha...@jauu.net
Date: Mon, 19 Jan 2015 15:00:21 +0100

 On 19 January 2015 at 14:55, Hannes Frederic Sowa
 han...@stressinduktion.org wrote:
 Acked-by: Hannes Frederic Sowa han...@stressinduktion.org

 I think this is the correct way forward on how to deal with atomic
 fragments.

 Hagen, do you submit patches to remove dst_allfrag/RTAX_FEATURE_ALLFRAG,
 IPCORK_ALLFRAG, etc. for net-next, too?
 
 Yes, patch sits already in the pipe. I wanted to wait for davem's pull.

It's one thing to change policy about how we might or might not
automatically set this bit in the kernel, but at a minimum you cannot
just remove RTAX_FEATURE_ALLFRAG, it's in a userspace header and
you'll break application builds.

Second of all, there is absolutely no reason to prevent the user from
setting this bit.  If someone wants to set RTAX_FEATURE_ALLFRAG on a
route on their own system, that is their business.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net] ipv6: stop sending PTB packets for MTU 1280

[David Miller]

From: Hagen Paul Pfeifer ha...@jauu.net
Date: Thu, 15 Jan 2015 22:34:25 +0100

 Reduce the attack vector and stop generating IPv6 Fragment Header for
 paths with an MTU smaller than the minimum required IPv6 MTU
 size (1280 byte) - called atomic fragments.
 
 See IETF I-D Deprecating the Generation of IPv6 Atomic Fragments [1]
 for more information and how this feature can be misused.
 
 [1] 
 https://tools.ietf.org/html/draft-ietf-6man-deprecate-atomfrag-generation-00
 
 Cc: stable@vger.kernel.org
 Signed-off-by: Fernando Gont fg...@si6networks.com
 Signed-off-by: Hagen Paul Pfeifer ha...@jauu.net

Applied, thanks.

But any follow-ups to get rid of RTAX_FEATURE_ALLFRAG altogether are
not to be seriously considered in my opinion.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net] i40e: adds FCoE configure option

[David Miller]

From: Jeff Kirsher jeffrey.t.kirs...@intel.com
Date: Wed, 14 Jan 2015 05:14:07 -0800

 From: Vasu Dev vasu@intel.com
 
 Adds FCoE config option I40E_FCOE, so that FCoE can be enabled
 as needed but otherwise have it disabled by default.
 
 This also eliminate multiple FCoE config checks, instead now just
 one config check for CONFIG_I40E_FCOE.
 
 The I40E FCoE was added with 3.17 kernel and therefore this patch
 shall be applied to stable 3.17 kernel also.
 
 CC: stable@vger.kernel.org
 Signed-off-by: Vasu Dev vasu@intel.com
 Tested-by: Jim Young jamesx.m.yo...@intel.com
 Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 1/1] drivers: net: cpsw: fix multicast flush in dual emac mode

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 13 Jan 2015 17:35:49 +0530

 Since ALE table is a common resource for both the interfaces in Dual EMAC
 mode and while bringing up the second interface in cpsw_ndo_set_rx_mode()
 all the multicast entries added by the first interface is flushed out and
 only second interface multicast addresses are added. Fixing this by
 flushing multicast addresses based on dual EMAC port vlans which will not
 affect the other emac port multicast addresses.
 
 Fixes: d9ba8f9 (driver: net: ethernet: cpsw: dual emac interface 
 implementation)
 Cc: stable@vger.kernel.org # v3.9+
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Tue, 6 Jan 2015 11:43:32 -0600

 CPSW completely hangs if we add, and later remove,
 VLAN ID #1. What happens is that after removing
 VLAN ID #1, no packets will be received by CPSW
 rendering network unusable.
 
 In order to fix the issue, we're returning -EINVAL
 if anybody tries to add VLAN ID #1. While at that,
 also filter out any ID  4095 because we only have
 12 bits for VLAN IDs.
 
 Fixes: 3b72c2f (drivers: net:ethernet: cpsw: add support for VLAN)
 Cc: stable@vger.kernel.org # v3.9+
 Cc: Mugunthan V N mugunthan...@ti.com
 Tested-by: Schuyler Patton spat...@ti.com
 Signed-off-by: Felipe Balbi ba...@ti.com

You can't just unilaterally make one VLAN ID unusable.

A better way to handle this situation must be found,
and if that means turning off hw VLAN support completely,
that's a much better alternative to this.

I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Tue, 6 Jan 2015 14:31:19 -0600

 What you're saying here is that you prefer to drop a feature that works
 for all other 1023 IDs because 1 ID is quirky. Sounds like overkill
 to me.

The other option is to software fallback only for VLAN 1.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: fix hangs with interrupts

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 2 Jan 2015 16:15:59 -0600

 The CPSW IP implements pulse-signaled interrupts. Due to
 that we must write a correct, pre-defined value to the
 CPDMA_MACEOIVECTOR register so the controller generates
 a pulse on the correct IRQ line to signal the End Of
 Interrupt.
 
 The way the driver is written today, all four IRQ lines
 are requested using the same IRQ handler and, because of
 that, we could fall into situations where a TX IRQ fires
 but we tell the controller that we ended an RX IRQ (or
 vice-versa). This situation triggers an IRQ storm on the
 reserved IRQ 127 of INTC which will in turn call ack_bad_irq()
 which will, then, print a ton of:
 ...
 Reported-by: Yegor Yefremov yegorsli...@googlemail.com
 Fixes: 510a1e7 (drivers: net: davinci_cpdma: acknowledge interrupt properly)
 Cc: stable@vger.kernel.org # v3.9+
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] stmmac: Don't init ptp again when resume from suspend/hibernation

[David Miller]

Two problems:

1) This post did not reach netdev and therefore did not make it into
   patchwork for tracking.  You need to correct this.

2) Do not CC: stable on networking changes, instead ask me explicitly
   to queue them up for -stable submission and to which trees.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHES] Networking

[David Miller]

Please queue up the following networking bug fixes for 3.12.x, 3.14.x,
3.17.x, and 3.18.x -stable, respectively.

Thanks a lot!


net_312.mbox
Description: Binary data


net_314.mbox
Description: Binary data


net_317.mbox
Description: Binary data


net_318.mbox
Description: Binary data

[PATCH] Sparc

[David Miller]

Please queue up this sparc bug fix for 3.12, 3.14, and 3.17.

It applies cleanly to all 3 releases.

Thanks.
From 5a2b59d3993e8ca4f7788a48a23e5cb303f26954 Mon Sep 17 00:00:00 2001
From: David S. Miller da...@davemloft.net
Date: Sun, 16 Nov 2014 13:19:32 -0800
Subject: [PATCH] sparc64: Fix constraints on swab helpers.

[ Upstream commit 5a2b59d3993e8ca4f7788a48a23e5cb303f26954 ]

We are reading the memory location, so we have to have a memory
constraint in there purely for the sake of showing the data flow
to the compiler.

Reported-by: Martin K. Petersen martin.peter...@oracle.com
Signed-off-by: David S. Miller da...@davemloft.net
---
 arch/sparc/include/uapi/asm/swab.h | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/sparc/include/uapi/asm/swab.h b/arch/sparc/include/uapi/asm/swab.h
index a34ad07..4c7c12d 100644
--- a/arch/sparc/include/uapi/asm/swab.h
+++ b/arch/sparc/include/uapi/asm/swab.h
@@ -9,9 +9,9 @@ static inline __u16 __arch_swab16p(const __u16 *addr)
 {
 	__u16 ret;
 
-	__asm__ __volatile__ (lduha [%1] %2, %0
+	__asm__ __volatile__ (lduha [%2] %3, %0
 			  : =r (ret)
-			  : r (addr), i (ASI_PL));
+			  : m (*addr), r (addr), i (ASI_PL));
 	return ret;
 }
 #define __arch_swab16p __arch_swab16p
@@ -20,9 +20,9 @@ static inline __u32 __arch_swab32p(const __u32 *addr)
 {
 	__u32 ret;
 
-	__asm__ __volatile__ (lduwa [%1] %2, %0
+	__asm__ __volatile__ (lduwa [%2] %3, %0
 			  : =r (ret)
-			  : r (addr), i (ASI_PL));
+			  : m (*addr), r (addr), i (ASI_PL));
 	return ret;
 }
 #define __arch_swab32p __arch_swab32p
@@ -31,9 +31,9 @@ static inline __u64 __arch_swab64p(const __u64 *addr)
 {
 	__u64 ret;
 
-	__asm__ __volatile__ (ldxa [%1] %2, %0
+	__asm__ __volatile__ (ldxa [%2] %3, %0
 			  : =r (ret)
-			  : r (addr), i (ASI_PL));
+			  : m (*addr), r (addr), i (ASI_PL));
 	return ret;
 }
 #define __arch_swab64p __arch_swab64p
-- 
1.7.11.7

[PATCHES] Networking

[David Miller]

Please queue up the following bug fixes for 3.12, 3.14, and 3.17
-stable respectively.

Thanks a lot!


net_312.mbox
Description: Binary data


net_314.mbox
Description: Binary data


net_317.mbox
Description: Binary data

Re: [PATCH] net/ping: handle protocol mismatching scenario

[David Miller]

From: Jane Zhou a17...@motorola.com
Date: Mon, 24 Nov 2014 11:44:08 -0800

 ping_lookup() may return a wrong sock if sk_buff's and sock's protocols
 dont' match. For example, sk_buff's protocol is ETH_P_IPV6, but sock's
 sk_family is AF_INET, in that case, if sk-sk_bound_dev_if is zero, a wrong
 sock will be returned.
 the fix is to continue the searching, if no matching, return NULL.
 
 Cc: David S. Miller da...@davemloft.net
 Cc: Alexey Kuznetsov kuz...@ms2.inr.ac.ru
 Cc: James Morris jmor...@namei.org
 Cc: Hideaki YOSHIFUJI yoshf...@linux-ipv6.org
 Cc: Patrick McHardy ka...@trash.net
 Cc: net...@vger.kernel.org
 Cc: stable@vger.kernel.org
 Signed-off-by: Jane Zhou a17...@motorola.com
 Signed-off-by: Yiwei Zhao gbj...@motorola.com

Applied, thank you.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net 2/3] ixgbe: fix use after free adapter-state test in ixgbe_remove/ixgbe_probe

[David Miller]

From: Jeff Kirsher jeffrey.t.kirs...@intel.com
Date: Fri, 21 Nov 2014 23:52:53 -0800

 From: Daniel Borkmann dbork...@redhat.com
 
 While working on a different issue, I noticed an annoying use
 after free bug on my machine when unloading the ixgbe driver:
 ...
 The issue is that test_and_set_bit() done on adapter-state is being
 performed *after* the netdevice has been freed via free_netdev().
 
 When netdev is being allocated on initialization time, it allocates
 a private area, here struct ixgbe_adapter, that resides after the
 net_device structure. In ixgbe_probe(), the device init routine,
 we set up the adapter after alloc_etherdev_mq() on the private area
 and add a reference for the pci_dev as well via pci_set_drvdata().
 
 Both in the error path of ixgbe_probe(), but also on module unload
 when ixgbe_remove() is being called, commit 41c62843eb6a (ixgbe:
 Fix rcu warnings induced by LER) accesses adapter after free_netdev().
 The patch stores the result in a bool and thus fixes above oops on my
 side.
 
 Fixes: 41c62843eb6a (ixgbe: Fix rcu warnings induced by LER)
 Cc: stable stable@vger.kernel.org
 Cc: Mark Rustad mark.d.rus...@intel.com
 Signed-off-by: Daniel Borkmann dbork...@redhat.com
 Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net 1/3] ixgbe: Correctly disable VLAN filter in promiscuous mode

[David Miller]

From: Jeff Kirsher jeffrey.t.kirs...@intel.com
Date: Fri, 21 Nov 2014 23:52:52 -0800

 From: Vlad Yasevich vyasev...@gmail.com
 
 IXGBE adapter seems to require that VLAN filtering be enabled if
 VMDQ or SRIOV are enabled.  When those functions are disabled,
 VLAN filtering may be disabled in promiscuous mode.
 
 Prior to commit a9b8943ee129 (ixgbe: remove vlan_filter_disable
 and enable functions)
 
 The logic was correct.  However, after the commit the logic
 got reversed and VLAN filtered in now turned on when VMDQ/SRIOV
 is disabled.
 
 This patch changes the condition to enable hw vlan filtered
 when VMDQ or SRIOV is enabled.
 
 Fixes: a9b8943ee129 (ixgbe: remove vlan_filter_disable and enable functions)
 Cc: stable stable@vger.kernel.org
 CC: Jacob Keller jacob.e.kel...@intel.com
 Signed-off-by: Vladislav Yasevich vyase...@redhat.com
 Acked-by: Emil Tantilov emil.s.tanti...@intel.com
 Tested-by: Phil Schmitt phillip.j.schm...@intel.com
 Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHES] Sparc

[David Miller]

From: Jiri Slaby jsl...@suse.cz
Date: Wed, 19 Nov 2014 12:54:59 +0100

 On 11/18/2014, 08:05 AM, David Miller wrote:
 
 Please add the following sparc bug fixes to 3.12, 3.14, and
 3.17 -stable, respectively.
 
 Thanks, now applied to 3.12.
 
 Note that PATCH 9/9 is missing in all of these. Is it intentional?

Yes, I edited the last one out at the last moment from the mbox file
by hand.

Sorry for the confusion.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: after stable is before stable

[David Miller]

From: Jiri Slaby jsl...@suse.cz
Date: Wed, 19 Nov 2014 13:17:29 +0100

 all below look good to me. They are for the net subsystem, however. And
 since David maintains 3.12 stable net patches, I am not going to take
 them directly (or at least not until his prior ACK).

Maintainers of changes need to ask me explicitly to queue up
networking -stable changes, on the netdev list CC:'ing me for
full transparency.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHES] Networking

[David Miller]

Please queue up the following networking fixes for 3.12, 3.14,
and 3.17 -stable, respectively.

Thanks.


net_312.mbox
Description: Binary data


net_314.mbox
Description: Binary data


net_317.mbox
Description: Binary data

[PATCHES] Sparc

[David Miller]

Please add the following sparc bug fixes to 3.12, 3.14, and
3.17 -stable, respectively.

Thanks.


sparc_312.mbox
Description: Binary data


sparc_314.mbox
Description: Binary data


sparc_317.mbox
Description: Binary data

Re: [PATCH v2] stmmac: pci: set default of the filter bins

[David Miller]

From: Andy Shevchenko andriy.shevche...@linux.intel.com
Date: Fri, 31 Oct 2014 18:28:03 +0200

 The commit 3b57de958e2a brought the support for a different amount of the
 filter bins, but didn't update the PCI driver accordingly. This patch appends
 the default values when the device is enumerated via PCI bus.
 
 Fixes: 3b57de958e2a (net: stmmac: Support devicetree configs for mcast and 
 ucast filter entries)
 Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
 Cc: stable@vger.kernel.org

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH stable v3.2 v3.4] ipv4: disable bh while doing route gc

[David Miller]

From: Ben Hutchings b...@decadent.org.uk
Date: Mon, 20 Oct 2014 13:23:28 +0100

 On Mon, 2014-10-20 at 00:23 -0400, David Miller wrote:
 From: Ben Hutchings b...@decadent.org.uk
 Date: Mon, 20 Oct 2014 04:09:41 +0100
 
  I've appplied this and the previous two patches mentioned ('ipv4: move
  route garbage collector to work queue' and 'ipv4: avoid parallel route
  cache gc executions').  But I didn't get the other two from you.  The
  last batch of networking fixes I received and applied was dated
  2014-08-07, and the next one I've seen is dated 2014-10-11 and has
  nothing for 3.2 or 3.4.  Did I miss one between these?
 
 I'm at the point where I'm personally not going to go back more than
 four releases, anything more than that is rediculous.
 
 And this time that was 3.17, 3.16, 3.14, and 3.10
 
 OK.  I appreciate all the work you've done to backport to 3.2, but would
 also have appreciated an explicit note to say you were dropping the
 earlier versions.

My apologies, but as time goes on and more -stable releases go active
I will certainly be tail dropping to keep it within 4 releases.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH stable v3.2 v3.4] ipv4: disable bh while doing route gc

[David Miller]

From: Ben Hutchings b...@decadent.org.uk
Date: Mon, 20 Oct 2014 04:09:41 +0100

 I've appplied this and the previous two patches mentioned ('ipv4: move
 route garbage collector to work queue' and 'ipv4: avoid parallel route
 cache gc executions').  But I didn't get the other two from you.  The
 last batch of networking fixes I received and applied was dated
 2014-08-07, and the next one I've seen is dated 2014-10-11 and has
 nothing for 3.2 or 3.4.  Did I miss one between these?

I'm at the point where I'm personally not going to go back more than
four releases, anything more than that is rediculous.

And this time that was 3.17, 3.16, 3.14, and 3.10
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH stable v3.2 v3.4] ipv4: disable bh while doing route gc

[David Miller]

From: Marcelo Ricardo Leitner mleit...@redhat.com
Date: Mon, 13 Oct 2014 14:03:30 -0300

 Further tests revealed that after moving the garbage collector to a work
 queue and protecting it with a spinlock may leave the system prone to
 soft lockups if bottom half gets very busy.
 
 It was reproced with a set of firewall rules that REJECTed packets. If
 the NIC bottom half handler ends up running on the same CPU that is
 running the garbage collector on a very large cache, the garbage
 collector will not be able to do its job due to the amount of work
 needed for handling the REJECTs and also won't reschedule.
 
 The fix is to disable bottom half during the garbage collecting, as it
 already was in the first place (most calls to it came from softirqs).
 
 Signed-off-by: Marcelo Ricardo Leitner mleit...@redhat.com
 Acked-by: Hannes Frederic Sowa han...@stressinduktion.org
 Acked-by: David S. Miller da...@davemloft.net
 Cc: stable@vger.kernel.org

-stable folks, please integrate this directly, thanks!
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] Drivers: net-next: hyperv: Fix a bug in netvsc_start_xmit()

[David Miller]

From: K. Y. Srinivasan k...@microsoft.com
Date: Sun, 28 Sep 2014 19:49:51 -0700

 After the packet is successfully sent, we should not touch the skb as it may
 have been freed. This patch is based on the work done by
 Long Li lon...@microsoft.com. 
 
 Signed-off-by: K. Y. Srinivasan k...@microsoft.com
 Tested-by: Long Li lon...@microsoft.com
 Cc: stable@vger.kernel.org

You hyperv guys really have to get your act together.  This is not
properly submitted.

Most importantly, this is a serious reference to free memory bug.
Therefore it should be targetted at 'net' not 'net-next'.

Secondly, you do not CC: stable for networking changes, you instead
ask me to queue it up for my next batch of -stable networking changes.

Thirdly, your Subject line is malformed.  You should not use
Drivers:  as a prefix.  Just the driver name is sufficient.
You should also not mentionen the target GIT tree outside of the
[PATCH ...] bracketed area.

Also, please be cognizant of how much of my time you unnecessarily
consume when you make a malformed submission like this.  That is
time I could spend reviewing other patches.

Thank you.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6 -stable] ipvs: avoid netns exit crash on ip_vs_conn_drop_conntrack

[David Miller]

From: Jiri Slaby jsl...@suse.cz
Date: Fri, 26 Sep 2014 14:16:16 +0200

 On 09/26/2014, 02:15 PM, Pablo Neira Ayuso wrote:
 On Fri, Sep 26, 2014 at 02:10:49PM +0200, Jiri Slaby wrote:
 On 09/26/2014, 01:05 PM, Pablo Neira Ayuso wrote:
 Hm, according to:

 Documentation/networking/netdev-FAQ.txt

 I should send now this to David via netdev.

 So please, withdraw. I'm going to stick to this procedure.

 The document does not work for 3.12, as David does not collect and send
 patches for that release. So please continue sending such patches me-wards.
 
 OK. So David only takes patches for current -stable, not for
 -longterm, right?
 
 Not really. For *some* of the stable and longterm stable trees. I do not
 which ones exactly now, better to ask him.

For a reliable trusted sub-maintainers of networking (of which I would
include Pablo for netfilter, and John Linville for wireless) they can
submit their bug fixes directly to any -stable tree.

In fact, I highly encourage this, as this helps me enormously.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3.12 000/104] 3.12.27-stable review

[David Miller]

From: Guenter Roeck li...@roeck-us.net
Date: Sat, 23 Aug 2014 08:14:54 -0700

 On 08/21/2014 01:05 AM, Jiri Slaby wrote:
 The last three are just cosmetical in 3.12. And I do not immediately
 see
 in the rest, how they could improve the state. So I am going to remove
 the add-basic-validations patch from 3.12.

 
 Build and tests now look good.

I am hugely disappointed in this.

This is why I really do all the backports for each -stable release
myself and I therefore really wish there was more thought put into
when these changes are placed into other trees.

Almost all of those sparc64 memory management fixes should not go into
anything before v3.13, because all of these fixes are in the context
of the page tables encoding PMDs using the PTE layout.

If you're just forcing changes you see go into other -stable
submissions into your tree until they compile, and just hoping that a
tester will catch any problems, you are absolutely doing it wrong and
taking a large amount of value out of the -stable releases.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [linux-stable] i40e: Don't stop driver probe when querying DCB config fails

[David Miller]

From: Jeff Kirsher jeffrey.t.kirs...@intel.com
Date: Wed, 13 Aug 2014 04:30:55 -0700

 From: Neerav Parikh neerav.par...@intel.com
 
 Commit id: 014269ff376f552363ecdab78d3d947fbe2237d9 in Linus's tree
 should be queued up for stable 3.14  3.15 since the i40e driver will
 not load when DCB is enabled, unless this patch is applied.
 
 In case of any AQ command to query port's DCB configuration fails
 during driver's probe time; the probe fails and returns an error.
 
 This patch prevents this issue by continuing the driver probe even
 when an error is returned.
 
 Also, added an error message to dump the AQ error status to show what
 error caused the failure to get the DCB configuration from firmware.
 
 Change-ID: Ifd5663512588bca684069bb7d4fb586dd72221af
 Signed-off-by: Neerav Parikh neerav.par...@intel.com
 Signed-off-by: Catherine Sullivan catherine.sulli...@intel.com
 Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

This is a very confusing submission.

Is this an already applied patch that you want accepted into the -stable
tree?  If so, which tree(s)?
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [linux-stable] i40e: Don't stop driver probe when querying DCB config fails

[David Miller]

From: Jeff Kirsher jeffrey.t.kirs...@intel.com
Date: Wed, 13 Aug 2014 04:30:55 -0700

 From: Neerav Parikh neerav.par...@intel.com
 
 Commit id: 014269ff376f552363ecdab78d3d947fbe2237d9 in Linus's tree
 should be queued up for stable 3.14  3.15 since the i40e driver will
 not load when DCB is enabled, unless this patch is applied.
 
 In case of any AQ command to query port's DCB configuration fails
 during driver's probe time; the probe fails and returns an error.
 
 This patch prevents this issue by continuing the driver probe even
 when an error is returned.
 
 Also, added an error message to dump the AQ error status to show what
 error caused the failure to get the DCB configuration from firmware.
 
 Change-ID: Ifd5663512588bca684069bb7d4fb586dd72221af
 Signed-off-by: Neerav Parikh neerav.par...@intel.com
 Signed-off-by: Catherine Sullivan catherine.sulli...@intel.com
 Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

Queued up for -stable, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

your netlink permission checks backport to v3.4

[David Miller]

I don't think you properly compile tested this code:

diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index c00e307..b79ce1e 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -440,7 +440,7 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg)
case SIOCGIFADDR:
break;
case SIOCSIFADDR:
-   if (!capable(CAP_NET_ADMIN))
+   if (!netlink_capable(skb, CAP_NET_ADMIN))
return -EACCES;
if (sdn-sdn_family != AF_DECnet)
return -EINVAL;

There is no skb variable in this function.

I think we're at the point where this backport makes no sense to submit
to the -stable tree.

Multiple rounds of attempting to backport these changes has been tries
and all such attempts have had problems.  Compile problems, authorship
errors, lack of follow-up bug fixes, etc.

This is why I did not try to backport these changes to v3.4 and
earlier.  The possiblity for introducing more regressions is larger
than the benefit from including these changes.

Please do not ask me to include this backport into my v3.4 -stable
series submissions any longer, thank you.

Sorry.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Revert net: phy: Set the driver when registering an MDIO bus device

[David Miller]

From: Fabio Estevam feste...@gmail.com
Date: Tue,  5 Aug 2014 08:13:42 -0300

 From: Fabio Estevam fabio.este...@freescale.com
 
 Commit a71e3c37960ce5f9 (net: phy: Set the driver when registering an MDIO 
 bus
 device) caused the following regression on the fec driver:
 ...
 The problem with the original commit is explained by Russell King:
 
 It has the effect (as can be seen from the oops) of attaching the MDIO bus
 device (itself is a bus-less device) to the platform driver, which means
 that if the platform driver supports power management, it will be called
 to power manage the MDIO bus device.
 
 Moreover, drivers do not expect to be called for power management
 operations for devices which they haven't probed, and certainly not for
 devices which aren't part of the same bus that the driver is registered
 against.
 
 This reverts commit a71e3c37960ce5f9c6a519bc1215e3ba9fa83e75.
 
 Cc: stable@vger.kernel.org #3.16
 Signed-off-by: Fabio Estevam fabio.este...@freescale.com

Applied, and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: sendmsg: fix NULL pointer dereference

[David Miller]

From: Andrey Ryabinin ryabinin@gmail.com
Date: Sat, 26 Jul 2014 21:26:58 +0400

 Sasha's report:
 ...
 This reports means that we've come to netlink_sendmsg() with msg-msg_name == 
 NULL and msg-msg_namelen  0.
 
 After this report there was no usual Unable to handle kernel NULL pointer 
 dereference
 and this gave me a clue that address 0 is mapped and contains valid socket 
 address structure in it.
 
 This bug was introduced in f3d3342602f8bcbf37d7c46641cb9bca7618eb1c
 (net: rework recvmsg handler msg_name and msg_namelen logic).
 Commit message states that:
   Set msg-msg_name = NULL if user specified a NULL in msg_name but had a
non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't
affect sendto as it would bail out earlier while trying to copy-in the
address.
 But in fact this affects sendto when address 0 is mapped and contains
 socket address structure in it. In such case copy-in address will succeed,
 verify_iovec() function will successfully exit with msg-msg_namelen  0
 and msg-msg_name == NULL.
 
 This patch fixes it by setting msg_namelen to 0 if msg_name == NULL.
 
 Cc: Hannes Frederic Sowa han...@stressinduktion.org
 Cc: Eric Dumazet eduma...@google.com
 Cc: stable@vger.kernel.org
 Reported-by: Sasha Levin sasha.le...@oracle.com
 Signed-off-by: Andrey Ryabinin a.ryabi...@samsung.com

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html