Re: s6-rc: output of ./finish not directed to logger?

2016-08-19 Thread Casper Ti. Vector
It works now.  Thanks :)

On Fri, Aug 19, 2016 at 01:16:10PM +0200, Laurent Bercot wrote:
>   Should be fixed in the latest git.

-- 
My current OpenPGP key:
RSA4096/0x227E8CAAB7AA186C (expires: 2020.10.19)
7077 7781 B859 5166 AE07 0286 227E 8CAA B7AA 186C



Re: s6-rc: output of ./finish not directed to logger?

2016-08-19 Thread Laurent Bercot

On 19/08/2016 11:09, Casper Ti. Vector wrote:

Latest version of s6-rc in the git repo creates a `./finish' wrapper
even when `./finish' does not exist, leading to errors:

$ ls /run/service/some.service
event  finish runrun.user   supervise

Another bug caused by asymmetry in specification :(


 It's not the asymmetry in the spec, it's because I'm an idiot who preaches
about premature optimization and still tries to be smart to save one
system call when it's definitely not a good idea. :P
 Should be fixed in the latest git.



By the way, I think s6's `servicedir.html' should also note that
`./finish' accepts arguments, and points the reader to
`s6-supervise.html'; otherwise that feature gets easily ignored or
forgotten.


 Updated, thanks!

--
 Laurent


Re: s6-rc: output of ./finish not directed to logger?

2016-08-19 Thread Casper Ti. Vector
Latest version of s6-rc in the git repo creates a `./finish' wrapper
even when `./finish' does not exist, leading to errors:
> $ ls /run/service/some.service
> event  finish runrun.user   supervise
Another bug caused by asymmetry in specification :(

By the way, I think s6's `servicedir.html' should also note that
`./finish' accepts arguments, and points the reader to
`s6-supervise.html'; otherwise that feature gets easily ignored or
forgotten.

On Thu, Aug 18, 2016 at 06:20:19PM +0200, Laurent Bercot wrote:
>   Please try with the latest git head of s6-rc and tell me if it works for 
> you.

-- 
My current OpenPGP key:
RSA4096/0x227E8CAAB7AA186C (expires: 2020.10.19)
7077 7781 B859 5166 AE07 0286 227E 8CAA B7AA 186C



Re: s6-rc: output of ./finish not directed to logger?

2016-08-18 Thread Laurent Bercot


 Please try with the latest git head of s6-rc and tell me if it works for you.

--
 Laurent


Re: s6-rc: output of ./finish not directed to logger?

2016-08-18 Thread Casper Ti. Vector
:)

On Thu, Aug 18, 2016 at 05:15:16PM +0200, Laurent Bercot wrote:
>   That's... an oversight, because all the infrastructure to make it work
> is already there. Thanks for the report - I'll add the missing pieces to
> the compiler as soon as possible. :)

-- 
My current OpenPGP key:
RSA4096/0x227E8CAAB7AA186C (expires: 2020.10.19)
7077 7781 B859 5166 AE07 0286 227E 8CAA B7AA 186C



Re: s6-rc: output of ./finish not directed to logger?

2016-08-18 Thread Laurent Bercot

On 18/08/2016 16:58, Casper Ti. Vector wrote:

I found that, with the current behaviour of s6-rc, the output of
`./finish' is not redirected to the logger process:
(...)
Is this a design decision?


 That's... an oversight, because all the infrastructure to make it work
is already there. Thanks for the report - I'll add the missing pieces to
the compiler as soon as possible. :)

--
 Laurent