Re: [pfSense Support] FW: Cosmetic Bug in Trafficshaper?

2005-09-13 Thread Ben Browning
I installed pfSense a few days ago using pfSense-LiveCD-0.84.iso (the
version from 09/11/05).

I've observed this bug also. After examining the source of the file
firewall_shaper_queues_edit.php I came to the following conclusion:

* When using HFSC, the bandwidth input box doesn't appear.
* Because of this, when you press the save button on any HFSC queue,
it clears the bandwidth value of that queue in the config xml file.
* Thus, anytime you press save on a HFSC queue, the bandwidth field
gets blanked.

This is more than just a cosmetic bug. If you ever edit the root
queues, their bandwidth gets set to 0. This bandwidth value is used
when calculating the maximum available bandwidth to give out to the
other queues. So, if I create a queue called qSSHUp under my qWANRoot
(which we'll pretend I have saved since running the wizard, and it now
shows up blank in the bandwidth field) and tell qSSHUp to guarantee a
realtime bandwidth of 32Kb, the traffic shaping rules won't load. It
will complain that there isn't that much bandwidth available to give
out.

To fix this, on line 202 of firewall_shaper_queues_edit.php I changed:

?php if ($schedulertype == cbq): ?

to

?php if ($schedulertype == cbq or $schedulertype == hfsc): ?


This has solved my disappearing bandwidth-field issue, and now allows
me to modify rules and have them load successfully.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [pfSense Support] FW: Cosmetic Bug in Trafficshaper?

2005-09-13 Thread Bill Marquette
ack, I'll poke at this shortly. I had some interesting
experiences with the bandwidth fields when writing the wizard.
They shouldn't be needed - realtime/upperlimit/linkshare are supposed
to be better. What I found was that bandwidth is needed so that
pfctl doesn't bitch about bandwidth being over allocated (also, it
seemed like it stomped on the queue even though I'd set upperlimit to a
reasonable setting).

--BillOn 9/13/05, Ben Browning [EMAIL PROTECTED] wrote:
I installed pfSense a few days ago using pfSense-LiveCD-0.84.iso (theversion from 09/11/05).I've observed this bug also. After examining the source of the filefirewall_shaper_queues_edit.php I came to the following conclusion:
* When using HFSC, the bandwidth input box doesn't appear.* Because of this, when you press the save button on any HFSC queue,it clears the bandwidth value of that queue in the config xml file.* Thus, anytime you press save on a HFSC queue, the bandwidth field
gets blanked.This is more than just a cosmetic bug. If you ever edit the rootqueues, their bandwidth gets set to 0. This bandwidth value is usedwhen calculating the maximum available bandwidth to give out to the
other queues. So, if I create a queue called qSSHUp under my qWANRoot(which we'll pretend I have saved since running the wizard, and it nowshows up blank in the bandwidth field) and tell qSSHUp to guarantee a
realtime bandwidth of 32Kb, the traffic shaping rules won't load. Itwill complain that there isn't that much bandwidth available to giveout.To fix this, on line 202 of firewall_shaper_queues_edit.php I changed:
?php if ($schedulertype == cbq): ?to?php if ($schedulertype == cbq or $schedulertype == hfsc): ?This has solved my disappearing bandwidth-field issue, and now allows
me to modify rules and have them load successfully.-To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [pfSense Support] FW: Cosmetic Bug in Trafficshaper?

2005-09-13 Thread Scott Ullrich
Woops!   Can you please open a ticket for this at
http://cvstrac.pfsense.com/tktnew and include the notes that you did
in the email so we don't forget.  Thanks!

On 9/13/05, Ben Browning [EMAIL PROTECTED] wrote:
 I installed pfSense a few days ago using pfSense-LiveCD-0.84.iso (the
 version from 09/11/05).
 
 I've observed this bug also. After examining the source of the file
 firewall_shaper_queues_edit.php I came to the following conclusion:
 
 * When using HFSC, the bandwidth input box doesn't appear.
 * Because of this, when you press the save button on any HFSC queue,
 it clears the bandwidth value of that queue in the config xml file.
 * Thus, anytime you press save on a HFSC queue, the bandwidth field
 gets blanked.
 
 This is more than just a cosmetic bug. If you ever edit the root
 queues, their bandwidth gets set to 0. This bandwidth value is used
 when calculating the maximum available bandwidth to give out to the
 other queues. So, if I create a queue called qSSHUp under my qWANRoot
 (which we'll pretend I have saved since running the wizard, and it now
 shows up blank in the bandwidth field) and tell qSSHUp to guarantee a
 realtime bandwidth of 32Kb, the traffic shaping rules won't load. It
 will complain that there isn't that much bandwidth available to give
 out.
 
 To fix this, on line 202 of firewall_shaper_queues_edit.php I changed:
 
 ?php if ($schedulertype == cbq): ?
 
 to
 
 ?php if ($schedulertype == cbq or $schedulertype == hfsc): ?
 
 
 This has solved my disappearing bandwidth-field issue, and now allows
 me to modify rules and have them load successfully.
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [pfSense Support] FW: Cosmetic Bug in Trafficshaper?

2005-09-12 Thread Scott Ullrich
I just edited a record and the value was saved correctly!?

Also, please use plain-text emails, not HTML emails on lists.

Scott


On 9/11/05, Robo.K. [EMAIL PROTECTED] wrote:

 Any ideas?
  
  
 From: Robo.K. [mailto:[EMAIL PROTECTED]  
 Sent: Sunday, September 11, 2005 1:14 AM
 To:  'support@pfsense.com'
 Subject: Cosmetic Bug in  Trafficshaper?
 
 
  
  
 After complete the  traffic shaper wizard I go into any item of Queue and 
 change anything , only  save queue, then in /firewall_shaper_queues.php  in 
 culmn Bandwidth   dismiss value of amount persents or kilobits. This box 
 remains  empty. 


  10   REDECN5No   1 % 
   qGamesDown 
  
  11   REDECN4No   1%  
   qOthersUpH 
  
  12   REDECN4No   1%  
   qOthersDownH 
  
  13   REDECN2No   
 qOthersUpL 
  
  14   REDECN2No   
 qOthersDownL  
  
  15   REDECN5No   
 pokusssnaaa
  
 
 --
 No virus found in this outgoing message.
 Checked by AVG  Anti-Virus.
 Version: 7.0.344 / Virus Database: 267.10.20/95 - Release Date:  9.9.2005
  
 
  
   
 
 
 --
  No virus found in this outgoing message.
  Checked by AVG Anti-Virus.
  Version: 7.0.344 / Virus Database: 267.10.21/96 - Release Date: 10.9.2005
   
 
   
 
  
 
 --
  * www.inMail.sk - Vasa emailova adresa na cely zivot ZDARMA
  * www.inshop.sk - virtualna obchodna galeria s viac ako 230 obchodmi!
 
  * www.SlovakNET.sk - profesionalny webhosting, domena .SK ZADARMO


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[pfSense Support] FW: Cosmetic Bug in Trafficshaper?

2005-09-11 Thread Robo.K.



Any ideas?


From: Robo.K. [mailto:[EMAIL PROTECTED]
Sent: Sunday, September 11, 2005 1:14 AMTo:
'support@pfsense.com'Subject: Cosmetic Bug in
Trafficshaper?

After complete the
traffic shaper wizard I go into any item of Queue and change anything , only
save queue, then in /firewall_shaper_queues.php in culmn Bandwidth
dismiss value of amount persents or kilobits. This box remains
empty.




  
  
10

RED
  ECN  
5

No

1 %
   
qGamesDown  

  


  
  
  
11

RED
  ECN  
4

No

1
  %  
qOthersUpH  

  


  
  
  
12

RED
  ECN  
4

No

1
  %  
qOthersDownH  

  


  
  
  
13

RED
  ECN  
2

No



qOthersUpL  

  


  
  
  
14

RED
  ECN  
2

No



qOthersDownL  

  



  
  
  
15

RED
  ECN  
5

No



pokusssnaaa 

--No virus found in this outgoing message.Checked by AVG
Anti-Virus.Version: 7.0.344 / Virus Database: 267.10.20/95 - Release Date:
9.9.2005



--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.21/96 - Release Date: 10.9.2005
 


--
* www.inMail.sk - Vasa emailova adresa na cely zivot ZDARMA
* www.inshop.sk - virtualna obchodna galeria s viac ako 230 obchodmi!
* www.SlovakNET.sk - profesionalny webhosting, domena .SK ZADARMO