Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Fri, Jul 11, 2014 at 12:01:19AM +, Jóhann B. Guðmundsson wrote: I had already submitted new patch with deployment [PATCH] Add DEPLOYMENT to hostnamectl which Zbyszek had suggested and you agreed to and FYI this has nothing to with trying to standardize anything it's about bringing consistency in the system for machines in certain deployment stages so administrators/developers will immediately identify in which stage the environment they are working in, is at. Hi Jóhann, I pushed your patch, but without the check against a static list. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, Jul 8, 2014 at 10:23 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) These days people usually use only 3 tier level ( used to be four back in the day ) as in Development and Integration is done the same tier while Staging and Production are separated tiers altogether. We could extend that and include the fourth tier missing tier ( as in Integration ) as optional for those that prefer 4 tier layer over 3 tier but people moved away form that model to the 3 tier one. Development tier Is the working environment for individual developers or small teams. More often than not this work is done in isolation with the rest of the tiers, the developer(s) can try radical changes to the code without adversely affecting the rest of the development team. Integration tier A common environment where all developers commit code changes. This environment combines and validates the work of the entire project team so it can be tested before being promoted to the Staging Environment. More common these days is for Development and Integration to be the same environment as well as run automate tests etc. Staging tier The staging tier is a environment that is as identical to the production environment as possible. The purpose of the Staging environment is to simulate as much of the Production environment as possible for the final test phase ( test using deployment process and test using an real data source, final test of the application itself etc ) as well as more often than not acts as an demonstration/training environment. Production The production tier consist the final products and might include a single machine or or cluster of machines or containers, cloud whatever. Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Thu, Jul 10, 2014 at 7:06 PM, Tom Gundersen t...@jklm.no wrote: On Tue, Jul 8, 2014 at 10:23 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) These days people usually use only 3 tier level ( used to be four back in the day ) as in Development and Integration is done the same tier while Staging and Production are separated tiers altogether. We could extend that and include the fourth tier missing tier ( as in Integration ) as optional for those that prefer 4 tier layer over 3 tier but people moved away form that model to the 3 tier one. Development tier Is the working environment for individual developers or small teams. More often than not this work is done in isolation with the rest of the tiers, the developer(s) can try radical changes to the code without adversely affecting the rest of the development team. Integration tier A common environment where all developers commit code changes. This environment combines and validates the work of the entire project team so it can be tested before being promoted to the Staging Environment. More common these days is for Development and Integration to be the same environment as well as run automate tests etc. Staging tier The staging tier is a environment that is as identical to the production environment as possible. The purpose of the Staging environment is to simulate as much of the Production environment as possible for the final test phase ( test using deployment process and test using an real data source, final test of the application itself etc ) as well as more often than not acts as an demonstration/training environment. Production The production tier consist the final products and might include a single machine or or cluster of machines or containers, cloud whatever. Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? ^^^too generic Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/10/2014 05:06 PM, Tom Gundersen wrote: On Thu, Jul 10, 2014 at 7:06 PM, Tom Gundersen t...@jklm.no wrote: On Tue, Jul 8, 2014 at 10:23 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) These days people usually use only 3 tier level ( used to be four back in the day ) as in Development and Integration is done the same tier while Staging and Production are separated tiers altogether. We could extend that and include the fourth tier missing tier ( as in Integration ) as optional for those that prefer 4 tier layer over 3 tier but people moved away form that model to the 3 tier one. Development tier Is the working environment for individual developers or small teams. More often than not this work is done in isolation with the rest of the tiers, the developer(s) can try radical changes to the code without adversely affecting the rest of the development team. Integration tier A common environment where all developers commit code changes. This environment combines and validates the work of the entire project team so it can be tested before being promoted to the Staging Environment. More common these days is for Development and Integration to be the same environment as well as run automate tests etc. Staging tier The staging tier is a environment that is as identical to the production environment as possible. The purpose of the Staging environment is to simulate as much of the Production environment as possible for the final test phase ( test using deployment process and test using an real data source, final test of the application itself etc ) as well as more often than not acts as an demonstration/training environment. Production The production tier consist the final products and might include a single machine or or cluster of machines or containers, cloud whatever. Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. Well, as I mentioned earlier, patch looks generally OK, but I am not OK with the strict checking of the value. It sounds Ok to verify that it is a single word, from a limited charset, but we are not going to become the standardization institute for IT workflows. Please remove the strict checking against the vocabulary, and repost! (also needs man page updates...) Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
]] Lennart Poettering On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. Well, as I mentioned earlier, patch looks generally OK, but I am not OK with the strict checking of the value. It sounds Ok to verify that it is a single word, from a limited charset, but we are not going to become the standardization institute for IT workflows. Did we agree on the name? If Environment is out, maybe ProductionLevel or something like that might fly. And yes, it should be freeform. -- Tollef Fog Heen UNIX is user friendly, it's just picky about who its friends are ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/10/2014 08:44 PM, Lennart Poettering wrote: On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. Well, as I mentioned earlier, patch looks generally OK, but I am not OK with the strict checking of the value. It sounds Ok to verify that it is a single word, from a limited charset, but we are not going to become the standardization institute for IT workflows. Please remove the strict checking against the vocabulary, and repost! (also needs man page updates...) Then it wont solve the problem I was hoping to solve nor can I continue the other work I planned on based on these specific values so feel free to implement as you see fit or drop it altogether. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/10/2014 08:53 PM, Tollef Fog Heen wrote: ]] Lennart Poettering On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. Well, as I mentioned earlier, patch looks generally OK, but I am not OK with the strict checking of the value. It sounds Ok to verify that it is a single word, from a limited charset, but we are not going to become the standardization institute for IT workflows. Did we agree on the name? If Environment is out, maybe ProductionLevel or something like that might fly. And yes, it should be freeform. Then submit the patch with freeform implemented and call it whatever you want. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Thu, 10.07.14 21:04, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 07/10/2014 08:44 PM, Lennart Poettering wrote: On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. Well, as I mentioned earlier, patch looks generally OK, but I am not OK with the strict checking of the value. It sounds Ok to verify that it is a single word, from a limited charset, but we are not going to become the standardization institute for IT workflows. Please remove the strict checking against the vocabulary, and repost! (also needs man page updates...) Then it wont solve the problem I was hoping to solve nor can I continue the other work I planned on based on these specific values so feel free to implement as you see fit or drop it altogether. Hmm? Not follow here. You still can use the exact values you want, however, the service will not check them against a whitelist, that's all. Anyway, if Jóhann lost interest, is anybody else interested to see this being added? Tollef? If so, I'd take Jóhann's patch, drop the checking and commit it... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/10/2014 11:37 PM, Lennart Poettering wrote: On Thu, 10.07.14 21:04, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 07/10/2014 08:44 PM, Lennart Poettering wrote: On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer so can I simple get an ack nack on the deployment patch and those that also want to be able to define free string in there can just patch it. Well, as I mentioned earlier, patch looks generally OK, but I am not OK with the strict checking of the value. It sounds Ok to verify that it is a single word, from a limited charset, but we are not going to become the standardization institute for IT workflows. Please remove the strict checking against the vocabulary, and repost! (also needs man page updates...) Then it wont solve the problem I was hoping to solve nor can I continue the other work I planned on based on these specific values so feel free to implement as you see fit or drop it altogether. Hmm? Not follow here. You still can use the exact values you want, however, the service will not check them against a whitelist, that's all. Systemd integration was just one part, the other part was I was going to contact Karel since I had noticed he has been gradually working on bringing consistency in terminal colorized output in commands the core/baseOS so I wanted to see if we could not come up with terminal color system theme ( which basically administrators have been trying to do and fail miserable in doing so based on the machine staging environment ) and work on integrating that. Something like DEPLOYMENT=Development could be associated with green terminal colour theme DEPLOYMENT=Integration could be associated with yellow terminal colour theme DEPLOYMENT=Staging could be associated with orange terminal colour theme DEPLOYMENT=Production could be associated with red terminal colour theme Then David had suggested to extend this further with in systemd by adding ConditionDeployment= which is a valid request from my point ( we disable for example various servers depending on which staging environments they are in ) I had already submitted new patch with deployment [PATCH] Add DEPLOYMENT to hostnamectl which Zbyszek had suggested and you agreed to and FYI this has nothing to with trying to standardize anything it's about bringing consistency in the system for machines in certain deployment stages so administrators/developers will immediately identify in which stage the environment they are working in, is at. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
Am 08.07.2014 02:55 schrieb Kay Sievers k...@vrfy.org: Shouldn't we possibly we find a word for environment which explains itself a bit better? Environment we usually call the numerous variables of a process or service. Just TAG maybe? It's unfortunate, but ENVIRONMENT is the most widespread term for this, overloaded as it is. Other ideas: CONFIG_TAG ENVIRONMENT_TAG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
Patches look good. Only found one tiny nit. We should come up with a
better name though, feels wrong that the name is very generic (and
clashes with other uses), whilst the usage is quite specific (limited
to testing, staging, production).
Cheers,
Tom
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson
johan...@gmail.com wrote:
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
strna(i-icon_name),
- strna(i-chassis));
+ strna(i-chassis),
+ strna(i-environment));
r = sd_id128_get_machine(mid);
if (r = 0)
@@ -157,6 +160,7 @@ static int show_all_names(sd_bus *bus) {
{ PrettyHostname, s, NULL, offsetof(StatusInfo,
pretty_hostname) },
{ IconName, s, NULL, offsetof(StatusInfo,
icon_name) },
{ Chassis,s, NULL, offsetof(StatusInfo, chassis)
},
+{ Environment,s, NULL, offsetof(StatusInfo,
environment) },
{ KernelName, s, NULL, offsetof(StatusInfo,
kernel_name) },
{ KernelRelease, s, NULL, offsetof(StatusInfo,
kernel_release) },
{ OperatingSystemPrettyName, s, NULL,
offsetof(StatusInfo, os_pretty_name) },
@@ -194,6 +198,7 @@ fail:
free(info.pretty_hostname);
free(info.icon_name);
free(info.chassis);
+free(info.environment);
free(info.kernel_name);
free(info.kernel_release);
free(info.os_pretty_name);
@@ -309,6 +314,13 @@ static int set_chassis(sd_bus *bus, char **args,
unsigned n) {
return set_simple_string(bus, SetChassis, args[1]);
}
+static int set_environment(sd_bus *bus, char **args, unsigned n) {
+assert(args);
+assert(n == 2);
+
+return set_simple_string(bus, SetEnvironment, args[1]);
+}
+
static int help(void) {
printf(%s [OPTIONS...] COMMAND ...\n\n
@@ -325,7 +337,8 @@ static int help(void) {
status Show current hostname settings\n
set-hostname NAME Set system hostname\n
set-icon-name NAME Set icon name for host\n
- set-chassis NAME Set chassis type for host\n,
+ set-chassis NAME Set chassis type for host\n
+ set-environment NAME Set environment for host\n,
program_invocation_short_name);
return 0;
@@ -423,6 +436,7 @@ static int hostnamectl_main(sd_bus *bus, int argc, char
*argv[]) {
{ set-hostname, EQUAL, 2, set_hostname },
{ set-icon-name, EQUAL, 2, set_icon_name },
{ set-chassis, EQUAL, 2, set_chassis },
+{ set-environment, EQUAL, 2, set_environment },
};
int left;
--
1.9.3
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/08/2014 12:55 AM, Kay Sievers wrote: Shouldn't we possibly we find a word for environment which explains itself a bit better? Environment we usually call the numerous variables of a process or service. I was aware of that but decided to move forward since people should be able to make the distinction vs introduces an new word with added learning curve but yeah sure I will resubmit with atmosphere instead. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, Jul 8, 2014 at 9:31 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 07/08/2014 12:55 AM, Kay Sievers wrote: Shouldn't we possibly we find a word for environment which explains itself a bit better? Environment we usually call the numerous variables of a process or service. I was aware of that but decided to move forward since people should be able to make the distinction vs introduces an new word with added learning curve but yeah sure I will resubmit with atmosphere instead. How about MachineRole? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, 08.07.14 02:55, Kay Sievers (k...@vrfy.org) wrote:
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson
johan...@gmail.com wrote:
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
Shouldn't we possibly we find a word for environment which explains
itself a bit better? Environment we usually call the numerous
variables of a process or service.
Yeah, I don't really like environment as name for this either. This is
already used quite commonly in the environment variable sense, we
shouldn't redefine this in this comment.
I'd go for something generic like description or comment or so. Or
maybe purpose. I think simply description appears to be the best
option for me.
BTW, something I also wanted to see for a long time, was a location
field, that can be freely configured by the admin, but is initially
filled in from geoip or so. In many setups it's quite relevant to know
where a server is located. Depending on the usecase ot could be as
generic as Berlin, Germany or maybe as specific as 3rd shelf, left
cabinet or so, whatever people need. (Of course, on laptops it makes
little sense...)
Lennart
--
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
2014-07-08 13:40 GMT+02:00 Lennart Poettering lenn...@poettering.net: I'd go for something generic like description or comment or so. Or maybe purpose. I think simply description appears to be the best option for me. BTW, something I also wanted to see for a long time, was a location field, that can be freely configured by the admin, but is initially filled in from geoip or so. In many setups it's quite relevant to know where a server is located. Depending on the usecase ot could be as generic as Berlin, Germany or maybe as specific as 3rd shelf, left cabinet or so, whatever people need. (Of course, on laptops it makes little sense...) This information looks like local state, i.e. can't be part of /usr/lib/os-release. So, will this create a copy of /usr/lib/os-release at /etc/os-release if this additional information is added? If so, what happens if the os itself is upgraded and /usr/lib/os-release get's an update? Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, Jul 8, 2014 at 1:47 PM, Michael Biebl mbi...@gmail.com wrote: 2014-07-08 13:40 GMT+02:00 Lennart Poettering lenn...@poettering.net: I'd go for something generic like description or comment or so. Or maybe purpose. I think simply description appears to be the best option for me. BTW, something I also wanted to see for a long time, was a location field, that can be freely configured by the admin, but is initially filled in from geoip or so. In many setups it's quite relevant to know where a server is located. Depending on the usecase ot could be as generic as Berlin, Germany or maybe as specific as 3rd shelf, left cabinet or so, whatever people need. (Of course, on laptops it makes little sense...) This information looks like local state, i.e. can't be part of /usr/lib/os-release. machine-info So, will this create a copy of /usr/lib/os-release at /etc/os-release if this additional information is added? If so, what happens if the os itself is upgraded and /usr/lib/os-release get's an update? Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, 08.07.14 13:47, Michael Biebl (mbi...@gmail.com) wrote: 2014-07-08 13:40 GMT+02:00 Lennart Poettering lenn...@poettering.net: I'd go for something generic like description or comment or so. Or maybe purpose. I think simply description appears to be the best option for me. BTW, something I also wanted to see for a long time, was a location field, that can be freely configured by the admin, but is initially filled in from geoip or so. In many setups it's quite relevant to know where a server is located. Depending on the usecase ot could be as generic as Berlin, Germany or maybe as specific as 3rd shelf, left cabinet or so, whatever people need. (Of course, on laptops it makes little sense...) This information looks like local state, i.e. can't be part of /usr/lib/os-release. Oh, yeah, both Description= and Location= should be saved in /etc/machine-info, not /usr/lib/os-release. See machine-info(5). Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/08/2014 11:28 AM, Peter Sztanojev wrote: On Tue, Jul 8, 2014 at 9:31 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 07/08/2014 12:55 AM, Kay Sievers wrote: Shouldn't we possibly we find a word for environment which explains itself a bit better? Environment we usually call the numerous variables of a process or service. I was aware of that but decided to move forward since people should be able to make the distinction vs introduces an new word with added learning curve but yeah sure I will resubmit with atmosphere instead. How about MachineRole? Machine role is different and define the purpose of the machine not the 3 tier environment it resides in. It was on my todo list to look at. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
2014-07-08 13:49 GMT+02:00 Kay Sievers k...@vrfy.org: This information looks like local state, i.e. can't be part of /usr/lib/os-release. machine-info Ah, k. Sorry for the noise. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/08/2014 11:40 AM, Lennart Poettering wrote:
On Tue, 08.07.14 02:55, Kay Sievers (k...@vrfy.org) wrote:
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson
johan...@gmail.com wrote:
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
Shouldn't we possibly we find a word for environment which explains
itself a bit better? Environment we usually call the numerous
variables of a process or service.
Yeah, I don't really like environment as name for this either. This is
already used quite commonly in the environment variable sense, we
shouldn't redefine this in this comment.
I hardly call this redefinition but OK
I'd go for something generic like description or comment or so. Or
maybe purpose. I think simply description appears to be the best
option for me.
This is very specific to deployment environment and to solve a very
specific long standing problem ( describe the operating environment ) so
the options can only be development,staging,production or if people see
the need to extend it further, it could include as well integration and
testing so an description ( which is even more generic than
environment) is a no go.
I think personally that atmosphere is the best synonym for
environment and should be used here since people are insisting using
something else then environment and are under the assumption that
administrators, developers and end users in in general will be confused
by this .
In the long run I think we should be working on an machine information
specificationand amongst other thing redefine Computer Chassis as
System Enclosure or even just drop it altogethersince it's usefulness
is limited to application which might behave differently based on the
System Enclosure type it's running on
For example M$ has 24 definition for chassis [1] while we have 5 (
vm,container,desktop,laptop,handset,server ) which we arguably could
simply reduce to 3 vm,container,hardware provided information ( limited
to the 29 bios standard only [2] ).
Anyway as I said in the long run I think we should be working on an
machine information specification
1. http://technet.microsoft.com/en-us/library/ee156537.aspx
2.
http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.8.0.pdf
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, Jul 08, 2014 at 01:16:43PM +, Jóhann B. Guðmundsson wrote: This is very specific to deployment environment and to solve a very specific long standing problem ( describe the operating environment ) so the options can only be development,staging,production or if people see the need to extend it further, it could include as well integration and testing so an description ( which is even more generic than environment) is a no go. OK, so what about Deployment= (my 1st choice) or OperatingEnvironment= ? I too think Description and Environment are too generic and clash with other uses. Atmosphere is too artificial. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, 08.07.14 20:36, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Tue, Jul 08, 2014 at 01:16:43PM +, Jóhann B. Guðmundsson wrote: This is very specific to deployment environment and to solve a very specific long standing problem ( describe the operating environment ) so the options can only be development,staging,production or if people see the need to extend it further, it could include as well integration and testing so an description ( which is even more generic than environment) is a no go. OK, so what about Deployment= (my 1st choice) or OperatingEnvironment= ? I too think Description and Environment are too generic and clash with other uses. Atmosphere is too artificial. Deployment sounds OK to me. Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
]] Lennart Poettering
On Tue, 08.07.14 02:55, Kay Sievers (k...@vrfy.org) wrote:
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson
johan...@gmail.com wrote:
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
Shouldn't we possibly we find a word for environment which explains
itself a bit better? Environment we usually call the numerous
variables of a process or service.
Yeah, I don't really like environment as name for this either. This is
already used quite commonly in the environment variable sense, we
shouldn't redefine this in this comment.
It's the term which is generally used when talking about, well,
environments, though.
See http://docs.puppetlabs.com/puppet/latest/reference/environments.html
for puppet's use of the term, or
http://docs.opscode.com/essentials_environments.html for Chef's to pick
two popular automation tools.
Make it be «Machine environment», maybe?
I'd go for something generic like description or comment or so. Or
maybe purpose. I think simply description appears to be the best
option for me.
Those are all useful (we have both description and purpose in the Debian
LDAP[1] for instance).
BTW, something I also wanted to see for a long time, was a location
field, that can be freely configured by the admin, but is initially
filled in from geoip or so. In many setups it's quite relevant to know
where a server is located. Depending on the usecase ot could be as
generic as Berlin, Germany or maybe as specific as 3rd shelf, left
cabinet or so, whatever people need. (Of course, on laptops it makes
little sense...)
Lennart
[1] for instance, https://db.debian.org/machines.cgi?host=abel
--
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) -- Tollef Fog Heen UNIX is user friendly, it's just picky about who its friends are ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) These days people usually use only 3 tier level ( used to be four back in the day ) as in Development and Integration is done the same tier while Staging and Production are separated tiers altogether. We could extend that and include the fourth tier missing tier ( as in Integration ) as optional for those that prefer 4 tier layer over 3 tier but people moved away form that model to the 3 tier one. Development tier Is the working environment for individual developers or small teams. More often than not this work is done in isolation with the rest of the tiers, the developer(s) can try radical changes to the code without adversely affecting the rest of the development team. Integration tier A common environment where all developers commit code changes. This environment combines and validates the work of the entire project team so it can be tested before being promoted to the Staging Environment. More common these days is for Development and Integration to be the same environment as well as run automate tests etc. Staging tier The staging tier is a environment that is as identical to the production environment as possible. The purpose of the Staging environment is to simulate as much of the Production environment as possible for the final test phase ( test using deployment process and test using an real data source, final test of the application itself etc ) as well as more often than not acts as an demonstration/training environment. Production The production tier consist the final products and might include a single machine or or cluster of machines or containers, cloud whatever. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, Jul 08, 2014 at 08:23:15PM +, Jóhann B. Guðmundsson wrote: On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) These days people usually use only 3 tier level ( used to be four back in the day ) as in Development and Integration is done the same tier while Staging and Production are separated tiers altogether. We could extend that and include the fourth tier missing tier ( as in Integration ) as optional for those that prefer 4 tier layer over 3 tier but people moved away form that model to the 3 tier one. Development tier Integration tier Staging tier Production We also have Disaster Recovery (DR) tier. It's basically copy of production, started when disaster strucks. -- Tomasz Torcz RIP is irrevelant. Spoofing is futile. xmpp: zdzich...@chrome.pl Your routes will be aggreggated. -- Alex Yuriev ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
]] Jóhann B. Guðmundsson On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to testing, staging, production). Surely at least qa and dev should go onto that list. (You generally want more than one dev environment too, often one or more per developer.) These days people usually use only 3 tier level ( used to be four back in the day ) as in Development and Integration is done the same tier while Staging and Production are separated tiers altogether. We could extend that and include the fourth tier missing tier ( as in Integration ) as optional for those that prefer 4 tier layer over 3 tier but people moved away form that model to the 3 tier one. That's not my experience. Some do what you say, some elide one of them, some do multiple levels of production, some add one or more tiers, in particular when you need to do things like «this test needs to run in this part of production so we can collect data». I don't believe there's a one-size-fits-all here. -- Tollef Fog Heen UNIX is user friendly, it's just picky about who its friends are ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On 07/08/2014 08:31 PM, Tomasz Torcz wrote: We also have Disaster Recovery (DR) tier. It's basically copy of production, started when disaster strucks. I dont think we should add Recovery as an layer since it's just a replica of production in one form or another and as an administrator or developer you treat that as an production as well as DR being a layered process of their own. JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
strna(i-icon_name),
- strna(i-chassis));
+ strna(i-chassis),
+ strna(i-environment));
r = sd_id128_get_machine(mid);
if (r = 0)
@@ -157,6 +160,7 @@ static int show_all_names(sd_bus *bus) {
{ PrettyHostname, s, NULL, offsetof(StatusInfo,
pretty_hostname) },
{ IconName, s, NULL, offsetof(StatusInfo, icon_name)
},
{ Chassis,s, NULL, offsetof(StatusInfo, chassis) },
+{ Environment,s, NULL, offsetof(StatusInfo,
environment) },
{ KernelName, s, NULL, offsetof(StatusInfo,
kernel_name) },
{ KernelRelease, s, NULL, offsetof(StatusInfo,
kernel_release) },
{ OperatingSystemPrettyName, s, NULL,
offsetof(StatusInfo, os_pretty_name) },
@@ -194,6 +198,7 @@ fail:
free(info.pretty_hostname);
free(info.icon_name);
free(info.chassis);
+free(info.environment);
free(info.kernel_name);
free(info.kernel_release);
free(info.os_pretty_name);
@@ -309,6 +314,13 @@ static int set_chassis(sd_bus *bus, char **args, unsigned
n) {
return set_simple_string(bus, SetChassis, args[1]);
}
+static int set_environment(sd_bus *bus, char **args, unsigned n) {
+assert(args);
+assert(n == 2);
+
+return set_simple_string(bus, SetEnvironment, args[1]);
+}
+
static int help(void) {
printf(%s [OPTIONS...] COMMAND ...\n\n
@@ -325,7 +337,8 @@ static int help(void) {
status Show current hostname settings\n
set-hostname NAME Set system hostname\n
set-icon-name NAME Set icon name for host\n
- set-chassis NAME Set chassis type for host\n,
+ set-chassis NAME Set chassis type for host\n
+ set-environment NAME Set environment for host\n,
program_invocation_short_name);
return 0;
@@ -423,6 +436,7 @@ static int hostnamectl_main(sd_bus *bus, int argc, char
*argv[]) {
{ set-hostname, EQUAL, 2, set_hostname },
{ set-icon-name, EQUAL, 2, set_icon_name },
{ set-chassis, EQUAL, 2, set_chassis },
+{ set-environment, EQUAL, 2, set_environment },
};
int left;
--
1.9.3
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson
johan...@gmail.com wrote:
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
Shouldn't we possibly we find a word for environment which explains
itself a bit better? Environment we usually call the numerous
variables of a process or service.
Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl
On Mon, Jul 7, 2014 at 5:55 PM, Kay Sievers k...@vrfy.org wrote:
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson
johan...@gmail.com wrote:
---
src/hostname/hostnamectl.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 267cd74..e164086 100644
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -67,6 +67,7 @@ typedef struct StatusInfo {
char *pretty_hostname;
char *icon_name;
char *chassis;
+char *environment;
char *kernel_name;
char *kernel_release;
char *os_pretty_name;
@@ -92,9 +93,11 @@ static void print_status_info(StatusInfo *i) {
printf(Transient hostname: %s\n, i-hostname);
printf( Icon name: %s\n
- Chassis: %s\n,
+ Chassis: %s\n
+ Environment: %s\n,
Shouldn't we possibly we find a word for environment which explains
itself a bit better? Environment we usually call the numerous
variables of a process or service.
How about stage?
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
