Re: [systemd-devel] [PATCH v2] use systemd.debug on the kernel command line, not debug

[Colin Guthrie]

'Twas brillig, and Greg KH at 03/04/14 02:02 did gyre and gimble:
 +} else if (streq(key, systemd.debug)  !value) {

Just as a small not to user typos, perhaps we should also check for
system.debug? It's a bit of a namespace crime, but it might avoid some
unneeded round trips requesting logs from users.

While it's now practically impossible for me to type the word system
_without_ putting a d on the end, many people triaging boot bugs at a
distro level will be advising users to edit their command prompt and
append debug systemd.debug and send in their logs which could easily
be misread by novice users, especially if they are totally unaware of
what systemd is (they may never even have heard the name before) - not
everyone who needs to collect debug information is a developer after all.

Just a small thought.

Cheers

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH v2] use systemd.debug on the kernel command line, not debug

[Greg KH]

If the kernel is started with debug, that's for the kernel to switch
into debug mode.  We should rely on a namespace for our options, like
everything else (with the exception of quiet).  Some people want to
only debug the kernel, not systemd, and the opposite as well so make
everyone happy.

diff --git a/man/kernel-command-line.xml b/man/kernel-command-line.xml
index dbfec612891a..19da7a3431b0 100644
--- a/man/kernel-command-line.xml
+++ b/man/kernel-command-line.xml
@@ -126,10 +126,10 @@
 /varlistentry
 
 varlistentry
-termvarnamedebug/varname/term
+termvarnamesystemd.debug/varname/term
 listitem
 paraParameter understood by
-both the kernel and the system
+the system
 and service manager to control
 console log verbosity. For
 details, see
diff --git a/src/core/main.c b/src/core/main.c
index 41605ee8d5cd..291b18519388 100644
--- a/src/core/main.c
+++ b/src/core/main.c
@@ -416,7 +416,7 @@ static int parse_proc_cmdline_item(const char *key, const 
char *value) {
 if (arg_show_status == _SHOW_STATUS_UNSET)
 arg_show_status = SHOW_STATUS_AUTO;
 
-} else if (streq(key, debug)  !value) {
+} else if (streq(key, systemd.debug)  !value) {
 
 /* Log to kmsg, the journal socket will fill up before the
  * journal is started and tools running during that time
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel