Re: [systemd-devel] consider renaming -.slice
systemd-journalctl and systemd-systemctl were also renamed to get more convenient ... (But hey, I don't really know what external stuff uses -.slice and -.mount ...) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
On Thu, Jan 16, 2014 at 8:59 AM, Holger Schurig holgerschu...@gmail.com wrote: systemd-journalctl and systemd-systemctl were also renamed to get more convenient ... Symlinks are cheap to create, if compat for these rather exotic things is needed. systemctl was always systemctl, but loginctl we also have renamed. (But hey, I don't really know what external stuff uses -.slice and -.mount ...) The problem is that / is escaped as '-, and root is therefore just -. We would need to change all mount unit names, which all have - for the / in it: home-kay-data.mount run-user-2702-gvfs.mount sys-fs-fuse-connections.mount Unlike the name for a rather optional binary, renaming that would cause a lot of things to break. Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
Oh, I confused that with the old /etc/systemd/systemd-journald.conf file, which was renamed. Kay, I only meant to special case the /, e.g. let home-kay-data.mount be it like it is, but rename - to root, so that it is root.mount and root.slice. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
On Thu, Jan 16, 2014 at 11:27:42AM +0100, Holger Schurig wrote: Oh, I confused that with the old /etc/systemd/systemd-journald.conf file, which was renamed. Kay, I only meant to special case the /, e.g. let home-kay-data.mount be it like it is, but rename - to root, so that it is root.mount and root.slice. This would still break applications like libvirt which expect the current naming conventions. These naming conventions must be considered to be part of the stable API for apps and so cannot be changed once included in an official release. Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
'Twas brillig, and Holger Schurig at 16/01/14 10:27 did gyre and gimble: Oh, I confused that with the old /etc/systemd/systemd-journald.conf file, which was renamed. Kay, I only meant to special case the /, e.g. let home-kay-data.mount be it like it is, but rename - to root, so that it is root.mount and root.slice. The problem with special casing it to root.mount is that this would prevent you having a /root mountpoint as it would also be encoded as root.mount So anything you special case it *to* has to be invalid in it's own right. -.mount fits this bill, but not sure if anything else does... Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
On Jan 16, 2014 9:34 AM, Holger Schurig holgerschu...@gmail.com wrote: Please consider renamign -.slice, because this sucks: # cd /lib/systemd/system # grep -r user@ * grep: invalid option -- '.' Usage: grep [OPTION]... PATTERN [FILE]... Try 'grep --help' for more information. Yes, I know that I can use grep -r -- user@ *, but this is just inconvenient. You can also use `grep -r user@ .` since you're passing -r anyway. (Latest grep even uses . as the default with -r.) Or you can use `grep -r user@ ./*` ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
On Thu, 16.01.14 11:27, Holger Schurig (holgerschu...@gmail.com) wrote: Oh, I confused that with the old /etc/systemd/systemd-journald.conf file, which was renamed. Kay, I only meant to special case the /, e.g. let home-kay-data.mount be it like it is, but rename - to root, so that it is root.mount and root.slice. This is not reversible as both /root and / would then map to root.slice. We need an bijective mapping here from cgroup/fs paths to unit names... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
On Thu, 16.01.14 08:33, Holger Schurig (holgerschu...@gmail.com) wrote: Please consider renamign -.slice, because this sucks: # cd /lib/systemd/system # grep -r user@ * grep: invalid option -- '.' Usage: grep [OPTION]... PATTERN [FILE]... Try 'grep --help' for more information. Yes, I know that I can use grep -r -- user@ *, but this is just inconvenient. Well, it's kinda built into the API for now (as pointed out by others), and it is quite systematic, since / simply maps to - when turning cgroup or file system paths into unit names. That also makes the encoding reversible which we rely on. I understand that this is inconvenient, but then again, -.slice and -.mount are not the most frequently used units, so I am not too concerned. That all said, we could actually change it, and keep compat with an alias name, however, if we do that, we really should have a very good reason, and also, we'd need a convincing encoding, that is also obvious, and reversible, and I see none for that... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] consider renaming -.slice
On Thu, Jan 16, 2014 at 8:33 AM, Holger Schurig holgerschu...@gmail.com wrote: Please consider renamign -.slice, because this sucks: It's the same issue as: $ systemctl status -- -.mount It's too late to change the / escaping rules, it's too widely used already. Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
