Re: tar -J for xz

2011-10-05 Thread Marc Espie
On Wed, Oct 05, 2011 at 12:05:18AM +0100, Nicholas Marriott wrote:
 And from the look of it they also have -J, but .xz is so rarely used
 right now I'm not sure it is something we really need to copy...

That's not gonna be the case from gnome3 (for instance). As I've been
told by Antoine, they're going to drop bz2 tarballs entirely.



Re: tar -J for xz

2011-10-05 Thread Antoine Jacoutot
On Wed, 5 Oct 2011, Marc Espie wrote:

 On Wed, Oct 05, 2011 at 12:05:18AM +0100, Nicholas Marriott wrote:
  And from the look of it they also have -J, but .xz is so rarely used
  right now I'm not sure it is something we really need to copy...
 
 That's not gonna be the case from gnome3 (for instance). As I've been
 told by Antoine, they're going to drop bz2 tarballs entirely.

To be more precise, it's not gnome3, it's any project hosted by the 
gnome foundation (e.g. glib, gtk...).

-- 
Antoine



Re: carp ipv6 checksum fix

2011-10-05 Thread Marco Pfatschbacher
On Sun, Oct 02, 2011 at 04:44:46PM +0200, Stefan Sperling wrote:
[...] 
 The problem is that the IPv6 input path uses IP6_EXTHDR_GET() to
 obtain a pointer to the carp header when verifying the carp header's
 checksum. IP6_EXTHDR_GET() internally uses m_pulldown(), which might
 return a pointer to a different mbuf in the chain. However, there is
 no way for the caller of IP6_EXTHDR_GET() to get at the different mbuf
 pointer returned by m_pulldown().
[...] 

I think it's easier to just use m_pullup here.
m_pulldown() is usually more efficient, since it doesn't have
have to start from the beginning of the chain, but that doesn't
matter for the carp case.

Does this fix your problem as well?

Index: ip_carp.c
===
RCS file: /cvs/src/sys/netinet/ip_carp.c,v
retrieving revision 1.190
diff -p -u -p -u -r1.190 ip_carp.c
--- ip_carp.c   6 Sep 2011 16:00:22 -   1.190
+++ ip_carp.c   5 Oct 2011 07:57:33 -
@@ -650,13 +650,12 @@ carp6_proto_input(struct mbuf **mp, int 
 
/* verify that we have a complete carp packet */
len = m-m_len;
-   IP6_EXTHDR_GET(ch, struct carp_header *, m, *offp, sizeof(*ch));
-   if (ch == NULL) {
+   if ((m = m_pullup(m, *offp + sizeof(*ch))) == NULL) {
carpstats.carps_badlen++;
CARP_LOG(LOG_INFO, sc, (packet size %u too small, len));
return (IPPROTO_DONE);
}
-
+   ch = (struct carp_header *)(mtod(m, caddr_t) + *offp);
 
/* verify the CARP checksum */
m-m_data += *offp;



Re: tar -J for xz

2011-10-05 Thread Christian Weisgerber
Amit Kulkarni amitk...@gmail.com wrote:

 http://git.tukaani.org/?p=xz.git;a=tree
 Probably can't import xz into base as parts of xz are GPL v3.

Actually all the interesting parts of xz are in the public domain.

The details are laid out in COPYING.
The GPLv3 part refers to pieces of the autoconf build infrastructure
and is probably wrong, but I can't blame the author for being careful
and not bothering to disentangle the GNU mess.

-- 
Christian naddy Weisgerber  na...@mips.inka.de



Re: tar -J for xz

2011-10-05 Thread Christian Weisgerber
Nicholas Marriott nicholas.marri...@gmail.com wrote:

 Or if we must have compression flags just have one flag and let tar
 figure out the right tool to use. Having -Z -z -J -j etc etc is silly.

bsdtar and gtar detect compressed archives automatically and
transparently invoke the corresponding decompressor.

$ bsdtar tf foo.tar.xz
foo/
foo/bla
...

However, they can't automatically devine the desired type of
compression when creating an archive...  Actually, gtar can: If
given the -a flag, it will deduce the compressor to choose from the
archive name, e.g.

$ gtar caf foo.tar.bz2 foo

will call bzip2.

-- 
Christian naddy Weisgerber  na...@mips.inka.de



Re: UPDATE: xenocara/xkeyboard-config

2011-10-05 Thread Alexandr Shadchin
On Mon, Oct 03, 2011 at 02:00:33AM +0600, Alexandr Shadchin wrote:
 Hi,
 
 This update xkeyboard-config to the latest release 2.4.
 http://koba.devio.us/distfiles/xkeyboard-config-2.4.diff
 
 Tested on amd64.
 
 Comments ? OK ? 
 
 -- 
 Alexandr Shadchin
 

New diff http://koba.devio.us/distfiles/xkeyboard-config-2.4.1.diff
* update to 2.4.1
* add pre-process manual page
* small rework Makefile

-- 
Alexandr Shadchin