is* functions

2013-07-06 Thread Jason McIntyre 
diff below from Daniel Dickman. it appears is* are functions, not macros
(defined in gen/isctype.c). i'm looking for oks.

jmc

Index: isalnum.3
===
RCS file: /home/cvs/src/lib/libc/gen/isalnum.3,v
retrieving revision 1.9
diff -u -r1.9 isalnum.3
--- isalnum.3   5 Jun 2013 03:39:22 -   1.9
+++ isalnum.3   5 Jul 2013 20:33:19 -
@@ -44,7 +44,7 @@
 .Sh DESCRIPTION
 The
 .Fn isalnum
-macro tests for any character for which
+function tests for any character for which
 .Xr isalpha 3
 or
 .Xr isdigit 3
@@ -52,7 +52,7 @@
 .Sh RETURN VALUES
 The
 .Fn isalnum
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalpha 3 ,
Index: isalpha.3
===
RCS file: /home/cvs/src/lib/libc/gen/isalpha.3,v
retrieving revision 1.10
diff -u -r1.10 isalpha.3
--- isalpha.3   5 Jun 2013 03:39:22 -   1.10
+++ isalpha.3   5 Jul 2013 20:33:31 -
@@ -67,7 +67,7 @@
 .Sh RETURN VALUES
 The
 .Fn isalpha
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: isascii.3
===
RCS file: /home/cvs/src/lib/libc/gen/isascii.3,v
retrieving revision 1.11
diff -u -r1.11 isascii.3
--- isascii.3   5 Jun 2013 03:39:22 -   1.11
+++ isascii.3   5 Jul 2013 20:33:41 -
@@ -47,7 +47,7 @@
 .Sh RETURN VALUES
 The
 .Fn isascii
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: isblank.3
===
RCS file: /home/cvs/src/lib/libc/gen/isblank.3,v
retrieving revision 1.10
diff -u -r1.10 isblank.3
--- isblank.3   5 Jun 2013 03:39:22 -   1.10
+++ isblank.3   5 Jul 2013 20:34:05 -
@@ -60,7 +60,7 @@
 .Sh RETURN VALUES
 The
 .Fn isblank
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: iscntrl.3
===
RCS file: /home/cvs/src/lib/libc/gen/iscntrl.3,v
retrieving revision 1.9
diff -u -r1.9 iscntrl.3
--- iscntrl.3   5 Jun 2013 03:39:22 -   1.9
+++ iscntrl.3   5 Jul 2013 20:34:16 -
@@ -48,7 +48,7 @@
 .Sh RETURN VALUES
 The
 .Fn iscntrl
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: isdigit.3
===
RCS file: /home/cvs/src/lib/libc/gen/isdigit.3,v
retrieving revision 1.9
diff -u -r1.9 isdigit.3
--- isdigit.3   5 Jun 2013 03:39:22 -   1.9
+++ isdigit.3   5 Jul 2013 20:34:24 -
@@ -48,7 +48,7 @@
 .Sh RETURN VALUES
 The
 .Fn isdigit
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: isgraph.3
===
RCS file: /home/cvs/src/lib/libc/gen/isgraph.3,v
retrieving revision 1.10
diff -u -r1.10 isgraph.3
--- isgraph.3   5 Jun 2013 03:39:22 -   1.10
+++ isgraph.3   5 Jul 2013 20:34:44 -
@@ -49,7 +49,7 @@
 .Sh RETURN VALUES
 The
 .Fn isgraph
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: islower.3
===
RCS file: /home/cvs/src/lib/libc/gen/islower.3,v
retrieving revision 1.10
diff -u -r1.10 islower.3
--- islower.3   5 Jun 2013 03:39:22 -   1.10
+++ islower.3   5 Jul 2013 20:36:10 -
@@ -60,7 +60,7 @@
 .Sh RETURN VALUES
 The
 .Fn islower
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: isprint.3
===
RCS file: /home/cvs/src/lib/libc/gen/isprint.3,v
retrieving revision 1.9
diff -u -r1.9 isprint.3
--- isprint.3   5 Jun 2013 03:39:22 -   1.9
+++ isprint.3   5 Jul 2013 20:36:31 -
@@ -49,7 +49,7 @@
 .Sh RETURN VALUES
 The
 .Fn isprint
-macro returns zero if the character tests false or
+function returns zero if the character tests false or
 non-zero if the character tests true.
 .Sh SEE ALSO
 .Xr isalnum 3 ,
Index: ispunct.3
===
RCS file:

Re: is* functions

2013-07-06 Thread Philip Guenther 
On Sat, Jul 6, 2013 at 12:29 AM, Jason McIntyre j...@kerhand.co.uk wrote:
 diff below from Daniel Dickman. it appears is* are functions, not macros
 (defined in gen/isctype.c). i'm looking for oks.

Oh no!  Someone found out that we changed them!  We must hide the evidence!

Uh, I mean, sure, yeah, ok guenther@

exec_elf.c: mistake ?

2013-07-06 Thread Maxime Villard 
Hi,
- - - - sys/kern/exec_elf.c l.236 ~ 251252
Are my code scanner and me wrong, or 'bdiff' may not be
initialized ?

Re: exec_elf.c: mistake ?

2013-07-06 Thread Kenneth R Westerback 
On Sat, Jul 06, 2013 at 05:21:31PM +0200, Maxime Villard wrote:
 Hi,
 - - - - sys/kern/exec_elf.c l.236 ~ 251252
 Are my code scanner and me wrong, or 'bdiff' may not be
 initialized ?
 

Codewise it does look possible that bdiff will be used uninitialized.
Whether it can happen in reality depends on whether ph-p_align can ever
be  1. Next question -- what would the correct value for bdiff be in that
case?  0? i.e. should the line be 'diff = bdiff = 0;'.

 Ken