Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

[Theo de Raadt]

Jimmy Hess  wrote:

> On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler  wrote:
> > I don't think these are "redundant quotes" but rather ditto marks:
> 
> The  ditto mark and the quote character are  not the same character,
> and the comments are nonsensical since they used the wrong character.
> 
> If the writer means Ditto mark, then you type the  Ditto character: 〃 (U+3003)
> and not the  double quotation mark symbol:  "  (U+0022)

We don't litter our source tree with UTF.

Let it go

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

[Ingo Schwarze]

Hi,

Jimmy Hess wrote on Fri, Apr 20, 2018 at 06:53:44AM -0500:
> On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler  wrote:

>> I don't think these are "redundant quotes" but rather ditto marks:

> The  ditto mark and the quote character are  not the same character,
> and the comments are nonsensical since they used the wrong character.
> 
> If the writer means Ditto mark, then you type the  Ditto character:
> U+3003 and not the double quotation mark symbol U+0022

Source files (and emails on our lists) use US-ASCII.
No UTF-8 allowed in there.

> Actually, for the below example it would be better to just repeat the
> small amount text;

No, that would exceed the 80 column limit for source files.

> just type  copy and paste  "context switches"  3 times,   instead of
> trying to be cute
> and confusing some readers in the process.
> 
> The comment for a structure member should stand on its own.

Paint my bikeshed pink.

Don't argue over personal style in comments.

Yours,
  Ingo


>> https://en.wikipedia.org/wiki/Ditto_mark
>> this is quite clear here, for example:
>>
>>>   u_int64_t p_uru_nvcsw;  /* LONG: voluntary context switches. 
>>> */
>>> - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */
>>> + u_int64_t p_uru_nivcsw; /* LONG: involuntary. */

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

[Landry Breuil]

On Fri, Apr 20, 2018 at 06:53:44AM -0500, Jimmy Hess wrote:
> On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler  wrote:
> > I don't think these are "redundant quotes" but rather ditto marks:
> 
> The  ditto mark and the quote character are  not the same character,
> and the comments are nonsensical since they used the wrong character.
> 
> If the writer means Ditto mark, then you type the  Ditto character: 〃 (U+3003)
> and not the  double quotation mark symbol:  "  (U+0022)

UTF-8 in source code ? please kill me now.

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

[Jimmy Hess]

On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler  wrote:
> I don't think these are "redundant quotes" but rather ditto marks:

The  ditto mark and the quote character are  not the same character,
and the comments are nonsensical since they used the wrong character.

If the writer means Ditto mark, then you type the  Ditto character: 〃 (U+3003)
and not the  double quotation mark symbol:  "  (U+0022)

Actually, for the below example  it would be better to just repeat the
small amount text;
just type  copy and paste  "context switches"  3 times,   instead of
trying to be cute
and confusing some readers in the process.

The comment for a structure member should stand on its own.

> https://en.wikipedia.org/wiki/Ditto_mark
> this is quite clear here, for example:
>
>>   u_int64_t p_uru_nvcsw;  /* LONG: voluntary context switches. */
>> - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */
>> + u_int64_t p_uru_nivcsw; /* LONG: involuntary. */
>


-- 
-JH

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

[Nan Xiao]

Hi Theo,

I am very sorry for this wrong modification!

Thanks!
Best Regards
Nan Xiao


On Fri, Apr 20, 2018 at 4:57 PM, Theo Buehler  wrote:
> I don't think these are "redundant quotes" but rather ditto marks:
>
> https://en.wikipedia.org/wiki/Ditto_mark
>
> this is quite clear here, for example:
>
>>   u_int64_t p_uru_nvcsw;  /* LONG: voluntary context switches. */
>> - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */
>> + u_int64_t p_uru_nivcsw; /* LONG: involuntary. */
>

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

[Theo Buehler]

I don't think these are "redundant quotes" but rather ditto marks:

https://en.wikipedia.org/wiki/Ditto_mark

this is quite clear here, for example:

>   u_int64_t p_uru_nvcsw;  /* LONG: voluntary context switches. */
> - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */
> + u_int64_t p_uru_nivcsw; /* LONG: involuntary. */