Re: dhcp-options(5) diff
On Wed, Feb 28, 2018 at 05:27:41PM +0100, Matthieu Herrb wrote: > On Wed, Feb 28, 2018 at 05:24:20PM +0100, Matthieu Herrb wrote: > > Hi, > > > > I've started using the classless-static-route option in dhcpd(8). This > > was not as painless as possible because I missed some important > > information from the underlying RFC to understand how the option is > > used by clients and how it should be configured on the server. > > > > The patch below tries to add this information to dhcp-options(5), > > without beeing too verbose. > > > > While there, I also noted that the classful routes are obsolete. I was > > wondering if we could just remove this option from the doc (and maybe > > tedu the code ?) instead. > > > > Ok, corrections, ... ? > > Argh I managed to mangle the diff with a last minute edit. Correct > version: I agree with the intent of this diff and am happy to work on tweaks to the actual verbiage in-tree. ok krw@ Ken > > Index: dhcp-options.5 > === > RCS file: /cvs/OpenBSD/src/usr.sbin/dhcpd/dhcp-options.5,v > retrieving revision 1.22 > diff -u -p -u -r1.22 dhcp-options.5 > --- dhcp-options.514 Sep 2015 20:06:59 - 1.22 > +++ dhcp-options.528 Feb 2018 16:26:50 - > @@ -171,6 +171,11 @@ RFC 1122. > .It Ic option classless-static-routes Ar ip/prefix ip Oo , Ar ip/prefix ip > ... Oc ; > This option specifies a list of static routes in CDIR notation, which > should be sent to the client. > +This option is specified in RFC3442. > +Note that, since the RFC says that clients supporting this option must > ignore the > +.Ic Routers > +option when both are present, the default route > +needs to be included in the list of routes specified here. > .It Ic option classless-ms-static-routes Ar ip/prefix ip Oo , Ar ip/prefix > ip ... Oc ; > This option does the same as > .Ic classless-static-routes , > @@ -517,6 +522,8 @@ The default route (0.0.0.0) is an illega > To specify the default route, use the > .Ic routers > option. > +Note that this option is obsolete and should be replaced by the > +.Ic classless-static-routes option. > .It Ic option streettalk-directory-assistance-server Ar ip-address Oo , Ar > ip-address ... Oc ; > The StreetTalk Directory Assistance (STDA) server option specifies a > list of STDA servers available to the client. > > -- > Matthieu Herrb
Re: dhcp-options(5) diff
On Wed, Feb 28, 2018 at 05:24:20PM +0100, Matthieu Herrb wrote: > Hi, > > I've started using the classless-static-route option in dhcpd(8). This > was not as painless as possible because I missed some important > information from the underlying RFC to understand how the option is > used by clients and how it should be configured on the server. > > The patch below tries to add this information to dhcp-options(5), > without beeing too verbose. > > While there, I also noted that the classful routes are obsolete. I was > wondering if we could just remove this option from the doc (and maybe > tedu the code ?) instead. > > Ok, corrections, ... ? Argh I managed to mangle the diff with a last minute edit. Correct version: Index: dhcp-options.5 === RCS file: /cvs/OpenBSD/src/usr.sbin/dhcpd/dhcp-options.5,v retrieving revision 1.22 diff -u -p -u -r1.22 dhcp-options.5 --- dhcp-options.5 14 Sep 2015 20:06:59 - 1.22 +++ dhcp-options.5 28 Feb 2018 16:26:50 - @@ -171,6 +171,11 @@ RFC 1122. .It Ic option classless-static-routes Ar ip/prefix ip Oo , Ar ip/prefix ip ... Oc ; This option specifies a list of static routes in CDIR notation, which should be sent to the client. +This option is specified in RFC3442. +Note that, since the RFC says that clients supporting this option must ignore the +.Ic Routers +option when both are present, the default route +needs to be included in the list of routes specified here. .It Ic option classless-ms-static-routes Ar ip/prefix ip Oo , Ar ip/prefix ip ... Oc ; This option does the same as .Ic classless-static-routes , @@ -517,6 +522,8 @@ The default route (0.0.0.0) is an illega To specify the default route, use the .Ic routers option. +Note that this option is obsolete and should be replaced by the +.Ic classless-static-routes option. .It Ic option streettalk-directory-assistance-server Ar ip-address Oo , Ar ip-address ... Oc ; The StreetTalk Directory Assistance (STDA) server option specifies a list of STDA servers available to the client. -- Matthieu Herrb
dhcp-options(5) diff
Hi, I've started using the classless-static-route option in dhcpd(8). This was not as painless as possible because I missed some important information from the underlying RFC to understand how the option is used by clients and how it should be configured on the server. The patch below tries to add this information to dhcp-options(5), without beeing too verbose. While there, I also noted that the classful routes are obsolete. I was wondering if we could just remove this option from the doc (and maybe tedu the code ?) instead. Ok, corrections, ... ? Index: dhcp-options.5 === RCS file: /cvs/OpenBSD/src/usr.sbin/dhcpd/dhcp-options.5,v retrieving revision 1.22 diff -u -p -u -r1.22 dhcp-options.5 --- dhcp-options.5 14 Sep 2015 20:06:59 - 1.22 +++ dhcp-options.5 28 Feb 2018 16:16:34 - @@ -171,6 +171,10 @@ RFC 1122. .It Ic option classless-static-routes Ar ip/prefix ip Oo , Ar ip/prefix ip ... Oc ; This option specifies a list of static routes in CDIR notation, which should be sent to the client. +This option is specified in RFC3442. +Note that, since the RFC says that clients supporting this option must ignore the +.Ic Routers option when both are present, the default route +needs to be included in the list of routes specified here. .It Ic option classless-ms-static-routes Ar ip/prefix ip Oo , Ar ip/prefix ip ... Oc ; This option does the same as .Ic classless-static-routes , @@ -517,6 +521,8 @@ The default route (0.0.0.0) is an illega To specify the default route, use the .Ic routers option. +Note that this option is obsolete and should be replaced by the +.Ic classless-static-routes option. .It Ic option streettalk-directory-assistance-server Ar ip-address Oo , Ar ip-address ... Oc ; The StreetTalk Directory Assistance (STDA) server option specifies a list of STDA servers available to the client. -- Matthieu Herrb
