Tomcat MAC IE5 SSL Partial Bug fix
Hi Jay, http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6983 I noted that you added a blank to create ; Secure instead of ;Secure. I am just curious where you got the background spec. for doing this change and if you have verified this with Mac IE 5? Well, I'm sure you have! BTW, does any browser handle this flag correctly? I.e. not sending secure cookies in non-secure sessions. It seems that cookie changes must be verified with a lot of browsers as we have noted subtle differences in old and new Netscapes, IEs, Operas etc. A real nightmare IMHO! Actually I think this patch may not be enough as it is likely to be handled differently among browsers. If somebody want to switich from https to http it may work with some browsers only. I.e. I urge that the Tomcat team makes a configuration setting for this. Several other people have indicated that they want to use Tomcat in this [not entitirely recommendable] way. Such a setting may affect other parts of Tomcat as well but that is just a guess, as I know practically nothing about the Tomcat inside. Locating the Secure stuff was just a shot in the air [using grep]... Regards Anders Rundgren, [a most of the time a] happy Tomcat user -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7787] New: - JSPs don't write cookies except with specific IP address
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7787. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7787 JSPs don't write cookies except with specific IP address Summary: JSPs don't write cookies except with specific IP address Product: Tomcat 4 Version: Unknown Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Unfortunately I cannot determine which version of Tomcat 4 I downloaded. I think I recall that I downloaded it 2 weeks ago and today's date is April 6, 2002. The files don't have an about.html to let me know this and the readme appears illusive to this information too. The CookieExample servelet technique works, but doing cookie read/writes with JSP does not work on localhost unless I switch to the actual 127.0.0.1 or real IP address of the web server, either remotely or locally. (Of course, 127.0.0.1 doesn't work remotely.) Note that I'm not running Apache, but purely Tomcat. Example: http://localhost:8080/scripts/cookies/ fails to allow cookie read/write, but the following works http://127.0.0.1:8080/scripts/cookies/ Steps to reproduce: 1. Create a directory structure under ROOT with the path /scripts/cookies, which the following files should be placed in. 2. Create an index.html with a hyperlink to begin the example. The hyperlink should go to write_cookie.jsp. 3. write_cookie.jsp should create a new cookie fruit with value apple. It should follow with a hyperlink which goes to read_cookie.jsp. 4. read_cookie.jsp should perform a standard dump of the full cookie array. It should be preceeded with a test to see if the array is null, then report no cookies found if this is true. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7787] - JSPs don't write cookies except with specific IP address
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7787. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7787 JSPs don't write cookies except with specific IP address --- Additional Comments From [EMAIL PROTECTED] 2002-04-06 09:52 --- Created an attachment (id=1493) Source Code -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7789] New: - JSP Cookie Read/Write Fails With DNS Names
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7789. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7789 JSP Cookie Read/Write Fails With DNS Names Summary: JSP Cookie Read/Write Fails With DNS Names Product: Tomcat 3 Version: 3.3.1 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] If you use a URL such as... http://localhost:8080/scripts/cookies/ -or- http://myserver:8080/scripts/cookies/ ...instead of... http://127.0.0.1:8080/scripts/cookies/ ...you will find that normal read/write of cookie operations will fail. This problem is also carried into Tomcat 4 too, by the way, and I have filed that bug report too. Steps to reproduce: 1. Use only Tomcat, alone, not in unison with the Apache web server. 2. Create a directory structure under ROOT with the path /scripts/cookies, which the following files should be placed in. 3. Create an index.html with a hyperlink to begin the example. The hyperlink should go to write_cookie.jsp. 4. write_cookie.jsp should create a new cookie fruit with value apple. It should follow with a hyperlink which goes to read_cookie.jsp. 5. read_cookie.jsp should perform a standard dump of the full cookie array. It should be preceeded with a test to see if the array is null, then report no cookies found if this is true. 6. Use a variety of browsers and run the two URL tests. I used IE 5.5 and Opera 6.01 in my tests and got the same results. I cleared my full cache on both, shut down the browsers, and tried again with the same results. I turned off ZoneAlarm Pro and retried. Same result. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7789] - JSP Cookie Read/Write Fails With DNS Names
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7789. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7789 JSP Cookie Read/Write Fails With DNS Names --- Additional Comments From [EMAIL PROTECTED] 2002-04-06 11:24 --- Created an attachment (id=1494) Source Code -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7715] - Apache+mod_ssl+mod_jk cannot download a file in IE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7715. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7715 Apache+mod_ssl+mod_jk cannot download a file in IE [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2002-04-06 11:52 --- I altered servlet according to bug 6709 and it worked. Thank you very much, Antti Lehto *** This bug has been marked as a duplicate of 6709 *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 6709] - Images on protected areas have not Last modified header
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6709. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6709 Images on protected areas have not Last modified header [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2002-04-06 11:52 --- *** Bug 7715 has been marked as a duplicate of this bug. *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [PATCH] jakarta-tomcat-connectors/jk/doc/Tomcat-Workers-HowTo.html
thanks I'll study all of this - Henri Gomez ___[_] EMAIL : [EMAIL PROTECTED](. .) PGP KEY : 697ECEDD...oOOo..(_)..oOOo... PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 -Original Message- From: Bernd Koecke [mailto:[EMAIL PROTECTED]] Sent: Friday, April 05, 2002 5:19 PM To: [EMAIL PROTECTED] Subject: [PATCH] jakarta-tomcat-connectors/jk/doc/Tomcat-Workers-HowTo.html Hi, here is the docs patch for the previouse patch of lb-worker. The base file is the current version from cvs. But someone should look at it with more experience in writing docs in English :) Have a nice weekend! Bernd -- Dipl.-Inform. Bernd Koecke UNIX-Entwicklung Schlund+Partner AG Fon: +49-721-91374-0 E-Mail: [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java CoyoteConnector2.java
remm02/04/06 04:24:05 Added: coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java CoyoteConnector2.java Log: - Add draft of the connector based on the protocol handler. Revision ChangesPath 1.1 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java Index: CoyoteAdapter.java === /* * $Header: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java,v 1.1 2002/04/06 12:24:05 remm Exp $ * $Revision: 1.1 $ * $Date: 2002/04/06 12:24:05 $ * * * * The Apache Software License, Version 1.1 * * Copyright (c) 1999 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. * * 2. Redistributions in binary form must reproduce the above copyright *notice, this list of conditions and the following disclaimer in *the documentation and/or other materials provided with the *distribution. * * 3. The end-user documentation included with the redistribution, if *any, must include the following acknowlegement: * This product includes software developed by the *Apache Software Foundation (http://www.apache.org/). *Alternately, this acknowlegement may appear in the software itself, *if and wherever such third-party acknowlegements normally appear. * * 4. The names The Jakarta Project, Tomcat, and Apache Software *Foundation must not be used to endorse or promote products derived *from this software without prior written permission. For written *permission, please contact [EMAIL PROTECTED] * * 5. Products derived from this software may not be called Apache *nor may Apache appear in their names without prior written *permission of the Apache Group. * * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE * DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * * * This software consists of voluntary contributions made by many * individuals on behalf of the Apache Software Foundation. For more * information on the Apache Software Foundation, please see * http://www.apache.org/. * * [Additional notices, if required by prior licensing conditions] * */ package org.apache.coyote.tomcat4; import java.io.BufferedInputStream; import java.io.EOFException; import java.io.InterruptedIOException; import java.io.InputStream; import java.io.IOException; import java.io.OutputStream; import java.net.InetAddress; import java.net.Socket; import java.util.ArrayList; import java.util.Enumeration; import java.util.Iterator; import java.util.Locale; import java.util.StringTokenizer; import java.util.TreeMap; import javax.servlet.ServletException; import javax.servlet.http.Cookie; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import org.apache.tomcat.util.buf.ByteChunk; import org.apache.tomcat.util.buf.HexUtils; import org.apache.tomcat.util.buf.MessageBytes; import org.apache.tomcat.util.http.Cookies; import org.apache.tomcat.util.http.ServerCookie; import org.apache.coyote.ActionCode; import org.apache.coyote.ActionHook; import org.apache.coyote.Adapter; import org.apache.coyote.InputBuffer; import org.apache.coyote.OutputBuffer; import org.apache.coyote.Request; import org.apache.coyote.Response; import org.apache.catalina.Connector; import org.apache.catalina.Container; import org.apache.catalina.Globals; import org.apache.catalina.HttpRequest; import org.apache.catalina.HttpResponse; import org.apache.catalina.Lifecycle; import org.apache.catalina.LifecycleEvent; import
[GUMP] Build Failure - jakarta-tomcat-4.0
This email is autogenerated from the output from:
http://jakarta.apache.org/builds/gump/2002-04-06/jakarta-tomcat-4.0.html
Buildfile: build.xml
deploy-prepare:
deploy-static:
deploy:
[echo] Target: Catalina - Deploy ...
flags:
flags.display:
[echo] --- Build environment for Catalina ---
[echo] If ${property_name} is displayed, then the property is not set)
[echo] --- Build options ---
[echo] full.dist=${full.dist}
[echo] build.sysclasspath=only
[echo] compile.debug=${compile.debug}
[echo] compile.deprecation=${compile.deprecation}
[echo] compile.optimize=${compile.optimize}
[echo] --- Ant Flags ---
[echo] style task available (required)=true
[echo] --- JDK ---
[echo] jdk.1.2.present=true
[echo] jdk.1.3.present=true
[echo] jdk.1.4.present=${jdk.1.4.present}
[echo] --- Source Dependencies ---
[echo] jtc.home.present=true
[echo] --- Required Libraries ---
[echo] beanutils.present=true
[echo] collections.present=true
[echo] digester.present=true
[echo] jaxp.present=true
[echo] jndi.present=true
[echo] logging.present=true
[echo] regexp.present=true
[echo] servlet.present=true
[echo] --- Optional Libraries ---
[echo] daemon.present=${daemon.present}
[echo] dbcp.present=true
[echo] jaas.present=true
[echo] javamail.present=true
[echo] jmx.present=true
[echo] jsse.present=true
[echo] jta.present=true
[echo] junit.present=true
[echo] ldap.present=true
[echo] modeler.present=true
[echo] pool.present=true
[echo] tyrex.present=${tyrex.present}
[echo] --- Required JARs ---
[echo] jndi.jar.present(except JDK 1.3+)=true
[echo] regexp.jar.present=true
[echo] servlet.jar.present=true
[echo] xerces.jar.present(except JDK 1.4+ or xerces2)=true
[echo] xerces2.jars.present(except JDK 1.4+ or xerces1)=${xerces2.jars.present}
[echo] --- Optional JARs ---
[echo] daemon.jar.present=${daemon.jar.present}
[echo] dbcp.jar.present=true
[echo] jaas.jar.present=true
[echo] javamail.jar.present=true
[echo] jdbc20ext.jar.present=true
[echo] jmx.jar.present=${jmx.jar.present}
[echo] jta.jar.present=true
[echo] junit.jar.present=${junit.jar.present}
[echo] ldap.jar.present=true
[echo] modeler.jar.present=true
[echo] pool.jar.present=true
[echo] tyrex.jar.present=${tyrex.jar.present}
[echo] --- Conditional compilation flags ---
[echo] compile.daemon=${compile.daemon}
[echo] compile.dbcp=true
[echo] compile.jaas=true
[echo] compile.javamail=true
[echo] compile.jmx=true
[echo] compile.jndi=true
[echo] compile.jsse=true
[echo] compile.jta=true
[echo] compile.junit=true
[echo] compile.ldap=true
[echo] compile.ssi=true
[echo] compile.tyrex=${compile.tyrex}
[echo] --- Distribution flags ---
[echo] copy.daemon.jar=${copy.daemon.jar}
[echo] copy.dbcp.jar=true
[echo] copy.jaas.jar=true
[echo] copy.jdbc20ext.jar=true
[echo] copy.javamail.jar=true
[echo] copy.jmx.jar=${copy.jmx.jar}
[echo] copy.jndi.jar=${copy.jndi.jar}
[echo] copy.jta.jar=true
[echo] copy.ldap.jar=${copy.ldap.jar}
[echo] copy.logging.jar=true
[echo] copy.modeler.jar=true
[echo] copy.pool.jar=true
[echo] copy.tyrex.jar=${copy.tyrex.jar}
[echo] copy.xerces.jar=true
[echo] copy.xerces2.jars=${copy.xerces2.jars}
build-prepare:
copy-activation.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-daemon.jar:
copy-dbcp.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jaas.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-jdbc20ext.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jmx.jar:
copy-jndi.jar:
copy-jsse.jar:
copy-jta.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-ldap.jar:
copy-modeler.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-pool.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-tyrex.jar:
copy-xerces.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/endorsed
copy-xerces2.jars:
build-static:
build-tomcat-util:
detect:
build-prepare:
build-main:
[echo] - Java-utils -
[echo] -- puretls.present = ${puretls.present}
[echo] -- jsse.present = true
[javac] Compiling
DO NOT REPLY [Bug 7794] New: - Common.ClassLoader and Apps.ClassLoader not loading .zip files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7794. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7794 Common.ClassLoader and Apps.ClassLoader not loading .zip files Summary: Common.ClassLoader and Apps.ClassLoader not loading .zip files Product: Tomcat 3 Version: 3.3 Final Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] It seems to me that if class files are packaged with .zip suffix instead of .jar, they do not get picked up by the Common.ClassLoader or Apps.ClassLoader. Also the documentation for the new class structure seems to indicate this. This behaviour is inconsistent with how regular Java works -- also .zip files are picked up from directories listed in $CLASSPATH (so, .zip files used to be included before Tomcat 3.3). This problem is manifest f.ex. when Oracle 8i JDBC classes are needed - the file name for these is classes12.zip. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res - New directory
remm02/04/06 08:33:16 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res LocalStrings.properties
remm02/04/06 08:34:03
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Added: util/java/org/apache/tomcat/util/net/res
LocalStrings.properties
Log:
- Add (empty) resource bundle at the right place.
Revision ChangesPath
1.2 +5 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
Index: PoolTcpEndpoint.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- PoolTcpEndpoint.java 5 Apr 2002 17:43:33 - 1.1
+++ PoolTcpEndpoint.java 6 Apr 2002 16:34:02 - 1.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v
1.1 2002/04/05 17:43:33 costin Exp $
- * $Revision: 1.1 $
- * $Date: 2002/04/05 17:43:33 $
+ * $Header:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v
1.2 2002/04/06 16:34:02 remm Exp $
+ * $Revision: 1.2 $
+ * $Date: 2002/04/06 16:34:02 $
*
*
*
@@ -96,7 +96,8 @@
*/
public class PoolTcpEndpoint { // implements Endpoint {
-private StringManager sm =
StringManager.getManager(org.apache.tomcat.resources);
+private StringManager sm =
+StringManager.getManager(org.apache.tomcat.util.net.res);
private static final int BACKLOG = 100;
private static final int TIMEOUT = 1000;
1.1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res/LocalStrings.properties
Binary file
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
On 5 Apr 2002, Eric Rescorla wrote: Remy Maucherat [EMAIL PROTECTED] writes: On Fri, 5 Apr 2002, Remy Maucherat wrote: I have big doubts the code that calls getSocket() can even work with ajp or pureTLS or other things. Probably a good idea to find where it is and call the right thing ( like getAttribute for certs, etc ). I'm not sure about it, but it doesn't look like client-cert would work with PureTLS. Hmm... I need to dig into this. Why do you think it wouldn't? The way it works - the connector ( or protocol handler ) creates the socket, using plain, jsse, pureTLS. And Remy is saying that some othe valves are calling getSocket() and use the socket/JSSE to extract info ( I assume using JSSE specific code). That is going to fail if PureTLS or Ajp are used. But I don't think we can do anything about it - the method must be deprecated and the code that calls it must be changed to call the right methods ( req.getAttribute() or similar ). BTW, with the new protocol handler - I still haven't implemented the ActionCode to support req.getAttribute. I need a way to pass information up ( all existing ActionCode are passing info from connector to protocol, and I need a way to return info ). After Remy reviews the o.a.t.util.handler.TcHandlerContext, I plan to use the context as a second param in the ActionHook - and use notes to pass/return all informations we need. Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java
remm02/04/06 08:51:50
Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
Log:
- Parse the port attribute.
Revision ChangesPath
1.2 +7 -4
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
Index: Http11Protocol.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- Http11Protocol.java 5 Apr 2002 17:50:39 - 1.1
+++ Http11Protocol.java 6 Apr 2002 16:51:50 - 1.2
@@ -91,12 +91,15 @@
/** Pass config info
*/
public void setAttribute( String name, Object value ) {
+
log.info(setAttribute + name + + value );
-
-if( maxKeepAliveRequests.equals(name) ) {
-//maxKeepAliveRequests=String.intValue((String)value);
+
+if (maxKeepAliveRequests.equals(name)) {
+maxKeepAliveRequests = Integer.parseInt((String) value.toString());
+} else if (port.equals(name)) {
+setPort(Integer.parseInt((String) value.toString()));
}
-
+
}
public Object getAttribute( String key ) {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java CoyoteConnector2.java
remm02/04/06 08:53:04
Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
CoyoteConnector2.java
Log:
- Set the port attribute.
- Use the same note index as the TC 3 adapter to store the Catalina request/response.
Revision ChangesPath
1.2 +5 -5
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java
Index: CoyoteAdapter.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- CoyoteAdapter.java6 Apr 2002 12:24:05 - 1.1
+++ CoyoteAdapter.java6 Apr 2002 16:53:04 - 1.2
@@ -1,6 +1,6 @@
-/* * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java,v
1.1 2002/04/06 12:24:05 remm Exp $
- * $Revision: 1.1 $
- * $Date: 2002/04/06 12:24:05 $
+/* * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java,v
1.2 2002/04/06 16:53:04 remm Exp $
+ * $Revision: 1.2 $
+ * $Date: 2002/04/06 16:53:04 $
*
*
*
@@ -119,7 +119,7 @@
*
* @author Craig R. McClanahan
* @author Remy Maucherat
- * @version $Revision: 1.1 $ $Date: 2002/04/06 12:24:05 $
+ * @version $Revision: 1.2 $ $Date: 2002/04/06 16:53:04 $
*/
final class CoyoteAdapter
@@ -129,7 +129,7 @@
// -- Constants
-public static final int ADAPTER_NOTES = 0;
+public static final int ADAPTER_NOTES = 1;
// --- Constructors
1.2 +6 -5
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector2.java
Index: CoyoteConnector2.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector2.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- CoyoteConnector2.java 6 Apr 2002 12:24:05 - 1.1
+++ CoyoteConnector2.java 6 Apr 2002 16:53:04 - 1.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector2.java,v
1.1 2002/04/06 12:24:05 remm Exp $
- * $Revision: 1.1 $
- * $Date: 2002/04/06 12:24:05 $
+ * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector2.java,v
1.2 2002/04/06 16:53:04 remm Exp $
+ * $Revision: 1.2 $
+ * $Date: 2002/04/06 16:53:04 $
*
*
*
@@ -110,7 +110,7 @@
*
* @author Craig R. McClanahan
* @author Remy Maucherat
- * @version $Revision: 1.1 $ $Date: 2002/04/06 12:24:05 $
+ * @version $Revision: 1.2 $ $Date: 2002/04/06 16:53:04 $
*/
@@ -936,6 +936,7 @@
Class clazz = Class.forName(protocolHandlerClassName);
protocolHandler = (ProtocolHandler) clazz.newInstance();
} catch (Exception e) {
+e.printStackTrace();
throw new LifecycleException
(sm.getString
(coyoteProcessor.processorInstantiationFailed, e));
@@ -943,7 +944,7 @@
protocolHandler.setAdapter(adapter);
// Set attributes
-
+protocolHandler.setAttribute(port, + port);
try {
protocolHandler.init();
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
On 5 Apr 2002, Eric Rescorla wrote: Remy Maucherat [EMAIL PROTECTED] writes: On Fri, 5 Apr 2002, Remy Maucherat wrote: I have big doubts the code that calls getSocket() can even work with ajp or pureTLS or other things. Probably a good idea to find where it is and call the right thing ( like getAttribute for certs, etc ). I'm not sure about it, but it doesn't look like client-cert would work with PureTLS. Hmm... I need to dig into this. Why do you think it wouldn't? The way it works - the connector ( or protocol handler ) creates the socket, using plain, jsse, pureTLS. And Remy is saying that some othe valves are calling getSocket() and use the socket/JSSE to extract info ( I assume using JSSE specific code). That is going to fail if PureTLS or Ajp are used. But I don't think we can do anything about it - the method must be deprecated and the code that calls it must be changed to call the right methods ( req.getAttribute() or similar ). Yes, unfortunately, I don't see a way to make it work. BTW, with the new protocol handler - I still haven't implemented the ActionCode to support req.getAttribute. I need a way to pass information up ( all existing ActionCode are passing info from connector to protocol, and I need a way to return info ). After Remy reviews the o.a.t.util.handler.TcHandlerContext, I plan to use the context as a second param in the ActionHook - and use notes to pass/return all informations we need. I don't like this habit of allowing bad design to live forever. The Action* must go, and be replaced by the TcHandler. The Http11Protocol appears to be working fine with the new Catalina connector, with the exception of the note below. Note: I have a problem implementing getRemoteHost and getRemoteAddr. I don't think it can be done lazily. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk build.xml
costin 02/04/06 08:59:12 Modified:jk build.xml Log: Fix the broken build. It seems Gump calls build.xml for jk. The jk build file used to build all the required deps - util, and soon coyote. I added a target to be used to build jk alone ( called from a main build that makes the whole thing ), and change the default back to calling the other build files. Revision ChangesPath 1.32 +4 -1 jakarta-tomcat-connectors/jk/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.xml,v retrieving revision 1.31 retrieving revision 1.32 diff -u -r1.31 -r1.32 --- build.xml 5 Apr 2002 19:11:42 - 1.31 +++ build.xml 6 Apr 2002 16:59:12 - 1.32 @@ -111,7 +111,10 @@ /target target name=build-main -depends=prepare,report,jkjava,jkant / +depends=prepare,report,jkutil,jkjava,jkant / + +target name=build-jk +depends=prepare,report,jkjava / !-- Building -- -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors build.xml
costin 02/04/06 09:00:24 Modified:.build.xml Log: Call all components in a good order, avoid duplicated builds. Revision ChangesPath 1.3 +2 -2 jakarta-tomcat-connectors/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/build.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- build.xml 5 Apr 2002 19:11:05 - 1.2 +++ build.xml 6 Apr 2002 17:00:24 - 1.3 @@ -11,7 +11,7 @@ ant dir=util / ant dir=coyote target=compile / ant dir=http11 / -ant dir=jk / +ant dir=jk target=build-jk/ jar jarfile=jtc.jar manifest=coyote/src/conf/MANIFEST.MF @@ -36,4 +36,4 @@ delete file=jtc.jar / /target -/project \ No newline at end of file +/project -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java
costin 02/04/06 09:02:47
Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java
Log:
Initial implementation for the coyote ProtocolHandler.
Very early code, not working - I have to implement the callbacks.
Note that all existing jk connectors will be deprecated/removed and merged
with coyote.
Revision ChangesPath
1.3 +46 -18
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java
Index: JkCoyoteHandler.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- JkCoyoteHandler.java 5 Apr 2002 13:37:39 - 1.2
+++ JkCoyoteHandler.java 6 Apr 2002 17:02:47 - 1.3
@@ -76,30 +76,15 @@
/** Plugs Jk2 into Coyote
*/
-public class JkCoyoteHandler implements ProtocolHandler
+public class JkCoyoteHandler extends JkHandler implements ProtocolHandler,
ActionHook
{
-static class ResponseActionHook implements ActionHook {
-public void action(ActionCode actionCode, Object param) {
-if( actionCode==ActionCode.ACTION_COMMIT ) {
-
-}
-if( actionCode==ActionCode.ACTION_RESET ) {
-
-}
-if( actionCode==ActionCode.ACTION_CLOSE ) {
-}
-if( actionCode==ActionCode.ACTION_ACK ) {
-
-}
-}
-}
-
Adapter adapter;
+protected JkMain jkMain=new JkMain();
/** Pass config info
*/
public void setAttribute( String name, Object value ) {
-
+System.out.println(Set attribute + name + + value );
}
public Object getAttribute( String name ) {
@@ -116,16 +101,59 @@
return adapter;
}
+boolean started=false;
+
/** Start the protocol
*/
public void init() {
+if( started ) return;
+started=true;
+jkMain.getWorkerEnv().addHandler(container, this );
+
+try {
+jkMain.init();
+jkMain.start();
+} catch( Exception ex ) {
+ex.printStackTrace();
+}
}
public void destroy() {
+// jkMain.stop();
+}
+
+// Jk Handler mehod
+public int invoke( Msg msg, MsgContext ep )
+throws IOException
+{
+System.out.println(XXX Invoke );
+org.apache.coyote.Request req=(org.apache.coyote.Request)ep.getRequest();
+org.apache.coyote.Response res=req.getResponse();
+res.setHook( this );
+try {
+adapter.service( req, res );
+} catch( Exception ex ) {
+ex.printStackTrace();
+}
+return OK;
}
+public void action(ActionCode actionCode, Object param) {
+System.out.println(XXX Action + actionCode + + param );
+if( actionCode==ActionCode.ACTION_COMMIT ) {
+
+}
+if( actionCode==ActionCode.ACTION_RESET ) {
+
+}
+if( actionCode==ActionCode.ACTION_CLOSE ) {
+}
+if( actionCode==ActionCode.ACTION_ACK ) {
+
+}
+}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
Remy Maucherat [EMAIL PROTECTED] writes: The way it works - the connector ( or protocol handler ) creates the socket, using plain, jsse, pureTLS. And Remy is saying that some othe valves are calling getSocket() and use the socket/JSSE to extract info ( I assume using JSSE specific code). That is going to fail if PureTLS or Ajp are used. But I don't think we can do anything about it - the method must be deprecated and the code that calls it must be changed to call the right methods ( req.getAttribute() or similar ). Yes, unfortunately, I don't see a way to make it work. Yes, it sounds like the calling code will have to change. How bad will that be? -Ekr -- [Eric Rescorla [EMAIL PROTECTED]] http://www.rtfm.com/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java
costin 02/04/06 09:57:35
Modified:coyote/src/java/org/apache/coyote Request.java
Log:
Remy, I changed the fields from protected to private - the class
is declared final, so protected doesn't make too much sense.
Also added a response field - they work in pair and it's easier
for recycling to store only one reference instead of 2.
Revision ChangesPath
1.10 +38 -27
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java
Index: Request.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- Request.java 4 Apr 2002 22:29:53 - 1.9
+++ Request.java 6 Apr 2002 17:57:35 - 1.10
@@ -127,61 +127,62 @@
// - Instance Variables
-protected int serverPort = -1;
-protected MessageBytes serverNameMB = new MessageBytes();
+private int serverPort = -1;
+private MessageBytes serverNameMB = new MessageBytes();
-protected String localHost;
+private String localHost;
-protected MessageBytes schemeMB = new MessageBytes();
+private MessageBytes schemeMB = new MessageBytes();
-protected MessageBytes methodMB = new MessageBytes();
-protected MessageBytes unparsedURIMB = new MessageBytes();
-protected MessageBytes uriMB = new MessageBytes();
-protected MessageBytes decodedUriMB = new MessageBytes();
-protected MessageBytes queryMB = new MessageBytes();
-protected MessageBytes protoMB = new MessageBytes();
+private MessageBytes methodMB = new MessageBytes();
+private MessageBytes unparsedURIMB = new MessageBytes();
+private MessageBytes uriMB = new MessageBytes();
+private MessageBytes decodedUriMB = new MessageBytes();
+private MessageBytes queryMB = new MessageBytes();
+private MessageBytes protoMB = new MessageBytes();
// remote address/host
-protected MessageBytes remoteAddrMB = new MessageBytes();
-protected MessageBytes remoteHostMB = new MessageBytes();
+private MessageBytes remoteAddrMB = new MessageBytes();
+private MessageBytes remoteHostMB = new MessageBytes();
-protected MimeHeaders headers = new MimeHeaders();
+private MimeHeaders headers = new MimeHeaders();
-protected MessageBytes instanceId = new MessageBytes();
+private MessageBytes instanceId = new MessageBytes();
/**
* Notes.
*/
-protected Object notes[] = new Object[Constants.MAX_NOTES];
+private Object notes[] = new Object[Constants.MAX_NOTES];
/**
* Associated input buffer.
*/
-protected InputBuffer inputBuffer = null;
+private InputBuffer inputBuffer = null;
/**
* URL decoder.
*/
-protected UDecoder urlDecoder = new UDecoder();
+private UDecoder urlDecoder = new UDecoder();
/**
* HTTP specific fields. (remove them ?)
*/
-protected int contentLength = -1;
+private int contentLength = -1;
// how much body we still have to read.
-protected int available = -1;
-protected MessageBytes contentTypeMB = null;
-protected String charEncoding = null;
-protected Cookies cookies = new Cookies(headers);
-protected Parameters parameters = new Parameters();
-
-protected MessageBytes remoteUser=new MessageBytes();
-protected MessageBytes authType=new MessageBytes();
-protected Hashtable attributes=new Hashtable();
+private int available = -1;
+private MessageBytes contentTypeMB = null;
+private String charEncoding = null;
+private Cookies cookies = new Cookies(headers);
+private Parameters parameters = new Parameters();
+
+private MessageBytes remoteUser=new MessageBytes();
+private MessageBytes authType=new MessageBytes();
+private Hashtable attributes=new Hashtable();
+private Response response;
// - Properties
@@ -345,6 +346,16 @@
return headers.getHeader(name);
}
+// Associated response
+
+public Response getResponse() {
+return response;
+}
+
+public void setResponse( Response response ) {
+this.response=response;
+}
+
// Cookies
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
