DO NOT REPLY [Bug 11115] New: - Shell scripts not executable

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5

Shell scripts not executable

   Summary: Shell scripts not executable
   Product: Tomcat 3
   Version: 3.3.x Nightly
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

In the nightly binaries, the bin/* shell scripts are not executable.

--Jeff

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 6088] - Too many custom tags?

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6088.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6088

Too many custom tags?





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 06:49 ---
FYI, a workaround for this was added to Jasper2:

[4.1.4] Generator:
Fix the limitation on the number of tags which can be used within a
single page, which was cause by the 64K bytecode limit for a sigle
method. Now Jasper generates separate methods for tag bodies when lots
of tags are used.

http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.1.7-beta/RELEASE-NOTES

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11115] - Shell scripts not executable

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5

Shell scripts not executable





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 07:11 ---
Something must have gone wrong with the packaging. build.xml seems to be correct...

Bojan

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11116] New: - Coyote connector hangs, test connector doesnt.

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6

Coyote connector hangs, test connector doesnt.

   Summary: Coyote connector hangs, test connector doesnt.
   Product: Tomcat 4
   Version: 4.1.7
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Some strange behavior with the Coyote connector.  When Tomcat first starts up, 
things go OK, but then after accessing a few pages the site will hang.  When 
I switched back to the HTTP1.1 test connection, this behavior disappears.  A 
couple clues:  The duration of the hang was exactly the length of the 
connection timeout I had set.  I set the connectionTimeout to 60 seconds -- 
hang for 60 seconds until I recieved a response.  Then I set it for 3 seconds 
and it took 3 seconds for Tomcat to respond.  Furthermore this behavior only 
happens on the basic-authentication part of my site.  Pages with no 
authentication at all do not hang.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




[connectors] compile error on jk_jni_aprImpl.c

2002-07-24 Thread Dev Zero G Ltd

PLEASE help, I've batting with this one for 2 days solid now

What should I do with this? Submit it as a bug? Or am I doing something 
wrong?

Freebsd 4.4, Apache 2.0.39, Tomcat 4.0.4, jakarta-tomcat-connectors 
sources from cvs, i.e. latest..

Mike

--- snip ---
Compiling /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
[so] Compile failed 1 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
[so] Command:libtool --mode=compile cc -c -o 
/usr/tmp/jakarta-tomcat-connectors/jk/build/jk2/apache2/jni/jk_jni_aprImpl.o 
-I/usr/tmp/jakarta-tomcat-connectors/jk/native2/common 
-I/usr/local/apache2/include -I/usr/local/apache2/include 
-I/usr/local/apache2/include 
-I/usr/tmp/jakarta-tomcat-connectors/jk/native2/include 
-I/usr/local/linux-jdk1.4.0/jre/../include 
-I/usr/local/linux-jdk1.4.0/jre/../include/linux -g -W -D_REENTRANT 
-DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR -DHAVE_JNI 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
[so] Output:
[so] mkdir 
/usr/tmp/jakarta-tomcat-connectors/jk/build/jk2/apache2/jni/.libs
[so] cc -c 
-I/usr/tmp/jakarta-tomcat-connectors/jk/native2/common 
-I/usr/local/apache2/include -I/usr/local/apache2/include 
-I/usr/local/apache2/include 
-I/usr/tmp/jakarta-tomcat-connectors/jk/native2/include 
-I/usr/local/linux-jdk1.4.0/jre/../include 
-I/usr/local/linux-jdk1.4.0/jre/../include/linux -g -W -D_REENTRANT 
-DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR -DHAVE_JNI 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c 
-fPIC -DPIC -o 
/usr/tmp/jakarta-tomcat-connectors/jk/build/jk2/apache2/jni/.libs/jk_jni_aprImpl.lo
[so] StdErr:
[so] In file included from 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_env.h:71,
[so]  from 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_pool.h:67,
[so]  from 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_map.h:67,
[so]  from 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c:78:
[so] 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_mutex.h:122: 
syntax error before `apr_thread_mutex_t'

BUILD FAILED
file:/usr/tmp/jakarta-tomcat-connectors/jk/native2/build.xml:276: 
Compile failed 
/usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [connectors] compile error on jk_jni_aprImpl.c

2002-07-24 Thread Bojan Smojver

Try running:

./buildconf.sh
./configure --apxs2=/path/to/apxs

and then just dump the mod_jk2.so (should be in jk/build/jk2/apache2)
into your Apache *.so directory, apply the appropriate LoadModule and
you should be set.

I had problems building with ant too...

Bojan

On Wed, 2002-07-24 at 17:24, Dev Zero G Ltd wrote:
 PLEASE help, I've batting with this one for 2 days solid now
 
 What should I do with this? Submit it as a bug? Or am I doing something 
 wrong?
 
 Freebsd 4.4, Apache 2.0.39, Tomcat 4.0.4, jakarta-tomcat-connectors 
 sources from cvs, i.e. latest..
 
 Mike
 
 --- snip ---
 Compiling /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
 [so] Compile failed 1 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
 [so] Command:libtool --mode=compile cc -c -o 
 /usr/tmp/jakarta-tomcat-connectors/jk/build/jk2/apache2/jni/jk_jni_aprImpl.o 
 -I/usr/tmp/jakarta-tomcat-connectors/jk/native2/common 
 -I/usr/local/apache2/include -I/usr/local/apache2/include 
 -I/usr/local/apache2/include 
 -I/usr/tmp/jakarta-tomcat-connectors/jk/native2/include 
 -I/usr/local/linux-jdk1.4.0/jre/../include 
 -I/usr/local/linux-jdk1.4.0/jre/../include/linux -g -W -D_REENTRANT 
 -DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR -DHAVE_JNI 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
 [so] Output:
 [so] mkdir 
 /usr/tmp/jakarta-tomcat-connectors/jk/build/jk2/apache2/jni/.libs
 [so] cc -c 
 -I/usr/tmp/jakarta-tomcat-connectors/jk/native2/common 
 -I/usr/local/apache2/include -I/usr/local/apache2/include 
 -I/usr/local/apache2/include 
 -I/usr/tmp/jakarta-tomcat-connectors/jk/native2/include 
 -I/usr/local/linux-jdk1.4.0/jre/../include 
 -I/usr/local/linux-jdk1.4.0/jre/../include/linux -g -W -D_REENTRANT 
 -DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR -DHAVE_JNI 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c 
 -fPIC -DPIC -o 
 /usr/tmp/jakarta-tomcat-connectors/jk/build/jk2/apache2/jni/.libs/jk_jni_aprImpl.lo
 [so] StdErr:
 [so] In file included from 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_env.h:71,
 [so]  from 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_pool.h:67,
 [so]  from 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_map.h:67,
 [so]  from 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c:78:
 [so] 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/include/jk_mutex.h:122: 
 syntax error before `apr_thread_mutex_t'
 
 BUILD FAILED
 file:/usr/tmp/jakarta-tomcat-connectors/jk/native2/build.xml:276: 
 Compile failed 
 /usr/tmp/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11116] - Coyote connector hangs, test connector doesnt.

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6

Coyote connector hangs, test connector doesnt.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 07:42 ---
Using the manager works for me (it uses BASIC), using a standards compliant
browser. Non compliant user-agents may not work.
If you want to reopen the bug, you'll have to submit an HTTP traffic capture
which shows invalid responses being generated.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11117] New: - Coyote connector does not correctly deal with large PUT when using chunked transfer encoding

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7

Coyote connector does not correctly deal with large PUT when using chunked transfer 
encoding

   Summary: Coyote connector does not correctly deal with large PUT
when using chunked transfer encoding
   Product: Tomcat 4
   Version: 4.1.7
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Major
  Priority: Other
 Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I've built a small test servlet (included below) that shows this behaviour.

If I upload data to tomcat (configured to use the HTTP/1.1 Coyote connector)
using a chunked transfer-encoding on a PUT, then the result (i.e. what I read
using the servlet's request.getInputStream() is corrupted.

This _only_ happens on large PUTs (it happens every time I tried it (about 10)
on a large PUT - I was testing with something around 700 kB, and another thing
of about 1 MB, but does NOT always corrupt it in the same way. I did not see any
corruption on small files (~50 kB and smaller), though I didn't test this
extensively.

The total length of the data read is exactly correct (712080 bytes in my first
test). At the first point of corruption in the file, a chunk header appears in
the output (\r\n1000\r\n) followed by correct data from about 700 bytes later
on, then a second copy (in the correct place, I think) of the corrupt data (i.e.
correct data, followed by the chunk header, followed by some data repeated, the
second instance of which is in the correct place - so the first instance is
being produced _instead_ of the correct data for that point in the input).

Test servlet follows:

import java.io.*;

import javax.servlet.*;
import javax.servlet.http.*;

public class Test extends HttpServlet
{

public void doPut(HttpServletRequest req, HttpServletResponse res)
throws ServletException, IOException
{
FileOutputStream fos = new FileOutputStream(/tmp/servlet-out);

InputStream is = req.getInputStream();

byte buf[] = new byte[2000];
int ret;

while((ret = is.read(buf))  0) {
fos.write(buf, 0, ret);
}

fos.close();
is.close();

PrintWriter pw = res.getWriter();
pw.println(Done);
pw.flush();
pw.close();
}
}

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11117] - Coyote connector does not correctly deal with large PUT when using chunked transfer encoding

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7

Coyote connector does not correctly deal with large PUT when using chunked transfer 
encoding





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 08:02 ---
Assuming that there's indeed a bug, this will be triggered by how the client
generates the chunks (I can translate by: thanks for attaching a test servlet,
but what I actually need is the client).

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11045] - Jikes compiler output appears in catalina.out not browser

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11045.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11045

Jikes compiler output appears in catalina.out not browser





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 08:05 ---
There's a compiler init param which is used to specify an external compiler,
but what it actually does is pass that to Ant. For the avarage user, it looks
almost the same as before, I think, so I don't see much to document.

(BTW, it would be nice to have one day some basic documentation on Jasper)

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_jk2

2002-07-24 Thread Henri Gomez

Quoting Dev Zero G Ltd [EMAIL PROTECTED]:

 Hello and thanks for reading!
 
 Trying to build mod_jk2 for Tomcat4 and Apache2... with huge problems :( 
 Having gotten this far, I have this compile problem:
 
 apache 2.0.39; freebsd 4.4 i386; conne4ctors 4.0.4
 
  snip 
 [so] In file included from 
 /usr/tmp/jakarta-tomcat-connectors-4.0.4-src/jk/native2/include/jk_env.h:71,
 [so] from 
 /usr/tmp/jakarta-tomcat-connectors-4.0.4-src/jk/native2/include/jk_pool.h:67,
 [so] from 
 /usr/tmp/jakarta-tomcat-connectors-4.0.4-src/jk/native2/common/jk_uriMap.c:73:
 [so] 
 /usr/tmp/jakarta-tomcat-connectors-4.0.4-src/jk/native2/include/jk_mutex.h:122:
 
 syntax error before `apr_thread_mutex_t'
 
 BUILD FAILED
 file:/usr/tmp/jakarta-tomcat-connectors-4.0.4-src/jk/native2/build.xml:276: 
 Compile failed 
 /usr/tmp/jakarta-tomcat-connectors-4.0.4-src/jk/native2/common/jk_uriMap.c
  snip 
 
 one of the main problems is that apache 2 installs into several 
 directories under freebsd ports, and the connector compile script 
 expects it to go into just one - apache2/ ...

There is options in the latest configure for mod_jk2 to adapt to your layout,
for example it match my apache 2.x rpm which install in many directories :)



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [VOTE]: Re: cvs commit:jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2002-07-24 Thread Henri Gomez

  I can live with any but the first.  It would be nice to have it as a
 config
  option however.  JkOptions is probably fine for 1.2.  Not sure where it
  should be set in Jk2.
 
 Thanks. I'm not sure about mod_jk2 either. The latest reports show that
 the code still doesn't work.

Great to have it in jk 1.2.x.

BTW, what's the default behaviour ?


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [VOTE]: Re: cvscommit:jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2002-07-24 Thread Bojan Smojver

On Wed, 2002-07-24 at 18:26, Henri Gomez wrote:
   I can live with any but the first.  It would be nice to have it as a
  config
   option however.  JkOptions is probably fine for 1.2.  Not sure where it
   should be set in Jk2.
  
  Thanks. I'm not sure about mod_jk2 either. The latest reports show that
  the code still doesn't work.
 
 Great to have it in jk 1.2.x.
 
 BTW, what's the default behaviour ?

Default is to let Apache do it's thing.

Bojan


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 10629] - include directive fails when referencing Parent Path within a WAR

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10629.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10629

include directive fails when referencing Parent Path within a WAR

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   Severity|Normal  |Major

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspCompilationContext.java

2002-07-24 Thread remm

remm2002/07/24 02:08:36

  Modified:jasper2/src/share/org/apache/jasper Tag: tomcat_4_branch
JspCompilationContext.java
  Log:
  - Canonicalize result of getResource and getResourceAsStream.
  - Fixes 10629.
  - Patch submitted by Andrew Conrad andrewconrad at msn.com
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.6.2.3   +5 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java
  
  Index: JspCompilationContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v
  retrieving revision 1.6.2.2
  retrieving revision 1.6.2.3
  diff -u -r1.6.2.2 -r1.6.2.3
  --- JspCompilationContext.java18 Jul 2002 20:48:19 -  1.6.2.2
  +++ JspCompilationContext.java24 Jul 2002 09:08:36 -  1.6.2.3
  @@ -227,12 +227,12 @@
* as an InputStream.
*/
   public java.io.InputStream getResourceAsStream(String res) {
  -return context.getResourceAsStream(res);
  +return context.getResourceAsStream(canonicalURI(res));
   }
   
   
   public URL getResource(String res) throws MalformedURLException {
  -return context.getResource(res);
  +return context.getResource(canonicalURI(res));
   }
   
   /** 
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspCompilationContext.java

2002-07-24 Thread remm

remm2002/07/24 02:09:47

  Modified:jasper2/src/share/org/apache/jasper
JspCompilationContext.java
  Log:
  - Canonicalize result of getResource and getResourceAsStream.
  - Fixes 10629.
  - Patch submitted by Andrew Conrad andrewconrad at msn.com
  
  Revision  ChangesPath
  1.9   +5 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java
  
  Index: JspCompilationContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- JspCompilationContext.java18 Jul 2002 20:48:00 -  1.8
  +++ JspCompilationContext.java24 Jul 2002 09:09:47 -  1.9
  @@ -227,12 +227,12 @@
* as an InputStream.
*/
   public java.io.InputStream getResourceAsStream(String res) {
  -return context.getResourceAsStream(res);
  +return context.getResourceAsStream(canonicalURI(res));
   }
   
   
   public URL getResource(String res) throws MalformedURLException {
  -return context.getResource(res);
  +return context.getResource(canonicalURI(res));
   }
   
   /** 
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 10629] - include directive fails when referencing Parent Path within a WAR

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10629.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10629

include directive fails when referencing Parent Path within a WAR

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 09:10 ---
I've applied the patch.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-4.0/webapps/ROOT index.jsp

2002-07-24 Thread remm

remm2002/07/24 04:28:02

  Modified:webapps/ROOT index.jsp
  Log:
  - Mention that special roles are needed to use the admin and manager webapp.
This should hopefully avoid lots of questions on tomcat-user.
  
  Revision  ChangesPath
  1.6   +7 -9  jakarta-tomcat-4.0/webapps/ROOT/index.jsp
  
  Index: index.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/ROOT/index.jsp,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- index.jsp 13 Jun 2002 17:38:28 -  1.5
  +++ index.jsp 24 Jul 2002 11:28:02 -  1.6
  @@ -150,20 +150,18 @@
   
   pwhere $CATALINA_HOME is the root of the Tomcat installation 
directory. If you're seeing this page, and you don't think you should be, then either 
you're either a user who has arrived at new installation of Tomcat, or you're an 
administrator who hasn't got his/her setup quite right. Providing the latter is the 
case, please refer to the a href=tomcat-docsTomcat Documentation/a for more 
detailed setup and administration information than is found in the INSTALL file./p
   
  -pIncluded with this release are a host of sample Servlets and JSPs 
(with associated source code), extensive documentation (including the Servlet 2.3 and 
JSP 1.2 API JavaDoc), and an introductory guide to developing web applications./p
  -
  -pYou can find more information about the JSP and Servlet technologies 
by subscribing to one or more of the following Servlet and JSP related interest 
lists:/p
  +pbNOTE: For security reasons, using the administration webapp 
  +is restricted to users with role admin. The manager webapp 
  +is restricted to users with role manager./b
  +Users are defined in 
code$CATALINA_HOME/conf/tomcat-users.xml/code./p
   
  -ul
  -liba href=mailto:[EMAIL PROTECTED]?subject=subscription 
request: jsp-interestbody=subscribe jsp-interest [Your Full 
Name][EMAIL PROTECTED]/a/b/li
  -liba href=mailto:[EMAIL PROTECTED]?subject=subscription 
request: servlet-interestbody=subscribe servlet-interest [Your Full 
Name][EMAIL PROTECTED]/a/b/li
  -/ul
  +pIncluded with this release are a host of sample Servlets and JSPs 
(with associated source code), extensive documentation (including the Servlet 2.3 and 
JSP 1.2 API JavaDoc), and an introductory guide to developing web applications./p
   
  -pIn addition, Tomcat-specific mailing lists are available at the 
Jakarta project web site:/p
  +pTomcat mailing lists are available at the Jakarta project web 
site:/p
   
  ul
  -   liba 
href=mailto:[EMAIL PROTECTED];[EMAIL PROTECTED]/a/b
 for developers working on Tomcat/li
  liba 
href=mailto:[EMAIL PROTECTED];[EMAIL PROTECTED]/a/b
 for general questions related to configuring and using Tomcat/li
  +   liba 
href=mailto:[EMAIL PROTECTED];[EMAIL PROTECTED]/a/b
 for developers working on Tomcat/li
  /ul
   
   pThanks for using Tomcat!/p
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 mod_jk.c

2002-07-24 Thread bojan

bojan   2002/07/24 04:38:13

  Modified:jk/native/apache-1.3 mod_jk.c
  Log:
  Introduce ForwardDirectories option into mod_jk for Apache 1.3.x, for
  compatibility with Apache 2.x version. Does nothing for now.
  
  Revision  ChangesPath
  1.28  +5 -1  jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- mod_jk.c  12 Jun 2002 15:51:48 -  1.27
  +++ mod_jk.c  24 Jul 2002 11:38:13 -  1.28
  @@ -1299,6 +1299,7 @@
*  ForwardURICompat = Forward URI normally, less spec compliant but 
mod_rewrite compatible (old TC)
*  ForwardURICompatUnparsed = Forward URI as unparsed, spec compliant but broke 
mod_rewrite (old TC)
*  ForwardURIEscaped= Forward URI escaped and Tomcat (3.3 rc2) stuff will 
do the decoding part
  + *  ForwardDirectories   = Forward all directory requests with no index files 
to Tomcat
*/
   
   const char *jk_set_options(cmd_parms *cmd,
  @@ -1338,6 +1339,9 @@
   else if (!strcasecmp(w, ForwardURIEscaped)) {
   opt = JK_OPT_FWDURIESCAPED;
   mask = JK_OPT_FWDURIMASK;
  +}
  +else if (!strcasecmp(w, ForwardDirectories)) {
  +opt = JK_OPT_FWDDIRS;
   }
   else
   return ap_pstrcat(cmd-pool, JkOptions: Illegal option ', w, ', 
NULL);
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 10789] - Setting DirectoryIndex of index.jsp does not get served by jk2

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789

Setting DirectoryIndex of index.jsp does not get served by jk2





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 13:29 ---
Bojan,

I just rebuilt mod_jk2 with the latest sources.  My 'quick' test shows it to 
be working.  Both some directories directly under my Apache document root and 
some of my aliased directories are having the index.jsp file picked up and 
served.  This evening I will try to test it a little more thoroughly.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




bug #11043

2002-07-24 Thread peter lin


http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11043

hey remmy,


I was thinking of debugging the bug I reported earlier this week.  Can
you give me any tips as to where to look, so that I can fix it and
submit a patch for it this weekend?


thanks


peter lin

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11128] New: - ServletContext memory leak

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11128.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11128

ServletContext memory leak

   Summary: ServletContext memory leak
   Product: Tomcat 4
   Version: 4.0.4 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Major
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


After removing a web-app, the servlet context stays around, together with
all context attributes, etc.

My profiler shows static references from org.apache.naming.ContextBinding.

The reason is, that org.apache.catalina.StandardContext does the contextBinding
BEFORE the thread context classloader has been set, i.e. the classloader used as
key is NOT the web app classloader that is later used for unbind.

I propose moving #bindThread() directly after setting the loader.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11128] - ServletContext memory leak

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11128.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11128

ServletContext memory leak





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 14:28 ---
Additionally, ContextBindings.unbindContext(this, this) must be called in #stop().
Also, JSPServlet should not create a DefaultLogger(servletContext) because that
context will also be held forever.

Cheers
Matthias

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11129] New: - New valve for putting the sessionIDs in the requestURI

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11129.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11129

New valve for putting the sessionIDs in the requestURI

   Summary: New valve for putting the sessionIDs in the requestURI
   Product: Tomcat 4
   Version: 4.1.8
  Platform: All
   URL: http://entity38.de/develop/SIDValve/
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The idea behind this valve ist to encode the session id at the beginning of the 
requestURI as if the session id were a directory: 
http://localhost:8080/SID414B8C73851AB59D04DEC5A4A79AF0B3/examples/test.jsp 

The advantage over the response.encodeURL() method is a) you don't have to 
encode every url by hand and b) it also works with html pages as long as you 
only use relative links. An other advantage is, that this pages are certainly 
not cached, even by older proxy caches like wingate and you don't need cookies.

This valve only filters the the sessionID out of the requestURI and sets it in 
the request. To get the sessionID into the requestURI you have to insert the 
following code at the beginnig of every jsp-page (e.g. with an jsp-include). 

 if(session.isNew()) {
String uri = /SID + session.getId() + request.getRequestURI();
response.sendRedirect(uri);
return;
 }

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11129] - New valve for putting the sessionIDs in the requestURI

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11129.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11129

New valve for putting the sessionIDs in the requestURI





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 14:46 ---
Created an attachment (id=2467)
The code for the valve

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-catalina/etc - New directory

2002-07-24 Thread remm

remm2002/07/24 08:55:11

  jakarta-tomcat-catalina/etc - New directory

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Help please: DirContextURLStreamHandler/Jasper question and possible bug...

2002-07-24 Thread Richard Frazer

I'm running with Tomcat 4.1 and am seeing the following problem (and have
actually been seeing the problem since 4.0.4):

Jasper relies on the fact that the DirContext is bound in
DirContextURLStreamHandler based on the app classloader.  This is bound when
the StandardContext is started, stopped, or reloaded.  The code in Jasper
that relies on it is the TagLibraryInfoImpl class.  It uses a
JarURLConnection which in turn uses DirContextURLStreamHandler to lookup the
DirContext based on Thread.currentThread().getContextClassloader().

This all works fine as long as the DirContext stays bound to the
DirContextURLStreamHandler for the lifetime of the application. However, the
DirContext gets unbound if another app is started later on on the same
thread as the first app.  If you look in StandardContext.start(), the code
looks like this:

// Binding thread
oldCCL = bindThread();
.
.
.
unbindThread(oldCCL);

The unbindThread method unbinds the DirContext from the
DirContextURLStreamHandler.  Why would the StandardContext.start() method
unbind a classloader from DirContextURLStreamHandler when it doesn't even
know whether it's still in use?

I'm by no means an expert here, so there may be something fairly obvious
that I'm missing.  Please help.

Thanks,
Richard



bug(s) in WebappClassLoader ? I need your knowledge

2002-07-24 Thread Gattaz, Olivier


Bonjour,

I found a bug in the class org.apache.catalina.loader.WebappClassLoader:

The method findClassInternal cannot return null when the required class
is not in one of the local repositories but in one of the external
repositories. 
This implies that the call to super.findClass(name);  in the method
findClass(String name) (line 954) cannot be done.

I try to use the capabitity of standard WebappClassLoader to add an
external repository to be able to load shared classes stored in a folder
out side of the WEB-INF/classes folder tree.

To minimize the dependence between my WebApp and catalina, I use the
reflexion to call upon the method addDirectory(String aRepository).

See behind :
- the config of my workstation.
- the log found in the stdout of tomcat
- the source code of my method which add an external repository in the
WebAppClassLoader.


I think that I found an other bug but I do'nt know where it is (...) :  
Before using the reflexion, I tried to write a extend of the catalina
WebappClassLoader but when you set a Loader tag in the config file
server.xml like the followed one, the created loader is an instance of
com.adonix.x3.x3web.tomcat.loader.CAdapiLoader, but the associated
classLoader is an instance of org.apache.catalina.loader.WebappClassLoader
and not an instance of
com.adonix.x3.x3web.tomcat.loader.CAdapiClassLoader !

Loader
className=com.adonix.x3.x3web.tomcat.loader.CAdapiLoader
delegate=false 
reloadable=false 
checkInterval=15 
debug=9 
 
loaderClass=com.adonix.x3.x3web.tomcat.loader.CAdapiClassLoader  /

Craig and Remy could be the best to answer me ?  

Note: I put at the end of this contribution the two exchanges of mall which
I had yesterday with Craig to illustrate the context of my developments

Thanks a lot in advance.

Olivier Gattaz 


Adonix - 5 avenue Victor Hugo - 38130 Echirolles - France


My plaform :
 - W2000 SP2
 - Apache httpd 2.0.39 + Mod_jk
 - Sun JDK 1.3.1_03
 - Tomcat 4.0.4 running like a service and configured for
   multiple instances by setting $CATALINA_BASE
   - set CATALINA_LOG=D:\Adonix\X3Web\data\SERVERSLOGS\TOMCAT
   - set CATALINA_HOME=C:\Program Files\Apache Tomcat 4.0
   - set CATALINA_BASE=C:\Program files\Adonix\X3Web\SERVERS_BASE
   - set JAVA_HOME=C:\jdk1.3.1_03

Log in the stdout (debug=9)

WebappClassLoader:
loadClass(com.adonix.adapidatasources.gx3app.screen.rec.CAdapiRecEWK2WEB3D,
false)
WebappClassLoader:   Searching local repositories
WebappClassLoader:
findClass(com.adonix.adapidatasources.gx3app.screen.rec.CAdapiRecEWK2WEB3D)
WebappClassLoader:
findClassInternal(com.adonix.adapidatasources.gx3app.screen.rec.CAdapiRecEWK
2WEB3D)
WebappClassLoader: -- Passing on ClassNotFoundException
java.lang.ClassNotFoundException:
com.adonix.adapidatasources.gx3app.screen.rec.CAdapiRecEWK2WEB3D
at
org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLo
ader.java:1586)
at
org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.jav
a:937)
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.jav
a:1372)
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.jav
a:1254)
at
java.lang.ClassLoader.loadClassInternal(ClassLoader.java:310)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:115)
at
com.adonix.adapi.CAdapiRecord.instanciateRecord(CAdapiRecord.java:885)
at
com.adonix.adapi.CAdapiRecord.instanciateRecord(CAdapiRecord.java:819)
at
com.adonix.adapi.protocol.CAdapiSeg.addData(CAdapiSeg.java:187)
at
com.adonix.adapi.protocol.CAdapiConn.readSeg(CAdapiConn.java:534)
at
com.adonix.adapi.protocol.CAdapiConn.run(CAdapiConn.java:701)
WebappClassLoader:   Delegating to parent classloader




Source of my method setClassLoader, 


//
private static String CATALINA_LOADER =
org.apache.catalina.loader.WebappClassLoader;
private static String CATALINA_LOADER_METHOD_ADDREP =
addRepository;
private static String CATALINA_LOADER_METHOD_GETURLS = getURLs;

//
/**
* invoke the method public void addRepository(String repository)
* if it is an instance of
org.apache.catalina.loader.WebappClassLoader
*/
private void setClassLoader(String aRepository) throws
ServletException
{
ClassLoader 

TLD's in jars don't work (was: RE: Help please: DirContextURLStreamHandler/Jasper question and possible bug...)

2002-07-24 Thread Richard Frazer

It occurs to me that I didn't explain very well how this problem manifests
itself.  The problem occurs when you have a tld inside a jar file.  Here's
the scenario:

App 1:
1. Request for App1 comes into the server
2. Request is assigned to thread1.
3. App1 is loaded on thread1.
4. Request is processed on thread1

App2:
5. Request for App2 comes into the server
6. Request is assigned to thread1.
7. App2 is loaded on thread1.
8. Request is processed on thread1.

Now, if the request for App2 is for an uncompiled jsp that uses a tld that
is stored in a jar file under WEB-INF/lib, an exception is thrown.  The
exception is thrown from DirContextURLStreamHandler.get().

Here's the top of the stack:

java.lang.IllegalStateException: Illegal class loader binding at
org.apache.naming.resources.DirContextURLStreamHandler.getDirContextURLStrea
mHandler.java:246) 
at
org.apache.naming.resources.DirContextURLStreamHandler.openConnection(DirCon
textURLStreamHandler.java:134) 
at java.net.URL.openConnection(URL.java:938) 
at
sun.net.www.protocol.jar.JarURLConnection.init(JarURLConnection.java:64)
at sun.net.www.protocol.jar.Handler.openConnection(Handler.java:24)
at java.net.URL.openConnection(URL.java:938)
at
org.apache.jasper.compiler.TagLibraryInfoImpl.init(TagLibraryInfoImpl.java
:209) 
at org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:358)
at org.apache.jasper.compiler.Parser.parseDirective(Parser.java:385)
at org.apache.jasper.compiler.Parser.parseElements(Parser.java:794)
at org.apache.jasper.compiler.Parser.parse(Parser.java:122) 

I would like to fix this problem and submit a patch, but I don't know if the
correct solution is to not have StandardContext.start() for App2 unbind
App1's DirContext, or to bind the DirContext for every request.

Thanks in advance.
Richard

-Original Message-
From: Richard Frazer [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, July 24, 2002 12:18 PM
To: Tomcat-Dev (E-mail)
Subject: Help please: DirContextURLStreamHandler/Jasper question and
possi ble bug...


I'm running with Tomcat 4.1 and am seeing the following problem (and have
actually been seeing the problem since 4.0.4):

Jasper relies on the fact that the DirContext is bound in
DirContextURLStreamHandler based on the app classloader.  This is bound when
the StandardContext is started, stopped, or reloaded.  The code in Jasper
that relies on it is the TagLibraryInfoImpl class.  It uses a
JarURLConnection which in turn uses DirContextURLStreamHandler to lookup the
DirContext based on Thread.currentThread().getContextClassloader().

This all works fine as long as the DirContext stays bound to the
DirContextURLStreamHandler for the lifetime of the application. However, the
DirContext gets unbound if another app is started later on on the same
thread as the first app.  If you look in StandardContext.start(), the code
looks like this:

// Binding thread
oldCCL = bindThread();
.
.
.
unbindThread(oldCCL);

The unbindThread method unbinds the DirContext from the
DirContextURLStreamHandler.  Why would the StandardContext.start() method
unbind a classloader from DirContextURLStreamHandler when it doesn't even
know whether it's still in use?

I'm by no means an expert here, so there may be something fairly obvious
that I'm missing.  Please help.

Thanks,
Richard



DO NOT REPLY [Bug 11137] New: - POST operation fails with many textboxes in form

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137

POST operation fails with many textboxes in form

   Summary: POST operation fails with many textboxes in form
   Product: Tomcat 3
   Version: 3.3.1 Final
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Using Tomcat 3.3.1 final and JDK 1.3 under Windows XP, a POST operation that 
submits the values of many textboxes to an HttpServlet subclass will fail.  
The POST operation in the servlet is called, but after it completes, 
a network connection error occurs (presumably the connection is simply 
rudely severed).  The odd time the operation succeeds and proper output is 
displayed.  The percentage of time that the operation fails is directly 
proportional to the number of textboxes on the form.

This occurs using both IE and Netscape (IE either hangs or reports page not 
found, Netscape reports Network connection failure), but only seems to occur 
under Windows XP (tested on both Win 98 and Win XP) -- under Windows 98 the 
problem could not be reproduced.  The java environment was identical in both 
cases.

A simple test case is provided:

-testpostbug.java-8---
import javax.servlet.http.*;
import java.io.PrintWriter;
import java.util.*;

 public class testpostbug extends javax.servlet.http.HttpServlet
 {
protected void doGet(HttpServletRequest req,HttpServletResponse resp) 
throws javax.servlet.ServletException, java.io.IOException
{
PrintWriter writer = resp.getWriter();
writer.println(doing GET);
writer.flush();
}

protected void doPost(HttpServletRequest req, HttpServletResponse resp) 
throws javax.servlet.ServletException, java.io.IOException
{
PrintWriter writer = resp.getWriter();
writer.println(doing POST);
writer.flush();
}
}
---8---

-test.html-8---
html
bodyform method=POST 
action=http://localhost:8080/webapp/servlet/testpostbug;
input type=text maxlength=50 name=one value=one
*** REPEAT ABOVE INPUT BOX FOR 100 TIMES WITH _DIFFERENT NAMES_ ***
*** BE SURE TO INCLUDE VALUES FOR THE TEXTBOXES ***
input type=submit name=submit value=submit
/form
/body
/html
---8---
(This test case is available as a ZIP file upon request.)

Be sure to properly modify the URL in the form tag in the html file, and to 
replace the ***'d comments with actual input boxes.

Clicking the submit button on this webpage will attempt to submit to the 
servlet, causing the error.  It will likely work on the first attempt -- hit 
the back button and click submit again, and it will fail.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11137] - POST operation fails with many textboxes in form

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137

POST operation fails with many textboxes in form





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 18:06 ---
Created an attachment (id=2472)
Test Case Zip File

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11137] - POST operation fails with many textboxes in form

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137

POST operation fails with many textboxes in form





--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 18:08 ---
ZIP file containing the test case has been added.

Note that Tomcat 4.0.4 does *NOT* seem to suffer from this problem.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11137] - POST operation fails with many textboxes in form

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11137

POST operation fails with many textboxes in form

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
  Component|Unknown |Connectors
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 18:35 ---
The Http10Interceptor is known to not work well on XP.  One work-around is to 
set socketCloseDelay=250 on the Http10Interceptor element.

A better solution is to use the Coyote HTTP/1.1 connector.  The instructions 
for installing it are at  http://jakarta.apache.org/builds/jakarta-tomcat-
connectors/coyote/release/v1.0-rc2/.  Unfortunately, the jar files there are 
broken for 3.3.  You need to use the ones from the nightly build 
http://jakarta.apache.org/builds/jakarta-tomcat/nightly-3.3/.

*** This bug has been marked as a duplicate of 8992 ***

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8992] - IE6/XP: Limitation of POST Area within HTTP request?

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8992.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8992

IE6/XP: Limitation of POST Area within HTTP request?

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 18:35 ---
*** Bug 11137 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: TLD's in jars don't work (was: RE: Help please: DirContextURLStre amHandler/Jasper question and possible bug...)

2002-07-24 Thread Richard Frazer

OK, I think that this problem can be solved by making two fixes.

1. In StandardContext, stop unbinding
Thread.currentThread().getContextClassloader from
DirContextURLStreamHandler.
2. In StandardContext, when setting
Thread.currentThread().setContextClassloader, I can save off the current
classloader and restore it as the context classloader when leaving start(),
stop(), and reload().  The WebappClassLoader will then get set gain as the
current context classloader by StandardHostValve.invoke().

If this sounds reasonable to people, I can create a patch and submit it.

Richard

-Original Message-
From: Richard Frazer [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, July 24, 2002 1:16 PM
To: 'Tomcat Developers List'
Subject: TLD's in jars don't work (was: RE: Help please:
DirContextURLStre amHandler/Jasper question and possible bug...)


It occurs to me that I didn't explain very well how this problem manifests
itself.  The problem occurs when you have a tld inside a jar file.  Here's
the scenario:

App 1:
1. Request for App1 comes into the server
2. Request is assigned to thread1.
3. App1 is loaded on thread1.
4. Request is processed on thread1

App2:
5. Request for App2 comes into the server
6. Request is assigned to thread1.
7. App2 is loaded on thread1.
8. Request is processed on thread1.

Now, if the request for App2 is for an uncompiled jsp that uses a tld that
is stored in a jar file under WEB-INF/lib, an exception is thrown.  The
exception is thrown from DirContextURLStreamHandler.get().

Here's the top of the stack:

java.lang.IllegalStateException: Illegal class loader binding at
org.apache.naming.resources.DirContextURLStreamHandler.getDirContextURLStrea
mHandler.java:246) 
at
org.apache.naming.resources.DirContextURLStreamHandler.openConnection(DirCon
textURLStreamHandler.java:134) 
at java.net.URL.openConnection(URL.java:938) 
at
sun.net.www.protocol.jar.JarURLConnection.init(JarURLConnection.java:64)
at sun.net.www.protocol.jar.Handler.openConnection(Handler.java:24)
at java.net.URL.openConnection(URL.java:938)
at
org.apache.jasper.compiler.TagLibraryInfoImpl.init(TagLibraryInfoImpl.java
:209) 
at org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:358)
at org.apache.jasper.compiler.Parser.parseDirective(Parser.java:385)
at org.apache.jasper.compiler.Parser.parseElements(Parser.java:794)
at org.apache.jasper.compiler.Parser.parse(Parser.java:122) 

I would like to fix this problem and submit a patch, but I don't know if the
correct solution is to not have StandardContext.start() for App2 unbind
App1's DirContext, or to bind the DirContext for every request.

Thanks in advance.
Richard

-Original Message-
From: Richard Frazer [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, July 24, 2002 12:18 PM
To: Tomcat-Dev (E-mail)
Subject: Help please: DirContextURLStreamHandler/Jasper question and
possi ble bug...


I'm running with Tomcat 4.1 and am seeing the following problem (and have
actually been seeing the problem since 4.0.4):

Jasper relies on the fact that the DirContext is bound in
DirContextURLStreamHandler based on the app classloader.  This is bound when
the StandardContext is started, stopped, or reloaded.  The code in Jasper
that relies on it is the TagLibraryInfoImpl class.  It uses a
JarURLConnection which in turn uses DirContextURLStreamHandler to lookup the
DirContext based on Thread.currentThread().getContextClassloader().

This all works fine as long as the DirContext stays bound to the
DirContextURLStreamHandler for the lifetime of the application. However, the
DirContext gets unbound if another app is started later on on the same
thread as the first app.  If you look in StandardContext.start(), the code
looks like this:

// Binding thread
oldCCL = bindThread();
.
.
.
unbindThread(oldCCL);

The unbindThread method unbinds the DirContext from the
DirContextURLStreamHandler.  Why would the StandardContext.start() method
unbind a classloader from DirContextURLStreamHandler when it doesn't even
know whether it's still in use?

I'm by no means an expert here, so there may be something fairly obvious
that I'm missing.  Please help.

Thanks,
Richard



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java ErrorDispatcher.java DefaultErrorHandler.java

2002-07-24 Thread luehe

luehe   2002/07/24 12:58:57

  Modified:jasper2/src/share/org/apache/jasper/resources
messages.properties
   jasper2/src/share/org/apache/jasper/compiler
JspDocumentParser.java ErrorDispatcher.java
DefaultErrorHandler.java
  Log:
  added error message for jsp.error.parse.xml.scripting.invalid.body error code + 
fixed NPE in ErrorDispatcher
  
  Revision  ChangesPath
  1.13  +2 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- messages.properties   22 Jul 2002 20:35:27 -  1.12
  +++ messages.properties   24 Jul 2002 19:58:57 -  1.13
  @@ -231,6 +231,7 @@
   jsp.error.no.more.content=End of content reached while more parsing required: tag 
nesting error?
   jsp.error.parse.xml=XML parsing error on file {0}: {1}
   jsp.error.parse.xml.line=XML parsing error on file {0}: (line {1}, col {2}): {3}
  +jsp.error.parse.xml.scripting.invalid.body=Body of {0} element must not contain any 
XML elements
   jsp.error.internal.tldinit=Exception initializing TldLocationsCache: {0}
   jsp.error.internal.filenotfound=Internal Error: File {0} not found
   jsp.error.internal.evaluator_not_found=Internal error: unable to load expression 
evaluator
  
  
  
  1.8   +15 -7 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
  
  Index: JspDocumentParser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- JspDocumentParser.java22 Jul 2002 23:02:55 -  1.7
  +++ JspDocumentParser.java24 Jul 2002 19:58:57 -  1.8
  @@ -314,7 +314,7 @@
}
   
if (current instanceof Node.ScriptingElement) {
  - checkScriptingBody(current.getBody());
  + checkScriptingBody((Node.ScriptingElement) current);
}
   
if (current.getParent() != null) {
  @@ -495,18 +495,26 @@
* Ensures that the given body only contains nodes that are instances of
* TemplateText.
*
  - * This check is performed only for the body of a scripting (that is, a
  + * This check is performed only for the body of a scripting (that is:
* declaration, scriptlet, or expression) element, after the end tag of a
* scripting element has been reached.
*/
  -private void checkScriptingBody(Node.Nodes body) throws SAXException {
  +private void checkScriptingBody(Node.ScriptingElement scriptingElem)
  + throws SAXException {
  + Node.Nodes body = scriptingElem.getBody();
if (body != null) {
int size = body.size();
for (int i=0; isize; i++) {
Node n = body.getNode(i);
if (!(n instanceof Node.TemplateText)) {
  + String elemType = TagConstants.JSP_SCRIPTLET;
  + if (scriptingElem instanceof Node.Declaration)
  + elemType = TagConstants.JSP_DECLARATION;
  + if (scriptingElem instanceof Node.Expression)
  + elemType = TagConstants.JSP_EXPRESSION;
String msg = err.getString(
  -jsp.error.parse.xml.scripting.invalid.body);
  +jsp.error.parse.xml.scripting.invalid.body,
  + elemType);
throw new SAXException(msg);
}
}
  
  
  
  1.3   +10 -5 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ErrorDispatcher.java
  
  Index: ErrorDispatcher.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ErrorDispatcher.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ErrorDispatcher.java  15 May 2002 20:42:03 -  1.2
  +++ ErrorDispatcher.java  24 Jul 2002 19:58:57 -  1.3
  @@ -391,11 +391,15 @@
   private void dispatch(Mark where, String errCode, Object[] args,
  Exception e) throws JasperException {
String file = null;
  + String errMsg = null;
int line = -1;
int column = -1;
   
// Localize
  - String errMsg = getString(errCode, args);
  + 
  + if (errCode != null) {
  + errMsg = getString(errCode, args);
  + }
   
// Get error location
if (where != 

DO NOT REPLY [Bug 6432] - Jasper should validate that an XML-view of a JSP page conforms as much as possible based on the DTD supplied in JSP.B of the JSP 1.2 specification

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6432.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6432

Jasper should validate that an XML-view of a JSP page conforms as much as possible 
based on the DTD supplied in JSP.B of the JSP 1.2 specification

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|LATER   |



--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 20:03 ---
Jasper2 already enforces that the body of a scripting (that is: declaration,
expression, or scriptlet) element does not contain any XML elements.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 6432] - Jasper should validate that an XML-view of a JSP page conforms as much as possible based on the DTD supplied in JSP.B of the JSP 1.2 specification

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6432.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6432

Jasper should validate that an XML-view of a JSP page conforms as much as possible 
based on the DTD supplied in JSP.B of the JSP 1.2 specification

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WORKSFORME

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 6432] - Jasper should validate that an XML-view of a JSP page conforms as much as possible based on the DTD supplied in JSP.B of the JSP 1.2 specification

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6432.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6432

Jasper should validate that an XML-view of a JSP page conforms as much as possible 
based on the DTD supplied in JSP.B of the JSP 1.2 specification

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |



--- Additional Comments From [EMAIL PROTECTED]  2002-07-24 20:07 ---
Sorry, I just realized this bug was filed against the original Jasper (as
opposed to Jasper2), where this indeed used to be a bug.
Will reopen and resolve as FIXED in Jasper2.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: [4.1.8] New test milestone released

2002-07-24 Thread Hoffman, Randy

4.1.8 broke my connection pool.  During a connection request, I go into a
loop establishing and dropping connections to the database.  I replaced a
commons-dbcp.jar from a nightly build two weeks ago and it fixes the
problem, 7-10-02 to be exact.  Any idea of changes in dbcp that might cause
such behavior?

Thanks!


-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]] 
Sent: Tuesday, July 23, 2002 11:45 AM
To: Tomcat Developers List; Tomcat Users List
Subject: [4.1.8] New test milestone released


A new test milestone of Tomcat 4.1 has just been released.

Downloads: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.8/

Significant changes over 4.1.7 Beta include:
- Many Jasper 2 bugfixes
- DBCP fixes

The list of changes is available in the release notes.

Remy


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: JSR77 tomcat5 configuration

2002-07-24 Thread costinm

On Wed, 24 Jul 2002, Craig R. McClanahan wrote:

 In general, my view is that the JSR-77 standards for managed object
 names, and the corresponding attributes, are not fine grained enough to
 deal with the actual manageable components in a servlet container.  We're
 going to need many more MBeans anyway -- it seems like a more viable
 strategy would be to map the standardized names for JSR-77 purposes to the
 corresponding Tomcat MBeans, but focus the Tomcat MBean architecture on
 what we need to manage Tomcat.

That's pretty clear - we'll have much more than what JSR-77 specifies,
but for things that are specified and as general concepts - I think
it would be usefull to stay close.

There are many things that will be slightly different - one example is the 
'node' - which in JSR77 is the 'hostname' and we'll need 'hostname:port' ( 
at least ) since we support more than one instance running on a single 
machine.


 As I've mentioned in the past, I'm also fine with looking at alternatives
 to XML-based configuration formats.  The *syntax* of the configuration
 parameters is not very important -- the big issue is representing the
 *semantics*.  Can you configure every configurable property of every
 component?  If you can, then however you want to store it is fine.  If you
 can't, then it's time to go back and re-engineer the config data
 persistence design.

+1

 Note that valves already have MBeans today in 4.1 -- extending this to the
 remaining components isn't that difficult :-).

Actually all Interceptors in 3.3 ( the main branch ) and all jk components 
have MBeans as well ( dynamic mbeans, but still mbeans ) :-)

What I'm strugling with is the naming conventions and how to map this
in a configuration file ( and make this extensible to non-file based
config ).


 Again, this is focused on syntax.  What are your thoughts on my complete
 coverage of configurable properties for all components assertion above?

I don't feel this as very hard to achieve. Maybe not random object graphs,
but at least what can be expressed in JMX attributes and the relations
and some object structures similar with what ant provides. 

If we think of all configurable components ( vavles, listeners, realms,
interceptors, jkhandlers ) as mbeans - with a well-defined name and
some clear attribute types - then we can express relations using 
refIds and we can use some simple patterns like those in ant to configure
complex attributes.

For example today it is difficult to define a Listener ( or Interceptor) 
that has some complex attributes, that would require XmlMapper rules.
With ant-like patterns this become possible. It's still not 
absolute 'complete coverage', but I think it should reasonably 
satisfy your requirement.

What remains hard and where XmlMapper is still the best solution is 
web.xml.

Costin


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11146] New: - reference for doc incorrect

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11146.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11146

reference for doc incorrect

   Summary: reference for doc incorrect
   Product: Tomcat 4
   Version: 4.0 Beta 1
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Documentation
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In the tomcat doc
http://jakarta.apache.org/tomcat/tomcat-3.3-doc/mod_jk-howto.html#s7
the documentation reads:
Troubleshooting and F.A.Q.s
Q. Where can I get help/support for mod_jk?
A. The primary mechanism for support is through the Tomcat Documentation 
included in the TOMCAT_HOME/doc directory.  These documents are viewable via 
browser through Tomcat http://localhost:8080/doc/index.html.  

I have no http://localhost:8080/doc/index.html after successfully installing 
Tomcat cooperating with Apache.

My index for documentation starts at:
http://localhost:8080/manual/

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Node.java

2002-07-24 Thread luehe

luehe   2002/07/24 15:00:11

  Modified:jasper2/src/share/org/apache/jasper/compiler Node.java
  Log:
  Added node types for jsp:invoke and jsp:doBody actions
  
  Revision  ChangesPath
  1.21  +41 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java
  
  Index: Node.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- Node.java 22 Jul 2002 20:35:27 -  1.20
  +++ Node.java 24 Jul 2002 22:00:10 -  1.21
  @@ -445,6 +445,34 @@
   }
   
   /**
  + * Represents a jsp:invoke tag file action
  + */
  +public static class InvokeAction extends Node {
  +
  + public InvokeAction(Attributes attrs, Mark start, Node parent) {
  + super(attrs, start, parent);
  + }
  +
  + public void accept(Visitor v) throws JasperException {
  + v.visit(this);
  + }
  +}
  +
  +/**
  + * Represents a jsp:doBody tag file action
  + */
  +public static class DoBodyAction extends Node {
  +
  + public DoBodyAction(Attributes attrs, Mark start, Node parent) {
  + super(attrs, start, parent);
  + }
  +
  + public void accept(Visitor v) throws JasperException {
  + v.visit(this);
  + }
  +}
  +
  +/**
* Represents a Jsp comment
* Comments are kept for completeness.
*/
  @@ -1592,6 +1620,16 @@
   }
   
   public void visit(JspBody n) throws JasperException {
  +doVisit(n);
  +visitBody(n);
  +}
  +
  +public void visit(InvokeAction n) throws JasperException {
  +doVisit(n);
  +visitBody(n);
  +}
  +
  +public void visit(DoBodyAction n) throws JasperException {
   doVisit(n);
   visitBody(n);
   }
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common JkMX.java

2002-07-24 Thread costin

costin  2002/07/24 15:10:59

  Modified:jk/java/org/apache/jk/common JkMX.java
  Log:
  Added the host attribute - since MX4J now defaults to localhost.
  
  Revision  ChangesPath
  1.4   +15 -1 jakarta-tomcat-connectors/jk/java/org/apache/jk/common/JkMX.java
  
  Index: JkMX.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/JkMX.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- JkMX.java 7 Jun 2002 00:24:23 -   1.3
  +++ JkMX.java 24 Jul 2002 22:10:59 -  1.4
  @@ -78,6 +78,7 @@
   {
   MBeanServer mserver;
   private int port=-1;
  +private String host;
   
   public JkMX()
   {
  @@ -90,6 +91,18 @@
   public void setPort( int i ) {
   port=i;
   }
  +
  +public int getPort() {
  +return port;
  +}
  +
  +public void setHost(String host ) {
  +this.host=host;
  +}
  +
  +public String getHost() {
  +return host;
  +}
   
   public void createMBean( Object proxy, String name ) {
   try {
  @@ -114,7 +127,8 @@
   try {
   ObjectName serverName = new ObjectName(Http:name=HttpAdaptor);
   mserver.createMBean(mx4j.adaptor.http.HttpAdaptor, serverName, null);
  -//mserver.setAttribute(serverName, new Attribute(Host, 10.0.0.181));
  +if( host!=null ) 
  +mserver.setAttribute(serverName, new Attribute(Host, host));
   mserver.setAttribute(serverName, new Attribute(Port, new 
Integer(port)));
   
   ObjectName processorName = new ObjectName(Http:name=XSLTProcessor);
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkMain.java

2002-07-24 Thread costin

costin  2002/07/24 15:13:06

  Modified:jk/java/org/apache/jk/server JkMain.java
  Log:
  Changed the default to include only the socket and base modules.
  
  For anything else you must explicitely edit jk2.properties.
  
  The reason for the change - many people seem confused about the
  messages about jni.so library, and this require additional actions
  ( i.e. install the .so ) anyway.
  
  Also replaced some printlns with log.
  
  Revision  ChangesPath
  1.28  +8 -3  
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkMain.java
  
  Index: JkMain.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkMain.java,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- JkMain.java   2 Jul 2002 19:58:27 -   1.27
  +++ JkMain.java   24 Jul 2002 22:13:06 -  1.28
  @@ -228,13 +228,18 @@
   }
   }
   
  -static String defaultHandlers[]= { apr,
  +static String defaultHandlers[]= { request,
  +   container,
  +   channelSocket};
  +/*
  + static String defaultHandlers[]= { apr,
  shm,
  request,
  container,
  channelSocket,
  channelJni,
  channelUnix};
  +*/
   
   public void stop() 
   {
  @@ -435,7 +440,7 @@
   JkHandler handler;
   String classN=modules.getProperty(type);
   if( classN == null ) {
  -System.err.println(No class name for  + fullName +   + type );
  +log.error(No class name for  + fullName +   + type );
   return null;
   }
   try {
  @@ -463,7 +468,7 @@
   String name= k.substring( plen );
   String propValue=props.getProperty( k );
   
  -System.out.println(Register  + name +   + propValue );
  +if( log.isDebugEnabled()) log.debug(Register  + name +   + 
propValue );
   modules.put( name, propValue );
   }
   }
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11147] New: - reference for servlet incorrect

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11147.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11147

reference for servlet incorrect

   Summary: reference for servlet incorrect
   Product: Tomcat 4
   Version: 4.0 Beta 1
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Documentation
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I am unable to access the (servlet) tomcat doc
http://jakarta.apache.org/tomcat/tomcat-4.1-doc/appdev/sample/web/hello

How can I gain access to this page??

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11146] - reference for doc incorrect

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11146.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11146

reference for doc incorrect

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11147] - reference for servlet incorrect

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11147.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11147

reference for servlet incorrect

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 11149] New: - Tomcat shutdown requires resolvable hostname

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11149.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11149

Tomcat shutdown requires resolvable hostname

   Summary: Tomcat shutdown requires resolvable hostname
   Product: Tomcat 3
   Version: 3.3.x Nightly
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

When I try to shutdown Tomcat, I get:

[jeff@kermit bin]$ ./shutdown 
Using classpath: ./../lib/tomcat.jar
Using JAVA_HOME: /usr/local/jdk
Using TOMCAT_HOME: ..
Stopping Tomcat.
Stopping tomcat on :8007 null
Error stopping Tomcat with Ajp12 on null:8007 java.net.UnknownHostException:
kermit.socialchange.net.au

On my box, 'uname -n' returns kermit.socialchange.net.au. This hostname isn't
in DNS and doesn't resolve. If I add it to /etc/hosts, then Tomcat shuts down
properly.


--Jeff

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2002-07-24 Thread kinman

kinman  2002/07/24 15:38:43

  Modified:jasper2/src/share/org/apache/jasper/compiler Node.java
   jasper2/src/share/org/apache/jasper/resources
messages.properties
  Added:   jasper2/src/share/org/apache/jasper/compiler
TagFileProcessor.java
  Log:
  - Add tag file directive processor to parse and extract TagInfo object
from a tag file.
  
Warning: This part of the spec is subject to change.  Also the code is
not fully tested.
  
  Revision  ChangesPath
  1.22  +16 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java
  
  Index: Node.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- Node.java 24 Jul 2002 22:00:10 -  1.21
  +++ Node.java 24 Jul 2002 22:38:43 -  1.22
  @@ -407,12 +407,25 @@
*/
   public static class AttributeDirective extends Node {
   
  +/* Use to collect all the parameters to this fragment attribut
  + * during parsing of the tag file.
  + */
  +private Vector fragmentInputs;
  +
public AttributeDirective(Attributes attrs, Mark start, Node parent) {
super(attrs, start, parent);
}
   
public void accept(Visitor v) throws JasperException {
v.visit(this);
  + }
  +
  + public void setFragmentInputs(Vector v) {
  + fragmentInputs = v;
  + }
  +
  + public Vector getFragmentInputs() {
  + return fragmentInputs;
}
   }
   
  
  
  
  1.1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
  
  Index: TagFileProcessor.java
  ===
  /*
   * $Header: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/
  compiler/TagFileProcessor.java,v 1.16 2002/05/24 23:57:42 kinman Exp $
   * $Revision: 1.1 $
   * $Date: 2002/07/24 22:38:43 $
   *
   * 
   *
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/).
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names The Jakarta Project, Tomcat, and Apache Software
   *Foundation must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called Apache
   *nor may Apache appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * http://www.apache.org/.
   *
   */
  
  package org.apache.jasper.compiler;
  
  import 

DO NOT REPLY [Bug 11150] New: - shutdown fails with AJP12 disabled

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11150.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11150

shutdown fails with AJP12 disabled

   Summary: shutdown fails with AJP12 disabled
   Product: Tomcat 3
   Version: 3.3.x Nightly
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

More shutdown bugs,

In server.xml, if I comment out the line:

Ajp12Connector port=8007 /

Then when I try to shut down, I get:

[jeff@kermit bin]$ ./shutdown
Using classpath: ./../lib/tomcat.jar
Using JAVA_HOME: /usr/local/jdk
Using TOMCAT_HOME: ..
Stopping Tomcat.
Stopping tomcat on :8007 null
Error stopping Tomcat with Ajp12 on kermit.socialchange.net.au/127.0.0.1:8007
java.net.ConnectException: Connection refused


AJP13 doesn't have this problem, ie when I comment out the AJP13 connector
(leaving AJP12 in), I can shut down fine.


--Jeff

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2002-07-24 Thread kinman

kinman  2002/07/24 16:57:12

  Modified:jasper2/src/share/org/apache/jasper/compiler
ParserController.java
   jasper2/src/share/org/apache/jasper/resources
messages.properties
  Log:
  - Fix problem with looking for tag directives in prescan phase.
  
  Revision  ChangesPath
  1.7   +1 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java
  
  Index: ParserController.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ParserController.java 22 Jul 2002 20:35:27 -  1.6
  +++ ParserController.java 24 Jul 2002 23:57:12 -  1.7
  @@ -254,7 +254,7 @@
jspReader.reset(startMark);
while (jspReader.skipUntil(%@) != null) {
jspReader.skipSpaces();
  - isTagFile = jspReader.matches(tag);
  + isTagFile = jspReader.matches(tag );
if (isTagFile || jspReader.matches(page)) {
jspReader.skipSpaces();
Attributes attrs = Parser.parseAttributes(this, jspReader);
  
  
  
  1.15  +4 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- messages.properties   24 Jul 2002 22:38:43 -  1.14
  +++ messages.properties   24 Jul 2002 23:57:12 -  1.15
  @@ -273,3 +273,6 @@
   
   jsp.error.dynamic.attributes.not.implemented=The {0} tag declares that it accepts 
dynamic attributes but does not implement the required interface
   jsp.error.nomatching.fragment=an attribute directive whose name attribute equals 
{0} and whose fragment attribute equals true must be declared prior to this directive.
  +jsp.error.attribute.noequal=equal symbol expected
  +jsp.error.attribute.noquote=quote symbol expected
  +jsp.error.attribute.unterminated=attribute for {0} is not properly terminated
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspUtil.java

2002-07-24 Thread luehe

luehe   2002/07/24 18:04:44

  Modified:jasper2/src/share/org/apache/jasper/compiler JspUtil.java
  Log:
  Removed JspUtil.replace(String name, char replace, char with)
  
  Revision  ChangesPath
  1.7   +3 -29 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspUtil.java
  
  Index: JspUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspUtil.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- JspUtil.java  22 Jul 2002 23:02:55 -  1.6
  +++ JspUtil.java  25 Jul 2002 01:04:44 -  1.7
  @@ -459,32 +459,6 @@
return buf.toString();
   }
   
  -/**
  - * Replaces any occurrences of the character ttreplace/tt with the
  - * character ttwith/tt.
  - */
  -public static String replace(String name, char replace, char with) {
  - StringBuffer buf = new StringBuffer();
  - int begin = 0;
  - int end;
  - int last = name.length();
  -
  - while (true) {
  - end = name.indexOf(replace, begin);
  - if (end  0) {
  - end = last;
  - }
  - buf.append(name.substring(begin, end));
  - if (end == last) {
  - break;
  - }
  - buf.append(with);
  - begin = end + 1;
  - }
  - 
  - return buf.toString();
  -}
  -
   public static class ValidAttribute {
String name;
boolean mandatory;
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-07-24 Thread luehe

luehe   2002/07/24 18:05:22

  Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
  Log:
  First shot at tag handler code generation for tag files
  
  Revision  ChangesPath
  1.44  +247 -6
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- Generator.java19 Jul 2002 17:12:57 -  1.43
  +++ Generator.java25 Jul 2002 01:05:22 -  1.44
  @@ -865,7 +865,12 @@
   
   // If any of the params have their values specified by
   // jsp:attribute, prepare those values first.
  -prepareParams( findJspBody( n ) );
  + Node jspBody = findJspBody(n);
  + if (jspBody != null) {
  + prepareParams(jspBody);
  + } else {
  + prepareParams(n);
  + }
   
   out.printin(JspRuntimeLibrary.include(request, response,  +
   pageParam );
  @@ -951,7 +956,12 @@
   
   // If any of the params have their values specified by
   // jsp:attribute, prepare those values first.
  -prepareParams( findJspBody( n ) );
  + Node jspBody = findJspBody(n);
  + if (jspBody != null) {
  + prepareParams(jspBody);
  + } else {
  + prepareParams(n);
  + }
   
out.printin(pageContext.forward();
out.print( pageParam );
  @@ -1684,6 +1694,87 @@
}
}
   
  +public void visit(Node.InvokeAction n) throws JasperException {
  +
  + /**
  +  * A visitor to handle jsp:param in a jsp:invoke
  +  */
  + class ParamVisitor extends Node.Visitor {
  +
  +public void visit(Node.ParamAction n) throws JasperException {
  + out.printin(params.put();
  + out.print(n.getAttributeValue(name));
  + out.print(, );
  + out.print(attributeValue(n.getValue(), false,
  +  String.class, null));
  + out.println(););
  + }
  + }
  +
  + // Assemble parameter map
  + out.printil(params = new java.util.HashMap(););
  + if (n.getBody() != null) {
  + prepareParams(n);
  + n.getBody().visit(new ParamVisitor());
  + }
  + 
  + // Invoke fragment with parameter map
  + String getterMethodName
  + = getAccessorMethodName(n.getAttributeValue(fragment),
  + true);
  + String varReader = n.getAttributeValue(varReader);
  + if (varReader != null) {
  + out.printil(sout = new java.io.StringWriter(););
  + out.printin(getterMethodName);
  + out.println(().invoke(sout, params););
  + } else {
  + out.printin(getterMethodName);
  + out.println(().invoke(null, params););
  + }
  + if (varReader != null) {
  + out.printin(jspContext.setAttribute(\);
  + out.print(varReader);
  + out.print(\, new java.io.StringReader(sout.toString())););
  + // XXX evaluate scope
  + }
  + }
  +
  +public void visit(Node.DoBodyAction n) throws JasperException {
  +
  + /**
  +  * A visitor to handle jsp:param in a jsp:doBody
  +  */
  + class ParamVisitor extends Node.Visitor {
  +
  +public void visit(Node.ParamAction n) throws JasperException {
  + out.printin(params.put();
  + out.print(n.getAttributeValue(name));
  + out.print(, );
  + out.print(attributeValue(n.getValue(), false,
  +  String.class, null));
  + out.println(););
  + }
  + }
  +
  + // Assemble parameter map
  + out.printil(params = new java.util.HashMap(););
  + if (n.getBody() != null) {
  + prepareParams(n);
  + n.getBody().visit(new ParamVisitor());
  + }
  +
  + // XXX Add scripting variables to parameter map
  +
  + // Invoke body with parameter map
  + String varReader = n.getAttributeValue(varReader);
  + if (varReader != null) {
  + out.printil(sout = new java.io.StringWriter(););
  + out.printil(getJspBody().invoke(sout, params););
  + } else {
  + out.printil(getJspBody().invoke(null, params););
  + }
  + }
  +
private void 

DO NOT REPLY [Bug 11150] - shutdown fails with AJP12 disabled

2002-07-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11150.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11150

shutdown fails with AJP12 disabled

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-07-25 03:19 ---
I believe that behavior is intentional. The ajp12 connector is purposely used to 
shutdown Tomcat. See 
http://jakarta.apache.org/tomcat/tomcat-3.3-doc/serverxml.html#Ajp12Connector

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




[PROPOSAL] /server-status like functionality

2002-07-24 Thread Tim Funk

I would like to introduce a page similar to /server-status for tomcat. 
If I implement such a thing - would there be interest to add it to CVS?

My plan is to report:
- uptime (Since valve was instatiated - which should be very close to 
start up time)
- Total requests
- Total Bytes transfered
- Memory footprint (free and used)

I would also have an extended flag which allows would report the total 
requests for the past 60 seconds (by second) and the same for the last 
60 minutes. As well as Memory stats for the same timespan.

The implementation would have 2 parts:
1) A new Valve (inherit from ValveBase, call it StatusValve?) which 
records stats after they are served.
2) A new web-app (which has one one servlet) that shows the stats. The 
page would be protected similar to the admin app. (Some role based 
authentication decided by the user)

My plan of attack would make the stats available via an MBean. All the 
stats would be stored in the StatusValve instance. The statistics could 
be reported via MBean getAttibute() calls.

Before I try such an endveour (which should be easy):
1) Is this worthwhile?
2) To register the MBean - there appears to be a file called:
catalina\src\share\org\apache\catalina\mbeans\mbeans-descriptors.xml - 
Do I need to add my MBean def to this file? Or is there a better mechanism?

-Tim



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]