DO NOT REPLY [Bug 18456] New: - isRequestedSessionIdValid returns false after getSession(true)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456 isRequestedSessionIdValid returns false after getSession(true) Summary: isRequestedSessionIdValid returns false after getSession(true) Product: Tomcat 4 Version: 4.1.18 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In a Tomcat 4.1.18 embedded within JBoss I have an application that uses Filters. At one point one of the filters decides if the current session should be recreated (for example after having checked that the session is not valid) and does it so using request.getSession(true). The problem is, that even then request.isRequestedSessionIdValid remains false. As a result methods further on in the execution pipeline, that do not have the knowledge of the fact that the session has been recreated do have troubles with it. To summarize: after request.getSession(true); read the session with request.getSession(false); then (session != null) since it is now new and valid but request.isRequestedSessionIsValid() == false it's IMO not logical - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18456] - isRequestedSessionIdValid returns false after getSession(true)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456 isRequestedSessionIdValid returns false after getSession(true) [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 09:32 --- If the session has been re-created, then request.isRequestedSessionIdValid() will always return 'false'. The test is is the Id sent by the browser the same as the current sessionId. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0] [PROPOSAL] Extra web.xml to declare compiled JSPs
What about using external entities? ie: ?xml version=1.0 encoding=ISO-8859-1? !DOCTYPE web-app PUBLIC -//Sun Microsystems, Inc.//DTD Web Application 2.3//EN http://java.sun.com/dtd/web-app_2_3.dtd; [ !ENTITY jspservlet system jspservlet.xml ] then, between the servlet and servlet mapping sections jspservlet; -SMD - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, March 21, 2003 6:05 AM Subject: [5.0] [PROPOSAL] Extra web.xml to declare compiled JSPs Hi, It is not very convinient or easy to insert the declarations for compiled JSPs into the webapp's web.xml file. It also has the disadvantage of adding a lot of mess in the web.xml, which the user may not like. For that reason, I propose that Tomcat parses a new (optional) XML file, with the same DTD as web.xml, which would contain declarations identical to web.xml, and which would be used for declaring the compiled JSPs. I propose naming that file compiledjsp.xml. An additional advantage is that it would allow Tomcat to precompile webapps as they are deployed (otherwise, nasty XML manipulation is needed to do that, and I think overwriting the originial web.xml during deployment is bad). Maybe someone has a better solution for this problem. Any comments ? Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18229] - All threads are busy, waiting. resource leak bug?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18229. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18229 All threads are busy, waiting. resource leak bug? --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 10:34 --- We're also using Linux and had this problem (have not tested 4.1.24 yet) so this definitely is not a Solaris-only problem. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP] Build timed out - jk2
This email is autogenerated from the output from:
http://cvs.apache.org/builds/gump/2003-03-28/jakarta-tomcat-jk-native2.html
Buildfile: build.xml
init.taskdef:
guess.os:
[echo] build.properties i386.Linux
[echo] Linux:true Win32:${win32} Netware:${netware} Solaris:${solaris}
HPUX:${hpux}
init.win32.properties:
init.win32.mc:
init.win32:
init.netware:
init.os:
guess.server:
[echo] Apache2 /usr/local/apache2 true
[echo] Apache13 /usr true
[echo] IIS ${iis.home} ${iis.detect}
[echo] Iplanet ${iplanet.home} ${iplanet.detect}
[echo] JNI true
init:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk2
apache20:
[mkdir] Created dir:
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk2/apache2
[so] Compiling 42 out of 42
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_logger_file.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_env.c
/home/rubys/bin/timeout: timed out
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP] Build timed out - jk
This email is autogenerated from the output from:
http://cvs.apache.org/builds/gump/2003-03-28/jakarta-tomcat-jk-native.html
Buildfile: build.xml
init:
[echo] /home/rubys
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk
[echo] linux=true solaris=${solaris} win32=${win32} hpux=${hpux}
netware=${netware}
apache20:
apache13:
iis:
netscape:
jni:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni
[so] Compiling 4 out of 4
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_map.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_pool.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_util.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c
Linking /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni/jni_connect.so
/home/rubys/bin/timeout: timed out
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
FYI: PureTLS 0.9b3 Released
0.9b3 Released! The current version of PureTLS is 0.9b3. New features include Security fix: Improved Bleichenbacher (million-message attack) protection (only relevant for servers) Checking for Basic Constraints in CA certificates Checking for Key Usage in CA certificates Validity date checking for certificates General bug fixes - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: FYI: PureTLS 0.9b3 Released
Henri Gomez wrote: 0.9b3 Released! The current version of PureTLS is 0.9b3. New features include Security fix: Improved Bleichenbacher (million-message attack) protection (only relevant for servers) Checking for Basic Constraints in CA certificates Checking for Key Usage in CA certificates Validity date checking for certificates General bug fixes I'm only building against PureTLS. Is it 100% binary compatible with the old one ? Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Deprecation of context.getInitParameter()
HI there, Shouldn't context.getInitParameter get deprecated as the preferred way to access a scalar environment string becomes a JNDI resource (env-entry)? This way programmers would know that they are encouraged to use JNDI versus servletcontext.getInitParameter(). This info would ease the burden of editing server.xml by 90% or so I suggest (because I have quite a bunch of init parameters stored in server.xml). Thx alot Johannes
DO NOT REPLY [Bug 18459] New: - MBean names for foreign classed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18459. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18459 MBean names for foreign classed Summary: MBean names for foreign classed Product: Tomcat 4 Version: 4.1.8 Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] For most classes catalina creates MBean with name as last part of class name. This results in an exception when foreign class name is used and it's last part is equal to catalina's one. An example: I've created a valve with class name Debug (in my com.gtechua... package) When I've tried to use it I've got: Bootstrap: Create Catalina server Bootstrap: Starting service ServerLifecycleListener: createMBeans: MBeanException java.lang.Exception: ManagedBean is not found with Debug at org.apache.catalina.mbeans.MBeanUtils.createMBean(MBeanUtils.java:783) at org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:644) at org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:590) at org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:783) at org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:751) at org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:339) at org.apache.catalina.mbeans.ServerLifecycleListener.lifecycleEvent(ServerLifecycleListener.java:206) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:166) at org.apache.catalina.core.StandardServer.start(StandardServer.java:2182) at org.apache.catalina.startup.CatalinaService.start(CatalinaService.java:271) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.catalina.startup.BootstrapService.start(BootstrapService.java:245) at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:307) Starting service Tomcat-Outer Apache Tomcat/4.1.12-LE-jdk14 Starting service Tomcat-Internal Apache Tomcat/4.1.12-LE-jdk14 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18459] - MBean names for foreign classed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18459. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18459 MBean names for foreign classed --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 11:51 --- The problem seems to be not in Name, but in nonexistance of the name in the registry. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18461] New: - problems with forward executed after include
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18461. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18461 problems with forward executed after include Summary: problems with forward executed after include Product: Tomcat 4 Version: 4.1.24 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Servlet JSP API AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] when a jsp includes a servlet, and that servlet tries to forward to something else (ie. a serlvet, a jsp, etc.) the forward does not succeed and the output is what has been outputed _before_ the forward - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18461] - problems with forward executed after include
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18461. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18461 problems with forward executed after include [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 12:34 --- According to the spec, an include may not: - Set headers - Set cookies - Perform forwards (jsp:forward or RequestDispatcher.forward() ) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18462] New: - System.err gets overriden to output to System.out
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18462. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18462 System.err gets overriden to output to System.out Summary: System.err gets overriden to output to System.out Product: Tomcat 4 Version: 4.1.24 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I am using Eclipse to do my development and I am running tomcat 4.1.24 from within eclipse. One of the nice features of eclipse is that anything you display with System.out comes out in blue and anything you send to System.err is displayed in red. However when tomcat is running Catalina overrides System.err and makes it point to System.out. This is very inconvinient because its much harder to search for severe error messages in a list of millions of trivial ones. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18456] - isRequestedSessionIdValid returns false after getSession(true)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456 isRequestedSessionIdValid returns false after getSession(true) [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 12:36 --- I doesn't make much sense, does it? Session ID and its validity is of any use only if it applies to the current session being in use. Information that the client have sent an invalid Session ID as well as this invalid Sesion ID itself is useless, if I already have a new session where I can put data. Now look at the following HttpServletRequest API description: public boolean isRequestedSessionIdValid() Checks whether the requested session ID is still valid. Returns: true if this request has an id for a valid session in the current session context; false otherwise Now if I create a new session using HttpServletRequest method then this very HttpServletRequest does have a valid session. public java.lang.String getRequestedSessionId() Returns the session ID specified by the client. This may not be the same as the ID of the actual session in use. For example, if the request specified an old (expired) session ID and the server has started a new session, this method gets a new session with a new ID. If the request did not specify a session ID, this method returns null. Returns: a String specifying the session ID, or null if the request did not specify a session ID So what you've stated is plainly wrong: if the server has started a new session this HttpServletRequest's methods should apply to the new session. As stated above the old invalid session ID is useless. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18456] - isRequestedSessionIdValid returns false after getSession(true)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456
isRequestedSessionIdValid returns false after getSession(true)
--- Additional Comments From [EMAIL PROTECTED] 2003-03-28 12:42 ---
I don't want to shift the work on you, here are two proposed corrections:
Tomcat v4.1.18
Solution 1:
org.apache.catalina.connector.HttpRequestBase
public boolean isRequestedSessionIdValid() {
if (requestedSessionId == null)
return (false);
if (context == null)
return (false);
// Return the validitity of the current session if it exists and is valid
if ((session != null) session.isValid())
return (true);
Manager manager = context.getManager();
if (manager == null)
return (false);
Session session = null;
try {
session = manager.findSession(requestedSessionId);
} catch (IOException e) {
session = null;
}
if ((session != null) session.isValid())
return (true);
else
return (false);
}
if the request has a session that is valid return true, otherwise lookup
current session ID.
Solution 2:
org.apache.catalina.connector.HttpRequestBase
private HttpSession doGetSession(boolean create) {
// There cannot be a session if no context has been assigned yet
if (context == null)
return (null);
// Return the current session if it exists and is valid
if ((session != null) !session.isValid())
session = null;
if (session != null)
return (session.getSession());
// Return the requested session if it exists and is valid
Manager manager = null;
if (context != null)
manager = context.getManager();
if (manager == null)
return (null); // Sessions are not supported
if (requestedSessionId != null) {
try {
session = manager.findSession(requestedSessionId);
} catch (IOException e) {
session = null;
}
if ((session != null) !session.isValid())
session = null;
if (session != null) {
return (session.getSession());
}
}
// Create a new session if requested and the response is not committed
if (!create)
return (null);
if ((context != null) (response != null)
context.getCookies()
response.getResponse().isCommitted()) {
throw new IllegalStateException
(sm.getString(httpRequestBase.createCommitted));
}
if (session != null) {
setRequestedSessionId(session.getId());
return (session.getSession());
} else
return (null);
}
After creating a new session put its ID as a new requestedSessionId.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18465] New: - Problem in build file with bad xerces value
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18465. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18465 Problem in build file with bad xerces value Summary: Problem in build file with bad xerces value Product: Tomcat 5 Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Minor Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The ANT script tries to download the 2.3 release of Xerces while this one is no more present on the webserver. Using the 2.4 instead solves this problem.. could be helpful ... - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18467] New: - Incorrect timezone value in access logs
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18467. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18467 Incorrect timezone value in access logs Summary: Incorrect timezone value in access logs Product: Tomcat 4 Version: 4.1.24 Platform: PC OS/Version: Linux Status: NEW Severity: Minor Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Currently the timezone indicator in log lines in access log file look like this: 127.0.0.1 - - [28/Mar/2003:11:21:46 2000] POST /myservlet HTTP/1.1 200 - In order to have RFC 822 compliant timezone value this line should look like this: 127.0.0.1 - - [28/Mar/2003:11:21:46 +2000] POST /myservlet HTTP/1.1 200 - Any reason not to have it this way? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] For the bug report #18467
Index: catalina/src/share/org/apache/catalina/valves/AccessLogValve.java === RCS file: /home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java,v retrieving revision 1.3 diff -u -r1.3 AccessLogValve.java --- catalina/src/share/org/apache/catalina/valves/AccessLogValve.java 11 Jan 2003 05:12:48 - 1.3 +++ catalina/src/share/org/apache/catalina/valves/AccessLogValve.java 28 Mar 2003 13:16:07 - -1028,10 +1028,8 // Initialize the timeZone, Date formatters, and currentDate TimeZone tz = TimeZone.getDefault(); -timeZone = + (tz.getRawOffset() / (60 * 60 * 10)); -if (timeZone.length() 5) -timeZone = timeZone.substring(0, 1) + 0 + -timeZone.substring(1, timeZone.length()); +SimpleDateFormat timeZoneFormatter = new SimpleDateFormat(Z); +timeZone = timeZoneFormatter.format(new Date()); dateFormatter = new SimpleDateFormat(-MM-dd); dateFormatter.setTimeZone(tz); dayFormatter = new SimpleDateFormat(dd); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteResponse.java
remm2003/03/28 05:57:56
Modified:coyote/src/java/org/apache/coyote/tomcat5
CoyoteResponse.java
Log:
- Fix dumb bug (when c-l is not set; oops).
Revision ChangesPath
1.22 +6 -5
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteResponse.java
Index: CoyoteResponse.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteResponse.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- CoyoteResponse.java 27 Mar 2003 22:36:21 - 1.21
+++ CoyoteResponse.java 28 Mar 2003 13:57:55 - 1.22
@@ -365,7 +365,8 @@
*/
public boolean isAppCommitted() {
return (this.appCommitted || isCommitted() || isSuspended()
-|| (getContentCount() = getContentLength()));
+|| ((getContentLength() != -1)
+ (getContentCount() = getContentLength(;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18456] - isRequestedSessionIdValid returns false after getSession(true)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18456 isRequestedSessionIdValid returns false after getSession(true) --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 14:19 --- Hi Tomasz, It seems that you simply haven't understood the text in the api docs. As Bill already tried to explain, with this function you can see, if the session is _new_. That means: The client has already accepted our cookie and sent it back with the current request. And you have to know: getSession(true or false) does _only_ return valid sessions. So no further check is necessary! This functionality have never changed since the creation of the spec. I think, you will not change it either, will you? It's up to you to close this bug. kind regards, Reinhard - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java
remm2003/03/28 06:22:54
Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
Log:
- Remove hack caused by an error in the listener.
Revision ChangesPath
1.14 +0 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
Index: Mapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- Mapper.java 25 Mar 2003 18:54:40 - 1.13
+++ Mapper.java 28 Mar 2003 14:22:54 - 1.14
@@ -862,10 +862,6 @@
if (b == -1) {
return -1;
}
-if( name==null || map.length ==0 ) {
-System.out.println(XXX Mapper: unexpected null + name + + map);
-return -1;
-}
if (name.compareTo(map[0].name) 0) {
return -1;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 MapperListener.java
remm2003/03/28 06:24:00
Modified:coyote/src/java/org/apache/coyote/tomcat5
MapperListener.java
Log:
- The right key is host, not name, which fixes the NPEs.
Revision ChangesPath
1.10 +3 -3
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/MapperListener.java
Index: MapperListener.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/MapperListener.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- MapperListener.java 25 Mar 2003 17:50:21 - 1.9
+++ MapperListener.java 28 Mar 2003 14:23:59 - 1.10
@@ -278,8 +278,8 @@
private void registerHost(ObjectName objectName)
throws Exception
{
-String name=objectName.getKeyProperty(name);
-log.info(Register host + name);
+String name=objectName.getKeyProperty(host);
+log.debug(Register host + name);
if( name != null ) {
mapper.addHost(name, objectName);
}
@@ -291,7 +291,7 @@
*/
private void unregisterHost(ObjectName objectName)
throws Exception {
-String name=objectName.getKeyProperty(name);
+String name=objectName.getKeyProperty(host);
mapper.removeHost(name);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.properties.default
jfarcand2003/03/28 06:52:43
Modified:.build.properties.default
Log:
New Xerces 2.3.0 location. Will do some test with Xerces 2.4 before using it...maybe
we will have another stable release (wow, two in a row :-) )
Revision ChangesPath
1.82 +2 -2 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- build.properties.default 26 Mar 2003 09:53:38 - 1.81
+++ build.properties.default 28 Mar 2003 14:52:43 - 1.82
@@ -122,7 +122,7 @@
xerces.lib=${xerces.home}
xercesImpl.jar=${xerces.lib}/xercesImpl.jar
xmlParserAPIs.jar=${xerces.lib}/xmlParserAPIs.jar
-xerces.loc=http://xml.apache.org/dist/xerces-j/Xerces-J-bin.2.3.0.tar.gz
+xerces.loc=http://xml.apache.org/dist/xerces-j/old_xerces2/Xerces-J-bin.2.3.0.tar.gz
# --
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18472] New: - mod_jk2 doesn't handle vhosts correctly when using the JkUriSet commands
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18472.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18472
mod_jk2 doesn't handle vhosts correctly when using the JkUriSet commands
Summary: mod_jk2 doesn't handle vhosts correctly when using the
JkUriSet commands
Product: Tomcat 4
Version: 4.1.24
Platform: All
OS/Version: All
Status: NEW
Severity: Major
Priority: Other
Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
When using the JkUriSet commands within a Location block the configuration gets
confused between vhosts.
Example:
VirtualHost example1.com
#define remote server
JkSet channel.socket:example1.port 8009
JkSet channel.socket:example1.host server3
JkSet ajp13:example1.channel channel.socket:example1
Location /examples/
JkSetUri group ajp13:example1
/Location
/VirtualHost
VirtualHost example2.com
#define remote server
JkSet channel.socket:example2.port 8500
JkSet channel.socket:example2.host server4
JkSet ajp13:example2.channel channel.socket:example2
Location /examples/
JkSetUri group ajp13:example2
/Location
/VirtualHost
Assuming that the hosts are specified in the order example1, example2 then all
requests for /examples/ will go to ajp13:example2 .
In mod_jk.c
static void *jk2_create_dir_config(apr_pool_t *p, char *path)
calls for the given path
jk_bean_t *jkb=workerEnv-globalEnv-createBean2(
workerEnv-globalEnv,
workerEnv-pool, uri,
(path==NULL)? :path );
createBean2 then checks to see if there is an existing config for the given
path. If it is then the existing config is updated and returned. This means
that the first /examples will be created correctly and when the 2nd config is
encountered createBean2 will return the config for the first /examples. This
will then be updated with the config of the second and so both /examples will
use the same config.
I suggest (have implemented and tested) the following alteration to fix this
problem.
The create_dir_config sends a unique path name (by adding a numerical suffix)
this will ensure that createBean2 will generate a unique bean for apache to hand
back to jk2_uriSet.
So that jkstatus will make any degree of sense I have updated jk2_uriSet so that
it re-sets the path back to the original path without the numeric suffix.
Here is the code for apache1.3 as a diff -c against the standard 4.1.21
Please let me know what you think
David Cassidy
***
../../jakarta-tomcat-connectors-4.1.21-src-ORIG/jk/native2/server/apache13/mod_jk2.c
2003-02-25 16:30:56.0 +
--- native2/server/apache13/mod_jk2.c 2003-03-27 11:31:59.0 +
***
*** 1,3
--- 1,4
+ // 4.1.18 version
/* = *
* *
* The Apache Software License, Version 1.1 *
***
*** 105,110
--- 106,142
* config. No good way to discover if it's the first time or not.
*/
static jk_workerEnv_t *workerEnv;
+ /* This is used to ensure that jk2_create_dir_config creates unique
+ * dir mappings. This prevents vhost configs as configured through
+ * httpd.conf from getting crossed.
+ */
+ static int dirCounter=0;
+
+ /* This gives a slightly better 500 error message than the standard :)
+ */
+ static int jk_error( request_rec *r, char *extras)
+ {
+ // this is a little hack to get around the fact that the lb worker
+ // might have already sent a page back
+ if ( r-bytes_sent 0 )
+ return OK;
+
+ ap_table_setn(r-notes, error-notes, ap_pstrcat(r-pool,
+ pThe mod_jk2 connector was unable handle the request for ,
+ ema href=\, ap_escape_uri(r-pool, r-uri), \,
+ ap_escape_html(r-pool, r-uri), /a/em/p\n,
+ pThis may mean an application server could not be contacted to
+ service this request. ,extras, PPlease try again later., NULL));
+
+ fprintf(stderr, Error send %d bytes ...\n, r-bytes_sent );
+ /* Allow error-notes string to be printed by ap_send_error_response() */
+ ap_table_setn(r-notes, verbose-error-to, ap_pstrdup(r-pool, *));
+
+ r-status_line = ap_psprintf(r-pool, %3.3u mod_jk2 error,
+ HTTP_INTERNAL_SERVER_ERROR);
+ return HTTP_INTERNAL_SERVER_ERROR;
+ }
+
/* Options setters */
***
*** 127,133
ap_get_module_config(s-module_config, jk2_module);
jk_env_t *env=workerEnv-globalEnv;
int rc;
!
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardPipeline.java
remm2003/03/28 06:58:08
Modified:catalina/src/share/org/apache/catalina/core
StandardPipeline.java
Log:
- Valves registration should only happen on start/stop, otherwise, the container
hierarchy may not be initialized.
Revision ChangesPath
1.7 +7 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardPipeline.java
Index: StandardPipeline.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardPipeline.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- StandardPipeline.java 27 Mar 2003 03:06:39 - 1.6
+++ StandardPipeline.java 28 Mar 2003 14:58:08 - 1.7
@@ -477,6 +477,8 @@
} catch (LifecycleException e) {
log.error(StandardPipeline.addValve: start: , e);
}
+// Register the newly added valve
+registerValve(valve);
}
// Add this Valve to the set associated with this Pipeline
@@ -486,8 +488,6 @@
results[valves.length] = valve;
valves = results;
}
-// register the newly added valve
-registerValve(valve);
}
@@ -602,9 +602,9 @@
} catch (LifecycleException e) {
log.error(StandardPipeline.removeValve: stop: , e);
}
+// Unregister the removed valave
+unregisterValve(valve);
}
-// unregister the removed valave
-unregisterValve(valve);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tomcat SSL mutual authentication: Nobody's got a clue?
Hi, when Internet Explorer prompts you with the list of certificates to send to the server, it checks KeyUsage of the certs in you keystore. If the list is empty, it means you have no usable cert. How do you generate your certs? If you use openssl, please consult openssl.txt in the docs. KeyUsage is explained there. The behavior is dependent of version of ie and windows. Certs from a trustcenter are very restricted in respect of usage. A email cert may be usable only for email, and nothing more. Same for file encryption (EFS), code signature and authentication, ... Non-Repudiation could be the KeyUsage you need. But don't know Take care: the KeyUsage of the CA-cert is sometimes also checked. Not talking about CRLs. With a Win2000 CA you have to chose the right profile when requesting the cert. This is definitely the wrong list to get deeper insight with certificates. But I am also not sure what the right place would be... openssl could be a good idea. With this program you can generate test certs for any usage: http://sourceforge.net/projects/myca (Usable with Linux and cygwin. It's based on openssl) Sometimes it is useful to test it with another browser. hope that helps, Reinhard Am Dienstag, 25. März 2003 23:53 schrieb [EMAIL PROTECTED]: Thanks, but I have read that documentation many times. That documentations tells us how to run Tomcat in SSL mode. And as I mentioned in the previous message, I know how to do that. What I want is mutual authentication, that is, 1. The Web server authenticates itself by sending its certificate to the client. (This is what the doc talks about) 2. The client authenticates itself by sending its certificate to the Web server. (This is not mentioned in that documentation, and is what I want to do) Bill Barker [EMAIL PROTECTED] wrote: http://jakarta.apache.org/tomcat/tomcat-4.1-doc/ssl-howto.html - Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, March 25, 2003 1:44 PM Subject: Tomcat SSL mutual authentication: Nobody's got a clue? I want configure Tomcat SSL for mutual authentication. And I've been exploring this for a while. If tomcat-users don't know this, tomcat-developers also get no clue? __ Try AOL and get 1045 hours FREE for 45 days! http://free.aol.com/tryaolfree/index.adp?375380 Get AOL Instant Messenger 5.1 for FREE! Download Now! http://aim.aol.com/aimnew/Aim/register.adp?promos=380455 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Try AOL and get 1045 hours FREE for 45 days! http://free.aol.com/tryaolfree/index.adp?375380 Get AOL Instant Messenger 5.1 for FREE! Download Now! http://aim.aol.com/aimnew/Aim/register.adp?promos=380455 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.properties.default
jfarcand2003/03/28 06:59:23
Modified:.build.properties.default
Log:
New Xerces 2.3.0 packaging structure.
Revision ChangesPath
1.83 +2 -2 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.82
retrieving revision 1.83
diff -u -r1.82 -r1.83
--- build.properties.default 28 Mar 2003 14:52:43 - 1.82
+++ build.properties.default 28 Mar 2003 14:59:23 - 1.83
@@ -119,7 +119,7 @@
# - Xerces XML Parser, version 2.3.0 -
xerces.home=${base.path}/xerces-2_3_0
-xerces.lib=${xerces.home}
+xerces.lib=${xerces.home}/tools
xercesImpl.jar=${xerces.lib}/xercesImpl.jar
xmlParserAPIs.jar=${xerces.lib}/xmlParserAPIs.jar
xerces.loc=http://xml.apache.org/dist/xerces-j/old_xerces2/Xerces-J-bin.2.3.0.tar.gz
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18465] - Problem in build file with bad xerces value
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18465. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18465 Problem in build file with bad xerces value [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 15:03 --- Fixed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.properties.default
jfarcand2003/03/28 07:10:03
Modified:.build.properties.default
Log:
Revert last commit. Did not download the right file. The packaging structure is the
same.
Revision ChangesPath
1.84 +2 -2 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.83
retrieving revision 1.84
diff -u -r1.83 -r1.84
--- build.properties.default 28 Mar 2003 14:59:23 - 1.83
+++ build.properties.default 28 Mar 2003 15:10:03 - 1.84
@@ -119,7 +119,7 @@
# - Xerces XML Parser, version 2.3.0 -
xerces.home=${base.path}/xerces-2_3_0
-xerces.lib=${xerces.home}/tools
+xerces.lib=${xerces.home}
xercesImpl.jar=${xerces.lib}/xercesImpl.jar
xmlParserAPIs.jar=${xerces.lib}/xmlParserAPIs.jar
xerces.loc=http://xml.apache.org/dist/xerces-j/old_xerces2/Xerces-J-bin.2.3.0.tar.gz
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: FYI: PureTLS 0.9b3 Released
Remy Maucherat wrote: Henri Gomez wrote: 0.9b3 Released! The current version of PureTLS is 0.9b3. New features include Security fix: Improved Bleichenbacher (million-message attack) protection (only relevant for servers) Checking for Basic Constraints in CA certificates Checking for Key Usage in CA certificates Validity date checking for certificates General bug fixes I'm only building against PureTLS. Is it 100% binary compatible with the old one ? Didn't test it yet, message forwarded to eric ;-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18475] New: - Invalid handling of auth type in WarpRequestHandler.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18475.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18475
Invalid handling of auth type in WarpRequestHandler.java
Summary: Invalid handling of auth type in
WarpRequestHandler.java
Product: Tomcat 5
Version: 5.0.0
Platform: All
OS/Version: All
Status: NEW
Severity: Major
Priority: Other
Component: Connector:Webapp
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]
WarpRequestHandler.handle(WarpConnection connection, WarpPacket packet)::
case Constants.TYPE_REQ_AUTH: {
String user=packet.readString();
String auth=packet.readString();
if (Constants.DEBUG)
logger.debug(Request user=+user+ auth=+auth);
request.setAuthType(auth);
// What to do for user name?
if(user != null auth != null auth.equals(Basic)) {
Principal prin = new BasicPrincipal(user);
request.setUserPrincipal(prin);
}
break;
}
The section of code above does not appropriately handle authenticated usernames
from the host web server. It also misleads users by reporting in the log that
the username is actually being passed to tomcat. The problem is that the
setting of the username is conditional on the authType String matching exactly
the word Basic. The default Authorization HTTP request header is of
type Basic but the RPC allows for any Authroization type; it even
mentions an example of type Kerberos.
Many schools have implemented custom HTTP Authroization types and the warp
connector will not appropriately deal with them. I have modified this class so
that our authentication mechanisms will work with warp and that code segment is
below:
WarpRequestHandler.handle(WarpConnection connection, WarpPacket packet)::
case Constants.TYPE_REQ_AUTH: {
String user=packet.readString();
String auth=packet.readString();
if (Constants.DEBUG)
logger.debug(Request user=+user+ auth=+auth);
request.setAuthType(auth);
// What to do for user name?
// Steve Barrett, [EMAIL PROTECTED] - 2003.03.28, will report in bugzilla
//if(user != null auth != null auth.equals(Basic)) {
if(user != null ) { // auth != null auth.equals
(Basic)) {
Principal prin = new BasicPrincipal(user);
request.setUserPrincipal(prin);
}
break;
}
This, however, is also not an appropriate solution because it allows ANY
request that appears to have properly authenticated a user to pass a username
to tomcat. It would be more appropriate if the ability to accept usernames
from front ends were a switch (like 'tomcatAuthentication=false' in ajp13)
and even better if there were an attribute which allowed the HTTP Authorization
request headers to be specified so that sites could define which type of
authtype they would be willing to accept.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18477] New: - JspC: unable to precompile linked jsp files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18477. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18477 JspC: unable to precompile linked jsp files Summary: JspC: unable to precompile linked jsp files Product: Tomcat 4 Version: 4.1.18 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Jasper 2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Here's the command I used to precompile my web application: java -classpath ~/tomcat/common/lib/servlet.jar:~/tomcat/common/lib/jasper-compiler.jar:~/tomcat/common/lib/jasper-runtime.jar:~/tomcat/common/lib/ant.jar org.apache.jasper.JspC -v6 -l -s -d /tmp/ -uriroot $PROJECT_HOME/$CLIENT/pages $PROJECT_HOME/$CLIENT/pages/core/application_attributes.jsp. The file is actually under $PROJECT_HOME/base/core. Jspc generates an empty application_attributes_jsp.java under /tmp/$PRJECT_HOME/$CLIENT/pages/core. It seems Jspc is using canonical path of the jsp file and based on that, it changs the outputDir. Is there a way to get around it? cw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18229] - All threads are busy, waiting. resource leak bug?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18229. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18229 All threads are busy, waiting. resource leak bug? --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 18:57 --- I've also observed the same problem on Linux with Tomcat 4.1.18. We're using org.apache.coyote.tomcat4.CoyoteConnector with SSL (as well as some non-SSL). Because we are still in development, I tend to restart the server often so this problem is not too visible yet. But there's been a few times where I we didn't restart the server for a couple of days and the problem manifested itself. I then had to restart the server. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18478] New: - Services on different ports accessing each other's webapps.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18478. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18478 Services on different ports accessing each other's webapps. Summary: Services on different ports accessing each other's webapps. Product: Tomcat 4 Version: 4.1.12 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Tomcat seems to be confused when multiple services are listening on different ports. It is able to serve up files from webapps that are not configured for that service. In addition you can request files based on the name of the webapp directory in which they live, as well as the path of the webapp specified in the Context element in server.xml (last example below). I'm afraid that this isn't clear, so here are some examples which make clear what I mean. I have two webapps set up in different services, one (ROOT) listening on port 80 and the other (test) on port 8080. My server.xml is appended below. With this setup, the requests http://localhost:80/test/ http://localhost:8080/test/ both return the directory listing for the 'test' webapp. This result is unaffected by whether or not there is a directory named 'test' in the ROOT webapp. The requests http://localhost:80/ http://localhost:8080/ both return the directory listing for the ROOT webapp. However the log for each request is written to the expected access log file. Requests to port 80 result in logs to the ROOT access log; those to port 8080 result in logs to the 'test' access log. If I change the Context element for the 'test' webapp to be Context path= docBase=test debug=0/ the requests http://localhost:80/test/ http://localhost:8080 http://localhost:8080/test/ all return the same thing, the directory listing of the 'test' webapp. The port on which the request is made alters only where the access log is written as before. If I now change the Context element for the 'test' webapp to be Context path=/some-other-path docBase=test debug=0/ the requests http://localhost:80/test/ http://localhost:80/some-other-path/ http://localhost:8080/test/ http://localhost:8080/some-other-path/ all return the directory listing of the 'test' webapp. Logs written as before. Expected behaviour: - requests to a certain port are served by the service listening on that port, from the webapp configured for that port; - requests which refer to the directory name (docBase) of a webapp, rather than the specified path, should fail. -- -- -- server.xml: ?xml version=1.0 encoding=UTF-8? Server port=8005 shutdown=SHUTDOWN debug=0 Service name=Tomcat-Standalone Connector className=org.apache.coyote.tomcat4.CoyoteConnector port=80 minProcessors=5 maxProcessors=1000 enableLookups=true redirectPort=443 acceptCount=10 debug=0 connectionTimeout=6 scheme=http secure=false/ Engine name=Standalone defaultHost=localhost debug=0 Logger className=org.apache.catalina.logger.FileLogger prefix=catalina_log. suffix=.txt timestamp=true/ Realm className=org.apache.catalina.realm.MemoryRealm/ Host name=localhost debug=0 appBase=webapps unpackWARs=true Valve className=org.apache.catalina.valves.AccessLogValve directory=logs prefix=localhost_access_log. suffix=.txt pattern=common/ Logger className=org.apache.catalina.logger.FileLogger directory=logs prefix=localhost_log. suffix=.txt timestamp=true/ Context path= docBase=ROOT debug=0/ /Host /Engine /Service Service name=test Connector className=org.apache.coyote.tomcat4.CoyoteConnector port=8080 minProcessors=5 maxProcessors=1000 enableLookups=true redirectPort=443 acceptCount=10 debug=0 connectionTimeout=6 scheme=http secure=false/ Engine name=Standalone defaultHost=localhost debug=0 Logger className=org.apache.catalina.logger.FileLogger prefix=test_catalina_log. suffix=.txt timestamp=true/ Realm className=org.apache.catalina.realm.MemoryRealm/ Host name=localhost debug=0 appBase=webapps unpackWARs=true Valve className=org.apache.catalina.valves.AccessLogValve directory=logs prefix=test_localhost_access_log. suffix=.txt pattern=common/ Logger className=org.apache.catalina.logger.FileLogger directory=logs prefix=test_localhost_log. suffix=.txt
DO NOT REPLY [Bug 18479] New: - HttpSessionBindingListener.valueUnbound() not called
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18479. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18479 HttpSessionBindingListener.valueUnbound() not called Summary: HttpSessionBindingListener.valueUnbound() not called Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Other Status: NEW Severity: Major Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have an object that implements HttpSessionBindingListener. It calls valueBound fine. But it never calls valueUnbound. Not when it times out and not when Tomcat is closed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18480] New: - Index page comes with the html source on Mozilla 1.2. Works fine with IE 6.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18480. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18480 Index page comes with the html source on Mozilla 1.2. Works fine with IE 6.0 Summary: Index page comes with the html source on Mozilla 1.2. Works fine with IE 6.0 Product: Tomcat 5 Version: 5.0.0 Platform: Sun OS/Version: Solaris Status: NEW Severity: Major Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When I bringover the latest sources for tomcat from the cvs repository and run the server built from sources I get the html source for the index.html when accessing with Mozilla 1.2. It works fine with IE 6.0. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardPipeline.java
remm2003/03/28 06:58:08
Modified:catalina/src/share/org/apache/catalina/core
StandardPipeline.java
Log:
- Valves registration should only happen on start/stop, otherwise, the
container
hierarchy may not be initialized.
Does this mean valves can't be added without stoping the container which
will have to remove dynamic valve creation/addition feature in admin?
Amy
Revision ChangesPath
1.7 +7 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/Standard
Pipeline.java
Index: StandardPipeline.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/cor
e/StandardPipeline.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- StandardPipeline.java 27 Mar 2003 03:06:39 - 1.6
+++ StandardPipeline.java 28 Mar 2003 14:58:08 - 1.7
@@ -477,6 +477,8 @@
} catch (LifecycleException e) {
log.error(StandardPipeline.addValve: start: , e);
}
+// Register the newly added valve
+registerValve(valve);
}
// Add this Valve to the set associated with this Pipeline
@@ -486,8 +488,6 @@
results[valves.length] = valve;
valves = results;
}
-// register the newly added valve
-registerValve(valve);
}
@@ -602,9 +602,9 @@
} catch (LifecycleException e) {
log.error(StandardPipeline.removeValve: stop: , e);
}
+// Unregister the removed valave
+unregisterValve(valve);
}
-// unregister the removed valave
-unregisterValve(valve);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18222] - when I click on link to Webapps: Administration tomcat threw an exception.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18222. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18222 when I click on link to Webapps: Administration tomcat threw an exception. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18061] - symlink to jar in WEB-INF/lib does not work on application reload
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18061. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18061 symlink to jar in WEB-INF/lib does not work on application reload [EMAIL PROTECTED] changed: What|Removed |Added Component|Webapps:Administration |Catalina - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18165] - Cannot access my project folder , but can from examples in webapps
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18165 Cannot access my project folder , but can from examples in webapps [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 20:10 --- Please ask user questions on tomcat-user instead of filing bugs. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 12643] - Undeploy an Existing Application in the Manager App fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12643. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12643 Undeploy an Existing Application in the Manager App fails [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18229] - All threads are busy, waiting. resource leak bug?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18229. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18229 All threads are busy, waiting. resource leak bug? [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 20:28 --- If you are using SSL, you must upgrade to 4.1.24, because there's that problem where client behavior can cause the connector to die. Whatever issue may or may not exist in JK 2 IS NOT THE SAME ISSUE. Please do not reopen that bug about that. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18480] - Index page comes with the html source on Mozilla 1.2. Works fine with IE 6.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18480. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18480 Index page comes with the html source on Mozilla 1.2. Works fine with IE 6.0 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 20:30 --- You have to point out an actual HTTP handling bug. Moz has LOTS of small problems with HTTP handling (disabling pipelining is the usual answer). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java
luehe 2003/03/28 12:56:16
Modified:catalina/src/share/org/apache/catalina/startup
TldConfig.java
Log:
Changed timing of setUseCaches call on JarURLConnection, to prevent
java.lang.IllegalStateException
Revision ChangesPath
1.4 +8 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java
Index: TldConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TldConfig.java26 Mar 2003 20:40:37 - 1.3
+++ TldConfig.java28 Mar 2003 20:56:15 - 1.4
@@ -444,7 +444,9 @@
resourcePath));
}
url = new URL(jar: + url.toString() + !/);
- tldScanJar((JarURLConnection) url.openConnection());
+ JarURLConnection conn = (JarURLConnection) url.openConnection();
+ conn.setUseCaches(false);
+ tldScanJar(conn);
}
/*
@@ -462,7 +464,6 @@
String jarPath = conn.getJarFileURL().toString();
try {
- conn.setUseCaches(false);
jarFile = conn.getJarFile();
Enumeration entries = jarFile.entries();
while (entries.hasMoreElements()) {
@@ -725,14 +726,17 @@
for (int i=0; iurls.length; i++) {
URLConnection conn = urls[i].openConnection();
if (conn instanceof JarURLConnection) {
+ conn.setUseCaches(false);
globalJarPaths.add((JarURLConnection) conn);
} else {
String urlStr = urls[i].toString();
if (urlStr.startsWith(file:)
urlStr.endsWith(.jar)) {
URL jarURL = new URL(jar: + urlStr + !/);
- globalJarPaths.add((JarURLConnection)
-jarURL.openConnection());
+ JarURLConnection jarConn = (JarURLConnection)
+ jarURL.openConnection();
+ jarConn.setUseCaches(false);
+ globalJarPaths.add(jarConn);
}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
HttpSessionBindingListener.valueUnbound() not called
Hi; I have an object that implements HttpSessionBindingListener. It calls valueBound fine. But it never calls valueUnbound. Not when it times out and not when Tomcat is closed. I am running 4.1.18. Any ideas? thanks - dave - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/admin/users group.jsp groups.jspf roles.jspf user.jsp
amyroh 2003/03/28 14:38:36 Modified:webapps/admin/users group.jsp groups.jspf roles.jspf user.jsp Log: Fix tomcat-user page. Revision ChangesPath 1.6 +2 -1 jakarta-tomcat-catalina/webapps/admin/users/group.jsp Index: group.jsp === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/group.jsp,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- group.jsp 12 Feb 2003 10:08:45 - 1.5 +++ group.jsp 28 Mar 2003 22:38:35 - 1.6 @@ -108,7 +108,8 @@ /table bean:define id=checkboxes scope=page value=true/ - + br + %@ include file=roles.jspf % %@ include file=../buttons.jsp % 1.4 +11 -9 jakarta-tomcat-catalina/webapps/admin/users/groups.jspf Index: groups.jspf === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/groups.jspf,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- groups.jspf 28 Mar 2003 02:51:07 - 1.3 +++ groups.jspf 28 Mar 2003 22:38:35 - 1.4 @@ -7,22 +7,23 @@ cellspacing=0 cellpadding=0 width=100% tr class=header-row logic:present name=checkboxes -th scope=col width=5%div align=left class=table-header-text +td width=5%div align=left class=table-header-text nbsp; -/th +/td /logic:present - th scope=col width=20%div align=left class=table-header-text + td width=20%div align=left class=table-header-text bean:message key=users.list.groupname/ - /div/th - th scope=coldiv align=left class=table-header-text + /div/td + tddiv align=left class=table-header-text bean:message key=users.list.description/ - /div/th + /div/td /tr +logic:present name=groupsForm logic:iterate name=groupsForm property=groups id=group type=java.lang.String tr class=line-row logic:present name=checkboxes - td scope=rowdiv align=center class=table-normal-text + tddiv align=center class=table-normal-text logic:present name=userForm label for=groups/label html:multibox property=groups value=%= group % styleId=groups/ @@ -34,7 +35,7 @@ /logic:notPresent /td /logic:present -td scope=rowdiv align=left class=table-normal-textnbsp; +tddiv align=left class=table-normal-textnbsp; html:link page='%= /users/setUpGroup.do?objectName= + URLEncoder.encode(group) + databaseName= + @@ -42,11 +43,12 @@ controls:attribute name=group attribute=groupname/ /html:link /div/td -td scope=rowdiv align=left class=table-normal-textnbsp; +tddiv align=left class=table-normal-textnbsp; controls:attribute name=group attribute=description/ /div/td /tr /logic:iterate +/logic:present /table /td/tr/table 1.4 +9 -7 jakarta-tomcat-catalina/webapps/admin/users/roles.jspf Index: roles.jspf === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/roles.jspf,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- roles.jspf28 Mar 2003 02:51:07 - 1.3 +++ roles.jspf28 Mar 2003 22:38:35 - 1.4 @@ -11,18 +11,19 @@ nbsp; /td /logic:present - th scope=col width=20%div align=left class=table-header-text + td width=20%div align=left class=table-header-text bean:message key=users.list.rolename/ - /div/th - th scope=coldiv align=left class=table-header-text + /div/td + tddiv align=left class=table-header-text bean:message key=users.list.description/ - /div/th + /div/td /tr +logic:present name=rolesForm logic:iterate name=rolesForm property=roles id=role type=java.lang.String tr class=line-row logic:present name=checkboxes - td scope=rowdiv align=center class=table-normal-text + tddiv align=center class=table-normal-text logic:present name=groupForm label for=roles/label html:multibox property=roles value=%= role % styleId=roles/ @@ -40,7 +41,7 @@ /logic:notPresent /td /logic:present -td scope=rowdiv align=left class=table-normal-textnbsp; +tddiv align=left
cvs commit: jakarta-tomcat-4.0/webapps/admin/users group.jsp groups.jspf roles.jspf user.jsp
amyroh 2003/03/28 14:46:38 Modified:webapps/admin/users group.jsp groups.jspf roles.jspf user.jsp Log: Fix bugzilla 18268. Revision ChangesPath 1.8 +1 -0 jakarta-tomcat-4.0/webapps/admin/users/group.jsp Index: group.jsp === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/group.jsp,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- group.jsp 12 Feb 2003 10:04:10 - 1.7 +++ group.jsp 28 Mar 2003 22:46:38 - 1.8 @@ -109,6 +109,7 @@ bean:define id=checkboxes scope=page value=true/ br + %@ include file=roles.jspf % %@ include file=../buttons.jsp % 1.4 +2 -0 jakarta-tomcat-4.0/webapps/admin/users/groups.jspf Index: groups.jspf === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/groups.jspf,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- groups.jspf 15 Jan 2003 22:25:22 - 1.3 +++ groups.jspf 28 Mar 2003 22:46:38 - 1.4 @@ -18,6 +18,7 @@ bean:message key=users.list.description/ /div/td /tr +logic:present name=groupsForm logic:iterate name=groupsForm property=groups id=group type=java.lang.String tr class=line-row @@ -47,6 +48,7 @@ /div/td /tr /logic:iterate +/logic:present /table /td/tr/table 1.5 +2 -0 jakarta-tomcat-4.0/webapps/admin/users/roles.jspf Index: roles.jspf === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/roles.jspf,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- roles.jspf15 Jan 2003 22:25:22 - 1.4 +++ roles.jspf28 Mar 2003 22:46:38 - 1.5 @@ -18,6 +18,7 @@ bean:message key=users.list.description/ /div/td /tr +logic:present name=rolesForm logic:iterate name=rolesForm property=roles id=role type=java.lang.String tr class=line-row @@ -53,6 +54,7 @@ /div/td /tr /logic:iterate +/logic:present /table /td/tr/table 1.9 +3 -0 jakarta-tomcat-4.0/webapps/admin/users/user.jsp Index: user.jsp === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/user.jsp,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- user.jsp 12 Feb 2003 10:04:10 - 1.8 +++ user.jsp 28 Mar 2003 22:46:38 - 1.9 @@ -120,6 +120,9 @@ bean:define id=checkboxes scope=page value=true/ br + %@ include file=groups.jspf % + br + %@ include file=roles.jspf % %@ include file=../buttons.jsp % - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18268] - cannot assign roles to users in administrator webapp
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18268. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18268 cannot assign roles to users in administrator webapp [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-03-28 22:49 --- Fixed in cvs. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/admin/users groups.jspf roles.jspf
amyroh 2003/03/28 14:56:33 Modified:webapps/admin/users groups.jspf roles.jspf Log: Put back scope for accessibility. Revision ChangesPath 1.5 +9 -9 jakarta-tomcat-catalina/webapps/admin/users/groups.jspf Index: groups.jspf === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/groups.jspf,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- groups.jspf 28 Mar 2003 22:38:35 - 1.4 +++ groups.jspf 28 Mar 2003 22:56:32 - 1.5 @@ -7,23 +7,23 @@ cellspacing=0 cellpadding=0 width=100% tr class=header-row logic:present name=checkboxes -td width=5%div align=left class=table-header-text +th scope=col width=5%div align=left class=table-header-text nbsp; -/td +/th /logic:present - td width=20%div align=left class=table-header-text + th scope=col width=20%div align=left class=table-header-text bean:message key=users.list.groupname/ - /div/td - tddiv align=left class=table-header-text + /div/th + th scope=coldiv align=left class=table-header-text bean:message key=users.list.description/ - /div/td + /div/th /tr logic:present name=groupsForm logic:iterate name=groupsForm property=groups id=group type=java.lang.String tr class=line-row logic:present name=checkboxes - tddiv align=center class=table-normal-text + td scope=rowdiv align=center class=table-normal-text logic:present name=userForm label for=groups/label html:multibox property=groups value=%= group % styleId=groups/ @@ -35,7 +35,7 @@ /logic:notPresent /td /logic:present -tddiv align=left class=table-normal-textnbsp; +td scope=rowdiv align=left class=table-normal-textnbsp; html:link page='%= /users/setUpGroup.do?objectName= + URLEncoder.encode(group) + databaseName= + @@ -43,7 +43,7 @@ controls:attribute name=group attribute=groupname/ /html:link /div/td -tddiv align=left class=table-normal-textnbsp; +td scope=rowdiv align=left class=table-normal-textnbsp; controls:attribute name=group attribute=description/ /div/td /tr 1.5 +7 -7 jakarta-tomcat-catalina/webapps/admin/users/roles.jspf Index: roles.jspf === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/roles.jspf,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- roles.jspf28 Mar 2003 22:38:35 - 1.4 +++ roles.jspf28 Mar 2003 22:56:32 - 1.5 @@ -11,19 +11,19 @@ nbsp; /td /logic:present - td width=20%div align=left class=table-header-text + th scope=col width=20%div align=left class=table-header-text bean:message key=users.list.rolename/ - /div/td - tddiv align=left class=table-header-text + /div/th + th scope=coldiv align=left class=table-header-text bean:message key=users.list.description/ - /div/td + /div/th /tr logic:present name=rolesForm logic:iterate name=rolesForm property=roles id=role type=java.lang.String tr class=line-row logic:present name=checkboxes - tddiv align=center class=table-normal-text + td scope=rowdiv align=center class=table-normal-text logic:present name=groupForm label for=roles/label html:multibox property=roles value=%= role % styleId=roles/ @@ -41,7 +41,7 @@ /logic:notPresent /td /logic:present -tddiv align=left class=table-normal-textnbsp; +td scope=rowdiv align=left class=table-normal-textnbsp; html:link page='%= /users/setUpRole.do?objectName= + URLEncoder.encode(role) + databaseName= + @@ -49,7 +49,7 @@ controls:attribute name=role attribute=rolename/ /html:link /div/td -tddiv align=left class=table-normal-textnbsp; +td scope=rowdiv align=left class=table-normal-textnbsp; controls:attribute name=role attribute=description/ /div/td /tr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18485] New: - Jasper tries to write something directly to $CATALINA_HOME
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18485. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18485 Jasper tries to write something directly to $CATALINA_HOME Summary: Jasper tries to write something directly to $CATALINA_HOME Product: Tomcat 4 Version: 4.1.24 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: Other Component: Jasper 2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I'm not a Java programmer so I'm not sure if I understand these errors correctly, but this is only contribution I can make.. I think there is something wrong with Jasper compiler in Tomcat 4.1.24. This error did not apear in my last Tomcat - 4.1.18. While compiling a java code, Tomcat's 4.1.24 japser tries to write something directly to $CATALINA_HOME. It shouldn't - usually Tomcat does not have write access to that directory. Messages below are from my Cocoon 2.0.4 context log. They apear when I use JspGenerator, but I'm sure that is not a Cocoon related issue, because this has been working fine in 4.1.18. ---x- 2003-03-28 18:31:28 Error compiling file: /home/stuff/tomcat- 4.1.24/work/Standalone/head/cocoon-2.0.4- dev/samples/generation/jsp_jsp.java [javac] Since fork is true, ignoring compiler setting. [javac] Compiling 1 source file [javac] Since fork is true, ignoring compiler setting. 2003-03-28 18:31:28 Info: Compile: javaFileName=/home/stuff/tomcat- 4.1.24/work/Standalone/head/cocoon-2.0.4-dev/samples/generation/jsp_jsp.java classpath=/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/classes/:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/avalon-framework-20020627.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/batik-all- 1.5b2.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/bsf-2.2.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/cocoon-2.0.4.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4- dev/WEB-INF/lib/commons-collections-2.1.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/commons-httpclient- 20020423.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/commons-jxpath-1.0.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon- 2.0.4-dev/WEB-INF/lib/commons-logging-1.0.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/deli- 0.50.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-altrmi-common-20020916.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-altrmi-server-impl- 20020916.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-altrmi-server-interfaces-20020916.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-cli- 1.0.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-collections-20020820.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-component- 20020916.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-concurrent-20020820.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-datasource-vm14- 20021121.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-i18n-1.0.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon- 2.0.4-dev/WEB-INF/lib/excalibur-instrument-20021108.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-instrument-manager- 20021108.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-instrument-manager-interfaces-20021108.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-io- 1.1.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-logger-20020820.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-monitor- 20020820.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-naming-1.0.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon- 2.0.4-dev/WEB-INF/lib/excalibur-pool-20020820.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-sourceresolve- 20020820.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB- INF/lib/excalibur-store-20020820.jar:/home/stuff/tomcat- 4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-INF/lib/excalibur-xmlutil- 20020820.jar:/home/stuff/tomcat-4.1.24/webapps/head/cocoon-2.0.4-dev/WEB-
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java Generator.java TagFileProcessor.java
luehe 2003/03/28 15:15:46
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Generator.java TagFileProcessor.java
Log:
Implemented latest JSP 2.0 spec changes regarding dynamic attributes
in Tag Files:
- Dynamic attributes are exposed in a Map named for the value of the
dynamic-attributes tag-directive attribute
- The Map contains each dynamic attribute name as the key and the
dynamic attribute value as the corresponding value. Only dynamic
attributes with no uri are to be present in the Map; all other
dynamic attributes are ignored.
Revision ChangesPath
1.62 +1 -0
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.61
retrieving revision 1.62
diff -u -r1.61 -r1.62
--- Compiler.java 28 Mar 2003 02:13:02 - 1.61
+++ Compiler.java 28 Mar 2003 23:15:45 - 1.62
@@ -196,6 +196,7 @@
throws Exception
{
long t1=System.currentTimeMillis();
+
// Setup page info area
pageInfo = new PageInfo(new BeanRepository(ctxt.getClassLoader(),
errDispatcher));
1.177 +18 -22
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.176
retrieving revision 1.177
diff -u -r1.176 -r1.177
--- Generator.java24 Mar 2003 17:35:26 - 1.176
+++ Generator.java28 Mar 2003 23:15:45 - 1.177
@@ -2880,7 +2880,7 @@
gen.compileTagHandlerPoolList(page);
}
if (gen.ctxt.isTagFile()) {
- TagInfo tagInfo = gen.ctxt.getTagInfo();
+ JasperTagInfo tagInfo = (JasperTagInfo) gen.ctxt.getTagInfo();
gen.generateTagHandlerPreamble(tagInfo, page);
if (gen.ctxt.isPrototypeMode()) {
@@ -2913,7 +2913,8 @@
/*
* Generates tag handler preamble.
*/
-private void generateTagHandlerPreamble(TagInfo tagInfo, Node.Nodes tag )
+private void generateTagHandlerPreamble(JasperTagInfo tagInfo,
+ Node.Nodes tag )
throws JasperException
{
@@ -3063,7 +3064,7 @@
throws JasperException {
if (tagInfo.hasDynamicAttributes()) {
- out.printil(private java.util.HashMap dynamicAttrs = new
java.util.HashMap(););
+ out.printil(private java.util.HashMap _jspx_dynamic_attrs = new
java.util.HashMap(););
}
// Declare attributes
@@ -3218,15 +3219,13 @@
public void generateSetDynamicAttribute() {
out.printil(public void setDynamicAttribute(String uri, String localName,
Object value) throws javax.servlet.jsp.JspException {);
out.pushIndent();
- out.printil(if (uri != null));
- out.pushIndent();
- // XXX Specification still needs to clarify what the variable name
- // looks like. Assume uri_localName for now.
- out.printil(dynamicAttrs.put(uri + \_\ + localName, value););
- out.popIndent();
- out.printil(else);
+ /*
+ * According to the spec, only dynamic attributes with no uri are to
+ * be present in the Map; all other dynamic attributes are ignored.
+ */
+ out.printil(if (uri == null));
out.pushIndent();
- out.printil(dynamicAttrs.put(localName, value););
+ out.printil(_jspx_dynamic_attrs.put(localName, value););
out.popIndent();
out.popIndent();
out.printil(});
@@ -3237,7 +3236,7 @@
* Also, if the tag accepts dynamic attributes, a page-scoped variable
* is made available for each dynamic attribute that was passed in.
*/
-private void generatePageScopedVariables(TagInfo tagInfo) {
+private void generatePageScopedVariables(JasperTagInfo tagInfo) {
// normal attributes
TagAttributeInfo[] attrInfos = tagInfo.getAttributes();
@@ -3253,14 +3252,11 @@
out.popIndent();
}
- // dynamic attributes
+ // Expose the Map containing dynamic attributes as a page-scoped var
if (tagInfo.hasDynamicAttributes()) {
- out.printil(for (java.util.Iterator i =
dynamicAttrs.entrySet().iterator(); i.hasNext(); ) {);
- out.pushIndent();
- out.printil(java.util.Map.Entry e = (java.util.Map.Entry) i.next(););
- out.printil(pageContext.setAttribute((String) e.getKey(),
e.getValue()););
-
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JasperTagInfo.java
luehe 2003/03/28 15:16:24
Added: jasper2/src/share/org/apache/jasper/compiler
JasperTagInfo.java
Log:
Implemented latest JSP 2.0 spec changes regarding dynamic attributes
in Tag Files:
- Dynamic attributes are exposed in a Map named for the value of the
dynamic-attributes tag-directive attribute
- The Map contains each dynamic attribute name as the key and the
dynamic attribute value as the corresponding value. Only dynamic
attributes with no uri are to be present in the Map; all other
dynamic attributes are ignored.
Revision ChangesPath
1.1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JasperTagInfo.java
Index: JasperTagInfo.java
===
/*
* $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JasperTagInfo.java,v
1.1 2003/03/28 23:16:24 luehe Exp $
* $Revision: 1.1 $
* $Date: 2003/03/28 23:16:24 $
*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Tomcat, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
*/
package org.apache.jasper.compiler;
import javax.servlet.jsp.tagext.*;
/**
* TagInfo extension used by tag handlers that are implemented via tag files.
* This class provides access to the name of the Map used to store the
* dynamic attribute names and values passed to the custom action invocation.
* This information is used by the code generator.
*/
class JasperTagInfo extends TagInfo {
private String dynamicAttrsMapName;
public JasperTagInfo(String tagName,
String tagClassName,
String bodyContent,
String infoString,
TagLibraryInfo taglib,
TagExtraInfo tagExtraInfo,
TagAttributeInfo[] attributeInfo,
String displayName,
String smallIcon,
String largeIcon,
TagVariableInfo[] tvi,
String mapName) {
super(tagName, tagClassName, bodyContent, infoString, taglib,
tagExtraInfo, attributeInfo, displayName, smallIcon, largeIcon,
Moving org.apache.coyote.tomcat5
To remove one of the circular deps and simplify the build - I will move the tomcat5-specific part of coyote to jakarta-tomcat-catalina. This way we have a one way dependency between catalina and coyote. I'll keep the package name so no other change will be needed ( except the build file - to jar both ). Probably end of the weekend I'll check in ( unless someone -1 ). Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler ELFunctionMapper.java JspUtil.java
kinman 2003/03/28 17:58:50
Modified:jasper2/src/share/org/apache/jasper/compiler
ELFunctionMapper.java JspUtil.java
Log:
- Allow arrays in function signatures.
Revision ChangesPath
1.7 +26 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ELFunctionMapper.java
Index: ELFunctionMapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ELFunctionMapper.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ELFunctionMapper.java 28 Mar 2003 02:18:52 - 1.6
+++ ELFunctionMapper.java 29 Mar 2003 01:58:50 - 1.7
@@ -173,9 +173,6 @@
el.visit(fv);
ArrayList functions = fv.funcs;
- // TODO Some optimization here: if the fmap has only one entry,
- // if it was generated before, use it.
-
if (functions.size() == 0) {
return;
}
@@ -205,7 +202,29 @@
if (k != 0) {
ds.append(, );
}
- ds.append(params[k] + .class);
+ int iArray = params[k].indexOf('[');
+ if (iArray 0) {
+ ds.append(params[k] + .class);
+ }
+ else {
+ String baseType = params[k].substring(0, iArray);
+ ds.append(java.lang.reflect.Array.newInstance();
+ ds.append(baseType);
+ ds.append(.class,);
+
+ // Count the number of array dimension
+ int aCount = 0;
+ for (int jj = iArray; jj params[k].length(); jj++ ) {
+ if (params[k].charAt(jj) == '[') {
+ aCount++;
+ }
+ }
+ if (aCount == 1) {
+ ds.append(0).getClass());
+ } else {
+ ds.append(new int[ + aCount + ]).getClass());
+ }
+ }
}
ds.append(});\n);
// Put the current name in the global function map
@@ -230,6 +249,9 @@
// If not all in the previous match, then no match.
return null;
}
+ } else if (mapName != null) {
+ // If not all in the previous match, then no match.
+ return null;
}
}
return mapName;
1.35 +35 -13
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspUtil.java
Index: JspUtil.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspUtil.java,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- JspUtil.java 19 Mar 2003 20:51:34 - 1.34
+++ JspUtil.java 29 Mar 2003 01:58:50 - 1.35
@@ -461,24 +461,46 @@
*/
public static Class toClass(String type, ClassLoader loader)
throws ClassNotFoundException {
+
+ Class c = null;
+ int i0 = type.indexOf('[');
+ int dims = 0;
+ if (i0 0) {
+ // This is an array. Count the dimensions
+ for (int i = 0; i type.length(); i++) {
+ if (type.charAt(i) == '[')
+ dims++;
+ }
+ type = type.substring(0, i0);
+ }
+
if (boolean.equals(type))
- return boolean.class;
+ c = boolean.class;
else if (char.equals(type))
- return char.class;
+ c = char.class;
else if (byte.equals(type))
- return byte.class;
+ c = byte.class;
else if (short.equals(type))
- return short.class;
+ c = short.class;
else if (int.equals(type))
- return int.class;
+ c = int.class;
else if (long.equals(type))
- return long.class;
+ c = long.class;
else if (float.equals(type))
- return float.class;
+ c = float.class;
else if (double.equals(type))
- return double.class;
- else
- return loader.loadClass(type);
+ c = double.class;
+ else if (type.indexOf('[') 0)
+ c = loader.loadClass(type);
+
+ if (dims == 0)
+ return c;
+
+ if (dims == 1)
+ return java.lang.reflect.Array.newInstance(c, 1).getClass();
+
+ // Array of more than i dimension
+ return java.lang.reflect.Array.newInstance(c, new int[dims]).getClass();
}
/**
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java
kinman 2003/03/28 18:15:18
Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java
Added: jasper2/src/share/org/apache/jasper
EmbeddedServletOptions.java
Removed: jasper2/src/share/org/apache/jasper
EmbededServletOptions.java
Log:
- Rename EmbededServletOptions.java to EmbeddedServletOptions.java
Revision ChangesPath
1.1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbeddedServletOptions.java
Index: EmbeddedServletOptions.java
===
/*
* $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbeddedServletOptions.java,v
1.1 2003/03/29 02:15:18 kinman Exp $
* $Revision: 1.1 $
* $Date: 2003/03/29 02:15:18 $
*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Tomcat, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
*/
package org.apache.jasper;
import java.io.File;
import java.util.*;
import javax.servlet.ServletConfig;
import javax.servlet.ServletContext;
import org.apache.jasper.compiler.TldLocationsCache;
import org.apache.jasper.compiler.JspConfig;
import org.apache.jasper.compiler.TagPluginManager;
import org.apache.jasper.compiler.Localizer;
import org.apache.jasper.xmlparser.ParserUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
/**
* A class to hold all init parameters specific to the JSP engine.
*
* @author Anil K. Vijendran
* @author Hans Bergsten
* @author Pierre Delisle
*/
public final class EmbeddedServletOptions implements Options {
// Logger
private static Log log = LogFactory.getLog(EmbeddedServletOptions.class);
private Properties settings = new Properties();
/**
* Is Jasper being used in development mode?
*/
private boolean development = true;
/**
* Should Ant fork its java compiles of JSP pages.
*/
public boolean fork = true;
/**
* Do you want to keep the generated Java files around?
*/
private boolean keepGenerated = true;
/**
* Do you want support for large files? What this essentially
* means is that we generated code so
DO NOT REPLY [Bug 18488] New: - it will throw exception when I logout
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18488. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18488 it will throw exception when I logout Summary: it will throw exception when I logout Product: Tomcat 4 Version: 4.1.24 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] it will throw exception when I logout . The following is the steps. 1.When I change some code,I use ant deploy tool to deploy my war package. tool: taskdef name=deploy classname=org.apache.catalina.ant.DeployTask / 2. I logout ,don't close web page window. -- session.invalidate(); 1st time, it do nothing. second time, it will throw java.lang.NullPointerException exception. this is the exception. HTTP Status 500 - type Exception report message description The server encountered an internal error () that prevented it from fulfilling this request. exception org.apache.jasper.JasperException at org.apache.jasper.servlet.JspServletWrapper.service (JspServletWrapper.java:254) at org.apache.jasper.servlet.JspServlet.serviceJspFile (JspServlet.java:295) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.gnu.web.SetCharacterEncodingFilter.doFilter (SetCharacterEncodingFilter.java:112) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:256) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:191) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.authenticator.AuthenticatorBase.invoke (AuthenticatorBase.java:494) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContext.invoke (StandardContext.java:2415) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:180) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java:171) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:172) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.authenticator.SingleSignOn.invoke (SingleSignOn.java:400) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardEngineValve.invoke (StandardEngineValve.java:174) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.coyote.tomcat4.CoyoteAdapter.service (CoyoteAdapter.java:223) at org.apache.coyote.http11.Http11Processor.process (Http11Processor.java:594) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnectio
DO NOT REPLY [Bug 18489] New: - thread leak in deploy war package
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18489. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18489 thread leak in deploy war package Summary: thread leak in deploy war package Product: Tomcat 4 Version: 4.1.24 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When I use ant deploy tool to redeploy my war (undeploy and deploy), after finished, tomcat will increase 2 or 3 thread. and it never decrease . this bug in tomcat 4.1.12,4.1.18,4.1.24 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18449] - symbol __divdi3: referenced symbol not found
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18449. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18449 symbol __divdi3: referenced symbol not found --- Additional Comments From [EMAIL PROTECTED] 2003-03-29 06:50 --- After looking at different bits of java code I noticed that I could edit build.properties file in the jakarta-tomcat-connectors-4.1.24-src/jk/build.properties file to include the line: build.native.cc=gcc I haven't seen this in any documentation but it saves creating a symbolic link to gcc from cc as per my previous comment. Still doesn't solve the problem though. Al - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14Support.java JSSESupport.java
billbarker2003/03/28 23:37:25
Modified:util/java/org/apache/tomcat/util/net/jsse JSSE14Support.java
JSSESupport.java
Log:
Yet more improvements for JSSE 1.1.x
The timeout is still problematic. The settings here work-for-me, but I'm open to
tweaking. The old settings were too strict, since they didn't give enough time for
non-MSIE browsers to finish the client interaction. The new settings are still a
little slow however.
The main fix is that since JSSE 1.1.x already computes X509Certificates, we don't
have to waste cycles computing them again.
Revision ChangesPath
1.2 +36 -7
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14Support.java
Index: JSSE14Support.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14Support.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JSSE14Support.java17 Mar 2003 04:04:07 - 1.1
+++ JSSE14Support.java29 Mar 2003 07:37:25 - 1.2
@@ -64,13 +64,15 @@
import java.net.*;
import java.util.Vector;
import java.security.cert.CertificateFactory;
+import java.security.cert.X509Certificate;
+import java.security.cert.Certificate;
import javax.net.ssl.SSLSession;
import javax.net.ssl.SSLSocket;
import javax.net.ssl.SSLException;
import javax.net.ssl.HandshakeCompletedListener;
import javax.net.ssl.HandshakeCompletedEvent;
import java.security.cert.CertificateFactory;
-import javax.security.cert.X509Certificate;
+
/* JSSESupport
@@ -112,12 +114,14 @@
throws IOException {
InputStream in = socket.getInputStream();
int oldTimeout = socket.getSoTimeout();
-socket.setSoTimeout(100);
+socket.setSoTimeout(1000);
byte[] b = new byte[0];
listener.reset();
socket.startHandshake();
-int maxTries = 50; // 50 * 100 = example 5 second rehandshake timeout
+int maxTries = 60; // 60 * 1000 = example 1 minute time out
for (int i = 0; i maxTries; i++) {
+ if(logger.isTraceEnabled())
+ logger.trace(Reading for try # +i);
try {
int x = in.read(b);
} catch(SSLException sslex) {
@@ -136,14 +140,39 @@
}
}
+protected X509Certificate [] getX509Certificates(SSLSession session)
+ throws IOException {
+ Certificate [] certs = session.getPeerCertificates();
+ X509Certificate [] x509Certs = new X509Certificate[certs.length];
+ for(int i=0; i certs.length; i++) {
+ if( certs[i] instanceof X509Certificate ) {
+ // always currently true with the JSSE 1.1.x
+ x509Certs[i] = (X509Certificate)certs[i];
+ } else {
+ try {
+ byte [] buffer = certs[i].getEncoded();
+ CertificateFactory cf =
+ CertificateFactory.getInstance(X.509);
+ ByteArrayInputStream stream =
+ new ByteArrayInputStream(buffer);
+ x509Certs[i] = (X509Certificate)
+ cf.generateCertificate(stream);
+ } catch(Exception ex) {
+ logger.info(Error translating cert + certs[i], ex);
+ return null;
+ }
+ }
+ }
+ if(x509Certs.length 1)
+ return null;
+ return x509Certs;
+}
+
+
private static class Listener implements HandshakeCompletedListener {
volatile boolean completed = false;
public void handshakeCompleted(HandshakeCompletedEvent event) {
completed = true;
-if(logger.isTraceEnabled())
-logger.trace(SSL handshake done : Socket = +
- event.getSocket() );
-
}
void reset() {
completed = false;
1.5 +47 -38
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSESupport.java
Index: JSSESupport.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSESupport.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JSSESupport.java 17 Mar 2003 04:04:07 - 1.4
+++ JSSESupport.java 29 Mar 2003 07:37:25 - 1.5
@@ -84,6 +84,8 @@
*/
class JSSESupport implements SSLSupport {
+private org.apache.commons.logging.Log log =
+ org.apache.commons.logging.LogFactory.getLog(JSSESupport.class);
protected SSLSocket ssl;
@@ -105,51 +107,58 @@
return getPeerCertificateChain(false);
}
+
Classloading Mysteries: WHATSUP?
I have created a daemon which I want to startup when Tomcat is started up. If I configure the daemon to be started with a servlet in web.xml or by using a PlugIn interface and struts-config.xml, I get two daemons running. How I don't know. If I don't start the daemon at startup but by tweaking a servlet after startup, where the servlet calls the daemon, then I don't get two daemons. Does anyone have any idea how this is happening? I am getting two classloaders of the same type, i.e. same type but different hashcodes. Anyone know what is going on. I am running Struts 1.1 and Tomcat 1.1.18. I have asked this question in a few ways with no responses. I can find nothing relevant in the archives. They are both coming from the WebappClassLoader which has as a parent [EMAIL PROTECTED] Hopefully someone has some assistance, because I am somewhat at a loss. This must have something to do with the launcher, but I don't know what. I have tried to get some information for a week out of this list. Not sure if no one is doing PlugIns, or why there is so little interest in this. The hashcodes I get for the classloaders are as follows: LOOP: ClassLoader.hashCode(): 728272 Class.hashCode(): 15612583 Check No.: 657) Fri Mar 28 22:47:17 PST 2003 END LOOP: ClassLoader.hashCode(): 20632381 Class.hashCode(): 10973446 Check No.: 659) Fri Mar 28 22:47:19 PST 2003 END The details on the classloaders are: LOOP: ClassLoader.toString(): WebappClassLoader available: Extension[org.apache.commons.beanutils, implementationVendor=Apache Software Foundation, implementationVersion=1.4-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.collections, implementationVendor=Apache Software Foundation, implementationVersion=2.0, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.dbcp, implementationVendor=Apache Software Foundation, implementationVersion=1.0-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.digester, implementationVendor=Apache Software Foundation, implementationVersion=1.3-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[commons-lang, implementationVendor=Apache Software Foundation, implementationVersion=1.0-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.logging, implementationVendor=Apache Software Foundation, implementationVersion=1.0.1-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.pool, implementationVendor=Apache Software Foundation, implementationVersion=1.0, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.resources, implementationVendor=Apache Software Foundation, implementationVersion=0.1-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.services, implementationVendor=Apache Software Foundation, implementationVersion=1.0-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[Struts Framework, implementationVendor=Apache Software Foundation, implementationVendorId=org.apache, implementationVersion=1.0, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[Components Framework, implementationVendor=Apache Software Foundation, implementationVendorId=org.apache, implementationVersion=0.7, specificationVendor=Apache Software Foundation, specificationVersion=1.0] delegate: false repositories: /WEB-INF/classes/ required: -- Parent Classloader: StandardClassLoader available: delegate: true repositories: required: -- Parent Classloader: StandardClassLoader available: Extension[org.apache.tools.ant, implementationVendor=Apache Software Foundation, implementationVersion=1.5.1, specificationVendor=Apache Software Foundation, specificationVersion=1.5.1] Extension[org.apache.commons.collections, implementationVendor=Apache Software Foundation, implementationVersion=1.1-dev, specificationVendor=Apache Software Foundation, specificationVersion=1.0] Extension[org.apache.commons.logging, implementationVendor=Apache Software Foundation, implementationVersion=1.0.2, specificationVendor=Apache Software Foundation, specificationVersion=1.0] delegate: true repositories: file:C:\michaelmcgrady\tomcat\common\lib\ant.jar file:C:\michaelmcgrady\tomcat\common\lib\commons-collections.jar file:C:\michaelmcgrady\tomcat\common\lib\commons-logging-api.jar file:C:\michaelmcgrady\tomcat\common\lib\jasper-compiler.jar file:C:\michaelmcgrady\tomcat\common\lib\jasper-runtime.jar file:C:\michaelmcgrady\tomcat\common\lib\jdbc2_0-stdext.jar
Re: JK2 module for AOLserver
Alexander Leyke wrote: Hi, A question about enhancement adoption process - how long does it typically take for new code to show up in CVS, in nightly builds? What is the verification process for new code? I have posted enhancement request to the mailing list and to Bugzilla (http://issues.apache.org/bugzilla/show_bug.cgi?id=18283). The code should be added by a commiter around, and for jk2 it could be JF Clere or Mladen. But may be Costin could add it to jtc. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
