DO NOT REPLY [Bug 23429] - isCompressable always false when charset is specified in Content-Type
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23429. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23429 isCompressable always false when charset is specified in Content-Type [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-09-26 06:42 --- Yes, obviously. This has been addressed since then. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 23432] - org.apache.jasper.JasperException: Unable to compile class for JSP
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23432. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23432 org.apache.jasper.JasperException: Unable to compile class for JSP [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-09-26 06:42 --- Download the hotfix which is available (in the bins folder). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Hans Bergsten wrote: Jan Luehe wrote: I think it depends on whether you anticipate (or support) LiteWebServer being bundled (as one or more libraries) into other products that use a different directory layout, with different locations for shared libs. If that's the case, limiting the location of shared libs to $CATALINA_HOME/shared/lib might be too restrictive. Your milage may wary, but no one embedding LiteWebServer (LWS) today has complained. Of course nobody did ;-) I have yet to see a webapp which doesn't have very visible TLDs, and when it doesn't, I don't think it would rely on possibly shared JARs which would contain the said TLDs. This is clearly from the non-portable department. I think sometimes too much flexibility is what makes a product hard to use. With LWS, I've stripped down Tomcat to the bare minimum and removed a lot of choices, and people seem to like how simple things get this way. Obviously, useless choices should be removed. Here, I'm ok with refining the feature a little bit (although it is probably not useful), but definitely not adding additional configuration options to it. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
About path attribute of Context in server.xml
Today I mistyped the path attribute /axis as axis in my Axis context in server.xml and myy Tomcat showed the following error: - 2003. 9. 26. ?? 3:56:33 org.apache.commons.modeler.Registry loadRegistry ??: Loading registry information 2003. 9. 26. ?? 3:56:33 org.apache.commons.modeler.Registry getRegistry ??: Creating new Registry instance 2003. 9. 26. ?? 3:56:34 org.apache.commons.modeler.Registry getServer ??: Creating MBeanServer 2003. 9. 26. ?? 3:56:34 org.apache.coyote.http11.Http11Protocol init ??: Initializing Coyote HTTP/1.1 on port 8080 Starting service Tomcat-Standalone Apache Tomcat/4.1.27 WebappLoader[axis]: Deploying class repositories to work directory D:\java\tools \eclipse3.0-m3\workspace\ws-axis\work\org\apache\jsp WebappLoader[axis]: Deploy class files /WEB-INF/classes to D:\java\tools\eclipse 3.0-m3\workspace\ws-axis\java\webapps\axis\WEB-INF\classes WebappLoader[axis]: Deploy JAR /WEB-INF/lib/commons-discovery.jar to D:\java\too ls\eclipse3.0-m3\workspace\ws-axis\java\webapps\axis\WEB-INF\lib\commons-dis cove ry.jar WebappLoader[axis]: Deploy JAR /WEB-INF/lib/commons-logging.jar to D:\java\tools \eclipse3.0-m3\workspace\ws-axis\java\webapps\axis\WEB-INF\lib\commons-loggi ng.j ar WebappLoader[axis]: Deploy JAR /WEB-INF/lib/log4j-1.2.8.jar to D:\java\tools\ecl ipse3.0-m3\workspace\ws-axis\java\webapps\axis\WEB-INF\lib\log4j-1.2.8.jar WebappLoader[axis]: Deploy JAR /WEB-INF/lib/wsdl4j.jar to D:\java\tools\eclipse3 .0-m3\workspace\ws-axis\java\webapps\axis\WEB-INF\lib\wsdl4j.jar WebappLoader[axis]: Reloading checks are enabled for this Context ContextConfig[axis] Exception processing JAR at resource path /WEB-INF/lib/commo ns-discovery.jar javax.servlet.ServletException: Exception processing JAR at resource path /WEB-I NF/lib/commons-discovery.jar at org.apache.catalina.startup.ContextConfig.tldScanJar(ContextConfig.ja va:930) at org.apache.catalina.startup.ContextConfig.tldScan(ContextConfig.java: 868) at org.apache.catalina.startup.ContextConfig.start(ContextConfig.java:64 7) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfi g.java:243) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(Lifecycl eSupport.java:166) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3 568) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188) at org.apache.catalina.core.StandardHost.start(StandardHost.java:738) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188) at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:347 ) at org.apache.catalina.core.StandardService.start(StandardService.java:4 97) at org.apache.catalina.core.StandardServer.start(StandardServer.java:219 0) at org.apache.catalina.startup.Catalina.start(Catalina.java:512) at org.apache.catalina.startup.Catalina.execute(Catalina.java:400) at org.apache.catalina.startup.Catalina.process(Catalina.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203) - Root Cause - java.io.FileNotFoundException at org.apache.naming.resources.DirContextURLConnection.getInputStream(Di rContextURLConnection.java:344) at sun.net.www.protocol.jar.URLJarFile.retrieve(URLJarFile.java:161) at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:42) at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:78) at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.ja va:85) at sun.net.www.protocol.jar.JarURLConnection.getJarFile(JarURLConnection .java:69) at org.apache.catalina.startup.ContextConfig.tldScanJar(ContextConfig.ja va:906) at org.apache.catalina.startup.ContextConfig.tldScan(ContextConfig.java: 868) at org.apache.catalina.startup.ContextConfig.start(ContextConfig.java:64 7) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfi g.java:243) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(Lifecycl eSupport.java:166) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3 568) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188) at org.apache.catalina.core.StandardHost.start(StandardHost.java:738) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188) at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:347 ) at org.apache.catalina.core.StandardService.start(StandardService.java:4 97) at
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Jan Luehe wrote: Remy, sorry, but I don't see which part of our email exchange you found very frustrating. As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. I've done some measurements on my Ultra 60. TldConfig already calculates the tldScanTime for each context, so that's the number I'm using. Following are the tldScanTime numbers for a sequence of 10 startups with the standard contexts: - w/o optimization (static initializer in TldConfig commented out): Context name tldScanTime for 10 runs | Average --- /manager 417/452/431/438/408/468/434/418/423/450 | 433.90 /admin 1399/1310/1440/1385/1288/1347/1345/1340/1280/1317 |1345.10 /servlets-examples 210/198/206/235/192/182/189/188/166/195 | 196.10 [] 222/222/213/218/222/225/215/204/223/221 | 218.50 /jsp-examples 996/841/854/862/900/855/903/845/856/815 | 872.70 /tomcat-docs 155/176/168/184/175/294/164/185/194/183 | 187.80 Total=3254.10 - With optimization Context name tldScanTime for 10 runs | Average --- /manager 239/225/242/375/230/241/234/228/237/319 | 257.00 /admin 1225/1192/1242/1171/1320/1251/1248/1270/1253/1219 |1239.10 /servlets-examples 74/69/165/79/92/71/106/96/95/123 | 97.00 [] 129/109/136/186/241/194/111/103/96/142| 144.70 /jsp-examples 728/736/757/843/812/796/782/753/820/813 | 784.00 /tomcat-docs 77/60/127/191/102/101/61/96/88/85 | 98.80 Total=2620.60 I'm not going to comment on how slow an Ultra 60 is ;-) You did disable caching for those tests, right ? If you didn't, those results are weird. My comments are: - Real world apps are not really helped by your optimizations (the admin webapp) - On my Pentium M, the difference is probably not measurable - This is .8s of the first startup, right ? This may not be significant, but if you increase the number of contexts and have additional JARs on your classpath of which you know they don't contain any TLDs, we're talking seconds, not ms. And overall, likely less than 5% of the overall startup time, assuming real webapps. And, again, that's only for the first startup. Look, there's still likely useful optimizations to be done in Tomcat 5. For example, you can see the buffering which I added, based on the analysis of Steve Appling, and which significantly reduces the I/O activity in many cases. In this example, the benches are identical, but in the real world, it should be a big difference. However, we should never do useless optimizations, as it always increases complexity. As I mentioned in my private email to you, it may not always be practical to rely on the list of noTldJars configured in catalina.properties if you bundle Tomcat with your own product. That's why I added the setProperty method on CatalinaProperties, in order to be able to override the value in catalina.properties. This allows the list of noTldJars to be determined more accurately at runtime. The code that is embedding Tomcat would call CatalinaProperties.setProperty() *before* starting Tomcat. And is exactly what I wanted to avoid. Again, CatalinaProperties is for configuring the bootstrap, not anything else (otherwise, stuff which belongs to server.xml will end up here, and it will end up being a huge mess). I leave the judgement up to the community. I'll have to reiterate my -1. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] Adding a note to docs/config/context.xml
This patch was made for the reason described at http://marc.theaimsgroup.com/?l=tomcat-devm=106456019300386w=2. Thanks, Ias = Lee, Changshin (Korean name) Ias (International name) Company Web Site: http://www.tmax.co.kr Personal Web Site: http://www.iasandcb.pe.kr - Senior Researcher, Emerging Technology Evangelist JCP member - http://jcp.org/en/participation/members/L RD Institute Tmax Soft, Inc. JCP member - http://jcp.org/en/participation/members/T = Index: context.xml === RCS file: /home/cvspublic/jakarta-tomcat-catalina/webapps/docs/config/context.xml,v retrieving revision 1.5 diff -u -r1.5 context.xml --- context.xml 30 Jul 2003 18:37:51 - 1.5 +++ context.xml 26 Sep 2003 08:16:45 - @@ -153,7 +153,9 @@ within a particular a href=host.htmlHost/a must be unique. If you specify a context path of an empty string (), you are defining the emdefault/em web application for this Host, which -will process all requests not assigned to other Contexts./p +will process all requests not assigned to other Contexts. +Note that you should set a value starting with the leading / +except ./p /attribute attribute name=reloadable required=false - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
About taglib-location value and other path values in web.xml
From Servlet 2.4 and JSP 2.0, web.xml is under several schemas.
Firs see the following:
Index: TldConfig.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catali
na/startup/TldConfig.java,v
retrieving revision 1.29
diff -u -r1.29 TldConfig.java
--- TldConfig.java 25 Sep 2003 19:27:59 - 1.29
+++ TldConfig.java 26 Sep 2003 08:52:29 -
@@ -671,6 +671,11 @@
String resourcePath = context.findTaglib(taglibs[i]);
// FIXME - Servlet 2.4 DTD implies that the location MUST be
// a context-relative path starting with '/'?
+// FYI - taglib-location subelement of taglib element
+// is typed as j2ee:pathType, which is now yet an another
j2ee:string.
+// Therefore one cannot suppose taglib-location content
+// should start with /.
+
if (!resourcePath.startsWith(/)) {
resourcePath = /WEB-INF/ + resourcePath;
}
As I added, I think it would be good to have absolutePathType in
j2ee_1_4.xsd so that we can take advantage of its constraint.
xsd:complexType name=absolutePathType
xsd:annotation
xsd:documentation
The elements that use this type designate an absolute path starting with a
/.
/xsd:documentation
/xsd:annotation
xsd:simpleContent
xsd:restriction base=j2ee:pathType
xsd:pattern value=/.*/
/xsd:restriction
/xsd:simpleContent
/xsd:complextType
Actually this declaration is very similar to that of war-pathType in
web-app_2_4.xsd except their base types, j2ee:pathType and j2ee:string. If
we can use this type, it is also possible to type taglib-location or some
PATH-derived element by it and drive users to follow the notation of the
absolute path. In addition, the absolutePathType can help about the issue at
http://marc.theaimsgroup.com/?l=tomcat-devm=106456019300386w=2 . At the
same time, I suggest PATH-derived element with
(as a resource relative to the root of the web application)
description should use absolutePathType for avoiding ambiguity.
Thanks,
Ias
=
Lee, Changshin (Korean name)
Ias (International name)
Company Web Site: http://www.tmax.co.kr
Personal Web Site: http://www.iasandcb.pe.kr
-
Senior Researcher, Emerging Technology Evangelist
JCP member - http://jcp.org/en/participation/members/L
RD Institute
Tmax Soft, Inc.
JCP member - http://jcp.org/en/participation/members/T
=
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Craig R. McClanahan wrote: Remy Maucherat wrote: Jan Luehe wrote: good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I honestly don't understand why we're searching parent classloaders for TLDs. So that you can have a single copy of a tag library that is shared across all of the webapps in that container -- for example, this is what JWSDP does with the JSTL and JavaServer Faces tag libraries. The most important reason that you need to scan the TLDs at startup is that you can define library-specific listeners in the TLD that become automatically installed, without having to touch web.xml. However, the specification requires that JARs in /WEB-INF/lib are scanned. It doesn't say anything about shared JARs, which would hint that, in this situation, TLDs should be in /WEB-INF. Furthermore, defining application level listeners and stuff like that in a shared component seems weird to me. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20540] - Unable to compile the JSP files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20540. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20540 Unable to compile the JSP files [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2003-09-26 12:44 --- Increasing debug level hasnt showed me anything. Sniffing the network packets I see the server sends the 500 error code and nothing else. 0x 4500 0105 ae98 4000 4006 f83a c8cb b724[EMAIL PROTECTED]@..:...$ 0x0010 c892 4a9d 0050 cae6 69a6 eb99 d4ff d755..J..P..i..U 0x0020 8018 1920 e6b2 0101 080a 0161 4609.aF. 0x0030 00e2 26ee 4854 5450 2f31 2e31 2035 3030...HTTP/1.1.500 0x0040 2049 6e74 6572 6e61 6c20 5365 7276 6572.Internal.Server 0x0050 2045 7272 6f72 0d0a 4461 7465 3a20 5468.Error..Date:.Th 0x0060 752c 2032 3520 5365 7020 3230 3033 2031u,.25.Sep.2003.1 0x0070 323a 3a33 3920 474d 540d 0a53 65722:33:39.GMT..Ser 0x0080 7665 723a 2041 7061 6368 6520 546f 6d63ver:.Apache.Tomc 0x0090 6174 2f34 2e31 2e32 3720 2848 5454 502fat/4.1.27.(HTTP/ 0x00a0 312e 3120 436f 6e6e 6563 746f 7229 0d0a1.1.Connector).. 0x00b0 436f 6e74 656e 742d 5479 7065 3a20 7465Content-Type:.te 0x00c0 7874 2f68 746d 6c3b 2063 6861 7273 6574xt/html;.charset 0x00d0 3d49 534f 2d38 3835 392d 310d 0a43 6f6e=ISO-8859-1..Con 0x00e0 7465 6e74 2d4c 656e 6774 683a 2030 0d0atent-Length:.0.. 0x00f0 436f 6e6e 6563 7469 6f6e 3a20 636c 6f73Connection:.clos 0x0100 650d 0a0d 0a e I have Tomcat running standalone and Apache with mod_proxy but I'm testing accessing the port 8080 (Tomcat) directly. Shouldnt it show the error report page like Tomcat 3.x ? If it is a configuration problem please let me know about it. Google and mailing list archives havent showed anything useful and I have other people having the same issue. Thanks in advance! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20540] - Unable to compile the JSP files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20540. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20540 Unable to compile the JSP files [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-09-26 12:53 --- Bugzilla is not a help desk support system. Tomcat3 and 4 are very different since they are major version releases. Please use tomcat-user to debug this configuration error. Odds are, you may need to examine the file permissions of directories vs the userid tomcat is running as. Any future reopens - will be closed unless a bug can be shown. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-site/docs/articles - New directory
remm2003/09/26 06:19:12 jakarta-tomcat-site/docs/articles - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-site/xdocs resources.xml
remm2003/09/26 06:22:30 Modified:docs resources.html xdocsresources.xml Added: docs/articles performance.pdf Log: - Add article on Tomcat performance, contributed by Peter Lin. Revision ChangesPath 1.18 +45 -48jakarta-tomcat-site/docs/resources.html Index: resources.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/resources.html,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- resources.html15 Sep 2003 22:12:07 - 1.17 +++ resources.html26 Sep 2003 13:22:29 - 1.18 @@ -122,15 +122,51 @@ table border=0 cellspacing=0 cellpadding=2 width=100% trtd bgcolor=#525D76 font color=#ff face=arial,helvetica,sanserif - a name=NotestrongNote/strong/a + a name=Free ToolsstrongFree Tools/strong/a /font /td/tr trtd blockquote pThe Apache Tomcat project doesn't endorse any of the products mentioned - here. They are mentioned just because they are Tomcat centric and may - be useful references. The books are listed by descending publication - date./p + here./p +ul +li + a href=http://openknows.free.fr/;Tomcat for Eclipse/a +/li +li + a href=http://www.sysdeo.com/eclipse/tomcatPlugin.html;Sysdeo Eclipse Tomcat Launcher plugin/a +/li +li + a href=http://www.day.com/en/product/communiqu1/cqenterprise/communiqu1/dnlogin.html;DAY Communique JSP Debugger/a +/li + /ul +/blockquote +/p + /td/tr + trtdbr//td/tr +/table +table border=0 cellspacing=0 cellpadding=2 width=100% + trtd bgcolor=#525D76 +font color=#ff face=arial,helvetica,sanserif + a name=ArticlesstrongArticles/strong/a +/font + /td/tr + trtd +blockquote +ul +li + ba href=articles/performance.pdfTomcat Performance/a/b, + by Peter Lin +/li +li + ba href=http://www.ubeans.com/tomcat/index.html;Tomcat 4.0 Load + Balancing with Apache 1.3/a/b, by Pascal Forget +/li +li + ba href=http://www.theserverside.com/resources/article.jsp?l=Tomcat; + In Memory Session Replication in Tomcat 4.0/a/b, by Filip Hanik +/li + /ul /blockquote /p /td/tr @@ -144,7 +180,11 @@ /td/tr trtd blockquote -pTomcat committers' names are indicated in bold./p +pThe Apache Tomcat project doesn't endorse any of the books mentioned + here. They are mentioned just because they are Tomcat centric and may + be useful references. The books are listed by descending publication + date./p +pTomcat committers' names are indicated in bold./p ul li ba href=http://www.brainysoftware.com/;How Tomcat Works/a/b, by Budi Kurniawanbr / @@ -155,10 +195,6 @@ iHungry Minds, Inc (06/2003)/i /li li - ba href=http://www.amazon.com/exec/obidos/tg/detail/-/1861008546/qid=1043089531/sr=1-7/ref=sr_1_7/002-9433156-6683214?v=glanceamp;s=books;Apache Tomcat Performance Handbook/a/b, by Peter Lin, bRemy Maucherat/bbr / - i? (05/2003)/i -/li -li ba href=http://www.amazon.com/exec/obidos/tg/detail/-/0596003188/qid=1043089531/sr=1-6/ref=sr_1_6/002-9433156-6683214?v=glanceamp;s=books;Tomcat: The Definitive Guide/a/b, by Jason Brittain, bIan F. Darwin/bbr / iO'Reilly amp; Associates (03/2003)/i /li @@ -184,45 +220,6 @@ li ba href=http://www.amazon.com/exec/obidos/tg/detail/-/1893115364/qid=1043089531/sr=1-4/ref=sr_1_4/002-9433156-6683214?v=glanceamp;s=books;Apache Jakarta-Tomcat/a/b, by James Goodwillbr / iAPress (12/2001)/i -/li - /ul -/blockquote -/p - /td/tr - trtdbr//td/tr -/table -table border=0 cellspacing=0 cellpadding=2 width=100% - trtd bgcolor=#525D76 -font color=#ff face=arial,helvetica,sanserif - a name=ArticlesstrongArticles/strong/a -/font - /td/tr - trtd -blockquote -ul -li - ba href=http://www.ubeans.com/tomcat/index.html;Apache 1.3.23 + Tomcat 4.0.2 + Load
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Remy, As I mentioned in my private email to you, it may not always be practical to rely on the list of noTldJars configured in catalina.properties if you bundle Tomcat with your own product. That's why I added the setProperty method on CatalinaProperties, in order to be able to override the value in catalina.properties. This allows the list of noTldJars to be determined more accurately at runtime. The code that is embedding Tomcat would call CatalinaProperties.setProperty() *before* starting Tomcat. And is exactly what I wanted to avoid. Again, CatalinaProperties is for configuring the bootstrap, not anything else (otherwise, stuff which belongs to server.xml will end up here, and it will end up being a huge mess). I agree w/ that. I leave the judgement up to the community. I'll have to reiterate my -1. OK, I'll revert my patch (and leave it as a private extension), until we have found a better solution that everybody agrees on. Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 23373] - Servlet destroy() methods not being called at shutdown
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23373. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23373 Servlet destroy() methods not being called at shutdown --- Additional Comments From [EMAIL PROTECTED] 2003-09-26 18:16 --- Tested as Fixed in nightly build. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 8752] - HTTPS redirect fails if using welcome-file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8752. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8752 HTTPS redirect fails if using welcome-file --- Additional Comments From [EMAIL PROTECTED] 2003-09-26 18:30 --- I have just double checked this with the test case provided. This is absolutely, definitely, postively, certainly and without the slightest iota of doubt NOT a tomcat bug. This is an IE bug. I have tried exactly the same test case with Mozilla and it works perfectly. You see it when there is a sequence of two redirects. In this case there is one redirect to use SSL and another to the welcome page (I haven't bothered to check the order in which this happens in but I am fairly sure it is SSL first). This is what happens: When the page is requested, Tomcat first redirects to SSL and then performs a second redirect to the welcome file. The response sent by IE to the first redirect comes in on port 8443 but the request headers refer to port 8080 (read in org.apache.coyote.http11.Http11Processor.parseHost()). This causes the second redirect to fail because the port in the request is used when constructing the second redirect. You will not see this problem if the standard ports are used because standard ports are not included in the request and Tomcat defaults to these if the port is not specified in the headers. Work arounds are: 1. Use the standard ports 2. Use a two stage re-direct I initiated a discussion on tomcat-dev about options to solve this a few months ago and after going around in circles, concluded that the best thing to do was to leave it as is. The main reasons for this were: - It is an IE not a tomcat bug - Production systems tend to use standard ports and will therefore be fine - All of the fixes identified broke something else or intoduced security issues. If you search the tomat-dev archives for 13861 you should find the various e- mails that went back and forth. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java CatalinaProperties.java catalina.properties
luehe 2003/09/26 12:31:16
Modified:catalina/src/share/org/apache/catalina/startup
TldConfig.java CatalinaProperties.java
catalina.properties
Log:
Reverted patch for JAR exclusion list
Revision ChangesPath
1.30 +6 -39
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java
Index: TldConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- TldConfig.java25 Sep 2003 19:27:59 - 1.29
+++ TldConfig.java26 Sep 2003 19:31:16 - 1.30
@@ -108,31 +108,12 @@
*/
public final class TldConfig {
-// Names of JARs that are known not to contain any TLDs
-private static HashSet noTldJars;
-
private static org.apache.commons.logging.Log log=
org.apache.commons.logging.LogFactory.getLog( TldConfig.class );
private static final String FILE_URL_PREFIX = file:;
private static final int FILE_URL_PREFIX_LEN = FILE_URL_PREFIX.length();
-
-/*
- * Initializes the set of JARs that are known not to contain any TLDs
- */
-static {
-String value = CatalinaProperties.getProperty(noTldJars);
-if (value != null) {
-noTldJars = new HashSet();
-StringTokenizer tokenizer = new StringTokenizer(value, ,);
-while (tokenizer.hasMoreElements()) {
-noTldJars.add(tokenizer.nextToken());
-}
-}
-}
-
-
// - Instance Variables
/**
@@ -752,19 +733,13 @@
* location that all web applications have access to (e.g.,
* CATALINA_HOME/common/lib).
*
- * The set of shared JARs to be scanned for TLDs is narrowed down by
- * the list of JARs specified as the value of the ttnoTldJars/tt
- * property in catalina.properties, which are known not to contain any
- * TLDs.
- *
* @return Map of JAR file paths
*/
private Map getJarPaths() {
HashMap jarPathMap = null;
-ClassLoader webappLoader = Thread.currentThread().getContextClassLoader();
-ClassLoader loader = webappLoader;
+ClassLoader loader = Thread.currentThread().getContextClassLoader();
while (loader != null) {
if (loader instanceof URLClassLoader) {
URL[] urls = ((URLClassLoader) loader).getURLs();
@@ -786,19 +761,11 @@
if (!path.endsWith(.jar)) {
continue;
}
-/*
- * Scan all JARs from WEB-INF/lib, plus any shared JARs
- * that are not known not to contain any TLDs
- */
-if (loader == webappLoader
-|| noTldJars == null
-|| !noTldJars.contains(file.getName())) {
-if (jarPathMap == null) {
-jarPathMap = new HashMap();
-jarPathMap.put(path, file);
-} else if (!jarPathMap.containsKey(path)) {
-jarPathMap.put(path, file);
-}
+if (jarPathMap == null) {
+jarPathMap = new HashMap();
+jarPathMap.put(path, file);
+} else if (!jarPathMap.containsKey(path)) {
+jarPathMap.put(path, file);
}
}
}
1.3 +4 -17
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/CatalinaProperties.java
Index: CatalinaProperties.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/CatalinaProperties.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- CatalinaProperties.java 24 Sep 2003 19:09:29 - 1.2
+++ CatalinaProperties.java 26 Sep 2003 19:31:16 - 1.3
@@ -117,19 +117,6 @@
}
-/**
- * Sets the property with the specified key to the specified value.
- *
- * @param key the property key
- * @param value the property value
- * @return the previous value of the specified key in the property
- * list, or codenull/code if it did not have one.
- */
-public static Object setProperty(String key, String value) {
-return properties.setProperty(key, value);
-}
-
-
cvs commit: jakarta-tomcat-catalina/catalina/src/conf catalina.properties
luehe 2003/09/26 12:32:08
Modified:catalina/src/conf catalina.properties
Log:
Reverted patch for JAR exclusion list
Revision ChangesPath
1.9 +0 -5 jakarta-tomcat-catalina/catalina/src/conf/catalina.properties
Index: catalina.properties
===
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/catalina.properties,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- catalina.properties 23 Sep 2003 21:10:28 - 1.8
+++ catalina.properties 26 Sep 2003 19:32:08 - 1.9
@@ -53,8 +53,3 @@
# repositories
# foo/bar.jar: Add bar.jar as a class repository
shared.loader=${catalina.base}/shared/classes,${catalina.base}/shared/lib/*.jar
-
-#
-# List of comma-separated names of JAR files that are known not to contain
-# any TLDs
-noTldJars=ant.jar,catalina.jar,catalina-ant.jar,catalina-cluster.jar,catalina-optional.jar,catalina-i18n-fr.jar,catalina-i18n-ja.jar,catalina-i18n-es.jar,commons-dbcp.jar,commons-modeler.jar,commons-logging-api.jar,commons-beanutils.jar,commons-fileupload-1.0.jar,commons-pool.jar,commons-digester.jar,commons-logging.jar,commons-collections.jar,commons-el.jar,jakarta-regexp-1.2.jar,jasper-compiler.jar,jasper-runtime.jar,jmx.jar,jmx-tools.jar,jsp-api.jar,jkshm.jar,jkconfig.jar,naming-common.jar,naming-resources.jar,naming-factory.jar,naming-java.jar,servlet-api.jar,servlets-default.jar,servlets-invoker.jar,servlets-common.jar,servlets-webdav.jar,tomcat-util.jar,tomcat-http11.jar,tomcat-jni.jar,tomcat-jk.jar,tomcat-jk2.jar,tomcat-coyote.jar,xercesImpl.jar,xmlParserAPIs.jar,sunjce_provider.jar,ldapsec.jar,localedata.jar,dnsns.jar
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Jan Luehe wrote: Remy, I leave the judgement up to the community. I'll have to reiterate my -1. OK, I'll revert my patch (and leave it as a private extension), until we have found a better solution that everybody agrees on. Thanks :) As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Remy Maucherat wrote: OK, I'll revert my patch (and leave it as a private extension), until we have found a better solution that everybody agrees on. Thanks :) As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. We can always revisit this issue at a later point. I feel like I'm on a bazaar. :) Thanks, Remy! Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. I meant the hardcoded list that you put in TldConfig. I don't think CatalinaProperties should contain that kind of configuration options (which are meant to configure the Bootstrap class Tomcat standalone uses). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. I meant the hardcoded list that you put in TldConfig. I don't think CatalinaProperties should contain that kind of configuration options (which are meant to configure the Bootstrap class Tomcat standalone uses). Got it. Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. I meant the hardcoded list that you put in TldConfig. I don't think CatalinaProperties should contain that kind of configuration options (which are meant to configure the Bootstrap class Tomcat standalone uses). Would you agree on a setNoTldJars method on TldConfig then, which would allow the hard-coded list to be overridden? Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java
Jan Luehe wrote: Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. I meant the hardcoded list that you put in TldConfig. I don't think CatalinaProperties should contain that kind of configuration options (which are meant to configure the Bootstrap class Tomcat standalone uses). Would you agree on a setNoTldJars method on TldConfig then, which would allow the hard-coded list to be overridden? I don't see what problems is would cause. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java
luehe 2003/09/26 16:09:08
Modified:catalina/src/share/org/apache/catalina/startup
TldConfig.java
Log:
Added hard-coded list of names of JARs that are known not to contain any TLDs.
This list can be overridden using the new TldConfig.setNoTldJars().
Revision ChangesPath
1.31 +96 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java
Index: TldConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- TldConfig.java26 Sep 2003 19:31:16 - 1.30
+++ TldConfig.java26 Sep 2003 23:09:08 - 1.31
@@ -108,12 +108,72 @@
*/
public final class TldConfig {
+// Names of JARs that are known not to contain any TLDs
+private static HashSet noTldJars;
+
private static org.apache.commons.logging.Log log=
org.apache.commons.logging.LogFactory.getLog( TldConfig.class );
private static final String FILE_URL_PREFIX = file:;
private static final int FILE_URL_PREFIX_LEN = FILE_URL_PREFIX.length();
+
+/*
+ * Initializes the set of JARs that are known not to contain any TLDs
+ */
+static {
+noTldJars = new HashSet();
+noTldJars.add(ant.jar);
+noTldJars.add(catalina.jar);
+noTldJars.add(catalina-ant.jar);
+noTldJars.add(catalina-cluster.jar);
+noTldJars.add(catalina-optional.jar);
+noTldJars.add(catalina-i18n-fr.jar);
+noTldJars.add(catalina-i18n-ja.jar);
+noTldJars.add(catalina-i18n-es.jar);
+noTldJars.add(commons-dbcp.jar);
+noTldJars.add(commons-modeler.jar);
+noTldJars.add(commons-logging-api.jar);
+noTldJars.add(commons-beanutils.jar);
+noTldJars.add(commons-fileupload-1.0.jar);
+noTldJars.add(commons-pool.jar);
+noTldJars.add(commons-digester.jar);
+noTldJars.add(commons-logging.jar);
+noTldJars.add(commons-collections.jar);
+noTldJars.add(commons-el.jar);
+noTldJars.add(jakarta-regexp-1.2.jar);
+noTldJars.add(jasper-compiler.jar);
+noTldJars.add(jasper-runtime.jar);
+noTldJars.add(jmx.jar);
+noTldJars.add(jmx-tools.jar);
+noTldJars.add(jsp-api.jar);
+noTldJars.add(jkshm.jar);
+noTldJars.add(jkconfig.jar);
+noTldJars.add(naming-common.jar);
+noTldJars.add(naming-resources.jar);
+noTldJars.add(naming-factory.jar);
+noTldJars.add(naming-java.jar);
+noTldJars.add(servlet-api.jar);
+noTldJars.add(servlets-default.jar);
+noTldJars.add(servlets-invoker.jar);
+noTldJars.add(servlets-common.jar);
+noTldJars.add(servlets-webdav.jar);
+noTldJars.add(tomcat-util.jar);
+noTldJars.add(tomcat-http11.jar);
+noTldJars.add(tomcat-jni.jar);
+noTldJars.add(tomcat-jk.jar);
+noTldJars.add(tomcat-jk2.jar);
+noTldJars.add(tomcat-coyote.jar);
+noTldJars.add(xercesImpl.jar);
+noTldJars.add(xmlParserAPIs.jar);
+// JARs from J2SE runtime
+noTldJars.add(sunjce_provider.jar);
+noTldJars.add(ldapsec.jar);
+noTldJars.add(localedata.jar);
+noTldJars.add(dnsns.jar);
+}
+
+
// - Instance Variables
/**
@@ -152,7 +212,23 @@
// - Public Methods
- /**
+/**
+ * Sets the list of JARs that are known not to contain any TLDs.
+ *
+ * @param jarNames List of comma-separated names of JAR files that are
+ * known not to contain any TLDs
+ */
+public static void setNoTldJars(String jarNames) {
+if (jarNames != null) {
+noTldJars.clear();
+StringTokenizer tokenizer = new StringTokenizer(jarNames, ,);
+while (tokenizer.hasMoreElements()) {
+noTldJars.add(tokenizer.nextToken());
+}
+}
+}
+
+/**
* Set the validation feature of the XML parser used when
* parsing xml instances.
* @param xmlValidation true to enable xml instance validation
@@ -733,13 +809,18 @@
* location that all web applications have access to (e.g.,
* CATALINA_HOME/common/lib).
*
+ * The set of shared JARs to be scanned for TLDs is narrowed down by
+ * the ttnoTldJars/tt class variable, which contains the names of JARs
+ * that are known not to contain any TLDs.
+ *
* @return Map of JAR file paths
*/
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java
kinman 2003/09/26 16:19:32
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Log:
- Support java extension direcotries when invoking javac.
Revision ChangesPath
1.70 +12 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -r1.69 -r1.70
--- Compiler.java 24 Aug 2003 01:18:44 - 1.69
+++ Compiler.java 26 Sep 2003 23:19:32 - 1.70
@@ -340,13 +340,13 @@
// Initializing classpath
Path path = new Path(project);
path.setPath(System.getProperty(java.class.path));
-info.append( cp= + System.getProperty(java.class.path) + \n);
+info.append(cp= + System.getProperty(java.class.path) + \n);
StringTokenizer tokenizer = new StringTokenizer(classpath, sep);
while (tokenizer.hasMoreElements()) {
String pathElement = tokenizer.nextToken();
File repository = new File(pathElement);
path.setLocation(repository);
-info.append( cp= + repository + \n);
+info.append(cp= + repository + \n);
}
if( log.isDebugEnabled() )
@@ -357,7 +357,16 @@
Path srcPath = new Path(project);
srcPath.setLocation(options.getScratchDir());
-info.append( work dir= + options.getScratchDir() + \n);
+info.append(work dir= + options.getScratchDir() + \n);
+
+// Initialize and set java extensions
+String exts = System.getProperty(java.ext.dirs);
+if (exts != null) {
+Path extdirs = new Path(project);
+extdirs.setPath(exts);
+javac.setExtdirs(extdirs);
+info.append(extension dir= + exts + \n);
+}
// Configure the compiler object
javac.setEncoding(javaEncoding);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java
billbarker2003/09/26 19:44:07
Modified:util/java/org/apache/tomcat/util/net/jsse
JSSE14SocketFactory.java
Log:
Fix typo.
Reported by: Chris Halstaed [EMAIL PROTECTED]
Revision ChangesPath
1.15 +1 -1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java
Index: JSSE14SocketFactory.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- JSSE14SocketFactory.java 9 Sep 2003 04:18:55 - 1.14
+++ JSSE14SocketFactory.java 27 Sep 2003 02:44:07 - 1.15
@@ -124,7 +124,7 @@
keystoreType = defaultKeystoreType;
}
- String trustAlgorithm = (String)attributes.get(truststoreAlgorithme);
+ String trustAlgorithm = (String)attributes.get(truststoreAlgorithm);
if( trustAlgorithm == null ) {
trustAlgorithm = algorithm;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
