DO NOT REPLY [Bug 26335] New: - Modification check for tagfiles does not work recursively
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335 Modification check for tagfiles does not work recursively Summary: Modification check for tagfiles does not work recursively Product: Tomcat 5 Version: 5.0.18 Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Example: tag1 defined in a tagfile tag2 defined in a tagfile which uses tag1 tag3 defined in a tagfile which uses tag2 index.jsp uses tag3 tagfile for tag1 is modified, reload of index.jsp does not reflect the changes despite of development mode. see attached web application for a test case. instructions to reproduce are on the welcome page. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26335] - Modification check for tagfiles does not work recursively
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335 Modification check for tagfiles does not work recursively --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 07:53 --- Created an attachment (id=10050) web application with test case - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25596] - Application briefly unavailable when using manager to reload
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596 Application briefly unavailable when using manager to reload --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 08:08 --- Hans, looks like the file descriptor leak only affects Apache 1.3, that explains why I didn't notice during my testing of web-app reloading today as I am using Apache 2.0. Using lsof doesn't reveal any extra file descriptors in use, either. Thanks for the heads up (and apologies for getting a bit off-topic). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26327] - StandardSession.isValid needs to check the time a servlet ended rather than when it began
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26327. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26327 StandardSession.isValid needs to check the time a servlet ended rather than when it began [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 08:50 --- I do not agree with this interpretation. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26331] - Unwanted duplicate context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26331. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26331 Unwanted duplicate context [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 08:51 --- Yes. The host will also auto deploy your context, since it's in the appBase. How about not filing a bug ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26335] - Modification check for tagfiles does not work recursively
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335 Modification check for tagfiles does not work recursively [EMAIL PROTECTED] changed: What|Removed |Added Severity|Major |Minor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26276] - Generated TLD inconsistent after tagfile changes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26276. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26276 Generated TLD inconsistent after tagfile changes [EMAIL PROTECTED] changed: What|Removed |Added Severity|Major |Minor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
Günter Knauf a écrit : IMHO, this is wrong. The server port isn't necessarily the port being listened on. See bug report and patch, long ignored: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901 ok, but its as wrong as before - my patch doesnt change the behaviour from what I see, and this is what I can find in the httpd-2.1 sources too in order to work with APR 1.0 because apr_sockaddr_port_get() was removed. I dont know for what reasons the patch you point to isnt applied yet; and I agree with you that it is better to correct the behaviour than change from wrong to wrong; so I'd suggest that you create another patch and post it here, and hope that it will be accepted by those who have commit rights, just as I do... We changed this port information many time in the past, and I'll commit the Kyle change in AP2 and close the bugzilla - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26338] New: - Service terminates with the message not a valid application
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26338. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26338 Service terminates with the message not a valid application Summary: Service terminates with the message not a valid application Product: Tomcat 4 Version: 4.0.6 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Enhancement Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] If you have installed Tomcat in d:\program files\Apache Tomcat and have a file d:\program lying around, an attempt to start the Tomcat-Service fails with the Windows error message --- Could not start the Apache Tomcat service on Local Computer. Error 193: %1 is not a valid Win32 application. --- If the file d:\program is removed, the service starts without problems. Perhaps you can describe the problem in the FAQ or somewhere else. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
Günter Knauf a écrit : IMHO, this is wrong. The server port isn't necessarily the port being listened on. See bug report and patch, long ignored: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901 ok, but its as wrong as before - my patch doesnt change the behaviour from what I see, and this is what I can find in the httpd-2.1 sources too in order to work with APR 1.0 because apr_sockaddr_port_get() was removed. I dont know for what reasons the patch you point to isnt applied yet; and I agree with you that it is better to correct the behaviour than change from wrong to wrong; so I'd suggest that you create another patch and post it here, and hope that it will be accepted by those who have commit rights, just as I do... In JK 1.2.x for Apache 2 we're using : s-server_name = (char *)ap_get_server_name(r); ... apr_sockaddr_port_get(port,r-connection-local_addr); s-server_port = port; Do you agree with this, if so I'll do the same for jk2 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 jk_service_apache2.c
hgomez 2004/01/22 01:19:55 Modified:jk/native2/server/apache2 jk_service_apache2.c Log: Get server name from Apache, the same way that JK 1.2.x. Port correction should now be studied Revision ChangesPath 1.37 +3 -4 jakarta-tomcat-connectors/jk/native2/server/apache2/jk_service_apache2.c Index: jk_service_apache2.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/jk_service_apache2.c,v retrieving revision 1.36 retrieving revision 1.37 diff -u -r1.36 -r1.37 --- jk_service_apache2.c 30 Sep 2003 13:42:02 - 1.36 +++ jk_service_apache2.c 22 Jan 2004 09:19:55 - 1.37 @@ -372,9 +372,8 @@ s-remote_host = NULL_FOR_EMPTY(s-remote_host); s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip); -/* get server name */ -s-server_name= (char *)(r-hostname ? r-hostname : - r-server-server_hostname); +/* get server name like in jk 1.2.x */ +s-server_name= (char *)ap_get_server_name(r); /* get the real port (otherwise redirect failed) */ apr_sockaddr_port_get(port,r-connection-local_addr); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] New: - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341 It's possible to call getAttribute() while session is invalidated without IAE Summary: It's possible to call getAttribute() while session is invalidated without IAE Product: Tomcat 5 Version: Nightly Build Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Servlet JSP API AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] While the session is invalidated all SessionBindingListener are notified with valueUnbound(). In valueUnbound() it's possible to call e.g. getAttribute() on the invalidating session without getting an IllegalArgumentException (which wasn't possible in Tomcat 4.1.29). And according to the servlet-spec (2.3 or 2.4) it shouldn't be possible: Except from HttpSession-API ... For session that are invalidated or expire, notifications are sent after the session has been invalidatd or expired. ... I would interpret this as: The valueUnbound() should be called AFTER the session is invalidated and so I have to get an IAE when calling session.getAttribute() in valueUnbound(). Thanks Lars - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Handling of JNDI ResourceLinks
Hi,
currently it is not possible to use ResourceLinks to bind a
UserTransaction in the java:comp context of a web application because
the way it is implemented ResourceLinks are always bound in the
java:comp/env context. I stumbled across this because I thought it would
make sense to configure my transaction manager only in one place and
have all my webapps access it via ResourceLinks instead of copying the
configuration for each webapp, which did not work. The current behaviour
is not documented and a little hard to understand. It is only a minor
thing (therefore I'm not filing a bug) but I would be grateful if you
could make that little change to make the behaviour a little more
consistent. I have attached a patch that does this which you may use if
you agree with the (rather simple) way I fixed it.
Thanks in advance and regards,
Robert
--
Robert Krüger
Signal7 GmbH
Brüder Knauss Str. 79
64285 Darmstadt
Germany
Index: catalina/src/share/org/apache/catalina/core/NamingContextListener.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
retrieving revision 1.4
diff --unified -r1.4 NamingContextListener.java
--- catalina/src/share/org/apache/catalina/core/NamingContextListener.java 2 Sep
2003 21:22:04 - 1.4
+++ catalina/src/share/org/apache/catalina/core/NamingContextListener.java 22 Jan
2004 09:46:03 -
@@ -939,10 +939,14 @@
addAdditionalParameters(resourceLink.getNamingResources(), ref,
resourceLink.getName());
try {
+javax.naming.Context ctx = envCtx;
+if(javax.transaction.UserTransaction.equals(resourceLink.getType())){
+ctx = compCtx;
+}
if (debug = 2)
log( Adding resource link + resourceLink.getName());
-createSubcontexts(envCtx, resourceLink.getName());
-envCtx.bind(resourceLink.getName(), ref);
+createSubcontexts(ctx, resourceLink.getName());
+ctx.bind(resourceLink.getName(), ref);
} catch (NamingException e) {
log(sm.getString(naming.bindFailed, e));
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341 It's possible to call getAttribute() while session is invalidated without IAE --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 10:39 --- I have this big urge about reverting the fix for bug 26051, and classify it as a this will never be fixed issue. It would definitely avoid lots of problems. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341 It's possible to call getAttribute() while session is invalidated without IAE --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 11:08 --- If I understand you right, you want to set this bug to will never be fixed and not the other (26051), right? If this bug won't be fixed, it's not possible for bound objects to determine if they are unbound because of a normal removeAttribute()-call or a session-invalidation. The following scenario is not possible with tomcat 5: The bound object has to do nothing if the value is simply removed from the session (e.g. it is replaced by a proxy object and later restored again) and has to free some resources if the session is invalidated. With tomcat 4 I could call session.getAttribute() and catch the IAE to know the session is invalid (session.isValid() would be a nice method) - this doesn't work with tomcat 5. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341 It's possible to call getAttribute() while session is invalidated without IAE --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 11:17 --- I was obviously talking about 26051 (additional fixes are also needed in quite a few places to really adress it). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341 It's possible to call getAttribute() while session is invalidated without IAE --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 11:23 --- BTW, this works with 5.0.18, but not with the nightly (because of the new accessCount check in isValid()), right ? If it doesn't work, I don't understand how it can be, and recommend you add debug in the StandardSession.expire and isValid to see what's going on. I recommend not using the nightlies for now: a few features will be added and they will not be as stable as what they used to be. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-server VM option does not work, changing VM breaks configure tool
Hello all, I'm trying to check if the -server option of the VM would improve performance. However, I'm running into weird problems. My platform is Windows 2000, J2SDK 1.4.2_02, Tomcat 5.0.16. Java was installed with the default options (it installed the JRE automatically). Tomcat was installed with the Service option checked, and correctly detected the path for the SDK. JAVA_HOME is set to c:\j2sdk1.4.2_02 PATH is set to C:\j2sdk1.4.2_02\bin;%SystemRoot%\system32;etc... Using the Configure Tomcat tool, I've set the Java options to: -Dcatalina.home=C:\Program Files\Apache Software Foundation\Tomcat 5.0 -Djava.endorsed.dirs=C:\Program Files\Apache Software Foundation\Tomcat 5.0\common\endorsed -server But then, when I try to run the service, I get that: $ net start apache tomcat The Apache Tomcat service is starting. The Apache Tomcat service could not be started. The service did not report an error. More help is available by typing NET HELPMSG 3534. Nothing in Windows' logs, and Tomcat stderr is truncated: $ more stderr.log Err I tried several times, and sometimes got only the first letter, and once more information, and the error is the same as when running: C:\c:\winnt\system32\java -server Error: no `server' JVM at `C:\Program Files\Java\j2re1.4.2_02\bin\server\jvm.dll'. Runnin c:\j2sdk1.4.2_02\bin\java -server does not give that error, so it seems that Tomcat is somehow picking the wrong java.exe. If I run Configure Tomcat again, and put C:\j2sdk1.4.2_02\bin\java.exe instead of the default java.exe, then the problem gets worse: $ net start apache tomcat The service is not responding to the control function. More help is available by typing NET HELPMSG 2186. And the Configure Tomcat tool does not start anymore, I have to modify the value in the registry. This is using clean installs for the J2SDK and Tomcat. I've glanced at the Tomcat 5.0.18 changelog, and didn't notice anything that could relate to that, but I haven't tried installing it yet. Does anybody know if I'm doing something wrong, or if there is a problem in Tomcat 5.0.16 install? TIA, Laurent - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-site/xdocs index.xml
remm2004/01/22 04:14:07 Modified:xdocsindex.xml Log: - Update version number. Revision ChangesPath 1.45 +1 -1 jakarta-tomcat-site/xdocs/index.xml Index: index.xml === RCS file: /home/cvs/jakarta-tomcat-site/xdocs/index.xml,v retrieving revision 1.44 retrieving revision 1.45 diff -u -r1.44 -r1.45 --- index.xml 3 Dec 2003 21:39:33 - 1.44 +++ index.xml 22 Jan 2004 12:14:07 - 1.45 @@ -40,7 +40,7 @@ tr td2.4/2.0/td - td5.0.16/td + td5.0.18/td /tr tr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341
It's possible to call getAttribute() while session is invalidated without IAE
--- Additional Comments From [EMAIL PROTECTED] 2004-01-22 12:17 ---
BTW: In my earlier submits I said IllegalArgumentException but meant
IllegalStateException.
My problem occurs in 5.0.16, 5.0.18, nightly build (01/21/2004) because of the
following code in catalina.session.StandardSession (the implementation-excerpts
below haven't changed since 5.0.16):
invalidate () { expire(); }
expire () { expire(true); }
expire(boolean)
{
this.expiring=true;
//invalidate session
this.expiring=false;
}
getAttribute()
{
if (! isValid()) throw IllegalStateException ();
...
}
isValid()
{
if (this.expiring) return true;
...
}
So while the invalidation the session is always valid.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
Hi Henri, In JK 1.2.x for Apache 2 we're using : s-server_name = (char *)ap_get_server_name(r); ... apr_sockaddr_port_get(port,r-connection-local_addr); s-server_port = port; Do you agree with this, if so I'll do the same for jk2 no, apr_sockaddr_port_get() was recently removed from APR 1.0; from APR ChangeLog: *) The following deprecated interfaces have been removed: ... apr_sockaddr_port_get- (access directly) ... so seems there's no new function anymore which can replace apr_sockaddr_port_get(); so I compared some files between 2.0.48 and 2.1-dev and found the same as my first patch does... Also my only intension is getting mod_jk/mod_jk2 compiled with httpd_2.1-dev; so every patch which uses an API that is still available with APR 1.0 is fine for me BTW: can you perhaps also patch the ./jk/native2/server/apache2/mod_jk2.dsp ?? here's the patch which removes the now obsolete source files, and changes the output to .so : http://www.gknw.com/test/mod_jk2.dsp.diff thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: -server VM option does not work, changing VM breaks configure tool
I'm trying to check if the -server option of the VM would improve performance. However, I'm running into weird problems. My platform is Windows 2000, J2SDK 1.4.2_02, Tomcat 5.0.16. Java was installed with the default options (it installed the JRE automatically). Tomcat was installed with the Service option checked, and correctly detected the path for the SDK. JAVA_HOME is set to c:\j2sdk1.4.2_02 PATH is set to C:\j2sdk1.4.2_02\bin;%SystemRoot%\system32;etc... Using the Configure Tomcat tool, I've set the Java options to: -Dcatalina.home=C:\Program Files\Apache Software Foundation\Tomcat 5.0 -Djava.endorsed.dirs=C:\Program Files\Apache Software Foundation\Tomcat 5.0\common\endorsed -server -server needs to be the first parameter following java executable. Try placing it as a first parameter. But then, when I try to run the service, I get that: $ net start apache tomcat The Apache Tomcat service is starting. The Apache Tomcat service could not be started. The service did not report an error. More help is available by typing NET HELPMSG 3534. Nothing in Windows' logs, and Tomcat stderr is truncated: $ more stderr.log Err I tried several times, and sometimes got only the first letter, and once more information, and the error is the same as when running: C:\c:\winnt\system32\java -server Error: no `server' JVM at `C:\Program Files\Java\j2re1.4.2_02\bin\server\jvm.dll'. Indeed, j2sdk1.4.2 does not install server vm within the j2re in C:\Program Files\Java\j2re1.4.2_02\bin\. You can simply copy appropriate binaried from j2sdk or update your PATH env variable so that JAVA_HOME\bin\java is picked up first. Does anybody know if I'm doing something wrong, or if there is a problem in Tomcat 5.0.16 install? Everything's fine with it, honest. Best regards, Dominik - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: -server VM option does not work, changing VM breaks configure tool
Answering myself, my apologies: I found a solution: checking the Auto box (unchecked by default) makes Tomcat work as expected, with the -server option. Since without it, Tomcat does not use the correct SDK, as it should from the quote below, I think this could be either a bug, or at least wrong default parameters. Java location: The installer will use the registry or the JAVA_HOME environment variable to determine the base path of the JDK or a JRE. If only a JRE (or an incorrect path) is specified, Tomcat will run but will be unable to compile JSP pages at runtime. Either all webapps will need to be precompiled (this can be easily done using the Tomcat deployer), or the lib\tools.jar file from a JDK installation must be copied to the common\lib path of the Tomcat installation. http://jakarta.apache.org/tomcat/tomcat-5.0-doc/setup.html Am I right there? Laurent Selon Laurent Blume [EMAIL PROTECTED]: Hello all, I'm trying to check if the -server option of the VM would improve performance. However, I'm running into weird problems. My platform is Windows 2000, J2SDK 1.4.2_02, Tomcat 5.0.16. Java was installed with the default options (it installed the JRE automatically). Tomcat was installed with the Service option checked, and correctly detected the path for the SDK. JAVA_HOME is set to c:\j2sdk1.4.2_02 PATH is set to C:\j2sdk1.4.2_02\bin;%SystemRoot%\system32;etc... Using the Configure Tomcat tool, I've set the Java options to: -Dcatalina.home=C:\Program Files\Apache Software Foundation\Tomcat 5.0 -Djava.endorsed.dirs=C:\Program Files\Apache Software Foundation\Tomcat 5.0\common\endorsed -server But then, when I try to run the service, I get that: $ net start apache tomcat The Apache Tomcat service is starting. The Apache Tomcat service could not be started. The service did not report an error. More help is available by typing NET HELPMSG 3534. Nothing in Windows' logs, and Tomcat stderr is truncated: $ more stderr.log Err I tried several times, and sometimes got only the first letter, and once more information, and the error is the same as when running: C:\c:\winnt\system32\java -server Error: no `server' JVM at `C:\Program Files\Java\j2re1.4.2_02\bin\server\jvm.dll'. Runnin c:\j2sdk1.4.2_02\bin\java -server does not give that error, so it seems that Tomcat is somehow picking the wrong java.exe. If I run Configure Tomcat again, and put C:\j2sdk1.4.2_02\bin\java.exe instead of the default java.exe, then the problem gets worse: $ net start apache tomcat The service is not responding to the control function. More help is available by typing NET HELPMSG 2186. And the Configure Tomcat tool does not start anymore, I have to modify the value in the registry. This is using clean installs for the J2SDK and Tomcat. I've glanced at the Tomcat 5.0.18 changelog, and didn't notice anything that could relate to that, but I haven't tried installing it yet. Does anybody know if I'm doing something wrong, or if there is a problem in Tomcat 5.0.16 install? TIA, Laurent - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- - 9, rue du Sentier - - 78400 Chatou - - France- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: -server VM option does not work, changing VM breaks configure tool
Dominik Use 8.3 file names shortened named for directories over 8 characters e.g. C:\Program Files to C:\PROGRA~1 -Martin - Original Message - From: Dominik Drzewiecki [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, January 22, 2004 8:37 AM Subject: Re: -server VM option does not work, changing VM breaks configure tool I'm trying to check if the -server option of the VM would improve performance. However, I'm running into weird problems. My platform is Windows 2000, J2SDK 1.4.2_02, Tomcat 5.0.16. Java was installed with the default options (it installed the JRE automatically). Tomcat was installed with the Service option checked, and correctly detected the path for the SDK. JAVA_HOME is set to c:\j2sdk1.4.2_02 PATH is set to C:\j2sdk1.4.2_02\bin;%SystemRoot%\system32;etc... Using the Configure Tomcat tool, I've set the Java options to: -Dcatalina.home=C:\Program Files\Apache Software Foundation\Tomcat 5.0 -Djava.endorsed.dirs=C:\Program Files\Apache Software Foundation\Tomcat 5.0\common\endorsed -server -server needs to be the first parameter following java executable. Try placing it as a first parameter. But then, when I try to run the service, I get that: $ net start apache tomcat The Apache Tomcat service is starting. The Apache Tomcat service could not be started. The service did not report an error. More help is available by typing NET HELPMSG 3534. Nothing in Windows' logs, and Tomcat stderr is truncated: $ more stderr.log Err I tried several times, and sometimes got only the first letter, and once more information, and the error is the same as when running: C:\c:\winnt\system32\java -server Error: no `server' JVM at `C:\Program Files\Java\j2re1.4.2_02\bin\server\jvm.dll'. Indeed, j2sdk1.4.2 does not install server vm within the j2re in C:\Program Files\Java\j2re1.4.2_02\bin\. You can simply copy appropriate binaried from j2sdk or update your PATH env variable so that JAVA_HOME\bin\java is picked up first. Does anybody know if I'm doing something wrong, or if there is a problem in Tomcat 5.0.16 install? Everything's fine with it, honest. Best regards, Dominik - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26346] - Calling getParameter produces NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346 Calling getParameter produces NullPointerException [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 14:48 --- Nice report. Actually, it seems the name you gave is null. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-site/docs bugreport.html index.html irc.html resources.html
remm2004/01/22 07:05:00 Modified:docs bugreport.html index.html irc.html resources.html Log: - Update version number. Revision ChangesPath 1.18 +1 -1 jakarta-tomcat-site/docs/bugreport.html Index: bugreport.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/bugreport.html,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- bugreport.html25 Nov 2003 13:57:22 - 1.17 +++ bugreport.html22 Jan 2004 15:05:00 - 1.18 @@ -329,7 +329,7 @@ /td/tr trtd colspan=2 div align=centerfont color=#525D76 size=-1em -Copyright #169; 1999-2003, Apache Software Foundation +Copyright #169; 1999-2004, Apache Software Foundation /em/font/div /td/tr /table 1.55 +2 -2 jakarta-tomcat-site/docs/index.html Index: index.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/index.html,v retrieving revision 1.54 retrieving revision 1.55 diff -u -r1.54 -r1.55 --- index.html3 Dec 2003 21:39:33 - 1.54 +++ index.html22 Jan 2004 15:05:00 - 1.55 @@ -173,7 +173,7 @@ /td td bgcolor=#a0ddf0 colspan= rowspan= valign=top align=left font color=#00 size=-1 face=arial,helvetica,sanserif -5.0.16 +5.0.18 /font /td /tr @@ -342,7 +342,7 @@ /td/tr trtd colspan=2 div align=centerfont color=#525D76 size=-1em -Copyright #169; 1999-2003, Apache Software Foundation +Copyright #169; 1999-2004, Apache Software Foundation /em/font/div /td/tr /table 1.19 +1 -1 jakarta-tomcat-site/docs/irc.html Index: irc.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/irc.html,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- irc.html 25 Nov 2003 13:57:22 - 1.18 +++ irc.html 22 Jan 2004 15:05:00 - 1.19 @@ -143,7 +143,7 @@ /td/tr trtd colspan=2 div align=centerfont color=#525D76 size=-1em -Copyright #169; 1999-2003, Apache Software Foundation +Copyright #169; 1999-2004, Apache Software Foundation /em/font/div /td/tr /table 1.22 +1 -1 jakarta-tomcat-site/docs/resources.html Index: resources.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/resources.html,v retrieving revision 1.21 retrieving revision 1.22 diff -u -r1.21 -r1.22 --- resources.html25 Nov 2003 13:57:22 - 1.21 +++ resources.html22 Jan 2004 15:05:00 - 1.22 @@ -238,7 +238,7 @@ /td/tr trtd colspan=2 div align=centerfont color=#525D76 size=-1em -Copyright #169; 1999-2003, Apache Software Foundation +Copyright #169; 1999-2004, Apache Software Foundation /em/font/div /td/tr /table - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26346] New: - Calling getParameter produces NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346 Calling getParameter produces NullPointerException Summary: Calling getParameter produces NullPointerException Product: Tomcat 5 Version: 5.0.16 Platform: PC OS/Version: Linux Status: NEW Severity: Major Priority: Other Component: Connector:Coyote AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Calling getParameter produces NullPointerException in some cases when the requested parameter was a radio button on a very long form (107 kB). In some cases, the problem appears only when the button is unchecked, in others the exception appears in both cases. User agent is Internet Explorer 6.0SP1 fully updated. The stack trace is always the same: java.lang.NullPointerException at java.util.Hashtable.get(Hashtable.java:333) at org.apache.tomcat.util.http.Parameters.getParameterValues (Parameters.java:231) at org.apache.coyote.tomcat5.CoyoteRequest.getParameterValues (CoyoteRequest.java:1131) at org.apache.coyote.tomcat5.CoyoteRequestFacade.getParameterValues (CoyoteRequestFacade.java:332) at info.informatica.html.FormField.setValue(FormField.java:204) at info.informatica.www.HttpDataEntryForm.setValues (HttpDataEntryForm.java:123) at info.informatica.servlet.form.FormServlet.fillForm (FormServlet.java:526) at info.informatica.servlet.form.FormServlet.doPost (FormServlet.java:481) at javax.servlet.http.HttpServlet.service(HttpServlet.java:763) at info.informatica.servlet.BaseServlet.service(BaseServlet.java:201) at javax.servlet.http.HttpServlet.service(HttpServlet.java:856) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:284) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:204) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:256) at org.apache.catalina.core.StandardValveContext.invokeNext (StandardValveContext.java:151) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:564) at org.apache.catalina.core.StandardContextValve.invokeInternal (StandardContextValve.java:245) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:199) at org.apache.catalina.core.StandardValveContext.invokeNext (StandardValveContext.java:151) at org.apache.catalina.authenticator.AuthenticatorBase.invoke (AuthenticatorBase.java:594) at org.apache.catalina.core.StandardValveContext.invokeNext (StandardValveContext.java:149) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:564) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:195) at org.apache.catalina.core.StandardValveContext.invokeNext (StandardValveContext.java:151) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:164) at org.apache.catalina.core.StandardValveContext.invokeNext (StandardValveContext.java:149) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:564) at org.apache.catalina.core.StandardEngineValve.invoke (StandardEngineValve.java:156) at org.apache.catalina.core.StandardValveContext.invokeNext (StandardValveContext.java:151) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:564) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:972) at org.apache.coyote.tomcat5.CoyoteAdapter.service (CoyoteAdapter.java:211) at org.apache.coyote.http11.Http11Processor.process (Http11Processor.java:805) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnectio n(Http11Protocol.java:696) at org.apache.tomcat.util.net.TcpWorkerThread.runIt (PoolTcpEndpoint.java:605) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run (ThreadPool.java:677) at java.lang.Thread.run(Thread.java:534) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26341] - It's possible to call getAttribute() while session is invalidated without IAE
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26341 It's possible to call getAttribute() while session is invalidated without IAE --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 13:39 --- I forgot about the flag. This is contradicting the new policy about the session being still useable when the expiration notification is sent. I think confirmation this is as intended is needed, otherwise, notification for attributes will have to be handled as yet another special case (or we'll have to decide we don't care). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] improve I18N for admintool
Hi, Could you take this patch to improve admintool's I18N? http://issues.apache.org/bugzilla/show_bug.cgi?id=25160 regargs, Takashi Okamoto - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 NWGNUmakefile
mmanders2004/01/22 08:42:31 Added: jk/native/apache-2.0 NWGNUmakefile Log: Makefile for building NetWare version of mod_jk submitted by Guenter Knauf ([EMAIL PROTECTED]). Revision ChangesPath 1.1 jakarta-tomcat-connectors/jk/native/apache-2.0/NWGNUmakefile Index: NWGNUmakefile === # # Makefile for mod_jk (uses the build system of Apache2 - gnu make) # created by Guenter Knauf [EMAIL PROTECTED] # #ifeq ($(strip $(JAVA_HOME)),) [EMAIL PROTECTED] You must set the JAVA_HOME environment var pointing to the NetWare Java SDK! #endif # # Declare the sub-directories to be built here # SUBDIRS = \ $(EOLIST) # # Get the 'head' of the build environment. This includes default targets and # paths to tools # include $(AP_WORK)\build\NWGNUhead.inc # # build this level's files # # Make sure all needed macro's are defined # JKCOMMON = ../common # # These directories will be at the beginning of the include list, followed by # INCDIRS # XINCDIRS += \ $(JKCOMMON) \ $(AP_WORK)/include \ $(NWOS) \ $(AP_WORK)/modules/arch/netware \ $(AP_WORK)/srclib/apr/include \ $(AP_WORK)/srclib/apr-util/include \ $(AP_WORK)/srclib/apr \ $(JAVA_HOME)/include \ $(JAVA_HOME)/include/netware \ $(EOLIST) # # These flags will come after CFLAGS # XCFLAGS += \ $(EOLIST) # # These defines will come after DEFINES # XDEFINES += \ -D__NOVELL_LIBC__ \ $(EOLIST) # # These flags will be added to the link.opt file # XLFLAGS += \ $(EOLIST) # # These values will be appended to the correct variables based on the value of # RELEASE # ifeq $(RELEASE) debug XINCDIRS += \ $(EOLIST) XCFLAGS += \ $(EOLIST) XDEFINES += \ $(EOLIST) XLFLAGS += \ $(EOLIST) endif ifeq $(RELEASE) noopt XINCDIRS += \ $(EOLIST) XCFLAGS += \ $(EOLIST) XDEFINES += \ $(EOLIST) XLFLAGS += \ $(EOLIST) endif ifeq $(RELEASE) release XINCDIRS += \ $(EOLIST) XCFLAGS += \ $(EOLIST) XDEFINES += \ $(EOLIST) XLFLAGS += \ $(EOLIST) endif # # These are used by the link target if an NLM is being generated # This is used by the link 'name' directive to name the nlm. If left blank # TARGET_nlm (see below) will be used. # NLM_NAME = mod_jk # # This is used by the link '-desc ' directive. # If left blank, NLM_NAME will be used. # NLM_DESCRIPTION = Apache $(VERSION_STR) plugin for Jakarta/Tomcat $(JK_VERSION_STR) # # This is used by the link '-copy ' directive. # If left blank, the ASF copyright defined in NWGNUtail.inc will be used. # NLM_COPYRIGHT = # # This is used by the '-threadname' directive. If left blank, # NLM_NAME Thread will be used. # NLM_THREAD_NAME = JK Module # # If this is specified, it will override VERSION value in # $(AP_WORK)\build\NWGNUenvironment.inc # NLM_VERSION = $(JK_VERSION) # # If this is specified, it will override the default of 64K # NLM_STACK_SIZE= 32768 # # If this is specified it will be used by the link '-entry' directive # NLM_ENTRY_SYM = _LibCPrelude # # If this is specified it will be used by the link '-exit' directive # NLM_EXIT_SYM = _LibCPostlude # # If this is specified it will be used by the link '-check' directive # NLM_CHECK_SYM = # # If these are specified it will be used by the link '-flags' directive # NLM_FLAGS = AUTOUNLOAD, PSEUDOPREEMPTION # # If this is specified it will be linked in with the XDCData option in the def # file instead of the default of $(NWOS)/apache.xdc. XDCData can be disabled # by setting APACHE_UNIPROC in the environment # XDCDATA = # # If there is an NLM target, put it here # TARGET_nlm = \ $(OBJDIR)/mod_jk.nlm \ $(EOLIST) # # If there is an LIB target, put it here # TARGET_lib = \ $(EOLIST) # # These are the OBJ files needed to create the NLM target above. # Paths must all use the '/' character #
DO NOT REPLY [Bug 26346] - Calling getParameter produces NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346 Calling getParameter produces NullPointerException [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 16:54 --- Actually, the parameter names are not null, but have names like sex, status, etc. And, as mentioned in the bug description, only happens with radio buttons on a large form. I made a lot of combinations with the form, but always got the same stack trace. According to Servlet spec, I do not expect a NullPointerException when requesting a parameter which, certainly, has a name. Therefore, this is a bug. I do keep investigating it, meanwhile if someone figures out what could be happening any suggestion would be welcome. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26346] - Calling getParameter produces NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346 Calling getParameter produces NullPointerException --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 17:01 --- Is this a GET request? Are you passing too much information via the request line? Does this happen with POST requests? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26346] - Calling getParameter produces NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26346
Calling getParameter produces NullPointerException
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution||INVALID
--- Additional Comments From [EMAIL PROTECTED] 2004-01-22 17:02 ---
Look at the getParameterValues code (line 231 is marked):
public String[] getParameterValues(String name) {
handleQueryParameters();
// sub-request
if( currentChild!=null ) {
currentChild.merge();
return (String[])currentChild.paramHashStringArray.get(name);
}
// no facade
String values[]=(String[])paramHashStringArray.get(name);
return values;
}
And line 333 in Hashtable (assuming you're using JDK 1.4.2):
public synchronized Object get(Object key) {
Entry tab[] = table;
int hash = key.hashCode();
int index = (hash 0x7FFF) % tab.length;
for (Entry e = tab[index] ; e != null ; e = e.next) {
if ((e.hash == hash) e.key.equals(key)) {
return e.value;
}
}
return null;
}
I recommend you don't bother reopening this bug ;)
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: -server VM option does not work, changing VM breaks configure tool
Selon Dominik Drzewiecki [EMAIL PROTECTED]: Try placing it as a first parameter. Sorry, I forgot to write that I had tried that quickly on the command line, and checked that order does not matter (in that case). Indeed, j2sdk1.4.2 does not install server vm within the j2re in C:\Program Files\Java\j2re1.4.2_02\bin\. You can simply copy appropriate binaried from j2sdk or update your PATH env variable so that JAVA_HOME\bin\java is picked up first. I'd rather avoid copying files around, since I'm just installing the server, and I'm not going to maintain it on the long term. I want to keep the install procedure as simple as possible for others. As for the PATH, that's just what I did, placed the SDK directory first in the PATH, checked that the right binary was picked first from a command line, even rebooted the system to make sure that Windows updates all its internal stuff, but still, Tomcat seemed to pick up the wrong one. Everything's fine with it, honest. Well, the install program itself certainly is very good, but really, I think there is a possibility that the parameters are somehow wrong, or the configure tool itself is not right. To say the least, I found the behaviour confusing, and I'm almost sure that the configure tool and Tomcat should not stop working after I chose the right JVM to use. Thanks for replying, I hope you'll be able to tell me what was wrong (even though my server is now working fine with the Auto parameter :-) Laurent - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
Günter Knauf a écrit : Hi Henri, In JK 1.2.x for Apache 2 we're using : s-server_name = (char *)ap_get_server_name(r); ... apr_sockaddr_port_get(port,r-connection-local_addr); s-server_port = port; Do you agree with this, if so I'll do the same for jk2 no, apr_sockaddr_port_get() was recently removed from APR 1.0; from APR ChangeLog: *) The following deprecated interfaces have been removed: ... apr_sockaddr_port_get- (access directly) ... so seems there's no new function anymore which can replace apr_sockaddr_port_get(); so I compared some files between 2.0.48 and 2.1-dev and found the same as my first patch does... Also my only intension is getting mod_jk/mod_jk2 compiled with httpd_2.1-dev; so every patch which uses an API that is still available with APR 1.0 is fine for me Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if everybody agree BTW: can you perhaps also patch the ./jk/native2/server/apache2/mod_jk2.dsp ?? here's the patch which removes the now obsolete source files, and changes the output to .so : http://www.gknw.com/test/mod_jk2.dsp.diff I'll try to patch it tomorrow... - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25127] - Tomcat 4.1.29 will not start with IBM JDK 1.3.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25127. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25127 Tomcat 4.1.29 will not start with IBM JDK 1.3.0 --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 17:08 --- I verified it with some other Java version: With 1.3.0_05 it worked fine. With 1.3.0_01 I had the same crash as with the version in my last post (this one was included in JBuilder 4) After some digging in the sun bug database, I came across the following two issues: http://developer.java.sun.com/developer/bugParade/bugs/4334201.html http://developer.java.sun.com/developer/bugParade/bugs/4401404.html They sound a bit like the current problem, although I know too little about JAR indexing and ResourceBundles. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: -server VM option does not work, changing VM breaks configure tool
Selon Martin Gainty [EMAIL PROTECTED]: Dominik Use 8.3 file names shortened named for directories over 8 characters e.g. C:\Program Files to C:\PROGRA~1 Well, since NTFS on my servers does not have that obsolete 8.3 names support, I'd rather stick to the long names, which work very well. I don't see how it relates to my question, though :-) Laurent - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java
remm2004/01/22 10:21:21
Modified:catalina/src/share/org/apache/catalina/session
StandardSession.java
Log:
- Improvements to session activity tracking, handling the case where the
session is new, as well as cross context.
- If this doesn't work, I give up ;)
Revision ChangesPath
1.31 +8 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
Index: StandardSession.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- StandardSession.java 21 Jan 2004 10:46:58 - 1.30
+++ StandardSession.java 22 Jan 2004 18:21:21 - 1.31
@@ -316,7 +316,7 @@
/**
* The access count for thsi session.
*/
-protected transient int accessCount = 0;
+protected transient int accessCount = 1;
// - Session Properties
@@ -630,7 +630,6 @@
*/
public void access() {
-this.isNew = false;
this.lastAccessedTime = this.thisAccessedTime;
this.thisAccessedTime = System.currentTimeMillis();
@@ -646,6 +645,7 @@
*/
public void endAccess() {
+isNew = false;
accessCount--;
}
@@ -725,6 +725,7 @@
}
}
}
+accessCount = 0;
setValid(false);
// Remove this session from our manager's active sessions
@@ -839,7 +840,7 @@
id = null;
lastAccessedTime = 0L;
maxInactiveInterval = -1;
-accessCount = 0;
+accessCount = 1;
notes.clear();
setPrincipal(null);
isNew = false;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java ApplicationHttpRequest.java StandardHostValve.java
remm2004/01/22 10:21:36
Modified:catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java
ApplicationHttpRequest.java StandardHostValve.java
Log:
- Improvements to session activity tracking, handling the case where the
session is new, as well as cross context.
- If this doesn't work, I give up ;)
Revision ChangesPath
1.27 +10 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
Index: ApplicationDispatcher.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- ApplicationDispatcher.java12 Sep 2003 17:04:12 - 1.26
+++ ApplicationDispatcher.java22 Jan 2004 18:21:36 - 1.27
@@ -441,6 +441,8 @@
}
processRequest(request,response);
+
+wrequest.recycle();
unwrapRequest();
}
@@ -582,6 +584,8 @@
new
Integer(ApplicationFilterFactory.INCLUDE));
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
origServletPath);
invoke(outerRequest, outerResponse);
+
+wrequest.recycle();
unwrapRequest();
unwrapResponse();
@@ -628,6 +632,8 @@
new
Integer(ApplicationFilterFactory.INCLUDE));
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
origServletPath);
invoke(outerRequest, outerResponse);
+
+wrequest.recycle();
unwrapRequest();
unwrapResponse();
1.15 +60 -60
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
Index: ApplicationHttpRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- ApplicationHttpRequest.java 22 Dec 2003 09:28:50 - 1.14
+++ ApplicationHttpRequest.java 22 Jan 2004 18:21:36 - 1.15
@@ -232,7 +232,7 @@
/**
* The currently active session for this request.
*/
-protected HttpSession session = null;
+protected Session session = null;
/**
@@ -387,17 +387,16 @@
public String getParameter(String name) {
parseParameters();
-synchronized (parameters) {
-Object value = parameters.get(name);
-if (value == null)
-return (null);
-else if (value instanceof String[])
-return (((String[]) value)[0]);
-else if (value instanceof String)
-return ((String) value);
-else
-return (value.toString());
-}
+
+Object value = parameters.get(name);
+if (value == null)
+return (null);
+else if (value instanceof String[])
+return (((String[]) value)[0]);
+else if (value instanceof String)
+return ((String) value);
+else
+return (value.toString());
}
@@ -421,9 +420,7 @@
public Enumeration getParameterNames() {
parseParameters();
-synchronized (parameters) {
-return (new Enumerator(parameters.keySet()));
-}
+return (new Enumerator(parameters.keySet()));
}
@@ -437,21 +434,19 @@
public String[] getParameterValues(String name) {
parseParameters();
-synchronized (parameters) {
-Object value = parameters.get(name);
-if (value == null)
-return ((String[]) null);
-else if (value instanceof String[])
-return ((String[]) value);
-else if (value instanceof String) {
-String values[] = new String[1];
-values[0] = (String) value;
-return (values);
-} else {
-String values[] = new String[1];
-values[0] = value.toString();
-return (values);
-}
+Object value = parameters.get(name);
+if (value == null)
+return ((String[]) null);
+else if (value instanceof String[])
+return ((String[]) value);
+else if (value instanceof String) {
+String values[] = new String[1];
+
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java
remm2004/01/22 10:22:24
Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteRequest.java
Log:
- Improvements to session activity tracking, handling the case where the
session is new, as well as cross context.
- The request will call endAccess, rather than the host.
- If this doesn't work, I give up ;)
Revision ChangesPath
1.29 +8 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java
Index: CoyoteRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- CoyoteRequest.java16 Dec 2003 19:46:23 - 1.28
+++ CoyoteRequest.java22 Jan 2004 18:22:24 - 1.29
@@ -439,6 +439,9 @@
notes.clear();
cookies = null;
+if (session != null) {
+session.endAccess();
+}
session = null;
requestedSessionCookie = false;
requestedSessionId = null;
@@ -2261,6 +2264,7 @@
if ((session != null) !session.isValid())
session = null;
if (session != null) {
+session.access();
return (session.getSession());
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java
remm2004/01/22 10:26:53
Modified:http11/src/java/org/apache/coyote/http11
Http11Processor.java Http11Protocol.java
Log:
- Allow configuring the header size (for most use cases, it was too big, and since
it represents 75% of the memory allocated by Tomcat).
- New default size: 4 KB (the whole HTTP header must fit inside that, for both
the request and the response).
- Allocations of these buffers can't be dynamic: there are too many references
lying around, and this guarantees leaks. The only safe way to reallocate the
buffers if to get rid of the processor.
- Note: In Tomcat 4.1.30, I'll integrate the same connectors as in 5.0.18, to
avoid possible problems.
Revision ChangesPath
1.95 +7 -2
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
Index: Http11Processor.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
retrieving revision 1.94
retrieving revision 1.95
diff -u -r1.94 -r1.95
--- Http11Processor.java 14 Jan 2004 11:12:50 - 1.94
+++ Http11Processor.java 22 Jan 2004 18:26:52 - 1.95
@@ -119,14 +119,19 @@
* Default constructor.
*/
public Http11Processor() {
+this(Constants.DEFAULT_HTTP_HEADER_BUFFER_SIZE);
+}
+
+
+public Http11Processor(int headerBufferSize) {
request = new Request();
-inputBuffer = new InternalInputBuffer(request);
+inputBuffer = new InternalInputBuffer(request, headerBufferSize);
request.setInputBuffer(inputBuffer);
response = new Response();
response.setHook(this);
-outputBuffer = new InternalOutputBuffer(response);
+outputBuffer = new InternalOutputBuffer(response, headerBufferSize);
response.setOutputBuffer(outputBuffer);
request.setResponse(response);
1.47 +12 -1
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
Index: Http11Protocol.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -r1.46 -r1.47
--- Http11Protocol.java 15 Jan 2004 13:16:41 - 1.46
+++ Http11Protocol.java 22 Jan 2004 18:26:52 - 1.47
@@ -246,6 +246,7 @@
private int maxKeepAliveRequests=100; // as in Apache HTTPD server
private int timeout = 30; // 5 minutes as in Apache HTTPD server
private int maxPostSize = 2 * 1024 * 1024;
+private int maxHttpHeaderSize = 4 * 1024;
private String reportedname;
private int socketCloseDelay=-1;
private boolean disableUploadTimeout = true;
@@ -397,6 +398,15 @@
setAttribute(maxPostSize, + valueI);
}
+public int getMaxHttpHeaderSize() {
+return maxHttpHeaderSize;
+}
+
+public void setMaxHttpHeaderSize(int valueI) {
+maxHttpHeaderSize = valueI;
+setAttribute(maxHttpHeaderSize, + valueI);
+}
+
public String getRestrictedUserAgents() {
return restrictedUserAgents;
}
@@ -639,7 +649,8 @@
public Object[] init() {
Object thData[]=new Object[3];
-Http11Processor processor = new Http11Processor();
+Http11Processor processor =
+new Http11Processor(proto.maxHttpHeaderSize);
processor.setAdapter( proto.adapter );
processor.setThreadPool( proto.tp );
processor.setMaxKeepAliveRequests( proto.maxKeepAliveRequests );
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java mbeans-descriptors.xml
remm2004/01/22 10:27:04
Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java mbeans-descriptors.xml
Log:
- Allow configuring the header size (for most use cases, it was too big, and since
it represents 75% of the memory allocated by Tomcat).
- New default size: 4 KB (the whole HTTP header must fit inside that, for both
the request and the response).
- Allocations of these buffers can't be dynamic: there are too many references
lying around, and this guarantees leaks. The only safe way to reallocate the
buffers if to get rid of the processor.
- Note: In Tomcat 4.1.30, I'll integrate the same connectors as in 5.0.18, to
avoid possible problems.
Revision ChangesPath
1.36 +23 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java
Index: CoyoteConnector.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- CoyoteConnector.java 10 Jan 2004 20:39:50 - 1.35
+++ CoyoteConnector.java 22 Jan 2004 18:27:04 - 1.36
@@ -301,6 +301,12 @@
/**
+ * Maximum size of a HTTP header. 4KB is the default.
+ */
+private int maxHttpHeaderSize = 4 * 1024;
+
+
+/**
* Maximum number of Keep-Alive requests to honor per connection.
*/
private int maxKeepAliveRequests = 100;
@@ -1041,6 +1047,21 @@
}
/**
+ * Return the maximum HTTP header size.
+ */
+public int getMaxHttpHeaderSize() {
+return maxHttpHeaderSize;
+}
+
+/**
+ * Set the maximum HTTP header size.
+ */
+public void setMaxHttpHeaderSize(int size) {
+maxHttpHeaderSize = size;
+setProperty(maxHttpHeaderSize, String.valueOf(size));
+}
+
+/**
* Return the maximum number of Keep-Alive requests to honor
* per connection.
*/
@@ -1055,6 +1076,7 @@
maxKeepAliveRequests = mkar;
setProperty(maxKeepAliveRequests, String.valueOf(mkar));
}
+
/**
* Return the scheme that will be assigned to requests received
1.13 +4 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/mbeans-descriptors.xml,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- mbeans-descriptors.xml10 Jan 2004 20:39:50 - 1.12
+++ mbeans-descriptors.xml22 Jan 2004 18:27:04 - 1.13
@@ -85,6 +85,10 @@
description=Alias name of this connector's keypair and supporting
certificate chain
type=java.lang.String/
+attribute name=maxHttpHeaderSize
+ description=Maximum size in bytes of the HTTP header
+ type=int/
+
attribute name=maxKeepAliveRequests
description=Maximum number of Keep-Alive requests to honor per
connection
type=int/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
JSSE 1.4: 'Want' vs. 'Need' Client Certificate Authentication
One of the additional features that has been introduced in JSSE 1.4 is the ability to 'want' client certificates instead of 'require'ing them (http://java.sun.com/j2se/1.4.2/docs/guide/security/jsse/JSSERefGuide.ht ml#NewMethods). It also appears that this functionality is not available in the PureTLS implementation of the SSL protocol (at least that I could find). This feature could be useful in scenarios where some users have client side certificates and some do not. This would still allow both sets of users to connect to the same host, but using different modes of authentication. Another nice thing that this feature would give us is the ability to provide a friendly You don't have a client certificate and contact this help desk to get your client certificate instead of not allowing any requests to get into the container. Considering the fact that this is only applicable to a JDK 1.4.x VM, is this something that could be built into the current distribution? Here are some options that I came up with to get this functionality in Tomcat. 1. Provide an additional argument to the org.apache.coyote.tomcat4.CoyoteServerSocketFactory in server.xml to 'want' certificate authentication. If the underlying SSL implementation does not support that feature, log an error/warning and revert to 'need' certificate authentication. 2. For the org.apache.tomcat.util.net.jsse.JSSE14* classes, change the functionality to 'want' certificates instead of 'need' them. This gives the application and container the ability to give the user an error if they do not have a certificate instead of closing the socket and making the browser show the 'Page can not be displayed' error. This would change existing behavior and thus could be a really bad thing to do. 3. Make my own modifications and don't incorporate into the default distribution. Regards, Mike Becker - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java
kinman 2004/01/22 11:35:07
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Log:
- Fix 26276: Generated TLD inconsistent after tagfile changes. Need to
remove compilation wrapper for tag files if its clients has been changed.
Revision ChangesPath
1.76 +19 -16
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -r1.75 -r1.76
--- Compiler.java 6 Jan 2004 19:42:39 - 1.75
+++ Compiler.java 22 Jan 2004 19:35:07 - 1.76
@@ -498,6 +498,7 @@
*/
public boolean isOutDated(boolean checkClass) {
+boolean outDated = false;
String jsp = ctxt.getJspFile();
long jspRealLastModified = 0;
@@ -513,7 +514,7 @@
return true;
}
-long targetLastModified;
+long targetLastModified = 0;
File targetFile;
if( checkClass ) {
@@ -523,29 +524,30 @@
}
if (!targetFile.exists()) {
-return true;
-}
-
-targetLastModified = targetFile.lastModified();
-if (targetLastModified jspRealLastModified) {
-if( log.isDebugEnabled() )
-log.debug(Compiler: outdated: + targetFile + +
targetLastModified );
-return true;
+outDated = true;
+} else {
+targetLastModified = targetFile.lastModified();
+if (targetLastModified jspRealLastModified) {
+if( log.isDebugEnabled() ) {
+log.debug(Compiler: outdated: + targetFile + +
+targetLastModified );
+}
+outDated = true;
+}
}
// determine if source dependent files (e.g. includes using include
- // directives) have been changed.
+// directives) have been changed.
if( jsw==null ) {
-return false;
+return outDated;
}
List depends = jsw.getDependants();
if (depends == null) {
-return false;
+return outDated;
}
Iterator it = depends.iterator();
-boolean outDated = false;
while (it.hasNext()) {
String include = (String)it.next();
try {
@@ -554,18 +556,19 @@
//System.out.println(Compiler: outdated, no includeUri +
include );
outDated = true;
}
-if (includeUrl.openConnection().getLastModified()
+if (!outDated includeUrl.openConnection().getLastModified()
targetLastModified) {
//System.out.println(Compiler: outdated, include old +
include );
outDated = true;
-// Remove any potential Wrappers for tag files
-ctxt.getRuntimeContext().removeWrapper(include);
}
+// Remove any potential Wrappers for tag files
+ctxt.getRuntimeContext().removeWrapper(include);
} catch (Exception e) {
e.printStackTrace();
outDated = true;
}
}
+
return outDated;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26358] - getServletName() Problem !!!
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26358. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26358 getServletName() Problem !!! [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 19:35 --- Since the Servlet name is derived from its servlet config, a NPE makes sense. The ServletConfig is not available until the init() is called. So I recommend doing your init messages in init(), not the Constructor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26276] - Generated TLD inconsistent after tagfile changes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26276. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26276 Generated TLD inconsistent after tagfile changes [EMAIL PROTECTED] changed: What|Removed |Added Severity|Minor |Major Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 19:38 --- Fixed. You proposed is not quite right, but thanks for reporting, and for taking time looking for a fix. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
Hi Henri,
Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if
everybody agree
ok.
With APR 1.0 apr_sockaddr_port_get() was removed without replacement.
I believe that the patch below is the correct replacement to archive _same_ behaviour
as with apr_sockaddr_port_get() before, and I tested that it also works with APR 0.9.x
(Apache 2.0.48 tested):
# patch for APR 1.0 compatiblity
#
--- jk_service_apache2.c.orig Tue Sep 30 18:16:14 2003
+++ jk_service_apache2.cWed Jan 21 17:43:14 2004
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t *s,
jk_worker_t *worker, void *serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -377,8 +376,7 @@
r-server-server_hostname);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = r-connection-local_addr-port;
s-server_software = (char *)ap_get_server_version();
===
There's an outstanding patch in bugzilla:
http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=8969
--- jk/native2/server/apache2/jk_service_apache2.c 30 Sep 2003 13:42:02 -1.36
+++ jk/native2/server/apache2/jk_service_apache2.c 7 Nov 2003 00:20:16 -
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t *s,
jk_worker_t *worker, void *serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -373,12 +372,10 @@
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
/* get server name */
-s-server_name= (char *)(r-hostname ? r-hostname :
- r-server-server_hostname);
+s-server_name= (char *)ap_get_server_name(r);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = ap_get_server_port(r);
s-server_software = (char *)ap_get_server_version();
with this patch I'm also fine since it uses an API which still exists in APR 1.0 (just
compiled with httpd-2.1-dev); but since I've no NAT setup for testing the issue
described in bugzilla I cant tell if the patch solves the isssue, nor if it hurts
something else
but according to the 5 votes in bugzilla it seems to solve their problems, so I tend
to this patch now ...
once it is decided what we use now, I will create the other patches for mod_jk again...
thanks, Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote:
Hi Henri,
Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if
everybody agree
ok.
With APR 1.0 apr_sockaddr_port_get() was removed without replacement.
I believe that the patch below is the correct replacement to archive _same_
behaviour as with apr_sockaddr_port_get() before, and I tested that it also works
with APR 0.9.x (Apache 2.0.48 tested):
Please look at the bug 16901 again. This is the WRONG behavior. The
port that should be passed back to the tomcat layer isn't necessarily
the same as the port being listened on. For example, configuring Apache
httpd2 like this is perfectly legal:
Listen 8000
...
ServerName www.example.com:80
This sort of thing is frequently used by people with server farms behind
load balancers. This way they can run several httpd's on the same
machine on different ports, group them, use NAT, all kinds of stuff.
The point is: the port visible to the world is a configured value, not
one that should be inferred from the socket. Please look at the patch
on the bug again. It uses ap_get_server_port() to look up the
*configured* port of the server record. Note, this is ap_ not apr_.
The patch on the bug removes the dead apr_ function you describe, but
replaces it with the correct way of looking up the server name and port:
by asking the httpd config functions.
Please re-read the bug, and look at the UseCanonicalName doc mentioned
therein.
# patch for APR 1.0 compatiblity
#
--- jk_service_apache2.c.orig Tue Sep 30 18:16:14 2003
+++ jk_service_apache2.c Wed Jan 21 17:43:14 2004
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t *s,
jk_worker_t *worker, void *serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -377,8 +376,7 @@
r-server-server_hostname);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = r-connection-local_addr-port;
s-server_software = (char *)ap_get_server_version();
===
There's an outstanding patch in bugzilla:
http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=8969
--- jk/native2/server/apache2/jk_service_apache2.c 30 Sep 2003 13:42:02 -1.36
+++ jk/native2/server/apache2/jk_service_apache2.c 7 Nov 2003 00:20:16 -
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t *s,
jk_worker_t *worker, void *serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -373,12 +372,10 @@
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
/* get server name */
-s-server_name= (char *)(r-hostname ? r-hostname :
- r-server-server_hostname);
+s-server_name= (char *)ap_get_server_name(r);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = ap_get_server_port(r);
s-server_software = (char *)ap_get_server_version();
with this patch I'm also fine since it uses an API which still exists in APR 1.0
(just compiled with httpd-2.1-dev); but since I've no NAT setup for testing the
issue described in bugzilla I cant tell if the patch solves the isssue, nor if it
hurts something else
but according to the 5 votes in bugzilla it seems to solve their problems, so I tend
to this patch now ...
once it is decided what we use now, I will create the other patches for mod_jk
again...
thanks, Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
[EMAIL PROTECTED]
Some people have a way with words, while others... erm... thingy.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JSSE 1.4: 'Want' vs. 'Need' Client Certificate Authentication
This has been on my list for awhile (just not very high :). I am leaning in the direction of 1): change the clientAuth parameter to be a String of the form: 'true', 'false', or 'want'. It's the simplest, and cleanest. Getting the PureTLS implementation caught up with the JSSE implementation is another item on my list :). - Original Message - From: Becker, Michael [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, January 22, 2004 10:38 AM Subject: JSSE 1.4: 'Want' vs. 'Need' Client Certificate Authentication One of the additional features that has been introduced in JSSE 1.4 is the ability to 'want' client certificates instead of 'require'ing them (http://java.sun.com/j2se/1.4.2/docs/guide/security/jsse/JSSERefGuide.ht ml#NewMethods). It also appears that this functionality is not available in the PureTLS implementation of the SSL protocol (at least that I could find). This feature could be useful in scenarios where some users have client side certificates and some do not. This would still allow both sets of users to connect to the same host, but using different modes of authentication. Another nice thing that this feature would give us is the ability to provide a friendly You don't have a client certificate and contact this help desk to get your client certificate instead of not allowing any requests to get into the container. Considering the fact that this is only applicable to a JDK 1.4.x VM, is this something that could be built into the current distribution? Here are some options that I came up with to get this functionality in Tomcat. 1. Provide an additional argument to the org.apache.coyote.tomcat4.CoyoteServerSocketFactory in server.xml to 'want' certificate authentication. If the underlying SSL implementation does not support that feature, log an error/warning and revert to 'need' certificate authentication. 2. For the org.apache.tomcat.util.net.jsse.JSSE14* classes, change the functionality to 'want' certificates instead of 'need' them. This gives the application and container the ability to give the user an error if they do not have a certificate instead of closing the socket and making the browser show the 'Page can not be displayed' error. This would change existing behavior and thus could be a really bad thing to do. 3. Make my own modifications and don't incorporate into the default distribution. Regards, Mike Becker - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
However, it is the correct value to pass to Tomcat. Tomcat correctly uses
this value for getLocalPort. The value of getServerPort (which is the one
used for redirection) is taken from the Host header (as required by the 2.4
servlet spec).
- Original Message -
From: Kyle VanderBeek [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Thursday, January 22, 2004 12:25 PM
Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote:
Hi Henri,
Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if
everybody agree
ok.
With APR 1.0 apr_sockaddr_port_get() was removed without replacement.
I believe that the patch below is the correct replacement to archive
_same_ behaviour as with apr_sockaddr_port_get() before, and I tested that
it also works with APR 0.9.x (Apache 2.0.48 tested):
Please look at the bug 16901 again. This is the WRONG behavior. The
port that should be passed back to the tomcat layer isn't necessarily
the same as the port being listened on. For example, configuring Apache
httpd2 like this is perfectly legal:
Listen 8000
...
ServerName www.example.com:80
This sort of thing is frequently used by people with server farms behind
load balancers. This way they can run several httpd's on the same
machine on different ports, group them, use NAT, all kinds of stuff.
The point is: the port visible to the world is a configured value, not
one that should be inferred from the socket. Please look at the patch
on the bug again. It uses ap_get_server_port() to look up the
*configured* port of the server record. Note, this is ap_ not apr_.
The patch on the bug removes the dead apr_ function you describe, but
replaces it with the correct way of looking up the server name and port:
by asking the httpd config functions.
Please re-read the bug, and look at the UseCanonicalName doc mentioned
therein.
# patch for APR 1.0 compatiblity
#
--- jk_service_apache2.c.orig Tue Sep 30 18:16:14 2003
+++ jk_service_apache2.c Wed Jan 21 17:43:14 2004
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t
*s,
jk_worker_t *worker, void
*serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -377,8 +376,7 @@
r-server-server_hostname);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = r-connection-local_addr-port;
s-server_software = (char *)ap_get_server_version();
===
There's an outstanding patch in bugzilla:
http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=8969
--- jk/native2/server/apache2/jk_service_apache2.c 30 Sep 2003
13:42:02 -1.36
+++ jk/native2/server/apache2/jk_service_apache2.c 7 Nov 2003
00:20:16 -
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t
*s,
jk_worker_t *worker, void
*serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -373,12 +372,10 @@
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
/* get server name */
-s-server_name= (char *)(r-hostname ? r-hostname :
- r-server-server_hostname);
+s-server_name= (char *)ap_get_server_name(r);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = ap_get_server_port(r);
s-server_software = (char *)ap_get_server_version();
with this patch I'm also fine since it uses an API which still exists in
APR 1.0 (just compiled with httpd-2.1-dev); but since I've no NAT setup for
testing the issue described in bugzilla I cant tell if the patch solves the
isssue, nor if it hurts something else
but according to the 5 votes in bugzilla it seems to solve their problems,
so I tend to this patch now ...
once it is decided what we use now, I will create the other patches for
mod_jk again...
thanks, Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
[EMAIL PROTECTED]
Some people have a way with words, while others... erm... thingy.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
This message is intended only for the use of the person(s) listed above as the
intended recipient(s), and may contain information that is PRIVILEGED and
CONFIDENTIAL. If you are
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
On Thu, Jan 22, 2004 at 01:16:45PM -0800, Bill Barker wrote:
However, it is the correct value to pass to Tomcat. Tomcat correctly uses
this value for getLocalPort. The value of getServerPort (which is the one
used for redirection) is taken from the Host header (as required by the 2.4
servlet spec).
Interesting. Because the problem we were having was that a redirect
generated from within Tomcat didn't work. It would put :8000 on the FQ
URL, which the client browser wouldn't be able to reach. That's the
reason I wrote the patch (and my old company is using it in production).
Perhaps there is a bug in the way redirect Locations are built? Is
Tomcat using local port if there is no port on the Host? Because in the
absence of a port, it should use the protocol default.
- Original Message -
From: Kyle VanderBeek [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Thursday, January 22, 2004 12:25 PM
Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote:
Hi Henri,
Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if
everybody agree
ok.
With APR 1.0 apr_sockaddr_port_get() was removed without replacement.
I believe that the patch below is the correct replacement to archive
_same_ behaviour as with apr_sockaddr_port_get() before, and I tested that
it also works with APR 0.9.x (Apache 2.0.48 tested):
Please look at the bug 16901 again. This is the WRONG behavior. The
port that should be passed back to the tomcat layer isn't necessarily
the same as the port being listened on. For example, configuring Apache
httpd2 like this is perfectly legal:
Listen 8000
...
ServerName www.example.com:80
This sort of thing is frequently used by people with server farms behind
load balancers. This way they can run several httpd's on the same
machine on different ports, group them, use NAT, all kinds of stuff.
The point is: the port visible to the world is a configured value, not
one that should be inferred from the socket. Please look at the patch
on the bug again. It uses ap_get_server_port() to look up the
*configured* port of the server record. Note, this is ap_ not apr_.
The patch on the bug removes the dead apr_ function you describe, but
replaces it with the correct way of looking up the server name and port:
by asking the httpd config functions.
Please re-read the bug, and look at the UseCanonicalName doc mentioned
therein.
# patch for APR 1.0 compatiblity
#
--- jk_service_apache2.c.orig Tue Sep 30 18:16:14 2003
+++ jk_service_apache2.c Wed Jan 21 17:43:14 2004
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t
*s,
jk_worker_t *worker, void
*serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -377,8 +376,7 @@
r-server-server_hostname);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = r-connection-local_addr-port;
s-server_software = (char *)ap_get_server_version();
===
There's an outstanding patch in bugzilla:
http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=8969
--- jk/native2/server/apache2/jk_service_apache2.c 30 Sep 2003
13:42:02 -1.36
+++ jk/native2/server/apache2/jk_service_apache2.c 7 Nov 2003
00:20:16 -
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t
*s,
jk_worker_t *worker, void
*serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -373,12 +372,10 @@
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
/* get server name */
-s-server_name= (char *)(r-hostname ? r-hostname :
- r-server-server_hostname);
+s-server_name= (char *)ap_get_server_name(r);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = ap_get_server_port(r);
s-server_software = (char *)ap_get_server_version();
with this patch I'm also fine since it uses an API which still exists in
APR 1.0 (just compiled with httpd-2.1-dev); but since I've no NAT setup for
testing the issue described in bugzilla I cant tell if the patch solves the
isssue, nor if it hurts something else
but according to the 5 votes in bugzilla it seems to solve their problems,
so I tend to this patch now ...
once it is decided what we use now, I will create the other
Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
Checking the CVS logs, It was fixed on 12/2/03, so 4.1.30 will be the first
4.1.x version with the fix. Prior to then, yes it did use the value from
Apache for getServerPort.
- Original Message -
From: Kyle VanderBeek [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Thursday, January 22, 2004 1:22 PM
Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
On Thu, Jan 22, 2004 at 01:16:45PM -0800, Bill Barker wrote:
However, it is the correct value to pass to Tomcat. Tomcat correctly uses
this value for getLocalPort. The value of getServerPort (which is the one
used for redirection) is taken from the Host header (as required by the
2.4
servlet spec).
Interesting. Because the problem we were having was that a redirect
generated from within Tomcat didn't work. It would put :8000 on the FQ
URL, which the client browser wouldn't be able to reach. That's the
reason I wrote the patch (and my old company is using it in production).
Perhaps there is a bug in the way redirect Locations are built? Is
Tomcat using local port if there is no port on the Host? Because in the
absence of a port, it should use the protocol default.
- Original Message -
From: Kyle VanderBeek [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Thursday, January 22, 2004 12:25 PM
Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c
On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote:
Hi Henri,
Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if
everybody agree
ok.
With APR 1.0 apr_sockaddr_port_get() was removed without replacement.
I believe that the patch below is the correct replacement to archive
_same_ behaviour as with apr_sockaddr_port_get() before, and I tested that
it also works with APR 0.9.x (Apache 2.0.48 tested):
Please look at the bug 16901 again. This is the WRONG behavior. The
port that should be passed back to the tomcat layer isn't necessarily
the same as the port being listened on. For example, configuring Apache
httpd2 like this is perfectly legal:
Listen 8000
...
ServerName www.example.com:80
This sort of thing is frequently used by people with server farms behind
load balancers. This way they can run several httpd's on the same
machine on different ports, group them, use NAT, all kinds of stuff.
The point is: the port visible to the world is a configured value, not
one that should be inferred from the socket. Please look at the patch
on the bug again. It uses ap_get_server_port() to look up the
*configured* port of the server record. Note, this is ap_ not apr_.
The patch on the bug removes the dead apr_ function you describe, but
replaces it with the correct way of looking up the server name and port:
by asking the httpd config functions.
Please re-read the bug, and look at the UseCanonicalName doc mentioned
therein.
# patch for APR 1.0 compatiblity
#
--- jk_service_apache2.c.orig Tue Sep 30 18:16:14 2003
+++ jk_service_apache2.c Wed Jan 21 17:43:14 2004
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t
*s,
jk_worker_t *worker, void
*serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -377,8 +376,7 @@
r-server-server_hostname);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = r-connection-local_addr-port;
s-server_software = (char *)ap_get_server_version();
===
There's an outstanding patch in bugzilla:
http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=8969
--- jk/native2/server/apache2/jk_service_apache2.c 30 Sep 2003
13:42:02 -1.36
+++ jk/native2/server/apache2/jk_service_apache2.c 7 Nov 2003
00:20:16 -
@@ -343,7 +343,6 @@
static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t
*s,
jk_worker_t *worker, void
*serverObj)
{
-apr_port_t port;
char *ssl_temp = NULL;
jk_workerEnv_t *workerEnv;
request_rec *r=serverObj;
@@ -373,12 +372,10 @@
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
/* get server name */
-s-server_name= (char *)(r-hostname ? r-hostname :
- r-server-server_hostname);
+s-server_name= (char *)ap_get_server_name(r);
/* get the real port (otherwise redirect failed) */
-apr_sockaddr_port_get(port,r-connection-local_addr);
-s-server_port = port;
+s-server_port = ap_get_server_port(r);
s-server_software = (char *)ap_get_server_version();
with this patch I'm also fine since it uses an API
DO NOT REPLY [Bug 26363] New: - JSP Compiler does not recognize unbalanced Struts tag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26363. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26363 JSP Compiler does not recognize unbalanced Struts tag Summary: JSP Compiler does not recognize unbalanced Struts tag Product: Tomcat 4 Version: 4.1.29 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I upgraded from Tomcat 4.1.29 To 5.0.18 and I found out that I have had bug in my existing web app. Tomcat 5.0.18 reportet ServletException in:/pages/players/players.jsp] /pages/players/players.jsp(85,62) The end tag /logic:present is unbalanced' Error message was correct. Four applications have had this bug for six months and we never found it before upgrading to 5.x. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 13212] - JSPC is unable to compile when JSP1.1 taglib jar contains tld file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13212. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13212 JSPC is unable to compile when JSP1.1 taglib jar contains tld file [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2004-01-22 23:50 --- I have just tested this with the latest version of TC4 from CVS and I do not see the error. If your scenario still exhibits an error with the latest version of TC4, please re-open this bug and provide more details of your configuration. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java TagFileProcessor.java
kinman 2004/01/22 17:50:08
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
TagFileProcessor.java
Log:
Fix 26335: Modification check for tagfiles does not work recursively.
Get reliable dependency info from the tag instance.
Revision ChangesPath
1.77 +4 -2
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.76
retrieving revision 1.77
diff -u -r1.76 -r1.77
--- Compiler.java 22 Jan 2004 19:35:07 - 1.76
+++ Compiler.java 23 Jan 2004 01:50:08 - 1.77
@@ -561,8 +561,10 @@
//System.out.println(Compiler: outdated, include old +
include );
outDated = true;
}
-// Remove any potential Wrappers for tag files
-ctxt.getRuntimeContext().removeWrapper(include);
+if (outDated) {
+// Remove any potential Wrappers for tag files
+ctxt.getRuntimeContext().removeWrapper(include);
+}
} catch (Exception e) {
e.printStackTrace();
outDated = true;
1.56 +15 -9
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
Index: TagFileProcessor.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -r1.55 -r1.56
--- TagFileProcessor.java 10 Dec 2003 00:24:23 - 1.55
+++ TagFileProcessor.java 23 Jan 2004 01:50:08 - 1.56
@@ -81,6 +81,7 @@
import org.apache.jasper.JasperException;
import org.apache.jasper.JspCompilationContext;
import org.apache.jasper.servlet.JspServletWrapper;
+import org.apache.jasper.runtime.JspSourceDependent;
/**
* 1. Processes and extracts the directive info in a tag file.
@@ -556,14 +557,19 @@
}
// Add the dependants for this tag file to its parent's
-// dependant list.
-PageInfo pageInfo = wrapper.getJspEngineContext().getCompiler().
-getPageInfo();
-if (pageInfo != null) {
-Iterator iter = pageInfo.getDependants().iterator();
-if (iter.hasNext()) {
-parentPageInfo.addDependant((String)iter.next());
+// dependant list. The only reliable dependency information
+// can only be obtained from the tag instance.
+try {
+Object tagIns = tagClazz.newInstance();
+if (tagIns instanceof JspSourceDependent) {
+Iterator iter =
+((JspSourceDependent)tagIns).getDependants().iterator();
+while (iter.hasNext()) {
+parentPageInfo.addDependant((String)iter.next());
+}
}
+} catch (Exception e) {
+// ignore errors
}
return tagClazz;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26335] - Modification check for tagfiles does not work recursively
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26335 Modification check for tagfiles does not work recursively [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-01-23 01:51 --- Fixed. Thanks for providing good test case. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 13212] - JSPC is unable to compile when JSP1.1 taglib jar contains tld file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13212. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13212 JSPC is unable to compile when JSP1.1 taglib jar contains tld file --- Additional Comments From [EMAIL PROTECTED] 2004-01-23 02:08 --- this is a very old bug back when tomcat 4.0.6 was released. I believe it was fixed a while back already, but wasn't updated as resolved. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
configuring tomcat for encoding types.
Hi , is there neway i can avoid writing these two statements in all my jsp's. response.setContentType(text/html;charset=UTF-8); request.setCharacterEncoding(UTF-8); I want that somehow i can configure these two setting for the server so that i dont have to modify all my jsp's. i m using version 4.1 Regards, Deepak Sharma --- NOTICE This email and any files transmitted with it are confidential and are solely for the use of the individual or entity to which it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you receive this transmission in error, please notify the sender by reply email and then destroy the message. Opinions, conclusions and other information in this message that do not relate to official business of NIIT shall be understood to be neither given nor endorsed by NIIT. Any information contained in this email, when addressed to NIIT Clients is subject to the terms and conditions in governing client contract. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26370] New: - channel.apr not recognised in workers2.properties
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26370. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26370 channel.apr not recognised in workers2.properties Summary: channel.apr not recognised in workers2.properties Product: Tomcat 4 Version: 4.1.29 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Connector:Coyote JK 2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] With the current conversion of mod_jk2 to use apr where possible, it appears that channel.apr is missing from jk_registry_init() in jk_registry.c. Is is possible to have this added at this time(?) or otherwise enable apr socket support? Thanks. Norm - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[ANN] Apache Tomcat 5.0.18 Stable released
The Tomcat Team announces the immediate availability of Apache Tomcat 5.0.18 Stable. Please refer to the changelog for the list of changes. Downloads: Binaries: http://jakarta.apache.org/site/binindex.cgi Sources: http://jakarta.apache.org/site/sourceindex.cgi The Apache Tomcat Team - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
