Re: Help getting Apache's Scarab up again
I see Scarab is running again. I am what passes for the support of Scarab, but since that is my only infrastructure activity and it hasn't required much effort, I don't watch the infrastructure list on a daily basis. Sorry if I missed an earlier message. My involvement in Scarab stopped as a consequence of employment and my activity on Torque is very low as well, so if there are other volunteers to take on the maintenance that would be great. If the Torque community would like Scarab updated, I think I could help with that as well, though it has been a long time since I worked with it and I think the setup has evolved quite a bit. Anyway just ask, and if I don't respond quickly enough, feel free to contact me directly ([EMAIL PROTECTED]). John McNally Jorge Uriarte wrote: Hi there, following suggestion from Henning Schemiedehause... I'd like to encourage the people that spoke up in this thread (Thomas, Jorge) to get in contact with the ASF infrastructure team ([EMAIL PROTECTED]) and sort out the Scarab issues and maybe volunteer as Scarab maintainers. ...I'd like to offer my help in what you might need to get your Scarab instance up again. Even though I'm implied in Scarab myself, this help is not bound to anything; If you want help to get it running so you can extract the issues, that's fine. If you want help migrating to an uptodate (and much better ;-) ) version of Scarab, that's even better! If I (or other Scarab committers) can help maintaining Scarab it would be great, because you bet, loosing Apache visibility is a great loose for our project, but I fear I'm not a committer in any Apache prokect, and there might be political/community reasons to disallow this. In this case, I will still be glad to help others to do it. Whatever decision you find better, let me know and we'll look for the best way to start. Greetings, _ Jorge - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[SOURCE] Issue #TRQS271 modified
You can view the issue detail at the following URL: http://issues.apache.org/scarab/issues/id/TRQS271 Type Defect Issue ID TRQS271 (Another test issue) Modified by John McNally jmcnally ([EMAIL PROTECTED]) The following modifications were made to this issue: - Resolution set to Fixed Status changed from New to Closed Reason: Yay, it worked! Now I just need to clean up the duplicate IDs. - This message is automatically generated by the Scarab issue tracking system. For more information: http://scarab.tigris.org/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Contributions to Torque source code
You can enter an issue at http://nagoya.apache.org/scarab/issues/ and attach files to it. Patches to existing classes should be in the form of diff -u. An alternative is to attach the changes to an email to this list. Substantial contributions, meaning more than a simple bug fix, should be accompanied by a CLA. http://www.apache.org/licenses/#clas John McNally [EMAIL PROTECTED] wrote: Hello all, How does one contribute to the torque source code? We have a couple of improvements that we think could benefit the whole community and would like to submit them to be included in Torque. I've look the db.apache.org site and haven't found any guidelines on this process. Can anybody point me in the right direction? Thx!! MG - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [CfV] Thomas Fischer as a committer
Henning P. Schmiedehausen wrote: Hi, I'd like to propose Thomas Fischer [EMAIL PROTECTED] as a committer for the DB Torque project. Thomas has demonstrated that he understands the Torque code and wants to contribute to the project. [X] +1 Yes, Thomas should become a committer John McNally - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] CfV: Torque 3.1.1 release
Henning P. Schmiedehausen wrote: This is the Call for Votes [CfV] for the release of version 3.1.1 of DB Torque including the DB Torque Generator and the Maven plugin for Torque. [X] +1 Yes John McNally - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JndiDataSourceFactory
The reason it is not cached is that the DataSource/JNDI concept allows
an adminstration application to change the DataSource that is bound to a
name and an application using that name would automatically start using
a different pool of connections.
john mcnally
Scott Eade wrote:
Thomas Vandahl wrote:
I was trying to use JndiDataSourceFactory in my project to keep the
configuration together. I found, however, that the database handling is
much slower that with dbcp. In the code I saw that in all other
DataSource-Factories the ds-object is cached. Not so in
JndiDataSourceFactory. Does this serve a purpose?
Anything against this fix?
-8-
/** A locally cached copy of the DataSource */
private DataSource ds = null;
/**
* @see org.apache.torque.dsfactory.DataSourceFactory#getDataSource
*/
public DataSource getDataSource() throws TorqueException
{
if (ds == null)
{
try
{
ds = ((DataSource) ctx.lookup(path));
}
catch (Exception e)
{
throw new TorqueException(e);
}
}
return ds;
}
-8-
I could see no side effects during testing but nmuch improved
performance. Do I miss something?
Seems reasonable to me. I'll add it to the small list of items to be
addressed for 3.1.1-rc3.
Scott
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: How to view bugs via Scarab?
Request the developer role. I do not expect any changes to the installation until the next beta of scarab is released. I think registration will still be required. john mcnally On Fri, 2004-04-09 at 21:24, Michael Hart wrote: Hi Guys, I'm trying to submit an issue regarding Torque and I wanted to check if it existed first, however there seems to be no direct public access to the bugs list (http://nagoya.apache.org/scarab/issues, reached from http://db.apache.org/torque/issue-tracking.html) - I've hunted around the mail archives, but I can't really find a rationale for this - any ideas? Anyway, I proceeded to register for access to the Scarab list, but even then it seems I don't have access to any modules - I still can't even view issues, let alone submit one. So I follow the request roles link and I guess I need to request a role for the Torque Source module, but I have no idea what role to request for, nor how long it will take for such a request to be fulfilled. Should I be requesting for to be an Observer or a QA or something else? If I've missed something, or there's a FAQ that answers this, then I do apologise. If not, then perhaps an easier-to-use system could be put in place (ie, not having to register just to view bugs/issues, or not having to request a role), or if these steps are still desired, then better documentation for guiding the average public user through the whole process would be useful (eg an explanation of what the roles are on the Request Roles page, or even better a How do I view/submit an issue guide on the issue-tracking.html page). The only help that seems to have any relevance to my situation is on the page when I log in to Scarab: If you are a registered user, but do not have access to any modules, contact the administrator. - I can't find a link to contact the administrator, so I'm trying this list. Thanks, Michael P.S. I'll post the issue I was referring to in my next msg to this list - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] [PROPOSAL] Adding a torque-gui repository inside of the torque project
I think it is a requirement in general, with possible exceptions to be considered on a per case basis. The code in question is currently licensed under GPL, so that is one thing that needs to be fixed. Paperwork such as a license grant is part of the incubation process. Some things like mail lists and cvs repository are not needed and would be temporary, so the overhead might be annoying, but I don't think we can avoid it. john mcnally On Mon, 2004-01-26 at 09:53, Martin Poeschl wrote: John McNally wrote: +1 on adding a gui component to torque. Is the plan to use the incubator process? If not, we should discuss this more. john mcnally do we have to use the incubator process??? martin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[SOURCE] Issue #TRQS1 - BigDecimal is too expensive to use for NumberKey
You can view the issue detail at the following URL: http://scarab.werken.com:8080/scarab/issues/id/TRQS1 Type Enhancement Issue ID TRQS1 (BigDecimal is too expensive to use for NumberKey) Reported by John McNally jmcnally ([EMAIL PROTECTED]) New issue details: - Summary set to BigDecimal is too expensive to... Status set to New Priority set to Medium Description set to BigDecimal allows unlimited ta... Issue created - This message is automatically generated by the Scarab issue tracking system. For more information: http://scarab.tigris.org/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
scarab issue ids
Issues entered into torque module after the move from werken.com to nagoya were getting ids assigned starting at 1. This has been fixed and the new issues adjusted to 191-201. john mcnally - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Configuring pools - how?
From the howto: JndiDataSourceFactory This factory is used if the DataSource is to be available via jndi. It is possible to use this factory to deploy a DataSource into jndi, but in many cases for using this factory the DataSource is already deployed. This factory is specified with the following property: torque.dsfactory.bookstore.factory=org.apache.torque.dsfactory.JndiDataSourceFactory Using pre-configured pool If a pool is known to already be available via jndi, only one more property is required. torque.dsfactory.bookstore.jndi.path=jdbc/bookstore which covers your personal best way to configure. It is definitely a valid option. Others are equally valid though and I think many users who only need the pool to be used by torque, just use torque's built in configuration such as that shown in the SharedPoolDataSource section. So the order of the options implies some preference, but I don't think there is any reason to specify that one is preferred over the other. john mcnally On Tue, 2003-10-28 at 01:36, Graham Leggett wrote: Hi all, Having read the pools howto in the docs from an end user point of view, I can say they do not answer the question how to. Specifically, it highlights a number of ways in which pools can be configured, but neglects to mention clearly the recommended way to configure pools. In addition, it seems that config from both the bookshop example, and config from Scarab have been mixed together in the section marked Tomcat example of external configuration/binding, which has confused me. It would seem to me that the best way to configure the pool, is to let the container create the pool and make it available. The howto neglects to mention though how the Torque singleton should be initialised in this case: Torque.init(what?). Is it possible to make the docs clearer? Regards, Graham -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [repost] Re: Configuring SharedPoolDataSourceFactory
So it is not possible to build multiple beans with a common set of properties, by extending a common (non-public) parent? That is not very convenient. Is there some descriptor file that can be put into the package to let the introspector know it is to check all classes in the hierarchy for public properties? john mcnally On Thu, 2003-09-11 at 01:53, Thomas Widmer wrote: I have the same logentries. I guess, the problem is because: torque.dsfactory.bookstore.pool.defaultMaxActive=30 The property defaultMaxActive is now called maxActive in the class SharedPoolDataSource. If you change the name it works. torque.dsfactory.bookstore.pool.testOnBorrow=true torque.dsfactory.bookstore.pool.validationQuery=SELECT 1 This properties are defined in the class InstanceKeyDataSource. The call to set the property is PropertyUtils.setSimpleProperty(ds, property, value); in AbstractDataSourceFactory. The PropertyUtils checks, if a class is public. When the class is not public the property is not set and an exception is thrown. Because the class InstanceKeyDataSource is not public the property is not set. Tom - Original Message - Subject: Re: [repost] Re: Configuring SharedPoolDataSourceFactory Scott Eade wrote: In the SharedPoolDataSourceFactory section of http://db.apache.org/torque/configuration-howto.html the configuration of the pool is shown thus: torque.dsfactory.bookstore.pool.defaultMaxActive=30 torque.dsfactory.bookstore.pool.testOnBorrow=true torque.dsfactory.bookstore.pool.validationQuery=SELECT 1 For me this results in the following appearing in my log file: ...ERROR...dsfactory.AbstractDataSourceFactory - Property: defaultMaxActive value: 3 is not supported by DataSource: org.apache.commons.dbcp.datasources.SharedPoolDataSource ...ERROR...dsfactory.AbstractDataSourceFactory - Property: testOnBorrow value: true is not supported by DataSource: org.apache.commons.dbcp.datasources.SharedPoolDataSource ...ERROR...dsfactory.AbstractDataSourceFactory - Property: validationQuery value: SELECT 1 is not supported by DataSource: org.apache.commons.dbcp.datasources.SharedPoolDataSource Is this something I am doing wrong or is there a problem somewhere in org.apache.torque.dsfactory.SharedPoolDataSourceFactory? Thanks, Scott -- Scott Eade Backstage Technologies Pty. Ltd. http://www.backstagetech.com.au - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Modify Transaction.rollback to ignore a null connection [was Re:cvs commit: db-torque/src/java/org/apache/torque/util BasePeer.java]
Sorry, you are going to need to point me to the documentation that shows
why null checks are a bad idea or a hack. Without them the code was
hiding root cause of many errors.
You think modifying Transaction.rollback to ignore a null connection is
a good one. I don't see how that could be a good thing, at least now an
exception is thrown which will hopefully be at a minimum logged.
Creating a contract that says rollback(Connection con) will do nothing
and return if con == null, is okay. but then the calling code is either
going to have to be very sure that con is not null or that the
application does not care if what it was trying to accomplish with
rollback actually happens.
john mcnally
On Sat, 2003-07-19 at 16:58, Henning P. Schmiedehausen wrote:
[EMAIL PROTECTED] writes:
jmcnally2003/07/19 11:49:40
This is a gross hack.
Make Transaction.rollback(Connection con) accept null as connection
and just return.
Not start hacking in lots of tests where you're bound to miss one or
two and then developers looking at the Torque code start to scratch
their head and ask themselves why did he do this on five occasions
and missed two others?
I'm strictly -1 on this change because I've removed lots of such bogus
code from Turbine.
Regards
Henning
Modified:src/java/org/apache/torque/util BasePeer.java
Log:
replaced
catch (TorqueException e)
{
Transaction.rollback(con);
throw e;
}
with
catch (TorqueException e)
{
if (con != null) Transaction.rollback(con);
throw e;
}
so that an exception which prevents getting a connection does not get
obscured by the attempt to use the connection in rollback.
Revision ChangesPath
1.72 +26 -12db-torque/src/java/org/apache/torque/util/BasePeer.java
Index: BasePeer.java
===
RCS file: /home/cvs/db-torque/src/java/org/apache/torque/util/BasePeer.java,v
retrieving revision 1.71
retrieving revision 1.72
diff -u -r1.71 -r1.72
--- BasePeer.java 25 Jun 2003 19:31:16 - 1.71
+++ BasePeer.java 19 Jul 2003 18:49:40 - 1.72
@@ -435,7 +435,10 @@
}
catch (TorqueException e)
{
-Transaction.rollback(con);
+if (con != null)
+{
+Transaction.rollback(con);
+}
throw new TorqueException(e);
}
}
@@ -625,7 +628,10 @@
}
catch (TorqueException e)
{
-Transaction.rollback(con);
+if (con != null)
+{
+Transaction.rollback(con);
+}
throw e;
}
@@ -1352,7 +1358,10 @@
}
catch (Exception e)
{
-Transaction.rollback(con);
+if (con != null)
+{
+Transaction.rollback(con);
+}
throw new TorqueException(e);
}
return results;
@@ -1743,7 +1752,10 @@
}
catch (TorqueException e)
{
-Transaction.rollback(con);
+if (con != null)
+{
+Transaction.rollback(con);
+}
throw e;
}
}
@@ -1806,18 +1818,20 @@
public static void doUpdate(Criteria selectCriteria, Criteria updateValues)
throws TorqueException
{
-Connection db = null;
+Connection con = null;
try
{
-db = Transaction.beginOptional(
-selectCriteria.getDbName(),
-updateValues.isUseTransaction());
-doUpdate(selectCriteria, updateValues, db);
-Transaction.commit(db);
+con = Transaction.beginOptional(selectCriteria.getDbName(),
+updateValues.isUseTransaction());
+doUpdate(selectCriteria, updateValues, con);
+Transaction.commit(con);
}
catch (TorqueException e)
{
-Transaction.rollback(db);
+if (con != null)
+{
+Transaction.rollback(con);
+}
throw e;
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine
upgraded scarab.werken.com
I have upgraded the version of scarab running on werken.com. Please send email directly to me reporting any problems. john mcnally ([EMAIL PROTECTED]) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
