Re: [Toybox] [BUG] ls applet ignores options if CONFIG_LS_COLOR is not set

[darken]

Works for me. Thanks for the fix!

2016-12-08 6:09 GMT+01:00 Rob Landley :

> On 12/07/2016 10:52 PM, Rob Landley wrote:
> > On 12/04/2016 10:29 PM, Rob Landley wrote:
> >> On 12/04/2016 08:36 PM, darken wrote:
> >>> If `CONFIG_LS_COLOR` is not set the `ls` applet doesn't take options
> and
> >>> either ignores them or says `ls: Unknown option...`.
> >>>
> >>> Some testoutput:
> >>> https://github.com/landley/toybox/issues/57
> >>>
> >>> Seems to be caused by commit:
> >>> https://github.com/landley/toybox/commit/
> 48c75324f758e77ca3ba64072a48a7407e765570
> >>> Reverting it fixes this.
> >>
> >> Huh.
> >>
> >> In generated.flags.h:
> >> #define OPTSTR_ls
> >> "(^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^
> A^As^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^
> A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A"
> >>
> >> Yeah, that's not right. Digging into it.
> >>
> >> Thanks for the heads up,
> >>
> >> Rob
> >>
> >
> > Sigh, nevermind. Regression test failed in the clean tree. (_After_I
> > checked it in, of course.) Fixing...
> >
> > Rob
>
> Ahem. Ok, try _now_.
>
> Rob
>
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [BUG] ls applet ignores options if CONFIG_LS_COLOR is not set

[Rob Landley]

On 12/07/2016 10:52 PM, Rob Landley wrote:
> On 12/04/2016 10:29 PM, Rob Landley wrote:
>> On 12/04/2016 08:36 PM, darken wrote:
>>> If `CONFIG_LS_COLOR` is not set the `ls` applet doesn't take options and
>>> either ignores them or says `ls: Unknown option...`.
>>>
>>> Some testoutput:
>>> https://github.com/landley/toybox/issues/57
>>>
>>> Seems to be caused by commit:
>>> https://github.com/landley/toybox/commit/48c75324f758e77ca3ba64072a48a7407e765570
>>> Reverting it fixes this.
>>
>> Huh.
>>
>> In generated.flags.h:
>> #define OPTSTR_ls
>> "(^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^As^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A"
>>
>> Yeah, that's not right. Digging into it.
>>
>> Thanks for the heads up,
>>
>> Rob
>>
> 
> Sigh, nevermind. Regression test failed in the clean tree. (_After_I
> checked it in, of course.) Fixing...
> 
> Rob

Ahem. Ok, try _now_.

Rob
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [BUG] ls applet ignores options if CONFIG_LS_COLOR is not set

[Rob Landley]

On 12/04/2016 10:29 PM, Rob Landley wrote:
> On 12/04/2016 08:36 PM, darken wrote:
>> If `CONFIG_LS_COLOR` is not set the `ls` applet doesn't take options and
>> either ignores them or says `ls: Unknown option...`.
>>
>> Some testoutput:
>> https://github.com/landley/toybox/issues/57
>>
>> Seems to be caused by commit:
>> https://github.com/landley/toybox/commit/48c75324f758e77ca3ba64072a48a7407e765570
>> Reverting it fixes this.
> 
> Huh.
> 
> In generated.flags.h:
> #define OPTSTR_ls
> "(^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^As^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A"
> 
> Yeah, that's not right. Digging into it.
> 
> Thanks for the heads up,
> 
> Rob
> 

Sigh, nevermind. Regression test failed in the clean tree. (_After_I
checked it in, of course.) Fixing...

Rob
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [BUG] ls applet ignores options if CONFIG_LS_COLOR is not set

[Rob Landley]

On 12/04/2016 10:29 PM, Rob Landley wrote:
> On 12/04/2016 08:36 PM, darken wrote:
>> If `CONFIG_LS_COLOR` is not set the `ls` applet doesn't take options and
>> either ignores them or says `ls: Unknown option...`.
>>
>> Some testoutput:
>> https://github.com/landley/toybox/issues/57
>>
>> Seems to be caused by commit:
>> https://github.com/landley/toybox/commit/48c75324f758e77ca3ba64072a48a7407e765570
>> Reverting it fixes this.
> 
> Huh.
> 
> In generated.flags.h:
> #define OPTSTR_ls
> "(^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^As^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A"
> 
> Yeah, that's not right. Digging into it.
> 
> Thanks for the heads up,

Try now?

Rob
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [BUG] ls applet ignores options if CONFIG_LS_COLOR is not set

[Rob Landley]

On 12/04/2016 08:36 PM, darken wrote:
> If `CONFIG_LS_COLOR` is not set the `ls` applet doesn't take options and
> either ignores them or says `ls: Unknown option...`.
> 
> Some testoutput:
> https://github.com/landley/toybox/issues/57
> 
> Seems to be caused by commit:
> https://github.com/landley/toybox/commit/48c75324f758e77ca3ba64072a48a7407e765570
> Reverting it fixes this.

Huh.

In generated.flags.h:
#define OPTSTR_ls
"(^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^As^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A"

Yeah, that's not right. Digging into it.

Thanks for the heads up,

Rob
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net