PMD problem?, was: core2 checkin reminder
On 6/30/06, Jim Marino [EMAIL PROTECTED] wrote:
Just a reminder (since it was buried in a previous email
thread)...When doing checkins on the sandbox core2 implementation,
please run:
$ mvn -Psourcecheck
This will execute PMD and Checkstyle as part of the build.
I ran into the same thing last night but was too tired to post to the thread.
I think the code that is causing PMD to barf is:
protected static File findLoadLocation() {
String location ...
File locfile = new File(location);
return locfile.getParentFile();
}
which I don't have an issue with and which I think PMD is incorrectly
complaining about given the rule in question.
Is this a bug in PMD? If so, should we comment out the rule or change our code?
I have to admit I'm not very keen on changing code to work around
defects in a code checking tool.
--
Jeremy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: PMD problem?, was: core2 checkin reminder
I'd say change PMD.
On Jul 1, 2006, at 1:04 AM, Jeremy Boynes wrote:
On 6/30/06, Jim Marino [EMAIL PROTECTED] wrote:
Just a reminder (since it was buried in a previous email
thread)...When doing checkins on the sandbox core2 implementation,
please run:
$ mvn -Psourcecheck
This will execute PMD and Checkstyle as part of the build.
I ran into the same thing last night but was too tired to post to
the thread.
I think the code that is causing PMD to barf is:
protected static File findLoadLocation() {
String location ...
File locfile = new File(location);
return locfile.getParentFile();
}
which I don't have an issue with and which I think PMD is incorrectly
complaining about given the rule in question.
Is this a bug in PMD? If so, should we comment out the rule or
change our code?
I have to admit I'm not very keen on changing code to work around
defects in a code checking tool.
--
Jeremy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: PMD problem?, was: core2 checkin reminder
On 7/1/06, Jim Marino [EMAIL PROTECTED] wrote: I'd say change PMD. Do you mean comment out the rule or fix the bug? The latter is a better solution but I'm hoping you mean the first :-) -- Jeremy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: PMD problem?, was: core2 checkin reminder
Yea sorry, comment out the rule. Jim On Jul 1, 2006, at 1:17 AM, Jeremy Boynes wrote: On 7/1/06, Jim Marino [EMAIL PROTECTED] wrote: I'd say change PMD. Do you mean comment out the rule or fix the bug? The latter is a better solution but I'm hoping you mean the first :-) -- Jeremy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
