Re: [U-Boot] [PATCH] AT91: factor out ROUND() macro

[Jean-Christophe PLAGNIOL-VILLARD]

On 23:35 Fri 17 Jul , Wolfgang Denk wrote:
 A large number of boards (all AT91 based) duplicated the ROUND()
 macro in their board specific config files. Add the definition to
 include/common.h and clean up the board config files.
 
 Signed-off-by: Wolfgang Denk w...@denx.de
build failled
as we do not include common.h but config.h it in the
cpu/arm926ejs/start.S

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] AT91: factor out ROUND() macro

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 2009070950.gc26...@game.jcrosoft.org you wrote:
 On 23:35 Fri 17 Jul , Wolfgang Denk wrote:
  A large number of boards (all AT91 based) duplicated the ROUND()
  macro in their board specific config files. Add the definition to
  include/common.h and clean up the board config files.
  
  Signed-off-by: Wolfgang Denk w...@denx.de
 build failled
 as we do not include common.h but config.h it in the
 cpu/arm926ejs/start.S

Yeah, this escaped my testing. But it's already in mainline, so we
need a fix for it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
All these theories, diverse as they are, have two things  in  common:
they explain the observed facts, and they are completeley and utterly
wrong.   - Terry Pratchett, _The Light Fantastic_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] AT91: factor out ROUND() macro

[Wolfgang Denk]

A large number of boards (all AT91 based) duplicated the ROUND()
macro in their board specific config files. Add the definition to
include/common.h and clean up the board config files.

Signed-off-by: Wolfgang Denk w...@denx.de
---
 include/common.h   |1 +
 include/configs/afeb9260.h |1 -
 include/configs/at91cap9adk.h  |1 -
 include/configs/at91rm9200ek.h |1 -
 include/configs/at91sam9260ek.h|1 -
 include/configs/at91sam9261ek.h|1 -
 include/configs/at91sam9263ek.h|1 -
 include/configs/at91sam9m10g45ek.h |1 -
 include/configs/at91sam9rlek.h |1 -
 include/configs/pm9261.h   |1 -
 include/configs/pm9263.h   |1 -
 11 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/include/common.h b/include/common.h
index a6c7c07..6e689b2 100644
--- a/include/common.h
+++ b/include/common.h
@@ -697,6 +697,7 @@ void show_boot_progress(int val);
 
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
 
+#define ROUND(a,b) (((a) + (b))  ~((b) - 1))
 #define DIV_ROUND(n,d) (((n) + ((d)/2)) / (d))
 #define DIV_ROUND_UP(n,d)  (((n) + (d) - 1) / (d))
 #define roundup(x, y)  x) + ((y) - 1)) / (y)) * (y))
diff --git a/include/configs/afeb9260.h b/include/configs/afeb9260.h
index c5134a2..22099c8 100644
--- a/include/configs/afeb9260.h
+++ b/include/configs/afeb9260.h
@@ -159,7 +159,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91cap9adk.h b/include/configs/at91cap9adk.h
index 526cd60..f977527 100644
--- a/include/configs/at91cap9adk.h
+++ b/include/configs/at91cap9adk.h
@@ -201,7 +201,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91rm9200ek.h b/include/configs/at91rm9200ek.h
index c898c73..58ec94a 100644
--- a/include/configs/at91rm9200ek.h
+++ b/include/configs/at91rm9200ek.h
@@ -311,7 +311,6 @@ struct bd_info_ext {
  */
 #define CONFIG_SYS_HZ_CLOCK (AT91C_MASTER_CLOCK / 2)
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
index 1828c63..dd886d8 100644
--- a/include/configs/at91sam9260ek.h
+++ b/include/configs/at91sam9260ek.h
@@ -205,7 +205,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91sam9261ek.h b/include/configs/at91sam9261ek.h
index 6d24023..cb0384a 100644
--- a/include/configs/at91sam9261ek.h
+++ b/include/configs/at91sam9261ek.h
@@ -223,7 +223,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91sam9263ek.h b/include/configs/at91sam9263ek.h
index 00f3114..2bd2915 100644
--- a/include/configs/at91sam9263ek.h
+++ b/include/configs/at91sam9263ek.h
@@ -333,7 +333,6 @@
 #define CONFIG_SYS_HUSH_PARSER
 #define CONFIG_SYS_PROMPT_HUSH_PS2  
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91sam9m10g45ek.h 
b/include/configs/at91sam9m10g45ek.h
index 572c45b..8f86839 100644
--- a/include/configs/at91sam9m10g45ek.h
+++ b/include/configs/at91sam9m10g45ek.h
@@ -209,7 +209,6 @@
 #define CONFIG_SYS_HUSH_PARSER
 #define CONFIG_SYS_PROMPT_HUSH_PS2  
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/at91sam9rlek.h b/include/configs/at91sam9rlek.h
index c466823..64a9951 100644
--- a/include/configs/at91sam9rlek.h
+++ b/include/configs/at91sam9rlek.h
@@ -168,7 +168,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/pm9261.h b/include/configs/pm9261.h
index 4784c40..3307a94 100644
--- a/include/configs/pm9261.h
+++ b/include/configs/pm9261.h
@@ -366,7 +366,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
diff --git a/include/configs/pm9263.h b/include/configs/pm9263.h
index 94e1eb9..a197061 100644
--- a/include/configs/pm9263.h
+++ b/include/configs/pm9263.h
@@ -395,7 +395,6 @@
 #define CONFIG_SYS_LONGHELP1
 #define CONFIG_CMDLINE_EDITING 1
 
-#define ROUND(A, B)(((A) + (B))  ~((B) - 1))
 /*
  * Size of malloc() pool
  */
-- 
1.6.0.6