Re: [PATCH 08/31] rockchip: rk3399: Remove use of xPL_MISC_DRIVERS options

2024-04-23 Thread Kever Yang



On 2024/4/1 04:28, Jonas Karlman wrote:

The TPL and/or SPL control FDT on RK3399 boards does not contain any
node with a compatible that is supported by driver/misc/ drivers.

Remove use of xPL_MISC_DRIVERS options to stop including e.g an unused
efuse driver in TPL and/or SPL.

Signed-off-by: Jonas Karlman 

Reviewed-by: Kever Yang 

Thanks,
- Kever

---
  arch/arm/mach-rockchip/Kconfig | 2 --
  1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 8dca9d2853b4..bc03d69a7f5c 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -250,7 +250,6 @@ config ROCKCHIP_RK3399
select TPL_NEEDS_SEPARATE_STACK if TPL
select SPL_SEPARATE_BSS
select SPL_SERIAL
-   select SPL_DRIVERS_MISC
select CLK
select FIT
select PINCTRL
@@ -282,7 +281,6 @@ config ROCKCHIP_RK3399
imply SYS_BOOTCOUNT_SINGLEWORD if BOOTCOUNT_LIMIT
imply TPL_CLK
imply TPL_DM
-   imply TPL_DRIVERS_MISC
imply TPL_LIBCOMMON_SUPPORT
imply TPL_LIBGENERIC_SUPPORT
imply TPL_OF_CONTROL


Re: [PATCH 08/31] rockchip: rk3399: Remove use of xPL_MISC_DRIVERS options

2024-04-02 Thread Quentin Schulz

Hi Jonas,

On 3/31/24 22:28, Jonas Karlman wrote:

The TPL and/or SPL control FDT on RK3399 boards does not contain any
node with a compatible that is supported by driver/misc/ drivers.

Remove use of xPL_MISC_DRIVERS options to stop including e.g an unused
efuse driver in TPL and/or SPL.



This also makes each board maintainer responsible for enabling CrOS EC 
(Embedded Controller on Chromebooks) and/or IO domain if they need it in 
TPL/SPL. But considering Gru Bob and Kevin don't seem to be enabling EC 
support in TPL/SPL and that IO domain isn't enabled for any board in 
TPL/SPL,


Reviewed-by: Quentin Schulz 

Thanks,
Quentin