Re: [U-Boot] [PATCH 02/11] arm: unified u-boot.lds
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1235542278-21451-2-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- .gitignore |1 + Makefile |1 - arm_config.mk|1 + board/actux1/config.mk |1 + board/actux2/config.mk |1 + board/actux3/config.mk |1 + ... diff --git a/arm_config.mk b/arm_config.mk index 73d9625..d821c36 100644 --- a/arm_config.mk +++ b/arm_config.mk @@ -22,3 +22,4 @@ # PLATFORM_CPPFLAGS += -DCONFIG_ARM -D__ARM__ +LDSCRIPT := $(OBJTREE)/lib_$(ARCH)/u-boot.lds ---^^ diff --git a/board/actux1/config.mk b/board/actux1/config.mk index 9a634cd..cddd01e 100644 --- a/board/actux1/config.mk +++ b/board/actux1/config.mk @@ -2,3 +2,4 @@ TEXT_BASE = 0x00e0 # include NPE ethernet driver BOARDLIBS = cpu/ixp/npe/libnpe.a +LDSCRIPT = $(SRCTREE)/board/$(BOARDDIR)/u-boot.lds --^^ etc. Is it $(OBJTREE)/lib_$(ARCH) or $(SRCTREE)/board/$(BOARDDIR) ? Should we not put a generic definition in the top level Makefile that then can be oiverridden (where needed) in the config files? ... - * (C) Copyright 2000 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * Copyright (C) 2005-2007 Samsung Electronics - * Kyungin Park kyugnmin.p...@samsung.com - * - * January 2004 - Changed to support H4 device - * Copyright (c) 2004 Texas Instruments - * - * (C) Copyright 2002 - * Gary Jennejohn, DENX Software Engineering, g...@denx.de ... - * (C) Copyright 2000-2004 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. - * 2004 (c) MontaVista Software, Inc. ... - * (C) Copyright 2000-2004 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * (C) Copyright 2000 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. - * 2003 (c) MontaVista Software, Inc. ... - * January 2004 - Changed to support H4 device - * Copyright (c) 2004 Texas Instruments ... - * January 2004 - Changed to support H4 device - * Copyright (c) 2004 Texas Instruments - * - * (C) Copyright 2002 - * Gary Jennejohn, DENX Software Engineering, g...@denx.de ... - * (c) Copyright 2004 - * Techware Information Technology, Inc. - * http://www.techware.com.tw/ ... - * (C) Copyright 2002-2004 - * Gary Jennejohn, DENX Software Engineering, g...@denx.de ... - * (C) Copyright 2006 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * (C) Copyright 2000-2005 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * (C) Copyright 2004 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de I'm not sure if you can simply drop all these Copyright notices (even if the code was oviously all just copied from the same base file. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Remember that Beethoven wrote his first symphony in C ... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/11] arm: unified u-boot.lds
On 09:41 Wed 25 Feb , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1235542278-21451-2-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- .gitignore |1 + Makefile |1 - arm_config.mk|1 + board/actux1/config.mk |1 + board/actux2/config.mk |1 + board/actux3/config.mk |1 + ... diff --git a/arm_config.mk b/arm_config.mk index 73d9625..d821c36 100644 --- a/arm_config.mk +++ b/arm_config.mk @@ -22,3 +22,4 @@ # PLATFORM_CPPFLAGS += -DCONFIG_ARM -D__ARM__ +LDSCRIPT := $(OBJTREE)/lib_$(ARCH)/u-boot.lds ---^^ diff --git a/board/actux1/config.mk b/board/actux1/config.mk index 9a634cd..cddd01e 100644 --- a/board/actux1/config.mk +++ b/board/actux1/config.mk @@ -2,3 +2,4 @@ TEXT_BASE = 0x00e0 # include NPE ethernet driver BOARDLIBS = cpu/ixp/npe/libnpe.a +LDSCRIPT = $(SRCTREE)/board/$(BOARDDIR)/u-boot.lds --^^ etc. Is it $(OBJTREE)/lib_$(ARCH) or $(SRCTREE)/board/$(BOARDDIR) ? Should we not put a generic definition in the top level Makefile that then can be oiverridden (where needed) in the config files? it's the case it's call in this sequence the arch is call first the cpu the soc and the board last so you can overwrite the LDSCRPIT when you want By default it's the ARCH lds that will be use but due to some board (we need to investigate why) we overwrite and a board specific lds which I try to avoid when it's possible ... - * (C) Copyright 2000 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * Copyright (C) 2005-2007 Samsung Electronics - * Kyungin Park kyugnmin.p...@samsung.com - * - * January 2004 - Changed to support H4 device - * Copyright (c) 2004 Texas Instruments - * - * (C) Copyright 2002 - * Gary Jennejohn, DENX Software Engineering, g...@denx.de ... - * (C) Copyright 2000-2004 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. - * 2004 (c) MontaVista Software, Inc. ... - * (C) Copyright 2000-2004 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * (C) Copyright 2000 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. - * 2003 (c) MontaVista Software, Inc. ... - * January 2004 - Changed to support H4 device - * Copyright (c) 2004 Texas Instruments ... - * January 2004 - Changed to support H4 device - * Copyright (c) 2004 Texas Instruments - * - * (C) Copyright 2002 - * Gary Jennejohn, DENX Software Engineering, g...@denx.de ... - * (c) Copyright 2004 - * Techware Information Technology, Inc. - * http://www.techware.com.tw/ ... - * (C) Copyright 2002-2004 - * Gary Jennejohn, DENX Software Engineering, g...@denx.de ... - * (C) Copyright 2006 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * (C) Copyright 2000-2005 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de. ... - * (C) Copyright 2004 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de I'm not sure if you can simply drop all these Copyright notices (even if the code was oviously all just copied from the same base file. Not sure too but it's the same file, actually I've use one as reference and remove the all other. Maybe we need to report all the copyright to the generic one Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
