Re: [U-Boot] [PATCH 1/2] zlib/gunzip: Use WATCHDOG_RESET macro

2010-10-12 Thread Wolfgang Denk
Dear Stefan Roese,

In message 1283952898-4247-1-git-send-email...@denx.de you wrote:
 As usually done in U-Boot, the watchdog_reset code is called via a
 macro (WATCHDOG_RESET). In zlib.c this was done differently, by using
 a function pointer which is initialized with WATCHDOG_RESET upon watchdog
 usage or with NULL otherwise. This patch now uses the plain
 WATCHDOG_RESET macros to call the function resulting in slightly smaller
 U-Boot images and simpler code.
 
 U-Boot code size reduction:
 
 PowerPC board with watchdog support (lwmon5):
 - 80 bytes smaller image size
 
 PowerPC board without watchdog support (sequoia):
 - 112 bytes smaller image size
 
 Signed-off-by: Stefan Roese s...@denx.de
 Cc: Detlev Zundel d...@denx.de
 Cc: Wolfgang Denk w...@denx.de
 ---
  lib/gunzip.c |5 -
  lib/zlib.c   |   10 --
  2 files changed, 4 insertions(+), 11 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You could end up being oddly sad and full of a strange, diffuse  com-
passion  which would lead you to believe that it might be a good idea
to wipe out the whole human race and start again with amoebas.
 - Terry Pratchett, _Guards! Guards!_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/2] zlib/gunzip: Use WATCHDOG_RESET macro

2010-09-13 Thread Detlev Zundel
Hi Stefan,

 As usually done in U-Boot, the watchdog_reset code is called via a
 macro (WATCHDOG_RESET). In zlib.c this was done differently, by using
 a function pointer which is initialized with WATCHDOG_RESET upon watchdog
 usage or with NULL otherwise. This patch now uses the plain
 WATCHDOG_RESET macros to call the function resulting in slightly smaller
 U-Boot images and simpler code.

 U-Boot code size reduction:

 PowerPC board with watchdog support (lwmon5):
 - 80 bytes smaller image size

 PowerPC board without watchdog support (sequoia):
 - 112 bytes smaller image size

 Signed-off-by: Stefan Roese s...@denx.de
 Cc: Detlev Zundel d...@denx.de
 Cc: Wolfgang Denk w...@denx.de

Thanks, now even I can understand the code ;)

Acked-by: Detlev Zundel d...@denx.de

Cheers
  Detlev

-- 
A zen-buddhist walked into a pizza shop and
said, Make me one with everything.
--
DENX Software Engineering GmbH,  MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot