Re: [U-Boot] [PATCH 15/16] New command bootmenu: ANSI terminal Boot Menu support
On Sunday 18 December 2011 15:16:21 Pali Rohár wrote: On Sunday 18 December 2011 15:07:25 Mike Frysinger wrote: On Sunday 18 December 2011 14:12:38 Pali Rohár wrote: On Sunday 18 December 2011 14:07:37 Mike Frysinger wrote: this needs checkpatch for sure seems like this doesn't use the existing common/menu.c code ... shouldn't it ? No my ANSI terminal bootmenu does not use common/menu.c (4 months ago, there was no menu.c file) so you'll be updating the patchseries to utilize common code that now exists ? What is implemented in that file common/menu.c? It here any info/doc? doc/README.menu if there are features you have/want that this code base doesn't support, the answer would be to enhance/extend rather than drop in an entirely new/parallel codebase. i know this is more work for you, but long term, the latter would be much more work for everyone. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/16] New command bootmenu: ANSI terminal Boot Menu support
this needs checkpatch for sure seems like this doesn't use the existing common/menu.c code ... shouldn't it ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/16] New command bootmenu: ANSI terminal Boot Menu support
On Sunday 18 December 2011 14:07:37 Mike Frysinger wrote: this needs checkpatch for sure seems like this doesn't use the existing common/menu.c code ... shouldn't it ? -mike No my ANSI terminal bootmenu does not use common/menu.c (4 months ago, there was no menu.c file) -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/16] New command bootmenu: ANSI terminal Boot Menu support
On Sunday 18 December 2011 14:12:38 Pali Rohár wrote: On Sunday 18 December 2011 14:07:37 Mike Frysinger wrote: this needs checkpatch for sure seems like this doesn't use the existing common/menu.c code ... shouldn't it ? No my ANSI terminal bootmenu does not use common/menu.c (4 months ago, there was no menu.c file) so you'll be updating the patchseries to utilize common code that now exists ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/16] New command bootmenu: ANSI terminal Boot Menu support
On Sunday 18 December 2011 15:07:25 Mike Frysinger wrote: On Sunday 18 December 2011 14:12:38 Pali Rohár wrote: On Sunday 18 December 2011 14:07:37 Mike Frysinger wrote: this needs checkpatch for sure seems like this doesn't use the existing common/menu.c code ... shouldn't it ? No my ANSI terminal bootmenu does not use common/menu.c (4 months ago, there was no menu.c file) so you'll be updating the patchseries to utilize common code that now exists ? -mike What is implemented in that file common/menu.c? It here any info/doc? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
