Re: Midnight Commander: bug report and patch
Hi, Daniel - On Wed, Jan 06, 2010 at 12:25:25AM -0500, Daniel Chen wrote: On Thu, Dec 24, 2009 at 11:37 AM, Ben Okopnik b...@linuxgazette.net wrote: I tried reporting this bug in Launchpad more about a week back, and never got any response. Since it's a pretty big one (zip file contents not showing up), I figured I'd send it here; hopefully, someone finds it helpful! There seems to be a workaround in place already, but the actual culprit definitely wasn't fixed. Thanks for chasing it down! I've merged your patch (diff -u tends to be friendlier for me) in the latest upload to Lucid, 3:4.7.0-1ubuntu1. Great! I'll use 'diff -u' in the future. Best regards, -- OKOPNIK CONSULTING Custom Computing Solutions For Your Business Expert-led Training | Dynamic, vital websites | Custom programming 443-250-7895http://okopnik.com -- Ubuntu-devel-discuss mailing list Ubuntu-devel-discuss@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss
Re: Midnight Commander: bug report and patch
On Thu, Dec 24, 2009 at 11:37 AM, Ben Okopnik b...@linuxgazette.net wrote: I tried reporting this bug in Launchpad more about a week back, and never got any response. Since it's a pretty big one (zip file contents not showing up), I figured I'd send it here; hopefully, someone finds it helpful! There seems to be a workaround in place already, but the actual culprit definitely wasn't fixed. Thanks for chasing it down! I've merged your patch (diff -u tends to be friendlier for me) in the latest upload to Lucid, 3:4.7.0-1ubuntu1. Best, -Dan -- Ubuntu-devel-discuss mailing list Ubuntu-devel-discuss@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss
RE: Midnight Commander: bug report and patch
Date: Thu, 24 Dec 2009 11:37:30 -0500 From: Ben Okopnik b...@linuxgazette.net Subject: Midnight Commander: bug report and patch To: ubuntu-devel-discuss@lists.ubuntu.com Message-ID: 20091224163730.ga6...@linuxgazette.net Content-Type: text/plain; charset=us-ascii Hi, all - I tried reporting this bug in Launchpad more about a week back, and never got any response. Since it's a pretty big one (zip file contents not showing up), I figured I'd send it here; hopefully, someone finds it helpful! The problem was caused by the regex in /usr/share/mc/extfs/uzip failing to parse the output of '/usr/bin/unzip -qq -v'. As a result, the subsequent code that processes the return from that regex also fails. Please take a look at the diff file for the fix (tested on ~20 random zip files.) Best regards, -- * Ben Okopnik * Editor-in-Chief, Linux Gazette * http://LinuxGazette.NET * * You're absolutely right. I had this the other day and didn't even think anymore about it. But mc should theoretically read what's inside an archive and display its contents. I just tried mine and it works for RAR and 7z archives, but not ZIP. Odd. Regards -- Chris Jones linuxdyna...@comcen.com.au Founder Linux Dynamix Foundation http://linuxdynamixfoundation.freehostia.com -- Ubuntu-devel-discuss mailing list Ubuntu-devel-discuss@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss
