[Bug 1060404] Re: update-grub runs and fails in containers
** Also affects: auto-upgrade-testing Importance: Undecided Status: New ** Changed in: auto-upgrade-testing Status: New = In Progress ** Changed in: auto-upgrade-testing Assignee: (unassigned) = Martin Pitt (pitti) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/auto-upgrade-testing/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:auto-upgrade-testing -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/auto-upgrade-testing/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
I applied a workaround for trusty in http://bazaar.launchpad.net/~auto- upgrade-testing-dev/auto-upgrade-testing/trunk/revision/92 . Not pretty, but it'll do. ** Changed in: auto-upgrade-testing Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/auto-upgrade-testing/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Err, I meant for quantal, not for trusty. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/auto-upgrade-testing/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
For the record, this hasn't fully been fixed in Quantal: Quantal's /etc/kernel/postinst.d/zz-update-grub does NOT have the container check as introduced in precise's grub2 (1.99-21ubuntu3.9) SRU. This breaks upgrades from quantal to saucy in containers: https://jenkins.qa.ubuntu.com/job/upgrade-ubuntu-quantal-saucy- desktop-amd64/27/ (I filed bug 1279658 about this and then found this bug when analyzing it). At this point I'm not sure whether it's still worth SRUing this to quantal, or whether we just apply a workaround in our testing. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Changed in: lxc (Ubuntu Precise) Status: Triaged = Invalid -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
This bug was fixed in the package grub2 - 1.99-21ubuntu3.9 --- grub2 (1.99-21ubuntu3.9) precise; urgency=low * Also skip update-grub when running in a container (LP: #1060404). -- Colin Watson cjwat...@ubuntu.com Tue, 22 Jan 2013 14:43:32 + ** Changed in: grub2 (Ubuntu Precise) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:ubuntu/precise-updates/grub2 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
The posted fix works for me too: running Juju on Raring with precise charms using juju-origin: proposed. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Ran into this bug trying out juju, the posted fix for precise (1.99-21ubuntu3.9) works for me. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1060404] Re: update-grub runs and fails in containers
On Tue, Jan 22, 2013 at 03:32:12AM -, Sebastian Hoffmann wrote: I can't reproduce fix on precise. I've used ppa:juju/0.6 (r608), grub-pc is ubuntu3.8, juju-origin: proposed, but I still get the same error. Can I please have a transcript of the error you're seeing? There are (at least) two possible failure modes here. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
I installed the version from precise-updates on a precise lxc, which didn't have grub-pc before. It worked for me. Here is the output: (...) Processing triggers for ureadahead ... Setting up libfreetype6 (2.4.8-1ubuntu2.1) ... Setting up gettext-base (0.18.1.1-5ubuntu3) ... Setting up libfuse2 (2.8.6-2ubuntu2) ... Setting up grub-common (1.99-21ubuntu3.8) ... Setting up grub2-common (1.99-21ubuntu3.8) ... Setting up grub-pc-bin (1.99-21ubuntu3.8) ... Setting up os-prober (1.51ubuntu3) ... Setting up grub-pc (1.99-21ubuntu3.8) ... Creating config file /etc/default/grub with new version lxc Setting up grub-gfxpayload-lists (0.6) ... Processing triggers for libc-bin ... ldconfig deferred processing now taking place root@precise:~# That lone lxc comes from grub's postinst calling running-in- container. I think it could have its output redirected to /dev/null, unless we want to restrict this test to lxc: root@precise:~# running-in-container lxc root@precise:~# -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1060404] Re: update-grub runs and fails in containers
Andreas: Thanks. I already noticed the running-in-container output and fixed it in Debian experimental (which will be merged into raring at some point); it probably isn't worth revising precise for in the absence of another pressing need to touch those lines of code, though. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Agreed. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Output when NOT running on LXC (a linode machine in this case): (...) Preparing to replace grub-pc 1.99-21ubuntu3.7 (using .../grub-pc_1.99-21ubuntu3.8_i386.deb) ... Unpacking replacement grub-pc ... Preparing to replace grub-pc-bin 1.99-21ubuntu3.7 (using .../grub-pc-bin_1.99-21ubuntu3.8_i386.deb) ... Unpacking replacement grub-pc-bin ... Preparing to replace grub2-common 1.99-21ubuntu3.7 (using .../grub2-common_1.99-21ubuntu3.8_i386.deb) ... Unpacking replacement grub2-common ... Preparing to replace grub-common 1.99-21ubuntu3.7 (using .../grub-common_1.99-21ubuntu3.8_i386.deb) ... Unpacking replacement grub-common ... Processing triggers for man-db ... Processing triggers for install-info ... Processing triggers for ureadahead ... Setting up grub-common (1.99-21ubuntu3.8) ... Setting up grub2-common (1.99-21ubuntu3.8) ... Setting up grub-pc-bin (1.99-21ubuntu3.8) ... Setting up grub-pc (1.99-21ubuntu3.8) ... Generating grub.cfg ... Found linux image: /boot/vmlinuz-3.2.0-36-virtual Found initrd image: /boot/initrd.img-3.2.0-36-virtual Found linux image: /boot/vmlinuz-3.2.0-35-virtual Found initrd image: /boot/initrd.img-3.2.0-35-virtual done root@ls3-precise:~# echo $? 0 root@ls3-precise:~# which running-in-container /bin/running-in-container root@ls3-precise:~# running-in-container root@ls3-precise:~# echo $? 1 root@ls3-precise:~# -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Hello Serge, or anyone else affected, Accepted grub2 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/grub2/1.99-21ubuntu3.9 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Tags removed: verification-done ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
I can confirm this fix working on precise for me. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:debian/experimental/grub2 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
I can't reproduce fix on precise. I've used ppa:juju/0.6 (r608), grub-pc is ubuntu3.8, juju-origin: proposed, but I still get the same error. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Confirmed in precise, thanks. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Hello Serge, or anyone else affected, Accepted grub2 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/grub2/1.99-21ubuntu3.8 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: grub2 (Ubuntu Precise) Status: In Progress = Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:ubuntu/precise-proposed/grub2 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
What is the work-around that I might be missing? Trying out juju with LXC by following https://juju.ubuntu.com/docs/getting-started.html will make you run directly into this bug. Quite a let-down as everything else runs so smoothly with juju ... -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
@Henning, At one point we thought a workaround was to have devtmpfs mounted in the container. However that is a bad thing to do as changes in the container's /dev will be reflected in the host's /dev. So the only workaround right now (until grub is fixed in precise) is to check (with 'mount') which device / is mounted from in the container, and then create that device in the container. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Any idea if this will be fixed for precise, or is it too risky? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Description changed: - == - SRU justification for lxc part: - 1. Impact: update-grub fails, causing apt-get updates to fail if there is a new kernel. - 2. Development fix: modify ubuntu templates to mount devtmpfs before starting container - 3. Stable fix: same as development fix. - 4. Test case: - sudo lxc-create -t ubuntu-cloud -n q1 - sudo lxc-start q1 - # inside the container, run sudo update-grub - 5. Regression potential: This adds one more mount per container (by default, removable), taking up more memory. - == - If grub is installed in a container (as happens, for instance, with the ubuntu-cloud template) then an update of grub or linux-image will cause update-grub to be run. It tries, finds it can't access the root device, fails, and causes the update to fail. + [XXX edit - removed the SRU justification for lxc part. The proposed solution + was not safe, and was undone in a later commit. devtmpfs cannot be mounted + in a container, because changes under the container's /dev are then + reflected in the host's /dev. + + If grub is installed in a container (as happens, for instance, with the + ubuntu-cloud template) then an update of grub or linux-image will cause + update-grub to be run. It tries, finds it can't access the root device, + fails, and causes the update to fail. It would be better for update-grub to detect that it is in a container and simply exit 0, so that the apt-get can succeed. I'm attaching a debdiff which does that. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
@Andreas, it needs to be fixed in grub. However the fix in raring should be SRUable. ** Changed in: grub2 (Ubuntu Precise) Importance: Undecided = High ** No longer affects: upstart (Ubuntu) ** No longer affects: upstart (Ubuntu Precise) ** No longer affects: upstart (Ubuntu Quantal) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Right, grub, and for now my workaround is to remove grub-pc if I'm in a container. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Description changed: + [Impact] GRUB upgrades fail in containers. + [Test Case] Upgrade the grub-pc package in a container. + [Regression Potential] In itself, this postinst fix should be quite safe. It's possible it won't solve the whole problem - e.g. linux-image-* upgrades calling update-grub - but I wanted to backport just what was in quantal/raring rather than getting creative in an SRU. + [XXX edit - removed the SRU justification for lxc part. The proposed solution was not safe, and was undone in a later commit. devtmpfs cannot be mounted in a container, because changes under the container's /dev are then reflected in the host's /dev. If grub is installed in a container (as happens, for instance, with the ubuntu-cloud template) then an update of grub or linux-image will cause update-grub to be run. It tries, finds it can't access the root device, fails, and causes the update to fail. It would be better for update-grub to detect that it is in a container and simply exit 0, so that the apt-get can succeed. I'm attaching a debdiff which does that. ** Changed in: grub2 (Ubuntu Precise) Status: Confirmed = In Progress ** Changed in: grub2 (Ubuntu Precise) Assignee: (unassigned) = Colin Watson (cjwatson) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:~ubuntu-core-dev/ubuntu/precise/grub2/precise -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:ubuntu/lxc -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grub2 (Ubuntu Precise) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: upstart (Ubuntu Precise) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:~cjwatson/ubuntu/quantal/grub2/2.00 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
This bug was fixed in the package grub2 - 2.00-7ubuntu3 --- grub2 (2.00-7ubuntu3) quantal; urgency=low * If the postinst is running in a container, skip grub-install and all its associated questions (LP: #1060404). * Merge UEFI secure boot tweaks from Fedora: - Don't error on insmod on UEFI/SB, but also don't do any insmodding. - Add sleep to the list of modules in the signed image. * Move Ubuntu modifications to the Fedora linuxefi patch into separate patches, to ease maintenance. * Implement secure boot handling policy as outlined by Steve Langasek: - Make the linux module call linuxefi when necessary, simplifying configuration. Add the linux module to the signed image. - If secure boot is enabled and the kernel is signed, linux will call linuxefi to hand over to it without calling ExitBootServices. - Otherwise, linux will fall through to previous code, call ExitBootServices itself, and boot the kernel normally. - Change linuxefi to return GRUB_ERR_ACCESS_DENIED rather than GRUB_ERR_INVALID_COMMAND in the case of an invalid signature, to make it easier to implement different handling of unsigned kernels in future if necessary. * Build two images for signing: one with prefix /EFI/BOOT for use on removable media, and one with prefix /EFI/ubuntu (and with the lvm, mdraid09, and mdraid1x modules added) for use on fixed disks. Setup mostly borrowed from Fedora. * Generate configuration for signed UEFI kernels if available. -- Colin Watson cjwat...@ubuntu.com Sun, 07 Oct 2012 11:36:29 +0100 ** Changed in: grub2 (Ubuntu Quantal) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Branch linked: lp:ubuntu/grub2 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Changed in: grub2 (Ubuntu) Status: Confirmed = Fix Committed ** Changed in: grub2 (Ubuntu) Assignee: (unassigned) = Colin Watson (cjwatson) ** Also affects: grub2 (Ubuntu Quantal) Importance: High Assignee: Colin Watson (cjwatson) Status: Fix Committed ** Also affects: upstart (Ubuntu Quantal) Importance: Undecided Status: Invalid ** Also affects: lxc (Ubuntu Quantal) Importance: High Status: Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Also affects: grub2 (Ubuntu Precise) Importance: Undecided Status: New ** Also affects: upstart (Ubuntu Precise) Importance: Undecided Status: New ** Also affects: lxc (Ubuntu Precise) Importance: Undecided Status: New ** Changed in: lxc (Ubuntu Precise) Status: New = Triaged ** Changed in: lxc (Ubuntu Precise) Importance: Undecided = High ** Changed in: lxc (Ubuntu Precise) Assignee: (unassigned) = Serge Hallyn (serge-hallyn) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Description changed: - If grub is installed in a container (as happens, for instance, with the - ubuntu-cloud template) then an update of grub or linux-image will cause - update-grub to be run. It tries, finds it can't access the root device, - fails, and causes the update to fail. + == + SRU justification for lxc part: + 1. Impact: update-grub fails, causing apt-get updates to fail if there is a new kernel. + 2. Development fix: modify ubuntu templates to mount devtmpfs before starting container + 3. Stable fix: same as development fix. + 4. Test case: + sudo lxc-create -t ubuntu-cloud -n q1 + sudo lxc-start q1 + # inside the container, run sudo update-grub + 5. Regression potential: This adds one more mount per container (by default, removable), taking up more memory. + == + If grub is installed in a container (as happens, for instance, with the ubuntu-cloud template) then an update of grub or linux-image will cause update-grub to be run. It tries, finds it can't access the root device, fails, and causes the update to fail. It would be better for update-grub to detect that it is in a container and simply exit 0, so that the apt-get can succeed. I'm attaching a debdiff which does that. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
** Also affects: lxc (Ubuntu) Importance: Undecided Status: New ** Changed in: lxc (Ubuntu) Importance: Undecided = High ** Changed in: lxc (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
After talking to cjwatson on irc, there is another option. update-grub is failing because /dev/disk/ is not set up in the container. So we could add an upstart job which runs only in containers, and manually sets up /dev/disk/. This also might help other software which relies on /dev/disk/. However, as grub is not installed in ubuntu containers by default (but is installed in ubuntu-cloud containers) we can't blindly re-use grub-probe. If we use grub-probe only if it is available, then we are helping fewer cases. If we detect the root device by hand, I fear we are duplicating too much fragile code. Perhaps the best option is simply an upstart job like the below (but smarter and safer): start on starting mountall task script type grub-probe /dev/null 21 || { exit 0; stop; } mkdir -p /dev/disk/by-label /dev/disk/by-uuid rootdev=`grub-probe -t device /` do_mknod /dev/rootdev rootlabel=`grub-probe -t fs_label /` ln -s ../../$rootdev /dev/disk/by-label/$rootlabel rootuuid=`grub-probe -t fs_uuid /` ln -s ../../$rootdev /dev/disk/by-uuid/$rootuuid end script ** Also affects: upstart (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
As hrw pointed out on #ubuntu-devel, a third option is to simply add devtmpfsdev devtmpfs defaults 0 0 to /var/lib/lxc/$c/fstab -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
I've pushed a patch to ubuntu:lxc which will cause devtmpfs to be mounted in ubuntu containers. There remains the problem that grub-install then queries the user about installing grub on /dev/vda1 (or whatever is hosting the container fs). ** Changed in: upstart (Ubuntu) Status: New = Invalid -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1060404] Re: update-grub runs and fails in containers
This bug was fixed in the package lxc - 0.8.0~rc1-4ubuntu37 --- lxc (0.8.0~rc1-4ubuntu37) quantal; urgency=low * update 0222-debian-dhcp3-package: use dhcp3-client, not server! * 0224-ubuntu-templates-devtmpfs: mount devtmpfs in ubuntu containers. (LP: #1060404) -- Serge Hallyn serge.hal...@ubuntu.com Thu, 04 Oct 2012 12:06:02 -0500 ** Changed in: lxc (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1060404 Title: update-grub runs and fails in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1060404/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs