Re: [EXTERNAL]Re: org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun Handshake failed

[Rémy Maucherat]

On Fri, Jan 5, 2018 at 3:43 PM, Michael Peng <
michael.p...@entrustdatacard.com> wrote:

> Hi, Remy,
>
> Is  the fix available for 8.5.16? if not, could you please share the code
> changes?
>

This is the fix as the code seemed incorrect when thinking about it some
more.

Rémy

RE: [EXTERNAL]Re: org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun Handshake failed

[Michael Peng]

Hi, Remy, 

Is  the fix available for 8.5.16? if not, could you please share the code 
changes?

Thanks,

Michael

-Original Message-
From: Rémy Maucherat [mailto:r...@apache.org] 
Sent: Friday, January 5, 2018 5:58 AM
To: Tomcat Users List 
Subject: [EXTERNAL]Re: 
org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun Handshake failed

On Fri, Jan 5, 2018 at 8:38 AM, Rémy Maucherat  wrote:

> On Fri, Jan 5, 2018 at 12:25 AM, Michael Peng < 
> michael.p...@entrustdatacard.com> wrote:
>
>> Do the changes make sense, and what would be the side effect ? In our 
>> case, the "netInBuffer" could be full, i.e., postion = limit for 
>> large data. Maybe the "netInBuffer" should not be cleared since 
>> "compact" would reset the "netInBuffer", should it?
>>
>> The buffer is flipped after that and the NIO code is the same anyway, 
>> so
> the change doesn't make sense indeed as is.
>
> Looking at it made it seem not right compared to NIO, so I made 
> another
change and hopefully fixed it.

Rémy