Re: Error in Tomcat 6.0 log4j documentation

2011-06-07 Thread Remon Sadikni

Hi Mark,

for me log4j only works with this additional line per appender:

log4j.appender.CATALINA.layout=org.apache.log4j.PatternLayout

Thanks,
Remon


On 06/06/2011 07:09 PM, Mark Thomas wrote:

On 06/06/2011 15:25, Remon Sadikni wrote:

Dear Tomcat-Developers and Users,

I think there is an error in the Tomcat 6.0 logging documentation with
log4j:
http://tomcat.apache.org/tomcat-6.0-doc/logging.html#Using_Log4j

For every appender there is a layout missing and in front of
conversionPattern there is missing layout..  So for example for the
appender CATALINA the right syntax would be:

log4j.appender.CATALINA=org.apache.log4j.DailyRollingFileAppender
log4j.appender.CATALINA.file=${catalina.base}/logs/catalina.
log4j.appender.CATALINA.encoding=UTF-8
# Roll-over the log once per day
log4j.appender.CATALINA.DatePattern='.'-MM-dd'.log'
log4j.appender.CATALINA.layout.conversionPattern = %d [%t] %-5p %c- %m%n
log4j.appender.CATALINA.layout=org.apache.log4j.PatternLayout
log4j.appender.CATALINA.append=true

The same errors appear in the Tomcat 7.0 documentation.

Thanks for the report.

I could see the missing layout. but no missing layouts for the appenders.

The fixes will be in 7.0.16 and 6.0.33.

Mark



-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org




--
+++
 Dipl. Inf. Remon Sadikni
 Scientific Programmer

 University of Hamburg / KlimaCampus Hamburg
 Center for Integrated Climate System Analysis and Prediction - CliSAP
 Grindelberg 5 / D-20144 Hamburg / Germany

 phone: +49-40-42838-7581
 email: remon.sadi...@zmaw.de
+++


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Error in Tomcat 6.0 log4j documentation

2011-06-07 Thread Mark Thomas
On 07/06/2011 11:52, Remon Sadikni wrote:
 Hi Mark,
 
 for me log4j only works with this additional line per appender:
 
 log4j.appender.CATALINA.layout=org.apache.log4j.PatternLayout

Where exactly? That line is already present in the docs. Or are you
looking at an older version?

The latest version in svn is this:
http://ci.apache.org/projects/tomcat/tomcat6/docs/logging.html#Using_Log4j

Is the whitespace an issue?

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Error in Tomcat 6.0 log4j documentation

2011-06-07 Thread Konstantin Kolinko
2011/6/7 Mark Thomas ma...@apache.org:
 On 07/06/2011 11:52, Remon Sadikni wrote:
 Hi Mark,

 for me log4j only works with this additional line per appender:

 log4j.appender.CATALINA.layout=org.apache.log4j.PatternLayout

 Where exactly? That line is already present in the docs. Or are you
 looking at an older version?

That line was already added by Christopher several days ago (revs
1129869, 1129863), as a response for the previous report of the same
issue.

It is not published yet, so see the ci link (the docs published by
buildbot) that Mark mentions below.


 The latest version in svn is this:
 http://ci.apache.org/projects/tomcat/tomcat6/docs/logging.html#Using_Log4j


BTW,
Log4J docs and out 5.5 docs start conversionPattern with an uppercase C.

http://tomcat.apache.org/tomcat-5.5-doc/logging.html
http://logging.apache.org/log4j/1.2/manual.html

I expect it to work either way though, as Log4J normalizes the
property name before applying (o.a.log4j.config.PropertySetter calls
Introspector.decapitalize())


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Error in Tomcat 6.0 log4j documentation

2011-06-07 Thread Remon Sadikni

Hi Konstantin, hi Mark,

all right, thank you. I only looked at the published version, not the 
one in svn.


Regards,
Remon

On 06/07/2011 05:06 PM, Konstantin Kolinko wrote:

2011/6/7 Mark Thomasma...@apache.org:

On 07/06/2011 11:52, Remon Sadikni wrote:

Hi Mark,

for me log4j only works with this additional line per appender:

log4j.appender.CATALINA.layout=org.apache.log4j.PatternLayout

Where exactly? That line is already present in the docs. Or are you
looking at an older version?

That line was already added by Christopher several days ago (revs
1129869, 1129863), as a response for the previous report of the same
issue.

It is not published yet, so see the ci link (the docs published by
buildbot) that Mark mentions below.


The latest version in svn is this:
http://ci.apache.org/projects/tomcat/tomcat6/docs/logging.html#Using_Log4j


BTW,
Log4J docs and out 5.5 docs start conversionPattern with an uppercase C.

http://tomcat.apache.org/tomcat-5.5-doc/logging.html
http://logging.apache.org/log4j/1.2/manual.html

I expect it to work either way though, as Log4J normalizes the
property name before applying (o.a.log4j.config.PropertySetter calls
Introspector.decapitalize())


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org




--
+++
 Dipl. Inf. Remon Sadikni
 Scientific Programmer

 University of Hamburg / KlimaCampus Hamburg
 Center for Integrated Climate System Analysis and Prediction - CliSAP
 Grindelberg 5 / D-20144 Hamburg / Germany

 phone: +49-40-42838-7581
 email: remon.sadi...@zmaw.de
+++


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Error in Tomcat 6.0 log4j documentation

2011-06-06 Thread Mark Thomas
On 06/06/2011 15:25, Remon Sadikni wrote:
 Dear Tomcat-Developers and Users,
 
 I think there is an error in the Tomcat 6.0 logging documentation with
 log4j:
 http://tomcat.apache.org/tomcat-6.0-doc/logging.html#Using_Log4j
 
 For every appender there is a layout missing and in front of
 conversionPattern there is missing layout..  So for example for the
 appender CATALINA the right syntax would be:
 
 log4j.appender.CATALINA=org.apache.log4j.DailyRollingFileAppender
 log4j.appender.CATALINA.file=${catalina.base}/logs/catalina.
 log4j.appender.CATALINA.encoding=UTF-8
 # Roll-over the log once per day
 log4j.appender.CATALINA.DatePattern='.'-MM-dd'.log'
 log4j.appender.CATALINA.layout.conversionPattern = %d [%t] %-5p %c- %m%n
 log4j.appender.CATALINA.layout=org.apache.log4j.PatternLayout
 log4j.appender.CATALINA.append=true
 
 The same errors appear in the Tomcat 7.0 documentation.

Thanks for the report.

I could see the missing layout. but no missing layouts for the appenders.

The fixes will be in 7.0.16 and 6.0.33.

Mark



-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org