Re: [users] Hook request

2005-02-01 Thread Ron Guerin
On Tue, 2005-01-25 at 12:16 -0800, Bill Shupp wrote:
 Ron Guerin wrote:
 
 The more I think about this, the more it seems like it might not be a 
 bad idea for very large sites.  However, it should be an option set in 
 config.php.  Can you easily alter it to work that way?

How about this?

config.php
--
  define(EXTRA_UPDATE, TRUE);

  function update_extra_processing() {
// user code goes here or else this does nothing
  }


records.php
---
  if(EXTRA_UPDATE) { update_extra_processing; } // in appropriate places

If this is what you had in mind, I can send you a patch like that.

- Ron




Re: [users] Hook request

2005-01-25 Thread Bill Shupp
Ron Guerin wrote:
I'd submit a patch but I'm under the impression I haven't made the case
for it being worth accepting.
 

The more I think about this, the more it seems like it might not be a 
bad idea for very large sites.  However, it should be an option set in 
config.php.  Can you easily alter it to work that way?

Regards,
Bill


Re: [users] Hook request

2005-01-22 Thread Ron Guerin
On Fri, 2005-01-21 at 15:44 -0500, dopry wrote:
 Why not handle it through update-data.sh?  

I do, actually.  That's what happens as a result.  I've changed that not
to actually run make though, it also sets a flag.  Under the
circumstances, I can't have multiple things running that are under the
assumption they have sole control over tinydns.  So rather than running
update-data.sh through cron, I have another script that runs from cron
and looks after all the bits of my tinydns, tinydyndns, and dnscache.

As far as VegaDNS is concerned, the change is small.  Instead of cron
running a job that dumps the zones to see if anything has changed, I
don't run the job unless something _has_ changed.  I could have
continued dumping and comparing zones out of VegaDNS every 5 minutes in
update-data.sh like I had been (impatient users), but that just seems
ugly to me.  I realize doing it my way probably seems ugly to you
though.  VegaDNS was obviously meant to take over the role of tinydns
front-end rather than to supplement the existing method, however, it
happens to work well for me that way.

- Ron




Re: [users] Hook request

2005-01-22 Thread Jason 'XenoPhage' Frisvold
Ron Guerin wrote:
Oh well, I tried. ;)
If I'm the only one who cares, then I'm sure you're right.   And it's a
small enough change that it's not a big deal for me to do it when
there's a new version.  I just try to make all patching a last resort.
 

You could always submit a patch and ask Bill to include it in the distro 
:)  Bill's a nice guy, he does stuff like that once in a while.. *grin*

- Ron
 


--
---
Jason 'XenoPhage' Frisvold
Engine / Technology Programmer
[EMAIL PROTECTED]
RedHat Certified - RHCE # 803004140609871
MySQL Pro Certified - ID# 207171862
MySQL Core Certified - ID# 205982910
---
Something mysterious is formed, born in the silent void. Waiting alone and 
unmoving, it is at once still and yet in constant motion. It is the source of all 
programs. I do not know its name, so I will call it the Tao of Programming.


Re: [users] Hook request

2005-01-22 Thread Ron Guerin
On Sat, 2005-01-22 at 15:39 -0500, Jason 'XenoPhage' Frisvold wrote:
 Ron Guerin wrote:
 
 Oh well, I tried. ;)
 
 If I'm the only one who cares, then I'm sure you're right.   And it's a
 small enough change that it's not a big deal for me to do it when
 there's a new version.  I just try to make all patching a last resort.
   
 
 
 You could always submit a patch and ask Bill to include it in the distro 
 :)  Bill's a nice guy, he does stuff like that once in a while.. *grin*

You don't have to convince me. I know it.  I use the Toaster.

I'd submit a patch but I'm under the impression I haven't made the case
for it being worth accepting.

- Ron