Re: [vchkpw] Decided to make the plunge today on late version of vpopmail
Rick Widmer wrote: Quey wrote: Rick on a kind of related note, did you see one of my posts in the thread: adduser processing times CDB from 27th of the 7th ? Looking at that thread... slow loading of users: I have added a note in the TODO to add an -O option to vadduser like the option in vadddomain, so it can only update the .cdb file once at the end of a batch of adds. Right now I'm pretty sure the .cdb is updated for each one. That would be good, however we have since moved to mysql and it flies, but it would still be a good idea ofr those still using cdb for sure. Missing some files in vdeldomain: The current code uses unlink(), I don't think I want to do anything more when deleting files. Considering that you had to e2fsck the disk I'm not sure I could. I don't believe vpopmail ever creates files or directories with a ? in the name and have no idea where they may have come from. They were whats left after vdeldomain, they were directory names and stuff like what was there before named correctly, after i deleted the domain something must have had a hissy somewhere and was unable to remove them so renamed them with a preceeding "?", that must have something to do with unlinks work I guess, when I next have to build another box I'll do a dummy run and delete it and see what happens, maybe it was coincidence and was purely a one-off case, I wouldnt suggest doing it yourself on anything production :) Cheers Q
Re: [vchkpw] Decided to make the plunge today on late version of vpopmail
Quey wrote: Rick on a kind of related note, did you see one of my posts in the thread: adduser processing times CDB from 27th of the 7th ? Looking at that thread... slow loading of users: I have added a note in the TODO to add an -O option to vadduser like the option in vadddomain, so it can only update the .cdb file once at the end of a batch of adds. Right now I'm pretty sure the .cdb is updated for each one. Missing some files in vdeldomain: The current code uses unlink(), I don't think I want to do anything more when deleting files. Considering that you had to e2fsck the disk I'm not sure I could. I don't believe vpopmail ever creates files or directories with a ? in the name and have no idea where they may have come from. Learn-Password: learn-password can be turned on at any time with /configure; make; make install. Be sure to re-compile everything that uses vpopmail Rick
Re: [vchkpw] Decided to make the plunge today on late version of vpopmail
Rick Widmer wrote: Steve Cole wrote: On two (low volume) machines with vpopmail interfaced with mysql as the data store, it seemed to work successfully. I updated the database schema with no issues. This is with v5.4.21 However, when I do a "vdeluser" on either machine, the program segfaults. On both systems. I tried it here with --enable-auth-module=mysql but don't get the segfault. So can you send me: The vpopmail ./configure options you are using The actual user/domain you are trying to delete The strace output You can send it private if you wish... Going back to 5.4.17 seemed to be no issue at all and of course, it works as expected. Nothing within vdeluser changed between those versions, but there were changes in vpopmail.c, but nothing that stands out. Rick Widmer wrote: Steve Cole wrote: On two (low volume) machines with vpopmail interfaced with mysql as the data store, it seemed to work successfully. I updated the database schema with no issues. This is with v5.4.21 However, when I do a "vdeluser" on either machine, the program segfaults. On both systems. I tried it here with --enable-auth-module=mysql but don't get the segfault. So can you send me: The vpopmail ./configure options you are using The actual user/domain you are trying to delete The strace output You can send it private if you wish... Going back to 5.4.17 seemed to be no issue at all and of course, it works as expected. Nothing within vdeluser changed between those versions, but there were changes in vpopmail.c, but nothing that stands out. Rick on a kind of related note, did you see one of my posts in the thread: adduser processing times CDB from 27th of the 7th ?
Re: [vchkpw] Decided to make the plunge today on late version of vpopmail
Steve Cole wrote: On two (low volume) machines with vpopmail interfaced with mysql as the data store, it seemed to work successfully. I updated the database schema with no issues. This is with v5.4.21 However, when I do a "vdeluser" on either machine, the program segfaults. On both systems. I tried it here with --enable-auth-module=mysql but don't get the segfault. So can you send me: The vpopmail ./configure options you are using The actual user/domain you are trying to delete The strace output You can send it private if you wish... Going back to 5.4.17 seemed to be no issue at all and of course, it works as expected. Nothing within vdeluser changed between those versions, but there were changes in vpopmail.c, but nothing that stands out.
Re: [vchkpw] Decided to make the plunge today on late version of vpopmail
On Thursday 06 September 2007, Joshua Megerman wrote: > The vpopmail table, and ONLY the vpopmail table, has a column named > 'pw_domain'. Every other table should have a 'domain' column, as the > earlier UPGRADE document listed (which incorrectly listed vpopmail as > having a 'domain' column). No, thankfully. I was the one who reported the inconsistency in the upgrade document when *.20 rolled. I should have mentioned that this same thing happened to one of my test boxes when I tried *.20 but it didn't on another (which it turns out is CDB because it handles two personal domains). So *.20 likely has the problem as well, I didn't delve that deeply the first time. I straced the command and it opens a MySQL connection, does a MySQL query and then segfaults immediately. As I said, the behaviour doesn't occur in the CDB binary. -- -- Cheers, Steve
Re: [vchkpw] Decided to make the plunge today on late version of vpopmail
> On two (low volume) machines with vpopmail interfaced with mysql as the > data > store, it seemed to work successfully. I updated the database schema with > no > issues. This is with v5.4.21 > Did you follow the UPGRADE document in 5.4.21 exactly and rename the 'domain' columns to 'pw_domain'? If so, then your DB is now wrong. Apparently the fix I posted about the UPGRADE document didn't make it into 5.4.21... The vpopmail table, and ONLY the vpopmail table, has a column named 'pw_domain'. Every other table should have a 'domain' column, as the earlier UPGRADE document listed (which incorrectly listed vpopmail as having a 'domain' column). The other suggestion I can make is try stracing the new version and see where it fails... Josh Joshua Megerman SJGames MIB #5273 - OGRE AI Testing Division You can't win; You can't break even; You can't even quit the game. - Layman's translation of the Laws of Thermodynamics [EMAIL PROTECTED]
[vchkpw] vpopmail 5.4.21 released
http://vpopmail.sf.net 5.4.21 - released 6 Sept 2007 Release Notes: Alessio Cecchi found a bug in vpopmaild add_alias command, and Joshua Megerman provided a patch. If you are using vpopmaild you probably want to upgrade... Changelog: 5.4.21 - Released 06-Sep-2007 Joshua Mergeman, Alessio Cecchi - fix bug in vpopmaild add_alias command NOTE: This release contains only the patch Joshua just posted to the vpopmail list...
[vchkpw] Decided to make the plunge today on late version of vpopmail
On two (low volume) machines with vpopmail interfaced with mysql as the data store, it seemed to work successfully. I updated the database schema with no issues. This is with v5.4.21 However, when I do a "vdeluser" on either machine, the program segfaults. On both systems. I tried various things like making sure my LDFLAGS="" and CFLAGS="-O" only to be sure it wasn't a compiler issue, without luck. So, to be clear, this is on two Debian Etch machines with GCC 4.1.1-15 and MySQL 5.0.32-7etch1 installed. Going back to 5.4.17 seemed to be no issue at all and of course, it works as expected. -- -- Cheers, Steve
Re: [vchkpw] Re: [vpopmail-devel] vpopmail 5.4.21 released
Joshua Megerman wrote: Alessio Cecchi found a bug in vpopmaild add_alias command, and Joshua Megerman provided a patch. If you are using vpopmaild you probably want to upgrade... You spelled my name correctly above... Changelog: 5.4.21 - Released 06-Sep-2007 Joshua Mergeman, Alessio Cecchi - fix bug in vpopmaild add_alias command But not in the Changelog... :( Kindly fix it and repost the release if you could :) Done...
[vchkpw] Re: [vpopmail-devel] vpopmail 5.4.21 released
> Alessio Cecchi found a bug in vpopmaild add_alias command, and Joshua > Megerman provided a patch. If you are using vpopmaild you probably want > to upgrade... > You spelled my name correctly above... > Changelog: > > 5.4.21 - Released 06-Sep-2007 > Joshua Mergeman, Alessio Cecchi > - fix bug in vpopmaild add_alias command But not in the Changelog... :( Kindly fix it and repost the release if you could :) Thanks, Josh Joshua Megerman SJGames MIB #5273 - OGRE AI Testing Division You can't win; You can't break even; You can't even quit the game. - Layman's translation of the Laws of Thermodynamics [EMAIL PROTECTED]
Re: [vchkpw] Problem with add_alias
Thank you both! The patch has been added to CVS, and will appear in the next release. Rick
Re: [vchkpw] Problem with add_alias
On Thursday 06 September 2007 15:48:56 Joshua Megerman wrote:
> > Also if i open the same .qmail vith vim i see [DOS] for encoding.
>
> Actually, looking at the code, he's right - the line in question is in
> vpopmaild.c, line 1002:
>
> if ((alias_line=strtok(NULL, "\n"))==NULL) {
>
> The strtok tokenizes after the '\n' (), leaving the '\r' () as the
> last character of the alias_line, which would have the exact effect he's
> seeing. Looks like the same bug exists on line 1051 as well (identical
> code block in remove_alias). Every other instance of strtok() uses one of
> two defines for the token list - TOKENS or PASS_TOKENS, these are the only
> two strtok() calls using an explicit token list. Patch is attached.
Thank you Joshua,
with this patch now add_alias from telnet works!
Bye
--
Alessio Cecchi is:
@ ILS -> http://www.linux.it/~alessice/
Assistenza Sistemi GNU/Linux -> http://www.cecchi.biz/
@ PLUG -> Presidente, http://www.prato.linux.it
Re: [vchkpw] Problem with add_alias
>> > Could be the problem relate to the "" of the telnete session?
>>
>> No.
>
> Sorry Rick but the problem is crlf, the domain are only for example (on my
> server i have used real domain name like gmail.com), but the problem is
> the .qmail generated by the add_alias, infact if i run dos2unix
> .qmail-prova
> the alias works.
>
> Also if i open the same .qmail vith vim i see [DOS] for encoding.
>
Actually, looking at the code, he's right - the line in question is in
vpopmaild.c, line 1002:
if ((alias_line=strtok(NULL, "\n"))==NULL) {
The strtok tokenizes after the '\n' (), leaving the '\r' () as the
last character of the alias_line, which would have the exact effect he's
seeing. Looks like the same bug exists on line 1051 as well (identical
code block in remove_alias). Every other instance of strtok() uses one of
two defines for the token list - TOKENS or PASS_TOKENS, these are the only
two strtok() calls using an explicit token list. Patch is attached.
Josh
Joshua Megerman
SJGames MIB #5273 - OGRE AI Testing Division
You can't win; You can't break even; You can't even quit the game.
- Layman's translation of the Laws of Thermodynamics
[EMAIL PROTECTED]--- ../vpopmail-5.4.20/vpopmaild.c 2007-08-22 02:17:45.0 -0400
+++ vpopmaild.c 2007-09-06 09:47:04.0 -0400
@@ -999,7 +999,7 @@
return(-1);
}
- if ((alias_line=strtok(NULL, "\n"))==NULL) {
+ if ((alias_line=strtok(NULL,TOKENS))==NULL) {
show_error( ERR_ALIAS_LINE_REQD, 906 );
return(-1);
}
@@ -1048,7 +1048,7 @@
return(-1);
}
- if ((alias_line=strtok(NULL, "\n"))==NULL) {
+ if ((alias_line=strtok(NULL,TOKENS))==NULL) {
show_error( ERR_ALIAS_LINE_REQD, 1006 );
return(-1);
}
Re: [vchkpw] Problem with add_alias
On Thursday 06 September 2007 07:18:32 Rick Widmer wrote: > > @400046dea9ab22704ab4 delivery 2089: failure: > > Sorry,_I_couldn't_find_any_host_named_server.com?._(#5.1.2)/ > > @400046dea9ab22738ea4 status: local 0/10 remote 0/20 > > > > > > Please note the problem of the domain name: > > > > server.com?. > > That is where you told it to send mail received by [EMAIL PROTECTED]: > > add_alias [EMAIL PROTECTED] [EMAIL PROTECTED] > > > Why this? > > server.com doesn't have any MX records, so qmail can't find a host to > send the message to. > > > Could be the problem relate to the "" of the telnete session? > > No. Sorry Rick but the problem is crlf, the domain are only for example (on my server i have used real domain name like gmail.com), but the problem is the .qmail generated by the add_alias, infact if i run dos2unix .qmail-prova the alias works. Also if i open the same .qmail vith vim i see [DOS] for encoding. Thanks -- Alessio Cecchi is: @ ILS -> http://www.linux.it/~alessice/ Assistenza Sistemi GNU/Linux -> http://www.cecchi.biz/ @ PLUG -> Presidente, http://www.prato.linux.it
Re: [vchkpw] Problem with add_alias
On Thursday 06 September 2007 01:18:32 am Rick Widmer wrote: > Alessio Cecchi wrote: > > I'm using vpopmail 5.4.20 with vpopmaild enable. > > > > When i add an alias from a telnet session: > > > > [EMAIL PROTECTED]:~$ telnet mail.pippo.com 89 > > Trying 83.49.65.71... > > Connected to mail.pippo.com. > > Escape character is '^]'. > > +OK > > login [EMAIL PROTECTED] X > > +OK+ > > vpopmail_dir /home/vpopmail > > domain_dir /home/vpopmail/domains/pippo.com > > [...] > > no_maildrop 0 > > system_admin_privileges 0 > > . > > add_alias [EMAIL PROTECTED] [EMAIL PROTECTED] > > +OK > > quit > > +OK > > Connection closed by foreign host. > > > > After i'm unable to send e-mail to the alias: > > > > Hi. This is the qmail-send program at s1.pippo.com. > > I'm afraid I wasn't able to deliver your message to the following > > addresses. This is a permanent error; I've given up. Sorry it didn't work > > out. > > > > <[EMAIL PROTECTED]>: > > Sorry, I couldn't find any host named server.com?. (#5.1.2) > > > > --- Below this line is a copy of the message. > > > > [...] > > > > @400046dea9ab22704ab4 delivery 2089: failure: > > Sorry,_I_couldn't_find_any_host_named_server.com?._(#5.1.2)/ > > @400046dea9ab22738ea4 status: local 0/10 remote 0/20 > > > > > > Please note the problem of the domain name: > > > > server.com?. > > That is where you told it to send mail received by [EMAIL PROTECTED]: > >add_alias [EMAIL PROTECTED] [EMAIL PROTECTED] > I think he's obscuring the real domain name, but the key here is the '?' after "server.com" and before the final '.' - it's how qmail indicates a funky character IIRC. > > Why this? > > server.com doesn't have any MX records, so qmail can't find a host to > send the message to. > But it does have an A record, so if he really was trying to send to "server.com", qmail should have responded with a "can't establish an SMTP connection" message instead. > > Could be the problem relate to the "" of the telnete session? > > No. I agree that it's unlikely, but maybe something else is happening. But I agree that the original poster needs to provide more info, preferably without hiding anything (other than passwords), so we can diagnose it better. Also, the output of valias showing the alias, and perhaps the actual alias DB dump showing it would be helpful too... Josh -- Joshua Megerman SJGames MIB #5273 - OGRE AI Testing Division You can't win; You can't break even; You can't even quit the game. - Layman's translation of the Laws of Thermodynamics [EMAIL PROTECTED]
