Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On Sun, 25 Sep 2011, semsem85 sami wrote: I have made a 2 min recording on one of sky italia channels. Here is the link: Hope this helps. Your sample doesn't have any DVB subtitles tracks, so I guess you really should be using the ttxtsubs plugin as VDR won't support nor record them by default: http://projects.vdr-developer.org/projects/plg-ttxtsubs BR, -- rofa ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On Sat, Sep 24, 2011 at 4:22 PM, semsem85 sami sami8...@hotmail.com wrote: On Fri, 23 Sep 2011, Rolf Ahrenberg wrote:If you have somewhere such a recording available, I could take a look at it and make sure my patch really fixes subtitling on those Sky Italia channels. I have made a 2 min recording on one of sky italia channels. Here is the link: https://rapidshare.com/files/3992138005/1.ts Hope this helps. Thanks and best regards, Sami Will you please stop making new threads with the same title! Especially a VDR announcement title. :\ ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On Wed, 21 Sep 2011, semsem85 sami wrote: I tried this version of vdr with the aim of displaying subtitles on sky italia channels but there were no subtitles shown at all, while at the same time tvheadend shows the subtitles. Please tell me if I have to do something to help. If you have somewhere such a recording available, I could take a look at it and make sure my patch really fixes subtitling on those Sky Italia channels. BR, -- rofa ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 09/21/11 13:08, semsem85 sami wrote: Hi, I tried this version of vdr with the aim of displaying subtitles on sky italia channels but there were no subtitles shown at all, while at the same time tvheadend shows the subtitles. Please tell me if I have to do something to help. The next developer version will contain a fix from Rolf Ahrenberg that should address this. Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 09.09.2011 19:37, Luca Olivetti wrote:
Al 09/09/11 16:54, En/na Klaus Schmidinger ha escrit:
I think this is still needed for output plugins that don't implement the method,
so that they should at least work as before this modification.
Can you please point out exactly which modificaton you are
referring to?
I'm referring to the modification that changed GetVideoSize
from being purely informational to being used for something.
In case you're interested, with the patch below, output plugins that
don't implement GetVideoSize will have the subtitles working as
before. I know that the proper fix is to implement GetVideoSize
and GetOsdSize (I actually did afterwards), but at least it doesn't
break what was working before.
--- dvbsubtitle.c.orig 2011-09-04 19:11:12.426133000 +0200
+++ dvbsubtitle.c 2011-09-09 19:27:46.064725000 +0200
@@ -887,7 +887,7 @@
double VideoAspect;
cDevice::PrimaryDevice()-GetOsdSize(OsdWidth, OsdHeight, OsdAspect);
cDevice::PrimaryDevice()-GetVideoSize(VideoWidth, VideoHeight,
VideoAspect);
- if (OsdWidth == displayWidth OsdHeight == displayHeight) {
+ if ((OsdWidth == displayWidth OsdHeight == displayHeight) || VideoWidth
== 0) {
osdFactorX = osdFactorY = 1.0;
osdDeltaX = osdDeltaY = 0;
}
You're right - adopted for 1.7.22.
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 09.09.2011 21:19, Reinhard Nissl wrote: Hi, Am 09.09.2011 16:54, schrieb Klaus Schmidinger: Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400. I switch to 1.7.21 from 1.7.17 and see that teletext subtitles appear now for example on Das Erste HD. I assume you mean *DVB* subtitles, right? No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that: vdr-xine: new OSD(-152, 0) requested with coordinates out of range Do these subtitles work correctly on your TT-S2 6400? I tested this with a recent recording of Wissen vor 8. The subtitles appeared at the right position. However, there was a horizontal, one pixel wide gap in each line, and sometimes the upper text line wasn't erased when I would have expected it to be. The latter may be a bug in VDR or the dvbhddevice plugin. I'll need to look into this some time... Which OSD size do you use on your TT-S2 6400? 1920x1080. Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 09/09/11 21:19, En/na Reinhard Nissl ha escrit: No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that: vdr-xine: new OSD(-152, 0) requested with coordinates out of range Reinhard, I'm using vdr-xine-0.9.3, and after setting the osd to 1920x1080, the subtitles are positioned correctly, at least on the bbc channels on 28.2E, both hd and sd. Previously I had the osd set to 640x480 (IIRC) and either the subtitles didn't show or they were at the left of the screen, vertically in the middle. The normal osd on 4:3 channels is compressed horizontally (it still covers the whole width of the screen but the characters are narrow), but the subtitles are fine. Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 05.09.2011 19:43, Luca Olivetti wrote: Al 05/09/11 18:15, En/na Klaus Schmidinger ha escrit: On 05.09.2011 00:08, Luca Olivetti wrote: Al 04/09/11 23:53, En/na Luca Olivetti ha escrit: Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit: Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters. Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData) It still works better with the above fix, but maybe there's a typo in there: shouldn't osdFactorX = VideoAspect * OsdHeight / displayWidth; be instead osdFactorX = VideoAspect * OsdHeight / displayHeight; I don't think so. 'VideoAspect * OsdHeight' is the width of a full screen subtitle display, using the entire OSD height, according to the aspect ratio of the video material. Dividing this by displayWidth (i.e. the actual width of the subtitle display) results in the osdFactorX, which is used to convert coordinates in the subtitle display to the OSD coordinate system. Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Assume the OSD aspect is 16:9 and the currently displayed video material is 4:3. To properly map the subtitles on the 16:9 OSD you need to do VideoAspect * OsdHeight to get the proper width, assuming that the full height shall be used. Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them. Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData. Can you provide me with some sample recording that demonstrates the problem you are seeing? I think you can check by yourself: I tested with the bbc channels at 28.2E. Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400. Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 05.09.2011 19:52, Luca Olivetti wrote: Al 05/09/11 19:43, En/na Luca Olivetti ha escrit: Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them. Ok, I had to setup the osd extents in xine to 1920x1080 to fix the issue. Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData. I think this is still needed for output plugins that don't implement the method, so that they should at least work as before this modification. Can you please point out exactly which modificaton you are referring to? Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 09/09/11 16:54, En/na Klaus Schmidinger ha escrit:
I think this is still needed for output plugins that don't implement the
method,
so that they should at least work as before this modification.
Can you please point out exactly which modificaton you are
referring to?
I'm referring to the modification that changed GetVideoSize
from being purely informational to being used for something.
In case you're interested, with the patch below, output plugins that
don't implement GetVideoSize will have the subtitles working as
before. I know that the proper fix is to implement GetVideoSize
and GetOsdSize (I actually did afterwards), but at least it doesn't
break what was working before.
--- dvbsubtitle.c.orig 2011-09-04 19:11:12.426133000 +0200
+++ dvbsubtitle.c 2011-09-09 19:27:46.064725000 +0200
@@ -887,7 +887,7 @@
double VideoAspect;
cDevice::PrimaryDevice()-GetOsdSize(OsdWidth, OsdHeight, OsdAspect);
cDevice::PrimaryDevice()-GetVideoSize(VideoWidth, VideoHeight, VideoAspect);
- if (OsdWidth == displayWidth OsdHeight == displayHeight) {
+ if ((OsdWidth == displayWidth OsdHeight == displayHeight) || VideoWidth
== 0) {
osdFactorX = osdFactorY = 1.0;
osdDeltaX = osdDeltaY = 0;
}
Bye
--
Luca
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 09/09/2011 10:19 PM, Reinhard Nissl wrote: Hi, Am 09.09.2011 16:54, schrieb Klaus Schmidinger: Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400. I switch to 1.7.21 from 1.7.17 and see that teletext subtitles appear now for example on Das Erste HD. No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that: vdr-xine: new OSD(-152, 0) requested with coordinates out of range I noticed a little different problem with vdr-sxfe (from xineliboutput). If I first watch some channel on vdr-sxfe client from the small window, the subtitles are positioned ok for me. But once I click the window for full screen mode, the subtitle position and size are not re-calculated and this causes that subtitles are shown in the middle of the screen. To fix this, I need to switch for another channel and then switch back to original channel. Mika ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 05.09.2011 00:08, Luca Olivetti wrote: Al 04/09/11 23:53, En/na Luca Olivetti ha escrit: Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit: Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters. Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData) It still works better with the above fix, but maybe there's a typo in there: shouldn't osdFactorX = VideoAspect * OsdHeight / displayWidth; be instead osdFactorX = VideoAspect * OsdHeight / displayHeight; I don't think so. 'VideoAspect * OsdHeight' is the width of a full screen subtitle display, using the entire OSD height, according to the aspect ratio of the video material. Dividing this by displayWidth (i.e. the actual width of the subtitle display) results in the osdFactorX, which is used to convert coordinates in the subtitle display to the OSD coordinate system. Can you provide me with some sample recording that demonstrates the problem you are seeing? Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 05/09/11 18:15, En/na Klaus Schmidinger ha escrit: On 05.09.2011 00:08, Luca Olivetti wrote: Al 04/09/11 23:53, En/na Luca Olivetti ha escrit: Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit: Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters. Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData) It still works better with the above fix, but maybe there's a typo in there: shouldn't osdFactorX = VideoAspect * OsdHeight / displayWidth; be instead osdFactorX = VideoAspect * OsdHeight / displayHeight; I don't think so. 'VideoAspect * OsdHeight' is the width of a full screen subtitle display, using the entire OSD height, according to the aspect ratio of the video material. Dividing this by displayWidth (i.e. the actual width of the subtitle display) results in the osdFactorX, which is used to convert coordinates in the subtitle display to the OSD coordinate system. Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them. Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData. Can you provide me with some sample recording that demonstrates the problem you are seeing? I think you can check by yourself: I tested with the bbc channels at 28.2E. Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 05/09/11 19:43, En/na Luca Olivetti ha escrit: Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them. Ok, I had to setup the osd extents in xine to 1920x1080 to fix the issue. Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData. I think this is still needed for output plugins that don't implement the method, so that they should at least work as before this modification. Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 04/09/11 15:42, En/na Klaus Schmidinger ha escrit: - The subtitle PIDs are now stored in the channels.conf file as an extension to the TPID field (thanks to Rolf Ahrenberg). When I start a recording on a satellite that's not the one the dish is pointing at, when it finally reaches the position the recording will have no subtitles. It also happens in live view, but then I can switch transponder and switch it back to get the subtitles. Does this modification fix the issue? Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 04.09.2011 16:20, Luca Olivetti wrote: Al 04/09/11 15:42, En/na Klaus Schmidinger ha escrit: - The subtitle PIDs are now stored in the channels.conf file as an extension to the TPID field (thanks to Rolf Ahrenberg). When I start a recording on a satellite that's not the one the dish is pointing at, when it finally reaches the position the recording will have no subtitles. It also happens in live view, but then I can switch transponder and switch it back to get the subtitles. Does this modification fix the issue? It might - there's one way to find out ;-) Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 04/09/11 16:41, En/na Klaus Schmidinger ha escrit: Does this modification fix the issue? It might - there's one way to find out ;-) Well, I'm getting old, so I try the latest and greatest only if it's strictly necessary :-D Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 04/09/11 17:22, En/na Luca Olivetti ha escrit: Al 04/09/11 16:41, En/na Klaus Schmidinger ha escrit: Does this modification fix the issue? It might - there's one way to find out ;-) Well, I'm getting old, so I try the latest and greatest only if it's strictly necessary :-D Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
On 04.09.2011 19:54, Luca Olivetti wrote: Al 04/09/11 17:22, En/na Luca Olivetti ha escrit: Al 04/09/11 16:41, En/na Klaus Schmidinger ha escrit: Does this modification fix the issue? It might - there's one way to find out ;-) Well, I'm getting old, so I try the latest and greatest only if it's strictly necessary :-D Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters. Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit: Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters. Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData) and the subtitles now work fine, both with the dxr3 and xine, in sd and hd (of course the latter only with xine). I have to say that with this version of vdr the subtitles are recorded even if the dish is not positioned at the start of the recording. Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.21
Al 04/09/11 23:53, En/na Luca Olivetti ha escrit: Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit: Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are whacky: they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-( I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters. Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData) It still works better with the above fix, but maybe there's a typo in there: shouldn't osdFactorX = VideoAspect * OsdHeight / displayWidth; be instead osdFactorX = VideoAspect * OsdHeight / displayHeight; ? -- Bye ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
