Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private
On 11/2/18 6:15 AM, Pekka Paalanen wrote: > On Thu, 1 Nov 2018 11:15:46 -0500 > Derek Foreman wrote: > >> Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar >> commits for other compositors) protects the compositor's keyboard >> mapping from client damage by duplicating the keymap for every >> client. >> >> On some systems there are other potential fixes for this - such as >> using sealed memfds on linux - but we can't use them since >> essentially all client code anywhere has mapped the keyboard map >> with a MAP_SHARED mmap() call. >> >> While we can't break years worth of code, we can require any future >> clients to use MAP_PRIVATE if they use a seat version above 6. >> >> If a compositor can't use sealing or a similar facility, it should >> still protect itself with copied keymaps, but clients must always >> assume shared mapping of a keymap will fail. >> >> Signed-off-by: Derek Foreman >> --- >> protocol/wayland.xml | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) > > Acked-by: Pekka Paalanen And landed now. Thanks, Derek > > Thanks, > pq > ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH v2] protocol: prefer wl_surface.damage_buffer
On 11/5/18 1:44 PM, Derek Foreman wrote: > On 11/5/18 7:57 AM, Simon Ser wrote: >> This commit makes wl_surface.damage_buffer preferred over wl_surface.damage. >> wl_surface.damage can be implemented in a non-optimal way by the compositor >> (e.g. by always damaging the whole buffer). >> >> Having two requests makes it complicated for the compositor to handle damage, >> making it necessary to transform one into the other's coordinates. >> >> Moreover, integration with wp_viewporter is tricky. >> >> Signed-off-by: Simon Ser > > Obnoxious nitpick: for some reason that file uses different formatting > than others in the repo, and 8 spaces are compressed into a single tab. > > Otherwise, this is: > Reviewed-by: Derek Foreman This is landed now, I changed the formatting to match the surrounding text when I did so. Thanks! Derek >> --- >> protocol/wayland.xml | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/protocol/wayland.xml b/protocol/wayland.xml >> index 141038b..df2b6d2 100644 >> --- a/protocol/wayland.xml >> +++ b/protocol/wayland.xml >> @@ -1397,9 +1397,9 @@ >> and clears pending damage. The server will clear the current >> damage as it repaints the surface. >> >> -Alternatively, damage can be posted with wl_surface.damage_buffer >> -which uses buffer coordinates instead of surface coordinates, >> -and is probably the preferred and intuitive way of doing this. >> +Note! New clients should not use this request. Instead damage can be >> +posted with wl_surface.damage_buffer which uses buffer coordinates >> +instead of surface coordinates. >> >> >> >> > ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: Weston making system slow
On Fri, 30 Nov 2018 09:41:54 +0530 deepan muthusamy wrote: > I have Weston without notify enabled, with this Weston my UI application > performance is fast. > > But I changed to Weston with notify, because I have to start as system > service. I followed the procedure provided by you guys only. > Now my UI application performance has reduced means application gets > slow.responding very slow. > Is Weston with notify lead to any performance degradation? No, it should not have any effect. I cannot imagine how using the systemd-notify plugin could ever affect Weston's runtime performance after start-up. You need to profile and debug it yourself. Thanks, pq pgp__amVbPoW8.pgp Description: OpenPGP digital signature ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
