Re: [webkit-dev] Who are the EFL reviewers?
The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes toniki...@gmail.com wrote: Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it. On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel e...@webkit.org wrote: We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Kenneth Rohde Christiansen Senior Engineer Application and Service Frameworks, Nokia Danmark A/S Phone +45 4093 0598 / E-mail kenneth.christiansen at gmail.com http://codeposts.blogspot.com ﹆﹆﹆ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Who are the EFL reviewers?
Hi, Is it possible to promote some other peoples to reviewers in the EFL port? Tomasz The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomestoniki...@gmail.com wrote: Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it. On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidele...@webkit.org wrote: We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Who are the EFL reviewers?
On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski t.moraw...@samsung.comwrote: Hi, Is it possible to promote some other peoples to reviewers in the EFL port? A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the submitter's permission). These are helpful to show when the reviewer nomination happens (as supporting evidence). If there are folks in the efl community who feel that they like to be reviewers, perhaps they can start doing this. (Then someone who is a reviewer can come along and give the final r+. I view it as a kind of mentorship thing because the reviewer should do a review as well and then the original person can learn from that if there were things that they missed.) dave Tomasz The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomestoniki...@gmail.com wrote: Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it. On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidele...@webkit.org wrote: We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Who are the EFL reviewers?
That sounds like a very good idea and I would be happy to help along giving the final r+ Kenneth On Mon, Apr 11, 2011 at 6:08 PM, David Levin le...@chromium.org wrote: On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski t.moraw...@samsung.com wrote: Hi, Is it possible to promote some other peoples to reviewers in the EFL port? A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the submitter's permission). These are helpful to show when the reviewer nomination happens (as supporting evidence). If there are folks in the efl community who feel that they like to be reviewers, perhaps they can start doing this. (Then someone who is a reviewer can come along and give the final r+. I view it as a kind of mentorship thing because the reviewer should do a review as well and then the original person can learn from that if there were things that they missed.) dave Tomasz The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomestoniki...@gmail.com wrote: Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it. On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidele...@webkit.org wrote: We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Kenneth Rohde Christiansen Senior Engineer Application and Service Frameworks, Nokia Danmark A/S Phone +45 4093 0598 / E-mail kenneth.christiansen at gmail.com http://codeposts.blogspot.com ﹆﹆﹆ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Who are the EFL reviewers?
On Mon, Apr 11, 2011 at 1:08 PM, David Levin le...@chromium.org wrote: Hi, Is it possible to promote some other peoples to reviewers in the EFL port? A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the submitter's permission). We (me, Lucas De Marchi, and Rafael Antognolli) are already informally reviewing patches; our reviews are then used by an official reviewer that either gives a r+ or rs+ based on our comments. I'm not currently allocated to work on WebKit, but if that would speed up the review queue (and provide some relief on Antonio and Kenneth, who have been primarily reviewing EFL patches), I could be a reviewer, yes. However, only one reviewer isn't optimal; I've worked mostly on the build system (besides quick fixes here and there), and Rafael and Lucas worked deep on the port, so they know more about how things work internally. It would be nice if one of them could also become a reviewer, but I can't speak for them. Leandro ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn't defined. Typically OS() is defined by including config.h but that file doesn't seem to be in the cpp files for WebKit2. What is the proper way of fixing this? - include wtf/Platform.h directly in the header files affected (which seem wrong to me). - include config.h in WebKit2 files (but this appears not to be done). - other? Thanks, dave On Mon, Nov 29, 2010 at 1:20 PM, laszlo.1.gom...@nokia.com wrote: Hi, I'd like to warm up this old thread. Dependency on prefix header support seems to be a problem for ARM compiler (ARMCC/RVCT) builds as well (e.g. Symbian build). I've filed a bug to see if we can eliminate this build system dependency - https://bugs.webkit.org/show_bug.cgi?id=50174. We're considering posting a patch that explicitly includes the prefix header in all WebKit2 cpp files (just like config.h) - as suggested earlier. Concerns/better suggestions are welcome (before we touch 200+ files). Thanks, Laszlo -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto: webkit-dev-boun...@lists.webkit.org] On Behalf Of ext Kenneth Christiansen Sent: Wednesday, July 07, 2010 2:36 PM To: Sam Weinig Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] WebKit2 build system Currently it seems that at least icecc does not. Also, qmake which is the build system for the Qt port does not support prefix headers directly and we thus have to emulate it using the precompiled header support. Kenneth On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig sam.wei...@gmail.com wrote: It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
Question answered (in irc): WebKit2 files should have config.h Thanks! On Mon, Apr 11, 2011 at 9:58 AM, David Levin le...@google.com wrote: Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn't defined. Typically OS() is defined by including config.h but that file doesn't seem to be in the cpp files for WebKit2. What is the proper way of fixing this? - include wtf/Platform.h directly in the header files affected (which seem wrong to me). - include config.h in WebKit2 files (but this appears not to be done). - other? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Text display procedure in Webkit GtK
HiI'm working on the WebKit and Text placement. I did lots of back trace on webkit in Gtk to find out where actually does the webkit gives the string of text to the text handler like cairo to show it.Can you give me any help or advise on that?Thanks Soheil Servati BeiraghPhD Candidate, ECE Department, Research Center for Integrated Microsystems,University of Windsor.___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Who are the EFL reviewers?
On Sun, Apr 10, 2011 at 8:51 PM, Eric Seidel e...@webkit.org wrote: We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? As other mentioned, as of now there are none. I've been doing some informal reviews, but it seems that I'm not receiving all the zillions of patches. Last Friday I reviewed all the bugs I was CC'ed and I didn't notice there were more pending in which I was not CC'ed. Another problem is that sometimes people disappear. I reviewed some patches asking for clarification or to change something and they were never answered. I think the best to do is just to close these bugs. thanks Lucas De Marchi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Text display procedure in Webkit GtK
On Mon, Apr 11, 2011 at 10:13 AM, Soheil Servati Beiragh sserv...@yahoo.com wrote: I'm working on the WebKit and Text placement. I did lots of back trace on webkit in Gtk to find out where actually does the webkit gives the string of text to the text handler like cairo to show it. Can you give me any help or advise on that? There are two places: 1. Font::drawGlyphs in Source/WebCore/platform/graphics/cairo/FontCairo.cpp for the simple text placement path. 2. Font::drawComplexText in Source/WebCore/platform/graphics/gtk/FontGtk.cpp for the complex text placement path. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
